linux/poky.git/meta/recipes-core/volatile-binds, branch styhead-5.1.3

volatile-binds: Remove workdir if OverlayFS fails

2024-07-18T16:21:39+00:00

To fulfill OverlayFS workdir requirements, the mount-copybind script creates a workdir. But if the mount operation fails for any reason, the workdir is left there. Then, subsequent runs of mount-copybind will again try to create the directory and pollute system logs with failed mkdir error messages. This commit mitigates the problem by unconditionally removing workdir if the OverlayFS is not used or fails to run. (From OE-Core rev: 7872edbb33024fc710ac683eaef5635b89a1b994) Signed-off-by: Ricardo Simoes Signed-off-by: Mark Jonas Signed-off-by: Richard Purdie

volatile-binds: Do not create workdir if OverlayFS is disabled

2024-07-18T16:21:39+00:00

When the mountpoint parameter is a directory, the mount-copybind will first try to use OverlayFS. Because of that, it needs to create the OverlayFS workdir (determined by the overlay_workdir). But if the environment variable MOUNT_COPYBIND_AVOID_OVERLAYFS is set to "1", the script uses bind mount. In that case, the overlay_workdir is useless, leaving the spec parent directory in a dirty state. This commit changes mount-copybind so that the overlay_workdir is only created when MOUNT_COPYBIND_AVOID_OVERLAYFS is not set to 1. (From OE-Core rev: 323765607f262b5fea0f19e8a05aeffe5076235a) Signed-off-by: Ricardo Simoes Signed-off-by: Mark Jonas Signed-off-by: Richard Purdie

recipes: Switch away from S = WORKDIR

2024-05-21T11:08:04+00:00

Where recipes use S = ${WORKDIR}, change them to set UNPACKDIR to a subdir of WORKDIR and make S point at this instead. I've chosen not to force S into any standard UNPACKDIR we may pick in future just so the S = UNPACKDIR case is clearly visible by the directory naming under WORKDIR as that should aid usability. (From OE-Core rev: d9328e3b0b062f0621de3d114584b44f384a1c02) Signed-off-by: Richard Purdie

volatile-binds: Calculate the name of the /var/lib service

2023-10-30T08:50:46+00:00

By default, /var/lib is bind mounted on /var/volatile/lib. If this is the case, the recipe adds conditions on systemd-random-seed in the service file mounting it. But as the VOLATILE_BINDS may be modified, /var/lib may be mounted elsewhere, for example in /persistent/var/lib. In this case, the conditions are not set because the service file name does not match expected one. This patch automatically records the name of the service mounting /var/lib, if any, in order to set the condition in the appropriate file. (From OE-Core rev: 66f0c2a1678cb69cf8d50372b0592c55e2dc3e3c) Signed-off-by: Stéphane Veyret Signed-off-by: Richard Purdie

volatile-binds: Allow creation of subdirectories

2023-10-30T08:50:46+00:00

The mount-copybind script will create the parent directory of the bind mount if it does not exist. But actually, if this is the case, the service will not even start because of the ConditionPathIsReadWrite. This patch adds a "or" condition to allow the service to start also if the parent directory of the bind mount does not exist. (From OE-Core rev: 1ca031b77546056ca1994469b0f2e93ea2018edf) Signed-off-by: Stéphane Veyret Signed-off-by: Richard Purdie

volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used

2022-04-30T21:00:20+00:00

Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the volatile-binds services. (From OE-Core rev: 86aea324e423ce5f411a21afa18356339e3545a8) Signed-off-by: Portia Stephens Signed-off-by: Richard Purdie

volatile-binds: Change DefaultDependencies from false to no

2022-04-30T21:00:20+00:00

The systemd-unit parameter DefaultDependencies changed from true/false to yes/no. This changed in systemd in v242. (From OE-Core rev: add4dcb03dc7b034253db05f0023cb97cab8b26d) Signed-off-by: Portia Stephens Signed-off-by: Richard Purdie

volatile-binds: add recipe variable to allow disabling OverlayFS

2022-03-29T14:59:29+00:00

Use the new MOUNT_COPYBIND_AVOID_OVERLAYFS flag provided by mount-copybind. When SELinux is enabled, processes accessing OverlayFS mounts will get a denial if the process setting up the mount doesn't have all the permissions that the accessor has. (From OE-Core rev: 6002bdc77643c363a8326bf163baecba8b36e3e0) Signed-off-by: Luca Boccassi Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie

mount-copybind: add MOUNT_COPYBIND_AVOID_OVERLAYFS env var to skip OverlayFS

2022-03-26T09:33:32+00:00

In some cases we don't want to even attempt to set up OverlayFS, for example because SELinux in enforcing mode would kill the process attempting to use the mount. See: https://lore.kernel.org/all/CA+FmFJBDwt52Z-dVGfuUcnRMiMtGPhK4cCQJ=J_fg0r3x-b6ng@mail.gmail.com/T/#mef98aa406324096d1889d3d467251f30456f403c If MOUNT_COPYBIND_AVOID_OVERLAYFS=1 is set, skip directly to copy and bind mount. (From OE-Core rev: a8e7dca69054798b1c9843a0de889cef3e261c4f) Signed-off-by: Luca Boccassi Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie

mount-copybind: fix shellcheck warning

2022-03-26T09:33:32+00:00

$ shellcheck meta/recipes-core/volatile-binds/files/mount-copybind In meta/recipes-core/volatile-binds/files/mount-copybind line 54: mountcontext=",rootcontext=$(matchpathcon -n $mountpoint)" ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: mountcontext=",rootcontext=$(matchpathcon -n "$mountpoint")" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... (From OE-Core rev: 56c7962a6c31acfe0e118f713954aeafd7e2d9c0) Signed-off-by: Luca Boccassi Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie