linux/poky.git/meta/lib/oeqa/utils/targetbuild.py, branch uninative-2.2

meta: Fix return value checks from subprocess.call()'s

2017-06-28T19:55:08+00:00

Python function subprocess.call() returns the return value of the executed process. If return values are not checked, errors may go unnoticed and bad things can happen. Change all callers of subprocess.call() which do not check for the return value to use subprocess.check_call() which raises CalledProcessError if the subprocess returns with non-zero value. https://docs.python.org/2/library/subprocess.html#using-the-subprocess-module All users of the function were found with: $ git grep "subprocess\.call" | \ egrep -v 'if.*subprocess\.call|=\ +subprocess\.call|return.*subprocess\.call' Tested similar patch on top of yocto jethro. Only compile tested core-image-minimal on poky master branch. (From OE-Core rev: 578c8205fd14c48c6d30ef2889d86f1b4aee060a) Signed-off-by: Mikko Rapeli Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

oeqa/utils/targetbuild: tmp dir improvements

2017-04-06T09:13:39+00:00

Don't hard-code /tmp as the tmpdir, instead use WORKDIR as the tmpdir if the instantiater doesn't specify a value. (From OE-Core rev: c43c966e0ed4ed836bdf90b1d4c3f2f45426f1ec) Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie

classes/oeqa: Replace subprocess.check_call() with check_output()

2017-01-23T23:30:57+00:00

If you use subprocess.check_output() the traceback will contain the output when the command fails which is very useful for debugging. There is no good reason not to use this everywhere. (From OE-Core rev: ad750dd1cc9d789abe723daddd098ce41d8547f5) Signed-off-by: Richard Purdie

meta: remove True option to getVar calls

2016-12-16T10:23:23+00:00

getVar() now defaults to expanding by default, thus remove the True option from getVar() calls with a regex search and replace. Search made with the following regex: getVar ?$( ?[^,()]*), True$ (From OE-Core rev: 7c552996597faaee2fbee185b250c0ee30ea3b5f) Signed-off-by: Joshua Lock Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

oeqa/targetbuild: use os.path.join instead of string concatenation

2016-06-23T13:26:16+00:00

(From OE-Core rev: 1d40f6e3d85d0cd3be6dd784677686ed4dec89c4) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

oeqa/targetbuild: add extra_cmds argument to run_configure

2016-06-23T13:26:16+00:00

Some upstreams need more than just gnu-configize ran before ./configure works, such as ./autogen.sh or autoreconf. Add extra_args (defaulting to gnu-configize) so that this can be done in test cases. (From OE-Core rev: 7096f2889f1623ce97a6696f6f4c7217f0efb972) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

oeqa/targetbuild: fix folder name estimate logic

2016-06-23T13:26:16+00:00

The re.sub() used to transform a tarball into a best guess folder name wasn't right, as there isn't enough escaping and tar.xz was missing. (From OE-Core rev: ac99135b009a1066486ed2afb2f298d0a5a3a854) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

classes/lib: Complete transition to python3

2016-06-02T07:24:01+00:00

This patch contains all the other misc pieces of the transition to python3 which didn't make sense to be broken into individual patches. (From OE-Core rev: fcd6b38bab8517d83e1ed48eef1bca9a9a190f57) Signed-off-by: Richard Purdie

oeqa/targetbuild: Ensure we run gnu-configize so config files are up to date

2015-09-12T21:48:47+00:00

On aarch64 we need to do this as the versions in the upstream source don't recognise the target triplet causing SDK test failures. (From OE-Core rev: 2374bfa3b98f787f4559f14a60647e4c2b051274) Signed-off-by: Richard Purdie

oeqa/targetbuild: Remove bashism

2015-08-19T17:05:43+00:00

Use '.' instead of 'source' so this works with dash as /bin/sh. (From OE-Core rev: 4114c904f173721c682f9ed1a593c77307ef9d35) Signed-off-by: Richard Purdie Signed-off-by: Ross Burton Signed-off-by: Richard Purdie