linux/poky.git/meta/classes/insane.bbclass, branch 1.5_M3.rc1

classes/insane: allow libdir QA check to be skipped using INSANE_SKIP

2013-07-18T20:23:43+00:00

This path check isn't handled in the normal way where a QA check function is called for every file (there's some minor setup that we want to avoid doing for every file) so we need to check INSANE_SKIP explicitly. In the process, change the code structure a little bit so that we can report the package that contains the errant file. Fixes [YOCTO #4822]. (From OE-Core rev: 3bdbec1bdecc52828cbbf8108786ff076c981845) Signed-off-by: Paul Eggleton Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

classes/insane: fix regression in libdir QA regex

2013-07-18T20:23:43+00:00

There was a slight mistake in the recent change to the lib_re regex - it still needs to begin with a /. (From OE-Core rev: 194e47e6d8d9b9ee98e0203f0ebb574084277c46) Signed-off-by: Paul Eggleton Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

insane.bbclass: Added QA warning for shipping /usr/share/info/dir

2013-07-05T14:34:23+00:00

/usr/share/info/dir should be generated at install time in a postinst. Added QA warning to check at build time for this file. The warning is disabled by default. [YOCTO #3969] (From OE-Core rev: be93fa1d8fd601d95147980938217142c7d98c62) Signed-off-by: Mihai Prica Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

classes/insane: fix libdir check regexes

2013-07-05T14:34:22+00:00

Ensure these do not pick up e.g. /lib/systemd/system/uuidd.socket, but ensure we pickup e.g. /usr/lib/libnss3.so.1d (example from Debian). This also fixes the broken exec_re regex (lib*.). (From OE-Core rev: 391a361190d7da19ad3381121649a41a28516cb5) Signed-off-by: Paul Eggleton Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

classes/insane: remove la2 check which no longer exists from ERROR_QA

2013-06-28T15:33:08+00:00

This check was actually removed a very long time ago in 6656381714c5956f71ca634f5a5f4aa4661bbf7e, before we even changed the QA checks to use names instead of numbers - the name was probably added ERROR_QA mistakenly because it hadn't also been removed from the comment listing the QA checks or the function that determined which ones were errors. (From OE-Core rev: ff65497cd9a96d5ab49b16ba1f7e30a216ff4a42) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

insane.bbclass: quiet package errors not in *_QA

2013-06-11T14:55:59+00:00

Currently, if a package QA type from package.bbclass is not listed in ERROR_QA, it gets shown, regardless of whether it's in WARN_QA. This differs from the behavior of the rest of the QA handling (which doesn't call package_qa_handle_error at all if it's in neither _QA variable), and is nonintuitive. Change this to use bb.note() if it's listed neither in ERROR_QA nor WARN_QA, so it ends up in the task logs, but doesn't clutter up the user's output. (From OE-Core rev: 8f5675e6d3eb8473f367de72d2d3d8a702011a47) Signed-off-by: Christopher Larson Signed-off-by: Richard Purdie

insane/package: refactor packaging sanity tests

2013-06-07T15:48:27+00:00

Refactor packaging sanity tests from package.bbclass to insane.bbclass so that the message can respect WARN_QA (print the warning message and go on the task) and ERROR_QA (print the error message and fail the task). - For the bb.warn(), give it a message name and add it to WARN_QA, then use package_qa_handle_error() to handle it. - For the bb.error(), give it a message name and add it to ERROR_QA, then use package_qa_handle_error() to handle it. - All the bb.warn() and bb.error() have been replaced in package.bbclass. - A few bb.warn() and bb.error() in insane.bbclass have been kept since they can not be replaced or doesn't have to, for example the bb.error() in package_qa_check_license(), it will print the error message and then invoke bb.fatal() to fail the task, I think that we don't have to replace it with package_qa_handle_error(). - Put all the WARN_QA and ERROR_QA in one line, so that they can be redefined by the user easily. [YOCTO #3190] [YOCTO #4396] (From OE-Core rev: 2f117ee615b703db07d3274ac592e2bd653743dd) Signed-off-by: Robert Yang Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

insane/package: let package.bbclass inherit insane.bbclass

2013-06-07T15:48:26+00:00

RP's comment: "What we're trying to do is move everything to use a standard mechanism for reporting issues of this type (do_package). With insane.bbclass, you can elect whether a given type of error is a warning or error and fails the task." * The package.bbclass had used package_qa_handle_error() which is from insane.bbclass, and we will use it for handling other warnings and errors, so let package.bbclass inherit insane.bbclass, this change will make the insane as a requirement (always included). * Change the "PACKAGEFUNCS ?=" to "+=", otherwise there would be an error like: Exception: variable SUMMARY references itself! This is because we let package.bbclass inherit insane.bbclass, and PACKAGEFUNCS has been set in insane.bbclass, so the "PACKAGEFUNCS ?=" will set nothing, then the "emit_pkgdata" doesn't run which will cause this error. * Add a QA_SANE variable in insane.bbclass, once the error type is ERROR_QA, it will fail the task and stop the build. [YOCTO #3190] [YOCTO #4396] (From OE-Core rev: 852dead71387c66ec0cba7c71e3814a74e409560) Signed-off-by: Robert Yang Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

bbclass: bb.fatal() clean up

2013-05-15T21:09:47+00:00

The bb.fatal() is defined as: def fatal(*args): logger.critical(''.join(args)) sys.exit(1) So anything after bb.fatal() in the same code block doesn't have any effect, e.g.: bb.fatal("%s_%s: %s" % (var, pkg, e)) raise e The "raise e" should be removed. I searched all the files which use bb.fatal(), only the following 3 classes have this issues: insane.bbclass package.bbclass package_rpm.bbclass [YOCTO #4461] (From OE-Core rev: 4c47525c5a171b1282615c9fbc7d84addef85f92) Signed-off-by: Robert Yang Signed-off-by: Saul Wold Signed-off-by: Richard Purdie

classes/insane: add check for PN in OVERRIDES

2013-05-10T10:37:16+00:00

If a recipe is named such that its PN value matches something already in OVERRIDES (such as when PN happens to be the same as MACHINE or DISTRO), it can have unexpected consequences. Assignments such as FILES_${PN} = "xyz" effectively turn into FILES = "xyz". Implements [YOCTO #4288]. (From OE-Core rev: c331f0a5cac765174a1b5de5c12aec7e965d4158) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie