linux/poky.git/meta/classes/chrpath.bbclass, branch yocto-2.2.2

chrpath.bbclass: Use bb.fatal() instead of raising FuncFailed

2016-10-04T15:29:05+00:00

This sets a good example and avoids unnecessarily contributing to perceived complexity and cargo culting. Motivating quote below: < kergoth> the *original* intent was for the function/task to error via whatever appropriate means, bb.fatal, whatever, and funcfailed was what you'd catch if you were calling exec_func/exec_task. that is, it's what those functions raise, not what metadata functions should be raising < kergoth> it didn't end up being used that way < kergoth> but there's really never a reason to raise it yourself FuncFailed.__init__ takes a 'name' argument rather than a 'msg' argument, which also shows that the original purpose got lost. (From OE-Core rev: 20e669f56489b2c8a9bc6a0e6f3eac81ef35445a) Signed-off-by: Ulf Magnusson Signed-off-by: Richard Purdie

chrpath: correct subprocess.Popen.communicate() return values

2016-08-10T09:46:33+00:00

This is a non-functional change, which intends to correct element names of a tuple returned by Popen.communicate(). Both in python2 and python3 subprocess.Popen.communicate() method returns a tuple (stdoutdata, stderrdata), thus old assignments and collateral comments are incorrect from human's point of view, however formally there is no error in the code. The change is desired to have to avoid copy-paste errors in future. (From OE-Core rev: f8c21df86bae5a85e221b69b91b347aeba6be4c3) Signed-off-by: Vladimir Zapolskiy Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

classes/lib: Update to use python3 command pipeline decoding

2016-06-02T07:24:00+00:00

In python3, strings are unicode by default. We need to encode/decode from command pipelines and other places where we interface with the real world using the correct locales. This patch updates various call sites to use the correct encoding/decodings. (From OE-Core rev: bb4685af1bffe17b3aa92a6d21398f38a44ea874) Signed-off-by: Richard Purdie

bbclass: fix spelling mistakes

2015-11-24T15:50:27+00:00

Fix some spelling mistakes in bbclass files (From OE-Core rev: ed484c06f436eea62c5d0b1a2964f219f3e5cb61) Signed-off-by: Maxin B. John Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

meta: Add explict getVar param for (non) expansion

2015-06-23T10:57:25+00:00

Rather than just use d.getVar(X), use the more explict d.getVar(X, False) since at some point in the future, having the default of expansion would be nice. This is the first step towards that. This patch was mostly made using the command: sed -e 's:$getVar([^,()]*$\s*):\1, False):g' -i `grep -ril getVar *` (From OE-Core rev: ab7c1d239b122c8e549e8112c88fd46c9e2b061b) Signed-off-by: Richard Purdie

chrpath.bbclass: handle RUNPATH as well as RPATH

2015-03-16T17:41:56+00:00

Binaries linked with gold may contain a RUNPATH instead of an RPATH. Update chrpath.bbclass process_file_linux() to handle both cases. (From OE-Core rev: 46ceb4d035e4f49e6b4a3a83bf604944d2b991c1) Signed-off-by: Andre McCurdy Signed-off-by: Ross Burton Signed-off-by: Richard Purdie

chrpath: Drop warning from darwn builds

2014-08-17T09:01:36+00:00

This was old debug which can safely be removed for less noisy builds. (From OE-Core rev: d0be4b37743492fc9c178fd6f9ef73a5eb2fd9c3) Signed-off-by: Richard Purdie

chrpath: properly handle rootdir with '..' in path

2014-05-11T11:27:21+00:00

When there is a '..' in the rootdir path, rootdir will not be a substring of fpath. This causes an incorrect rpath of the difference between the workdir and the sysroot to be computed, which is incorrect. Normalizing basedir fixes this issue. (From OE-Core rev: 753cfcadd8cc683e69b6707b823dc49dfb34ab0b) Signed-off-by: Richard Purdie

chrpath: Improve crazy code

2013-11-29T09:52:57+00:00

The current code is a little bit overcomplicated, deficient and also possibly broken. Issues include: a) Not maximally optisming rpaths (e.g. a lib in usr/lib might get an rpath of $ORIGIN/../../usr/lib) b) The return in the middle of the for loop look suspiciously like it might break on some binaries c) The depth function, loops of "../" prepending and so on can be replaced with a call to os.path.relpath This patch cleans up the above issues. Running binaries should result in less "../" resolutions which can't hurt performance either. [YOCTO #3989] (From OE-Core rev: feea54df6768036649ca6c57524e2a1f480ad249) Signed-off-by: Richard Purdie

chrpath: Add support for relocating darwin binaries

2013-08-23T15:20:14+00:00

On darwin, install_name_tool can be used to relocate binaries/libraries. This adds support for adjusting them with relative paths rather than hardcoded ones. The Linux code is factored out into a function but is otherwise unchanged. (From OE-Core rev: ed5ace3437eb0f751172e6b93399639c94b89e59) Signed-off-by: Richard Purdie