linux/poky.git/meta/classes-global/insane.bbclass, branch nanbield-4.3.2

insane: unimplemented-ptest: ignore source file errors

2023-10-17T10:41:34+00:00

In some cases, pathlib.Path.glob() might throw FileNotFoundError when file/directory disappear while it is iterating over them. This "warning" is not important enough to crash build in this case so just take a bb.note of the problem and move on. (From OE-Core rev: 85ddbb67f0f6f823cac0966db78e5b74c5a54c4c) Signed-off-by: Yoann Congal Reported-by: Mark Hatle Closes: https://lists.openembedded.org/g/openembedded-core/message/189254 Signed-off-by: Richard Purdie

insane: skip unimplemented-ptest on S=WORKDIR recipes

2023-10-17T10:41:34+00:00

On S=WORKDIR recipes, the unimplemented-ptest check will scan the whole WORKDIR and "see" disappearing file and directory. (From OE-Core rev: 9a2d2f7c2b7236667a6d80355f73db4c27e6582e) Signed-off-by: Yoann Congal Reported-by: Mark Hatle Closes: https://lists.openembedded.org/g/openembedded-core/message/189254 Signed-off-by: Richard Purdie

insane: Add a naive heuristic to detect test subdirectories

2023-10-15T08:11:47+00:00

if there is a "test" or "tests" subdirectory at toplevel, this usually means we have some unit tests available. This test is very good at detecting handcrafted tests and I was not able to find any false positive. False positive can be dealt with the usual INSANE_SKIP mechanism (From OE-Core rev: 0c91ad29f7ea313bc25481be9d40f216c0770b98) Signed-off-by: Jérémy Rosen Reviewed-by: Yoann Congal Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie

insane: Detect build-system test harnesses

2023-10-15T08:11:47+00:00

most build-systems have a way to implement a "make check" or equivalent command that will run tests in the source directory. This heuristic will detect the keywords in the build-system configuration that activates tests. Note that in the case of autotools, we use Makefile.in as our source instead of Makefile.am to easily follow includes. Filenaming conventions for autotools files are not reliable enough to do naive matching. (From OE-Core rev: bc9013295256443e877f29b7e00605ffa5177efa) Signed-off-by: Jérémy Rosen Reviewed-by: Yoann Congal Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie

insane: Detect python and perl based tests

2023-10-15T08:11:47+00:00

match_line_in_files will look for a regex in all files matching a glob. we use iglob to avoid a complete, recursive scan of all source. iglob is based on python iterators and will scan as we walk through the directories pytest are detected by looking for "import pytest" or "from pytest" in any python file. perl Test:: is detetected by looking for any t/*.t in the toplevel source directory. (From OE-Core rev: 00d64ac38ae4af6193fae3b02375a16b1821f29e) Signed-off-by: Jérémy Rosen Reviewed-by: Yoann Congal Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie

insane: Add unimplemented-ptest infrastructure

2023-10-15T08:11:47+00:00

This infrastructure will use heuristics to detect when package sources seem to have unit tests implemented but no ptest have been implemented in the recipe. No heuristics have been implemented at this point, only the infrastructure to skip the test when ptest are implemented. This is part of python_do_qa_patch since we need the sources in their final state but do not need any configuration done A missing-ptest QA test already existed but it was used for a different purpose and overridden by ptest.bbclass. Thus, a new QA keyword was added Note: The QA test is not enabled by default and may be enabled to hunt down potential ptests with: WARN_QA += "unimplemented-ptest" (From OE-Core rev: 282ae38543e22cbdcbf69c64eace551997927ce3) Signed-off-by: Jérémy Rosen Reviewed-by: Yoann Congal Signed-off-by: Luca Ceresoli Signed-off-by: Richard Purdie

insane.bbclass: Count raw bytes in shebang-size

2023-09-22T06:45:17+00:00

Operating systems limit the shebang to a maximum number of bytes. This patch makes the shebang-size check count raw bytes instead of UTF-8 characters. (From OE-Core rev: d4ac66c5cdaf971fb717cc5c5bf9aa51a787d412) Signed-off-by: Jan Garcia Signed-off-by: Richard Purdie

insane.bbclass: Remove an unused variable

2023-08-24T15:50:24+00:00

The use of coremeta_path was removed with commit 61a881fdbe (insane: Improve patch-status layer filtering) when the patch-status QA test was generalized. (From OE-Core rev: 71a2c7b2608640dfa45d065692541d537149052e) Signed-off-by: Peter Kjellerstedt Signed-off-by: Richard Purdie

insane.bbclass: add a RECIPE_MAINTAINER check (oe-core recipes only)

2023-07-30T08:16:52+00:00

Absent maintainer entries are as well a frequent source of friction, as they are checked only in selftest, and so aren't revealed until autobuilder runs. The selftest is retained as it also checks for obsolete entries in maintainers.inc (not possible to do in insane class). (From OE-Core rev: 675dff0e37666c1cffa10a83f6f1f67d5fadd204) Signed-off-by: Alexander Kanavin Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie

insane.bbclass: add a SUMMARY/HOMEPAGE check (oe-core recipes only)

2023-07-30T08:16:52+00:00

This was done in a selftest, but that is too late and creates friction in integration as errors are not seen until autobuilder fails. Bonus fix: SUMMARY check wasn't even working, as in the absence of one set in the recipe there is a default value set from bitbake.conf. I left DESCRIPTION check out for now, as many recipes don't actually have it, and it's set from SUMMARY (plus a dot) if absent. (From OE-Core rev: 4144c2f43da39336b03cfd612cbe1694cbf8c7bd) Signed-off-by: Alexander Kanavin Signed-off-by: Alexandre Belloni Signed-off-by: Richard Purdie