linux/poky.git/bitbake/lib/bb/server, branch uninative-3.6

bitbake: server/process: Disable gc around critical section

2022-04-03T16:51:26+00:00

The python gc can trigger whilst we're holding the event stream lock and when cleaning up objects, they can trigger warnings. This translates into a new event which would then need the lock and we can deadlock. Disable gc whilst we hold that lock to avoid this unfortunate and problematic situation. (Bitbake rev: 96a6303949cefd469bcf5ed250ff512271354357) Signed-off-by: Richard Purdie

bitbake: cooker/process: Fix signal handling lockups

2022-03-30T12:05:03+00:00

If a parser process is terminated while holding a write lock, then it will lead to a deadlock (see https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Process.terminate). With SIGTERM, we don't want to terminate holding the lock. We also don't want a SIGINT to cause a partial write to the event stream. I tried using signal masks to avoid this but it doesn't work, see https://bugs.python.org/issue47139 Instead, add a signal handler and catch the calls around the critical section. We also need a thread lock to ensure other threads in the same process don't handle the signal until all the threads are not in the lock. (Bitbake rev: a40efaa5556a188dfe46c8d060adde37dc400dcd) Signed-off-by: Richard Purdie

bitbake: server/process: Correct a typo in a comment

2022-03-28T12:33:28+00:00

(Bitbake rev: b4a157b2fe2fb481ffa40e0f32659d05dd6320c2) Signed-off-by: Peter Kjellerstedt Signed-off-by: Richard Purdie

bitbake: server/process: Move threads left debug to after cooker shutdown

2022-03-26T09:27:43+00:00

This debug is useful but the cooker shutdown or post_serve() may have cleanup left so run after those. (Bitbake rev: 1463fc0448d1a6a7265806a4a8b165b610dfb43f) Signed-off-by: Richard Purdie

bitbake: server/xmlrpcserver: Add missing xmlrpcclient import

2022-03-08T09:45:57+00:00

This avoids backtraces when starting toaster or using bitbake in remote mode. (Bitbake rev: bf723f2cb5d288ca730e4f029110b36380420a01) Signed-off-by: Richard Purdie

bitbake: lib/bb: Fix string concatination potential performance issues

2021-11-03T10:12:42+00:00

Python scales badly when concatinating strings in loops. Most of these references aren't problematic but at least one (in data.py) is probably a performance issue as the issue is compounded as strings become large. The way to handle this in python is to create lists which don't reconstruct all the objects when appending to them. We may as well fix all the references since it stops them being copy/pasted into something problematic in the future. This patch was based on issues highligthted by a report from AWS Codeguru. (Bitbake rev: d654139a833127b16274dca0ccbbab7e3bb33ed0) Signed-off-by: Richard Purdie

bitbake: bitbake: correct deprecation warning in process.py

2021-09-17T06:26:24+00:00

(Bitbake rev: aff52fe21a0b27f6302555c1e52a864550eb46ce) Signed-off-by: Alexander Kanavin Signed-off-by: Richard Purdie

bitbake: cooker/process: Fix typos in exiting message

2021-09-01T17:56:25+00:00

(Bitbake rev: 1ff1ea3880d293b14ce0fc65e3bc4c938d587a2f) Signed-off-by: Martin Jansa Signed-off-by: Richard Purdie

bitbake: process: Improve traceback error reporting from main loop

2021-08-06T05:34:58+00:00

Currently the code can just show nothing as the exception if there was a double fault, which in this code path is quite likely. This leads to an error log which effectively says "it failed" with no information about how. Improve things so we get a nice verbose traceback left in the logs/output which is preferable to no logs. (Bitbake rev: e5782b71647d1eb6de53bde7bc4f6019a5589f21) Signed-off-by: Richard Purdie

bitbake: server: Fix early parsing errors preventing zombie bitbake

2021-07-20T18:00:32+00:00

If the client process never sends cooker data, the server timeout will be 0.0, not None. This will prevent the server from exiting, as it is waiting for a new client. In particular, the client will disconnect with a bad "INHERIT" line, such as: INHERIT += "this-class-does-not-exist" Instead of checking explicitly for None, check for a false value, which means either 0.0 or None. (Bitbake rev: 13e2855bff6a6ead6dbd33c5be4b988aafcd4afa) Signed-off-by: Joshua Watt Signed-off-by: Richard Purdie