linux/poky.git/bitbake/bin/bitbake-diffsigs, branch uninative-2.1

bitbake: bitbake-diffsigs: fix regression after recent server changes

2017-07-27T14:14:20+00:00

We were bridging the gap between the server and UI here by calling a bb.siggen.find_siginfo, a function defined and set on that module from the metadata. This worked from the UI side before but since the recent server changes is no longer accessible. Create a new command so this can execute on the server side and return the result by way of a new event. (We're still running compare_sigfiles() on the signature generator but that isn't quite the same thing and does still work.) Fixes [YOCTO #11844]. (Bitbake rev: fdcea991baa4f83d9c98d468d7b49c8c388a4a15) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: fix traceback with no arguments

2017-04-11T17:05:09+00:00

In the move over to argparse we've made the two signature file arguments optional and thus if -t is not in use we need to explicitly check if at least one signature file has been specified - and if not, show an error and the command-line help. (Bitbake rev: 9011366689b26305281fcb2d412dcacece917e18) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: colourise output

2017-04-10T22:00:32+00:00

If the output is a TTY, add colour to the output in order to make it easier to read. At the moment this is fairly basic, just add colour to the "titles" of each change and to the diff output. I tried to introduce this without changing the code too much - rather than moving everything over to the new python formatting style, I've introduced a color_format() function which takes care of the colour formatting, either accepting additional format arguments or alternatively leaving the caller to use the old-style formatting (%) to insert values. (Bitbake rev: 04a023c8fdea1e1812fcdcaf00345aab59f9abe1) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: add an option to find and compare specific signatures

2017-04-10T22:00:32+00:00

With the -t option which recurses to find the ultimate cause of a signature change, it was hardcoded to take the last two executions of the specified task. On the other hand, if you have two specific task hashes (say from bitbake output, or some other tool) then you'll want to pick those, so provide an option to specify those as well. (Note, the new -s option needs to be specified alongside -t rather than instead of it.) (Bitbake rev: d9813b1a4223cf8dc80cab90e467ddf4bf8d1078) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: change to use argparse

2017-04-10T22:00:32+00:00

Argparse is a bit easier to deal with than optparse, and since we're about to add some options, migrate this script over. (Bitbake rev: 7f130e0b5ce6cfc6b35176465f260092cd3b3d64) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: lib/bb/siggen: show a diff when dumping changes to multi-line values

2017-04-10T22:00:32+00:00

When dumping changes to signatures e.g. output of bitbake -s printdiff, if for example a function has changed, it's much more readable to see a unified diff of the changes rather than just printing the old function followed by the new function, so use difflib to do that. Note: I elected to keep to one item in the returned list per change, rather than one line per line of output, so that the caller can still look at changes individually if needed. Thus I've added some handling to bitbake-diffsigs to split the change into lines so that each line is displayed indented. (Bitbake rev: 4d254ae63a35231c98e3f73f669b040ed1144042) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: drop naive logic for removing duplicate files

2017-04-10T22:00:32+00:00

This logic doesn't work in practice, certainly not with current versions where sigdata files are preserved in the stamps directory and therefore there will often be multiple sigdata files - you can now easily get files for the same signature from sstate and the stamps directory with the result that bitbake-diffsigs reports nothing has changed. Instead, let's change the find_siginfo function in OE-Core to simply not return duplicates so we don't have to filter them out here. (Bitbake rev: f0d7ab259d8ef95643e7229474b7850608aa4426) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: properly report which signature is missing

2017-04-10T22:00:32+00:00

If just one of the two signatures we want to compare aren't available, report that one rather than misleadingly claiming both are missing. (Bitbake rev: c87764b9147792a10efad3ed5378f36f0a055bc6) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: bitbake-diffsigs: fix -t picking wrong files to compare

2017-04-10T22:00:32+00:00

We weren't picking the right files to compare here - according to the order in which the list is sorted (by mtime), we need to be taking the last two items and not the first two. (Bitbake rev: 99f49b56115b1f8d1a0a0b911da62ffd1f997b5f) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie

bitbake: lib/bb/msg: introduce logger_create() function

2017-03-27T19:23:19+00:00

We use this code to set up a logger with colour in a number of different places, so create one function that does this and make some of bitbake's utility scripts use it. (Bitbake rev: b1ba7d1cc8ec33e2d081230287abd07f52136097) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie