diff options
Diffstat (limited to 'recipes-extended/xen/files/tools-misc-fix-hypothetical-buffer-overflow.patch')
| -rw-r--r-- | recipes-extended/xen/files/tools-misc-fix-hypothetical-buffer-overflow.patch | 46 |
1 files changed, 0 insertions, 46 deletions
diff --git a/recipes-extended/xen/files/tools-misc-fix-hypothetical-buffer-overflow.patch b/recipes-extended/xen/files/tools-misc-fix-hypothetical-buffer-overflow.patch deleted file mode 100644 index a4998619..00000000 --- a/recipes-extended/xen/files/tools-misc-fix-hypothetical-buffer-overflow.patch +++ /dev/null | |||
| @@ -1,46 +0,0 @@ | |||
| 1 | From 27751d89248c8c5eef6d8b56eb8f7d2084145080 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= | ||
| 3 | <marmarek@invisiblethingslab.com> | ||
| 4 | Date: Thu, 5 Apr 2018 03:50:50 +0200 | ||
| 5 | Subject: [PATCH] tools/misc: fix hypothetical buffer overflow in xen-lowmemd | ||
| 6 | MIME-Version: 1.0 | ||
| 7 | Content-Type: text/plain; charset=UTF-8 | ||
| 8 | Content-Transfer-Encoding: 8bit | ||
| 9 | |||
| 10 | gcc-8 complains: | ||
| 11 | |||
| 12 | xen-lowmemd.c: In function 'handle_low_mem': | ||
| 13 | xen-lowmemd.c:80:55: error: '%s' directive output may be truncated writing up to 511 bytes into a region of size 489 [-Werror=format-truncation=] | ||
| 14 | snprintf(error, BUFSZ,"Failed to write target %s to xenstore", data); | ||
| 15 | ^~ ~~~~ | ||
| 16 | xen-lowmemd.c:80:9: note: 'snprintf' output between 36 and 547 bytes into a destination of size 512 | ||
| 17 | snprintf(error, BUFSZ,"Failed to write target %s to xenstore", data); | ||
| 18 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| 19 | |||
| 20 | In practice it wouldn't happen, because 'data' contains string | ||
| 21 | representation of 64-bit unsigned number (20 characters at most). | ||
| 22 | But place a limit to mute gcc warning. | ||
| 23 | |||
| 24 | Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> | ||
| 25 | Acked-by: Wei Liu <wei.liu2@citrix.com> | ||
| 26 | Release-Acked-by: Juergen Gross <jgross@suse.com> | ||
| 27 | --- | ||
| 28 | tools/misc/xen-lowmemd.c | 2 +- | ||
| 29 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
| 30 | |||
| 31 | diff --git a/tools/misc/xen-lowmemd.c b/tools/misc/xen-lowmemd.c | ||
| 32 | index 865a54c..79ad34c 100644 | ||
| 33 | --- a/tools/misc/xen-lowmemd.c | ||
| 34 | +++ b/tools/misc/xen-lowmemd.c | ||
| 35 | @@ -77,7 +77,7 @@ void handle_low_mem(void) | ||
| 36 | if (!xs_write(xs_handle, XBT_NULL, | ||
| 37 | "/local/domain/0/memory/target", data, strlen(data))) | ||
| 38 | { | ||
| 39 | - snprintf(error, BUFSZ,"Failed to write target %s to xenstore", data); | ||
| 40 | + snprintf(error, BUFSZ,"Failed to write target %.24s to xenstore", data); | ||
| 41 | perror(error); | ||
| 42 | } | ||
| 43 | } | ||
| 44 | -- | ||
| 45 | 2.7.4 | ||
| 46 | |||
