diff options
| author | Bruce Ashfield <bruce.ashfield@windriver.com> | 2018-04-19 16:49:41 -0400 |
|---|---|---|
| committer | Bruce Ashfield <bruce.ashfield@windriver.com> | 2018-04-20 10:03:50 -0400 |
| commit | fcc09c8c3639ca5c529d4f28db9b1d090331739f (patch) | |
| tree | b7bb1e0b27ef1b600508c4dfb9080269c173e84c /recipes-containers/runc | |
| parent | 7d2ee2dfa266f339d57823a72560ca2fcf01bd49 (diff) | |
| download | meta-virtualization-fcc09c8c3639ca5c529d4f28db9b1d090331739f.tar.gz | |
runc/containerd: fix build with go 1.9.x
go 1.9.x was triggering linkage errors on some build hosts due to
missing symbols.
| tmp/work/core2-64-poky-linux/runc-docker/1.0.0-rc5+gitAUTOINC+4fc53a81fb-r0/recipe-sysroot/usr/lib/../lib/libc.a(dl-reloc-static-pie.o): In function `elf_mac:
| /usr/src/debug/glibc/2.27-r0/git/sysdeps/x86_64/dl-machine.h:59: undefined reference to `_DYNAMIC'
| tmp/work/core2-64-poky-linux/runc-docker/1.0.0-rc5+gitAUTOINC+4fc53a81fb-r0/recipe-sysroot/usr/lib/../lib/libc.a(dl-reloc-static-pie.o): In function `elf_get:
| /usr/src/debug/glibc/2.27-r0/git/elf/get-dynamic-info.h:48: undefined reference to `_DYNAMIC'
By ensuring that our sysroot provided go binary and build flags make
it into the build enviroment we can build properly with 1.9 and 1.10
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Diffstat (limited to 'recipes-containers/runc')
4 files changed, 29 insertions, 25 deletions
diff --git a/recipes-containers/runc/runc-docker/0001-Disable-building-recvtty.patch b/recipes-containers/runc/runc-docker/0001-Disable-building-recvtty.patch deleted file mode 100644 index 8de1b170..00000000 --- a/recipes-containers/runc/runc-docker/0001-Disable-building-recvtty.patch +++ /dev/null | |||
| @@ -1,23 +0,0 @@ | |||
| 1 | From aa2fc7b0eacba61175f083cc8d8adc233bcd0575 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Paul Barker <pbarker@toganlabs.com> | ||
| 3 | Date: Thu, 12 Oct 2017 11:34:24 +0000 | ||
| 4 | Subject: [PATCH] Disable building recvtty | ||
| 5 | |||
| 6 | Signed-off-by: Paul Barker <pbarker@toganlabs.com> | ||
| 7 | Upstream-status: Inappropriate | ||
| 8 | --- | ||
| 9 | Makefile | 1 - | ||
| 10 | 1 file changed, 1 deletion(-) | ||
| 11 | |||
| 12 | Index: git/src/import/Makefile | ||
| 13 | =================================================================== | ||
| 14 | --- git.orig/src/import/Makefile | ||
| 15 | +++ git/src/import/Makefile | ||
| 16 | @@ -40,7 +40,6 @@ | ||
| 17 | |||
| 18 | static: $(SOURCES) | ||
| 19 | CGO_ENABLED=1 $(GO) build $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo cgo static_build" -installsuffix netgo -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o runc . | ||
| 20 | - CGO_ENABLED=1 $(GO) build $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo cgo static_build" -installsuffix netgo -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty | ||
| 21 | |||
| 22 | release: | ||
| 23 | script/release.sh -r release/$(VERSION) -v $(VERSION) | ||
diff --git a/recipes-containers/runc/runc-docker/0001-build-drop-recvtty-and-use-GOBUILDFLAGS.patch b/recipes-containers/runc/runc-docker/0001-build-drop-recvtty-and-use-GOBUILDFLAGS.patch new file mode 100644 index 00000000..f885aaf7 --- /dev/null +++ b/recipes-containers/runc/runc-docker/0001-build-drop-recvtty-and-use-GOBUILDFLAGS.patch | |||
| @@ -0,0 +1,27 @@ | |||
| 1 | From a9a2b9e72027d0b2357f6dfe8b154762aaa8dd02 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Bruce Ashfield <bruce.ashfield@windriver.com> | ||
| 3 | Date: Thu, 19 Apr 2018 16:39:41 -0400 | ||
| 4 | Subject: [PATCH] build: drop recvtty and use GOBUILDFLAGS | ||
| 5 | |||
| 6 | Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> | ||
| 7 | --- | ||
| 8 | Makefile | 3 +-- | ||
| 9 | 1 file changed, 1 insertion(+), 2 deletions(-) | ||
| 10 | |||
| 11 | diff --git a/src/import/Makefile b/src/import/Makefile | ||
| 12 | index c6de11d..0e9bddb 100644 | ||
| 13 | --- a/src/import/Makefile | ||
| 14 | +++ b/src/import/Makefile | ||
| 15 | @@ -39,8 +39,7 @@ contrib/cmd/recvtty/recvtty: $(SOURCES) | ||
| 16 | $(GO) build -buildmode=pie $(EXTRA_FLAGS) -ldflags "-X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -tags "$(BUILDTAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty | ||
| 17 | |||
| 18 | static: $(SOURCES) | ||
| 19 | - CGO_ENABLED=1 $(GO) build $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo cgo static_build" -installsuffix netgo -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o runc . | ||
| 20 | - CGO_ENABLED=1 $(GO) build $(EXTRA_FLAGS) -tags "$(BUILDTAGS) netgo cgo static_build" -installsuffix netgo -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" -o contrib/cmd/recvtty/recvtty ./contrib/cmd/recvtty | ||
| 21 | + CGO_ENABLED=1 $(GO) build -tags "$(BUILDTAGS) netgo cgo static_build" -installsuffix netgo -ldflags "-w -extldflags -static -X main.gitCommit=${COMMIT} -X main.version=${VERSION} $(EXTRA_LDFLAGS)" $(GOBUILDFLAGS) -o runc . | ||
| 22 | |||
| 23 | release: | ||
| 24 | script/release.sh -r release/$(VERSION) -v $(VERSION) | ||
| 25 | -- | ||
| 26 | 2.7.4 | ||
| 27 | |||
diff --git a/recipes-containers/runc/runc-docker_git.bb b/recipes-containers/runc/runc-docker_git.bb index 9acfbae4..81e5a5d4 100644 --- a/recipes-containers/runc/runc-docker_git.bb +++ b/recipes-containers/runc/runc-docker_git.bb | |||
| @@ -5,7 +5,7 @@ include runc.inc | |||
| 5 | SRCREV_runc-docker = "4fc53a81fb7c994640722ac585fa9ca548971871" | 5 | SRCREV_runc-docker = "4fc53a81fb7c994640722ac585fa9ca548971871" |
| 6 | SRC_URI = "git://github.com/opencontainers/runc;nobranch=1;name=runc-docker \ | 6 | SRC_URI = "git://github.com/opencontainers/runc;nobranch=1;name=runc-docker \ |
| 7 | file://0001-runc-Add-console-socket-dev-null.patch \ | 7 | file://0001-runc-Add-console-socket-dev-null.patch \ |
| 8 | file://0001-Disable-building-recvtty.patch \ | 8 | file://0001-build-drop-recvtty-and-use-GOBUILDFLAGS.patch \ |
| 9 | file://0001-runc-docker-SIGUSR1-daemonize.patch \ | 9 | file://0001-runc-docker-SIGUSR1-daemonize.patch \ |
| 10 | " | 10 | " |
| 11 | 11 | ||
diff --git a/recipes-containers/runc/runc.inc b/recipes-containers/runc/runc.inc index ec017225..9199cef9 100644 --- a/recipes-containers/runc/runc.inc +++ b/recipes-containers/runc/runc.inc | |||
| @@ -51,7 +51,7 @@ do_compile() { | |||
| 51 | export CFLAGS="" | 51 | export CFLAGS="" |
| 52 | export LDFLAGS="" | 52 | export LDFLAGS="" |
| 53 | 53 | ||
| 54 | oe_runmake static | 54 | oe_runmake static |
| 55 | } | 55 | } |
| 56 | 56 | ||
| 57 | do_install() { | 57 | do_install() { |
