singulartiy: update to v3.8.3

2026-01-21T23:00:26+00:00

Bumping singularity to version v3.8.3-231-g9dceb4240, which comprises the following commits: dab3f5958 remove dependabot 5311c58d8 remove reference to maintaining the 3.8 branch d6ad7b62d disable dependabot a8a87c283 update reference to Apptainer 64041754b New Issue and PR creation lockdown (#6396) 022ccb8e1 disable dependabot on no longer maintained master branch 14f9b2893 defer to Apptainer ed6a01199 add extra patches to sylabs/scs-{key|library}-client 190ff0642 fix: do not output progress bar on redirected output 1f59b8ca3 e2e: linearize config --set --reset for concurrent pull tests cb9de1f0d feat: enable multi-part concurrency of 3 by default 679283181 feat: support for multi-part concurrent library image download 0ea5691e5 Bump plugin examples go.mod to go 1.16 and tidy 232d2579e build(deps): bump github.com/docker/docker 5e7ce75ea build(deps): bump github.com/containerd/containerd from 1.5.7 to 1.5.8 c0b68648f Update mvdan.cc/sh/v3 to fix variables scope in functions 2f5ae2779 fix: perform nvccli env->flags inside runtime, not CLI f9eef16b4 Remove initFile function 9a037421e Split SIF/bare types w.r.t `allow container $type` config 464be983b Remove github.com/containerd/cgroups fdf1496bf Update go.sum d151a8f0e 3.8.3 changelog / install.md changes 7915a504f build(deps): use github.com/sylabs/sif/v2 66ea4de52 build(deps): replace golang.org/x/crypto/ssh/terminal with golang.org/x/term 095ab698f ci: enable staticcheck linter ac4ea80b4 disable issue5808 regression test 4c45a965b installation instruction improvements fb46d06e9 disable issue5808 regression test 25d05c534 fix for markdownlint 57f5b34c4 Changelog and Install file updates for release 3.8.4 d18e43a69 reminder for libseccomp-dev package de28a42f7 add seccomp, cryptsetup, devscripts, correct go version test 645319097 fix: wire up contexts in CLI package 5e053ef0f Use 1.43 instead of 1.43.0 07fcc5601 e2e: ensure GPU tests use intended profile a1e78baa8 ci: enable dupl linter 78442de39 fix: wire up context in ORAS getResolver a8896d9f9 ci: bump golangci-lint to 1.43 93a3ab358 fix: Don't truncate config file until we have valid output to write 0dd0bf00d Update copyright year in --mount modified source 4e1e1f9e2 Add `--mount` entry to CHANGELOG.md bafb290c9 e2e: add actions test cases for `--mount` flag a6424c122 e2e: add build test cases for `--mount` flag 639e5e87f Add --mount flag to build command 51c934c8c Add `--mount` flag for long form mount specifications d27ff7a6f Handle multiple newline delimited mounts in ParseMountString c515be0bf Add ParseMountString for long-form mount specs 5344b137a Split ParseBindPath from config Get/Setters & add basic tests 8e9ecfc49 no longer set python=3 for conda ad02fd190 build: bump Go to 1.17.3 87847f6c8 Use StringArray for build bind option a9c9855a0 Fix typos 6db36af97 Update go.sum a361ec940 cgroups v2 support (apply from v1/OCI spec) 767dfa08e run e2e on any changes to .go source e6ea561cf disallow nvccli in setuid mode da7e74b1f Flip RunAsRoot->UserNS in RPC for NvCCLI ee5a57f95 Add changes to CHANGELOG.md showing ldconfig & cryptsetup are not searched for in $PATH 9b1817a0a fix: Correctly report --fakeroot + --nvccli build limitations 618e8fac3 fix: Pass SINGULARITY_NVCCLI to build post/test 94392c275 security: use trusted paths for execs from RPC server 548c6093e Rework --nv handling, add nvidia-container-cli option b85aad2f0 restore some previous behavior 9736d224b Mention support of older go versions in packaging. 772498d91 EnsureImage for E2E overlay tests 02093ce60 Fix TestFindOnPath 1e572c2a4 Update and provide test busybox.sif for alt archs 33f836840 build: remove RHEL6 workaround 72ca9d7b6 build: remove SLES 11 workarounds 5cc847934 build: simplify RPM spec 6c1f78572 docs: move GOPATH/bin export to golangci-lint section 64ad04e58 Markdown changes for 3.9.0-rc.1 fd0145b0e build: bump Go to 1.17.2 0ea3f8666 README - Zenodo link and general edits 70fa2943e Remove push prompt from newpair command b9d1d0e39 Update to CNI & Plugins 1.0.1 with stable 1.0 spec d6aacf08b Temporarily disable TestBusyBoxPacker b66377ceb chore(ci): bump Go to 1.17.1 785be6763 Typos found by codespell 134fea1f0 e2e: Bump OpenSUSE example, add arm64 for OpenSUSE & CentOS bootstrap 3b579e299 Fix LGTM uint32 parse warnings b694db7b2 e2e: Disable busybox bootstrap due to frequent dl failures 7dc244529 fix: wire up contexts in ORAS push/pull 520d94a70 fix: wire up contexts in CLI package 494dd00f2 Change log-plugin example to run at CLI level c2b04b490 refactor: adapt oras code to v0.5.0 API 5b2fe74d9 build(deps): bump oras.land/oras-go from 0.4.0 to 0.5.0 e907b2408 build(deps): bump github.com/docker/docker ac0aac8b4 Use v1.42.0 instead of v1.42 28e46ec06 ci: remove unnecessary disablement of govet check-shadowing 12fdd3cd8 ci: remove exclude-rules in linter config 1a0fbba3a ci: remove linters-settings for disabled linters bd704bc97 chore: bump golangci-lint to 1.42 fe2bd71eb document installing golangci-lint v1.42.0 469f8d8de build: add new build tag format comments ff7959b57 build: bump to Go 1.17 dd9d511d9 Bump mvdan.cc/sh/v3 and fix script sourcing from PATH plus minor fixes f8d33287f test: update interpreter test to reflect mvdan.cc/sh/v3@v3.4.0 0874bef1b update to 1.16 except for rpm, update mvdan.cc/sh/v3 to 3.4.0 2e60c3043 chore(deps): bump github.com/docker/docker f1457cb32 refactor: move pkg/util/gpu to internal 1a90cb4ac refactor: move packer/unpacker to internal 14c88119d Unify path handling for external binaries cbdb8478a Remove --nonet flag (unused) 93591a7c8 Remove environment variables eval for --bind, --nv and --rocm for build command 93f11bb3c go mod tidy update 53d6c7809 Honor `--no-https` for `library://hostname/...` URIs 5bf1b27c5 Change `--nohttps` flag to `--no-https` 63b84a11f indicate to use -w for gofumpt d7a565bf6 gofumpt all code ab4295da4 Enable gofumpt for golangci-lint a3514061d chore(deps): bump github.com/containerd/containerd from 1.5.6 to 1.5.7 7198716cb chore(deps): bump github.com/containerd/cgroups from 1.0.1 to 1.0.2 5187133c1 CHANGELOG.md update 96c0222c6 Do not automatically create an IPC namespace for instances 805ecc655 Add `--compat` short-hand for improved OCI/Docker compatibility 4102355dc chore(deps): bump github.com/opencontainers/selinux from 1.8.5 to 1.9.1 df93777dc revert copyright year change for now ed56e00f2 chore(deps): bump github.com/containers/image/v5 from 5.16.0 to 5.16.1 0ec89fa24 Replace cp (except -L) calls with docker CopyWithTar 5d5e46a5b restore contact info 04179d852 switch ci to rocky8 14ccbaf81 Inherit Docker/OCI LABELs during build 5cb2eed25 chore(deps): bump github.com/containerd/containerd from 1.5.5 to 1.5.6 d2db4d34b Enforce no dependency on buildcfg in pkg/..., based on sylabs/singularity#184 6a2bcaaf0 Ensure CoC is recognized by GitHub af3ba2b20 Split pkg/util/crypt key and device functionality 88a101321 Go, not Golang 5d3dab9e7 Update INSTALL.md for non-GOPATH build etc. 53d65b59b Lint markdown in CI, and fix existing lint 0288dac97 Allow --writable-tmpfs for %test step of build ea59ea9c3 bump golangci-lint to 1.41 318ce48be check source only once in a separate CI job 06a33c9ea refactor(ci): remove run-linter script 212ed6c0e update for go 1.16 7a73d0f63 fix merge errors 83d10d550 remove macos build d744e2b02 refactor: remove Darwin support from e2e-test script fca637d65 refactor: simplify platform support in e2e package db2a1499e refactor: simplify platform support in test package e24b2484f refactor: simplify platform support in capabilities package b48f8df9e refactor: simplify platform support in rlimit package 3dd4679d6 refactor: simplify platform support in init package 0677e741f refactor: simplify platform support in namespaces package 16c64ee9a refactor: simplify platform support in require package 33003fefc refactor: simplify platform support in starter package b4254b9af refactor: simplify platform support in loop package 6744491d6 refactor: simplify platform support in sources package 632df808c refactor: simplify platform support in cli package 24570a0ff refactor: simplify platform support in seccomp package cff3be38d refactor: simplify platform support in selinux package 48bfe2685 refactor: simplify platform support in apparmor package 8d0f9d748 refactor: remove ExcludedOS from cmdline.Flag 215cf0f37 Fix LGTM warning: Unreachable statement 4ecbfa452 Updates to the Changelog 816ca3b6d Changelog updates for r3.8.3 8ccb94315 Fix a regression introduced by #6008 adding bind mounts without destination two times 08dd8e66b Revert "Fix a regression introduced by #6008 adding bind mounts without destination two times" 201a7e277 Fix a regression introduced by #6008 adding bind mounts without destination two times 26a215ee8 Fix a regression introduced by #6008 adding bind mounts without destination two times 18799d8df Change log edits for release v3.8.2 3d8c116d4 Change log edits for release v3.8.2 162321329 add message about update to golang-x-crypto dcb9b390c update golang-x-crypto to latest version b824245e9 chore(deps): bump github.com/hpcng/sif from 1.5.1 to 1.6.0 c81e8d86d fix url in comments 8b046442f Add e2e test for conda env activation from `%environment` 11d25abe6 fix: interpret individual Stmt in internalExecHandler 927ab88a4 chore(deps): bump github.com/sylabs/scs-build-client from 0.1.6 to 0.2.1 5c0652f57 chore(deps): bump github.com/sylabs/json-resp from 0.7.1 to 0.8.0 758c3eb36 fix EscapeDoubleQuotes name in comment caught by revive fba6d34e8 fix: Check for *host* non-root uid when setting unsquashfs flags 8a1deecd5 fix: always check dest for globbed %files 3ae281b00 Failing test for issue #261 multi-glob copy 0aae4b5eb Markdown doc changes for 3.8.2 fb37ecb01 fix: Escape ' in docker CMD / ENTRYPOINT for runscript d069e7b95 testing: skip hugetlb cgroup limit for non-2MB page size 50e8c7798 move mountinfo panic fix message to 3.8.1 where it was implemented but not documented 4f2ef4205 Add test and changelog entry for mountinfo splitting fix 63f623cbc fix: honor hostname in library URI for `singularity build` ab4eca82b Ensure lolcow references point to non-fortune image 291193174 Fix e2e for usages messages from #217 6a219e083 fix: avoid duplicate `remote.yaml` entries from multiple login 076c7c68e docs: revise CLI help for remote login 8f9718571 fix: --tokenfile not supported for oci login so give error 1d3ad986e fix: honor hostname in library:// URI for `singularity delete` a1055ebbf Copy globbed files to correct destination in `%files` 3e971c4fe fix: use correct Debian arch for debootstrap 84446800a chore: bump Go to 1.16.7 af9d9e248 chore(deps): bump github.com/containers/image/v5 from 5.15.0 to 5.15.2 8c2cd0d84 chore(deps): bump github.com/containers/image/v5 from 5.15.0 to 5.15.2 7a59a1e6d chore(deps): bump github.com/google/uuid from 1.2.0 to 1.3.0 044a7f9aa Added myself to CONTRIBUTORS.md 6495bda29 Improvement to the comment 08c7d38d3 R3.8.1 CHANGELOG.md update to fix file size verification of Arch Linux pacman.conf db95190ae Fix for issue #6091: Unable to build ArchLinux image due to pacman config download problem. b7895b09d Remove reference to sylabs repo issue bc8115f6b Remove reference to Sylabs repo issue 197993227 Improvements to 3.8.1 CHANGELOG.md 9b3c92b6e 3.8.1 INSTALL.md updates 70e96d9db 3.8.1 CHANGELOG.md updates 22e80a349 chore(deps): bump github.com/google/uuid from 1.2.0 to 1.3.0 d0b61c624 Update README link to Talks web page f44a29161 fix: remove use of deprecated Amodebuf field a988550fa refactor: use GetReader to obtain key material b5911ccd3 fix: partially replace UUID module e837a7d76 fix: update code to account for uuid module breaking changes b34c18f5d fix: ensure created SIF images are unloaded 97083a976 Bump github.com/hpcng/sif from 1.2.3 to 1.5.1 3e2660a96 undo "Inherit Docker/OCI LABELs during build" to keep out of 3.8.1 release a44f37602 Account for mvdan.cc/sh default vars in env unit test 3263c649b Bump mvdan.cc/sh/v3 from 3.2.4 to 3.3.1 d5541a86a Bump github.com/opencontainers/selinux from 1.8.3 to 1.8.4 1cf43e7b8 Bump github.com/cyphar/filepath-securejoin from 0.2.2 to 0.2.3 ab2baf64e sylabs should be replaced with hpcng 17b5189ec fix: Allow env vars with literal $ via \\\$ in SINGULARITYENV_ f346edb1d test: fix (*sifFormat).initializer unit test 01898841a Handle absolute symlinks in multi-stage copy 9cfbba96c e2e: fix registry instance for Skopeo 1.4.0 f2f868c7e Inherit Docker/OCI LABELs during build 1fc849fec ci: use Go 1.16.6 8eed5ac04 Update restrictive permissions sandbox warning b85f43001 Move RELEASE_PROCEDURE.md out of .github/ dir afa46a929 Track release-3.8 branch with dependabot f1c0fb77e refactor: include config.h directly in Go source bd7bafb6a Revert "refactor(ci): remove run-linter script" bae87f261 Revert "refactor(ci): set build tags in linter config" f7110d9ae Link to singularityce-community from README.md Conflicts: README.md af7ef8952 refactor(ci): remove run-linter script 6155091c7 refactor(ci): set build tags in linter config 00d4beaba fix: remove some lint in dummy sylog implementation 4be877d6a chore: bump Go to 1.16.5 c8165fc76 ci: replace deprecated golint linter feb349b49 fix: address lint found by revive linter e5e8e20ab Bump github.com/containerd/containerd from 1.5.4 to 1.5.5 536500ac3 Bump github.com/opencontainers/selinux from 1.8.2 to 1.8.3 b86c07e10 Bump github.com/containers/image/v5 from 5.13.2 to 5.15.0 cf1358b69 Split mountinfo lines on single blank instead of whitespace 5f4171868 Bump github.com/spf13/cobra from 1.1.3 to 1.2.1 13e49e5c3 Bump github.com/containerd/containerd from 1.5.2 to 1.5.4 32a0abff1 Bump github.com/containers/image/v5 from 5.12.0 to 5.13.2 23c09282c Bump github.com/sylabs/scs-library-client from 1.0.4 to 1.0.5 5ab6e5d1f Bump github.com/opencontainers/selinux from 1.8.1 to 1.8.2 76b0e3206 Update oras module to new vanity url 1b0c9aa8d update the help url from sylabs to hpcng 87847d933 update help url 876251913 Make getting IMAGE_ARG less redundant aec7ebbf5 suggest singularity --version to distinguish from singularity-ce 26ae10a0a Run gofmt with -s e137639eb change new image.Init name to image.ReInit 90f69dd96 avoid gc closing image file descriptor, by initializing when first referenced 4f32dcaa6 changed base image to rockylinux/rockylinux:8.4 5991629bb changed base image from CentOS to RockyLinux 0be54019b tell git describe to use most recent tag 916945612 Use env var to pass image argument Rename ContainerImage to ImageArg to better describe what is being stored d15f67832 Rename to avoid conflicts with Contain config cf56e6714 Update EngineConfig to store image argument, update logging example Fixes #6032 91a71d3a2 ci: bump golangci-lint to v1.40.1 abe1817d6 ci: remove deprecated maligned linter dd73e7db7 update debian in ci from stretch to buster 5248288a2 Minor improvement to the Release procdeure steps 7d44b1aa2 Add Debian packaging fixes to the change log 85b885aa0 Updates to the CHANGELOG preparing for final v3.8.0 release e5af79907 Removing the reference to the Hub and Registry which doesn't exist anymore 2ec18d623 Point documentation to HPCng site 0d67abe92 Rewrite RELEASE_PROCEDURE.md ba375d422 Replicating relevant changed from Sylabs PR 20 94f22e879 use generic names for ci builds, and add one testing oldest go version 6da1255d9 update to golang 1.16.4 90915f734 fix: use unix Setresuid/Setresgid 1830ddb7c Remove master socket file descriptor from Go netpoll in stage 2 (#5946) 5d35a1b8d cleanup extended 7b5832453 do not cd before running singularity, not needed 3468dfb32 updated instruction for debian directory d6add39f7 Update INSTALL.md dde0b3e81 reverted conflict 97abf4adc switched back architecture to any 0fc098a47 added debian link 32e264dc1 note how to clean up after the build 8cada7989 mention the place where the debian packages can be found after successful build. 586255902 Update INSTALL.md add3e7850 corrected some spelling errors. 5a3469e08 subsection for debian added. 811077cfe resolved conflicts a5ef1c3f7 added detailed info about the build process. 11c52b046 Some updates to make the debian packageing work. 1e638b488 add package-version as top level directory in dist tarball 18fcb7d83 Add space after user prompts for aesthetic purposes 15de334bd Do not show keystore URI in newpair confirmation message fa6e59986 update versions and links 33e53c107 Bump github.com/hpcng/sif from 1.2.2 to 1.2.3 4e6d1e509 remove dist/alpinelinux d1f2ab5d5 update web page links in md files 0ef343f4e Bump github.com/containerd/containerd from 1.5.0-beta.4 to 1.5.2 22aada9bb update from check-go.mod aced1a365 Bump containerd dep with required oras update 84bc3bc33 Allow escaping commas and colons in source bind path with the following syntax: 1a0e3ad96 Bump github.com/sylabs/scs-key-client from 0.6.1 to 0.6.2 50eae88b0 add v3.7.4 for 3.8.0-rc.2 7e943fd18 e2e: Update library:// actions fail e2e comment 1f676cda3 e2e: if an invalid remote is set ensure library:// actions fail dcfc12f50 fix: respect current remote for actions against library:// URIs ae6331e8c Changelog updates 521df2068 Updated message ed2142872 Create stale.yml d28857b4f Bump github.com/fatih/color from 1.11.0 to 1.12.0 865447aae replace sylabs URL with hpcng e062d467b Update CI e2e workflow 63ebe4e3a Update install instructions to v3.8.0 a2b9aa823 Updates to the CHANGELOG for v3.8.0 80396dc25 Setting the current list of maintainers for the code ca15c27b5 Update CONTRIBUTORS.md file 5d83f57aa Bump github.com/vbauerster/mpb/v6 from 6.0.3 to 6.0.4 934e359a4 Bump github.com/fatih/color from 1.10.0 to 1.11.0 a5876650a Bump github.com/pelletier/go-toml from 1.9.0 to 1.9.1 3856e7125 Bump github.com/opencontainers/selinux from 1.8.0 to 1.8.1 00b97f7a7 Update CI badge d058208ee Run e2e tests based on changes. f5568b51b Use github actions in replacement of CircleCI aa74d5b56 fix 3763a5623 Rename package github.com/sylabs/singularity to github.com/hpcng/singularity 3521763ad Update sif module to use github.com/hpcng/sif 18b3a8cbf Bump github.com/containers/image/v5 from 5.11.1 to 5.12.0 a9c63a447 Update CHANGELOG for changes through 2021-04-30 421206141 Trigger build e08cfa446 Update the contributors document ca6dd710b Spelling mistake in api.go cfafb71a0 fix: respect proxy on keyserver operations 9ce8fccf0 fix: wait for cryptsetup /dev/mapper device to appear (#5953) 90da97582 Implement a copy-through ProgressCallback for silent loglevels f427dfa66 oras: Work around harbor failure to accept SifConfigMediaType 177d3fb0c Bump github.com/containers/image/v5 from 5.11.0 to 5.11.1 fb96eb330 Update contributing information a8f0056a5 Streamline makefile test rules e2b795f47 Remove old integration testdata 54057c1fe Remove cmd/singularity/cli_test.go a63da656c Remove cmd/singularity/build_test.go & deffile_test.go 7be600d7d Remove action-test target 78941f933 Return helpers still needed by build_test.go 301dfb67e Remove cmd/singularity/security_test.go 756a3f5a1 Remove cmd/singularity/actions_test.go de5a055c7 Remove cmd/singularity/remote_test.go d5e836bef Remove cmd/singularity/instance_test.go 20264ead4 Remove cmd/singularity/pull_test.go 46e6568fb Remove cmd/singularity/env_test.go b83246c72 Remove cmd/singularity/help_test.go 8926dee73 Remove cmd/singularity/docker_test.go 9413e6841 Do not singularity build in ocibundle/sif tests f88007c7a Remove TestSelfTest integration test f49d42fbd Do not singularity build SIF in image unit tests df73659eb fix: avoid spurious error when network not requested 4f1dd0c36 fix: avoid setfsuid return warning on some gcc versions c13802a62 Add overlay command to ease the creation of ext3 writable overlay: - allow to create an overlay as a single ext3 image file. - allow to create and add an ext3 writable overlay to an existing SIF image. 953e6220f Bump github.com/containers/image/v5 from 5.10.5 to 5.11.0 83b953aeb Wrap e2e.PrepRegistry in a subtest 6428b6449 Accommodate ppc64le pageSize in TestCgroups b63980045 Disable -race for tests on ppc64le only 3eb9b4370 Add `--nv`, `--rocm`, `--bind` flags to build command. 34d5cf7d7 Accommodate multiple networks in --network request e66004d0d Address lint eaef312ff Adapt tests for allow net networks 2bfed39c4 Refactor and at unpriv network restriction f62363452 User list/group membership util funcs e93365544 Util slice.Contains[Any]String funcs b5a0df5b4 e2e test for allow net users / groups 87c1762a1 WIP - Allow configured non-root users/groups to use --net afaef2000 Bump github.com/pelletier/go-toml from 1.8.1 to 1.9.0 269d0d8b7 3.7.3 CHANGELOG and INSTALL changes c112a84e6 Update opencontainers/umoci to v0.4.7 ac07900d7 Bump github.com/sylabs/scs-key-client from 0.6.0 to 0.6.1 9ef88030e Bump github.com/sylabs/scs-build-client from 0.1.5 to 0.1.6 3d95251f0 Bump github.com/sylabs/scs-library-client from 1.0.3 to 1.0.4 5e931e593 Bump github.com/sylabs/json-resp from 0.7.0 to 0.7.1 061eadf3f changed PowerTools -> powertools, alien rpm install 0f1037456 fix: added test for conflicting args f64c928ee feat: add e2e tests for host name in library ref 2413cde5e fix: properly handle library://collection/container ref ae8e6e461 fixed powertools repo name 4f7aae4e5 Bump github.com/vbauerster/mpb/v6 from 6.0.2 to 6.0.3 fc98b3ca4 feat: implement support for host in library reference c73bdf711 Bump github.com/deislabs/oras from 0.10.0 to 0.11.1 49fd07901 e2e: walk until gid!=0 when finding unpriv uid/gid 84e871e46 3.7.2 changelog updates e12740db0 Bump mvdan.cc/sh/v3 from 3.2.2 to 3.2.4 bd7f8b30b Bump github.com/containerd/containerd from 1.4.3 to 1.4.4 1990a6053 Return original instead of panicking if RelocatePath fails 9c5093a2f Panic if SINGULARITY_SUID_INSTALL is set inside RelocatePath 333e49f12 Don't generate any relocation code if SINGULARITY_SUID_INSTALL 495815c32 Apply review comments b40a1b282 Make runtime relocatable 8a0d4e91c Update CHANGELOG.md and CONTRIBUTORS.md 35add4570 Bump github.com/containers/image/v5 from 5.10.4 to 5.10.5 bc54719f4 Bump github.com/containers/image/v5 from 5.10.3 to 5.10.4 dbd9ed700 Bump github.com/containers/image/v5 from 5.10.2 to 5.10.3 c6bf4595b Fix high memory usage during build when destination image is present and is big by inverting logic and check for known image format instead of checking for a definition file which is reading the file entirely in memory and causing high memory usage. b963118d5 Unit test: fix TestLoop by closing loop device 774d743a5 Bump github.com/vbauerster/mpb/v6 from 6.0.1 to 6.0.2 f28292586 Bump github.com/spf13/cobra from 1.1.2 to 1.1.3 3aca23496 Fix progress bar display when content-length unknown f26042552 Bump github.com/deislabs/oras from 0.9.0 to 0.10.0 28e892af9 Bump github.com/containernetworking/plugins from 0.9.0 to 0.9.1 46362422f Bump github.com/sylabs/scs-library-client from 1.0.2 to 1.0.3 f86674504 Bump github.com/containers/image/v5 from 5.10.1 to 5.10.2 c3d29c850 Bump github.com/spf13/cobra from 1.1.1 to 1.1.2 bddd8616d Refactor --builder and --keyserver handling to match --library f93b64c03 Fix falling back to default library message URI 9099c8802 Set empty default var --library in build/delete/push/search 23b5917c3 Correct e2e issue5808 remote remove f9d6c956d fix: allow pull with --library https://library.sylabs.io 5c7ebc55e Add failing test for #5808 ee292fb73 e2e: Force insecure policy for skopeo ea3d00077 Bump github.com/containernetworking/cni from 0.8.0 to 0.8.1 8f7d693c6 Bump mvdan.cc/sh/v3 from 3.2.1 to 3.2.2 76c7774ee Bump github.com/containers/image/v5 from 5.9.0 to 5.10.1 cdf30825d Upgrade to oras v0.9.0 0d5db59d6 Bump github.com/buger/jsonparser from 1.1.0 to 1.1.1 f40667ab4 Update README/INSTALL.md for 3.7.1 release 03dbee2ff Show correct web URL for detached builds aef9b0646 add --without-seccomp 76dec27e4 Update changelog with post 3.7.0 fixes 709328499 Bump github.com/buger/jsonparser from 1.0.0 to 1.1.0 376f61778 Switch from img to skopeo for e2e registry prep 7815ef611 Bump github.com/containernetworking/plugins from 0.8.7 to 0.9.0 f073207e2 Remove spurious warning in parseTokenSection() 4e007a72b Use -buildmode=default on ppc64le e6319312c Fix loop devices file descriptor leak when shared loop devices is enabled dd885377a Bump github.com/opencontainers/selinux from 1.6.0 to 1.8.0 8d499cb22 fix some phrasing and typos in starter_linux.go 09f0c49b0 e2e: Prepare docker-registry first, to avoid instance/oci errors fcfc098e5 Bump github.com/containers/image/v5 from 5.8.1 to 5.9.0 9d295978e Add capabilities funcs for non-linux (unsupported) cbb58e8cf e2e/security - compare to root CapEff, not regex 04eab3169 Bump mvdan.cc/sh/v3 from 3.2.0 to 3.2.1 52ac48498 Bump github.com/containerd/containerd from 1.4.2 to 1.4.3 fca8488e4 Bump github.com/containers/image/v5 from 5.8.0 to 5.8.1 84eb15d62 Re-commit/push due to CI (AWS ?) issue e24e639c9 Support unsquashfs 4.4 in inspect e2e test e0117b943 Allow failure of /sys/fs/selinux remount on kernel 5.9+ d939c14e0 Bump github.com/containerd/containerd from 1.4.1 to 1.4.2 f3d1766b2 Bump gopkg.in/yaml.v2 from 2.3.0 to 2.4.0 ab130b13f Typo fix for CHANGELOG v3.7.0 41c75be82 Fix version number typo in changelog 53d87f601 Release 3.7.0 markdown doc changes 36e0e7c51 e2e - pass docker hub credentials through sudo call 7ddbe62b7 Set _CONTAINERS_ROOTLESS_UID in fakeroot build environment 3e45ed97a Bump github.com/containers/image/v5 from 5.6.0 to 5.8.0 783aa2ff2 Update to scs-library-client v1.0.2 (#5708) c0959a192 Move rpmbuild jobs into a separate CI workflow. 8f332df3c Fix repeated output of non-terminated progress bar b4999fb0c add built tags b54319502 CHANGELOG and MD updates for 3.7.0-rc.1 6eac3945b exported function 5e0c1dd32 Fix loop device file descriptor leak for ocibundle package 3f9071513 Remove TravisCI badge from README.md ac2aa0c0f Add cwd option for --no-mount 6ded3fb1b Add e2e tests for --no-mount b4bce99ce Add --no-mount to disable singularity.conf mount options 150b230a9 refactor: adapt to scs-key-client v0.6.0 1594ca206 Bump github.com/sylabs/scs-key-client from 0.5.1 to 0.6.0 e48a5b72c Add regression test 35636264f Clean comments from %file args before use 3f65227fa Pass context down through GetLocalPacker b63cc700b Verify SIF sources at build, optional Fingerprint check 4442131b3 Fix failure with unsquashfs >= 4.4 when extracting pseudo devices as a non root user e359bf22e Move FindSize() helper func to platform agnostic location d63e8e919 Updated to scs-library-client v1.0.0 d81abe5d2 Fixed comment d15c09917 Fix for removal of duplicated [Ff]indSize() func 02d0cd91a Update go.{mod,sum} c1c797da5 Basic e2e tests for GPU functionality 6f0779465 Light refactor of GPU libs handling ece18a4eb Updated go.{mod,sum} a5f5223f4 Display quota usage and URL after library push (upload) b85cd4872 Push progress bar fixes 0998a0d50 Make push/pull verification warning messages consistent 90fcf53e1 Bump mvdan.cc/sh/v3 from 3.1.2 to 3.2.0 ac7b6b7d6 Bump github.com/fatih/color from 1.9.0 to 1.10.0 d35c3cbcf Overhaul `singularity search`. 731822b86 Show token status in `singularity remote status` 12a9dbe14 error checking 1b0209192 check test cases 230ce9dc9 Update CI config and helper scripts to use credentials from env 12ccffe21 Ensure all unit tests pulling from Dockerhub are excluded from short f0d2437b5 Authenticate with dockerhub before running e2e 5e3ce48a9 Regression test for #5668 unsquashfs on tmpfs d1e6c2d94 unsquashfs - don't extract xattrs where not supported by fs d8de79c9b Drop ineffective ldconfig LookPath error check a8a40259e Try /sbin/ldconfig for gpu libs if $PATH ldconfig fails 84360fca7 Pass user env/flag binds into conatiner as SINGULARITY_BIND 808c1e57b Reset environment while retrieving library dependencies for unsquashfs sandbox 3f1e9dceb Propagate proxy environment variables for e2e tests 3696aa6d1 Set labels dynamically from build post section through SINGULARITY_LABELS dd3d13fa8 Support key import from stdin cd66c7cd0 Update Sif layer mediaType for ORAS 17dcf2504 Change shell interpreter command timeout from 5 seconds to 1 minute 534afeab8 use max value from config c52adca82 use max value from config a337a4532 use config value 6cf53d865 Return error when listing private key from global keyring e37a50abf For actions, defer cache init until we know we need it 7cc21b1d4 Clarify CLI help for docker / oras URIs b07cef75a Drop the depends on github.com/docker/docker 396e0cb2c Fix e2e key help tests e55d021df Use global-pgp-public instead of pgp-public. Fix CLI key help. 417cc321b Add global keyring management for ECL 2d42b1f64 Drop the depends on github.com/opencontainers/image-tools b2736bb87 Bump umoci to 0.4.6 850a48162 Regression test for #5465 5332c40a2 Allow /etc/localtime & /etc/hosts bind to fail ec949633d Ensure files staged into build do not match distro package content 230535763 Small refactor of library push code 86b8fdd32 Add -D/--description flag for library pushes c606c1a7b Force a prompt if `PS1` is empty entering a container. d2b237359 Give useful message when we can't extract an ext3 image b3ba7e436 Use correct private pull func in OCI PullToFile ee4c6209b Update e2e testPullDisableCacheCmd to fail on #5628 74babc850 Regression test for #5631 enable fusemount=no fc0fa3c07 Don't install old golangci-lint in individual CI jobs f5e3c5931 Refine remote login flow where token already exists 297293157 Don't fail on enable fusemount=no when no fuse mounts needed 4d1b3d14e Be more explicit in `remote login` prompts / info 05a9d4159 Record build-arch as a label with build host architecture 65fbac8f6 Bump github.com/spf13/cobra from 1.1.0 to 1.1.1 6b98a5714 Copy app metadata when listing apps 405831921 Use powers of 1024 in cache list -v sizes 437e5f85b Note package availability in INSTALL.md fdb727c9b Add trust info to key pull help. key store->keyring d94dbf006 Support double quoted filenames in %files sections bdb41d76b e2e test for actions umask propagation 195835c33 Restore umask in container, actions, not fakeroot 8495e708e Bump github.com/spf13/cobra from 1.0.0 to 1.1.0 18322f791 Improved nvidia driver selection consistency when using nvidia-container-cli (#5574) 4d4a60ead Fix remaining lint 68a236547 pkg/util/fs/overlay Linux only c00607f72 Add pkg/util/rlimit/rlimit_unsupported.go 916514ed3 Fix e2e code triggering deadcode error on mac 34b319231 3.6.4 CHANGELOG entry 35dc1e4d7 Move test require cgroups checks to require_linux.go adc246f8d Update golangci-lint and make version check more permissive 017ad914e Run unsquashfs in a sandboxed environment via singularity exec and optionally `-f` option to prevent overwrite or creation of files on the host filesystem during the extraction, the removal of `-f` is conditional, typically for image build `-f` is required and seems unavoidable. 2afaa233d Add scs-library-client update/bugfix to CHANGELOG.md 3afa1a178 Bump github.com/sylabs/scs-library-client from 0.5.6 to 0.5.7 (#5588) c7b02eec8 Grab all inspect metadata and add them as a SIF descriptor. 783aa145e have docker client use SINGULARITY_TMPDIR for temp files b2a00b09f Bump gotest.tools/v3 from 3.0.2 to 3.0.3 46fce5887 Read inspect metadata from inspect-metadata.json SIF descriptor 8fc9d23e7 Fix e2e remote tests. Fix sylabsRemote logic within CLI. Fix `singularity remote use` useless global sync. 4fe17201e Run unsquashfs in a sandboxed environment via singularity exec and optionally `-f` option to prevent overwrite or creation of files on the host filesystem during the extraction, the removal of `-f` is conditional, typically for image build `-f` is required and seems unavoidable. a23565395 Bump Go version in INSTALL.md to 1.14.9 e52c8373c Move CI to Ubuntu 20.04 and Go 1.14.9 d64823075 Check for empty username with Docker/OCI registry login. f58ac3904 Fix wrong status check within keyserver round trip. 20f3c2a87 Enforcement when endpoint is exclusive denying use of alternative library, builder or keyserver. Add a endpoint remote configuration cache with a refreshing rate of 1 month. Fixed some messages and login password logic. 69f06eb51 Bump github.com/sylabs/scs-library-client from 0.5.6 to 0.5.7 (#5588) b6093549e Fix lint issues 2e65cdf2a Fix CLI unit tests 3fc8612ee Singularity remote command enhancements: e1cd50ffe remove centos-specific packages, no longer needed c8cdd7389 add action-test to test actions other than overlay 3dc4648db Bump github.com/containerd/containerd from 1.4.0 to 1.4.1 (#5580) fd6865968 Bump github.com/containers/image/v5 from 5.5.2 to 5.6.0 (#5579) 21bdad676 reduce no-output timeout of rpmbuild to 10 minutes 190d112ef remove special centos behavior and extra fi 74f0352cc v3.6.3 release CHANGELOG.md / INSTALL.md entries 17aa470f3 fix: ensure packer TempDir locations are secure 5a8be6796 fix: ensure proper perms on bundle tempDir 82b2e7166 refactor: return imageDir from convertImage 01a5cb2fc fix: ensure proper perms on tempDir in execStarter 9dfffdb79 Update CHANGELOG.md for cherry-picks in #5563 86ad23c09 Bump github.com/pelletier/go-toml from 1.8.0 to 1.8.1 (#5570) 1be97c9c4 Ensure sandbox option overrides remote build dst d80db6cc9 Ensure sandbox option overrides remote build dst c9815100b Do not load keyring in prepare_linux if ECL not enabled 200db219b Fix unsupported builtins panic from shell interpreter and add umask support 2e8be5f63 Fix decryption issue when using both IPC and PID namespaces 621d932b4 Add CAP_MKNOD in capability bounding set of RPC to fix issue with cryptsetup when decrypting image from a docker container 74f2d1611 Do not load keyring in prepare_linux if ECL not enabled f231b426e add rpm build and test of centos7 and 8 716bdd670 move travis files to circle 821df288b refactor: return imageDir from convertImage eb925ab6b fix: ensure packer TempDir locations are secure d777ed1e9 fix: ensure proper perms on bundle tempDir d54e43fb1 fix: ensure proper perms on tempDir in execStarter bc5884992 Fix unsupported builtins panic from shell interpreter and add umask support 9fbaddbb4 Fix decryption issue when using both IPC and PID namespaces f5dc97a11 Add CAP_MKNOD in capability bounding set of RPC to fix issue with cryptsetup when decrypting image from a docker container 052825274 added example build-singularity 9e24129e9 Bump github.com/containernetworking/plugins from 0.8.6 to 0.8.7 (#5537) 63662e323 Allow RHEL7 cap set in e2e/security tests d9a79c6e6 Bump github.com/sylabs/scs-build-client from 0.1.4 to 0.1.5 (#5531) 5c40c2ae5 Bump github.com/sylabs/scs-library-client from 0.5.5 to 0.5.6 (#5530) 94b8dcadb CHANGELOG.md updates for 3.6.2 f64e9e227 Bump versions in INSTALL.md for 3.6.2 44b29c6fd Don't fail if parent of cache dir not accessible e16776867 Remove legacy dependabot config c665ffc0a Correct --no-home message for 3.6 CWD behavior dc6f46d4b Fix typo in -user-xattrs warning message 8b9f1b3fe Regression test for #5399 93dfdf8bc Use -user-xattrs in rootless unsquashfs when possible 547399010 Pass engine configuration through environment variables instead of a unix socket pair to allow bigger configuration to be passed between CLI and runtime. This implementation depends of RLIMIT_STACK current limit and also has a maximum hardcoded maximum size of 1Mb for the engine configuration. d902a87b5 Bump github.com/containerd/containerd from 1.3.7 to 1.4.0 (#5504) 6fb46d856 Bump github.com/apex/log from 1.8.0 to 1.9.0 (#5513) ac2aa43d3 Bump github.com/containers/image/v5 from 5.5.1 to 5.5.2 (#5512) fa5a27fa6 Use alpine for hash pull test - cached so one less download f195a1612 Remove redundant key pull in e2e tests 0bf17ebb6 Correct missed alpine:3.8 pulls to 3.11.5 efbf58732 fix: address 'Ctty not valid in child' in e2e-test 6df609de1 Fix environment variable duplication within singularity engine configuration between host variables and SINGULARITYENV_ prefixed variables. 3e26476fa Fix LD_LIBRARY_PATH environment override regression with --nv/--rocm 2fcc48aee Simplify delete confirmation message b87075f25 Bump github.com/seccomp/containers-golang from 0.5.0 to 0.6.0 (#5486) f139de0ff Bump github.com/sylabs/scs-key-client from 0.5.0 to 0.5.1 (#5489) b73c0a24a Add --force flag for singularity delete 009b134bf Respect remote and current arch for singularity delete 07abc0fd6 Filter `mkdirat` for seccomp tests on ARM64 92097b177 Allow rw as (noop) bind option 7c3204ca4 Bump github.com/apex/log from 1.7.0 to 1.8.0 (#5480) 595d38bc4 Fix sshfs FUSE e2e tests to use ssh_config from the sshfs alpine image 93cdec1d9 Bump github.com/apex/log from 1.6.0 to 1.7.0 (#5472) 03a933ab6 Bump github.com/sylabs/json-resp from 0.6.0 to 0.7.0 (#5471) f6b5f569a Bump github.com/containerd/containerd from 1.3.6 to 1.3.7 (#5470) 0e60db3d7 Reworked RPC capability handling to fix regression issue during overlay mount. RPC now modifies its effective capabilities on a per method call basis and will abort execution by reporting the missing capability in a less cryptic error message. bafe5bbb6 Create dependabot.yml 605a7ce68 Use -mem and -processors on all ensureGzipComp mksquashfs calls b073c582f Add CHANGELOG.md entry for legacy unset PATH fix a808d2af9 Add regression test for #5426 65274f63e Don't unset PATH in legacy /environment file handling 9236db413 Changelog entries for 3.6.1 merged PRs a1500c2da Provide advisory error message for missing overlay image upper/work 6ce29d94d Use squashfs mem and processors limits in enzureGzipComp 30dc5c43a Ensure build destination path is not empty 35854da99 Fix _FORTIFY_SOURCE=2 runtime failure and enable security hardening features 1c8902b38 Bump github.com/sylabs/sif from 1.2.0 to 1.2.1 (#5431) 7d24865d2 Load command tree in doc gen code 7c17188cc Bump github.com/apex/log from 1.5.0 to 1.6.0 (#5423) f19861a61 Ensure expected privilege during remote add/remove inner test goroutines 7ffd3cc48 Update to sif v.1.2.0 (integrity additions) ad9658a81 Update CHANGELOG.md for 3.6.0 release 01d3e16a0 Bump github.com/apex/log from 1.4.0 to 1.5.0 (#5421) 88ccf15ee Bump github.com/opencontainers/selinux from 1.5.2 to 1.6.0 (#5418) 622f00b4a Update container IDs used in tests to reflect latest CNI spec 6a193eb4b Expose boolean to ignore verify errors in VerifyCallback 8faa17fa2 Bump github.com/containernetworking/cni from 0.7.1 to 0.8.0 4bdf9a55a Skip inaccessible loop devices in shared loop code e838063fb Fix lint a44675896 Removed repetitive code, renamed variables, return correct statement 9294ebc95 Load keyring handle dynamically to avoid libnss issue a42ae70ef Update signed test images acb74dabd Fix up verify E2E tests bb5920761 Implement output for verify 384736b3e Migrate ECL code to use SIF integrity package 7a6ed9a33 Migrate push/pull code paths to use new signing code 1c45595cf Use SIF integrity package for verify a548c7241 Use SIF integrity package for signing 7d06f8bc5 Bump github.com/containerd/containerd from 1.3.5 to 1.3.6 (#5406) e499d0175 Made changes via Adam's suggestions 3efd3264f Changed STDOUT formatting to use TabWriter; Edited -l (--logs) flag description ddbd4f190 Bump github.com/containerd/containerd from 1.3.4 to 1.3.5 (#5402) 8e0be03ff Bump mvdan.cc/sh/v3 from 3.1.1 to 3.1.2 (#5401) f9259bda5 Added GetLogFilePaths to use as getter function for .err .out streams 206c54e27 Added myself to Contributors.MD a34b78cb2 Added .err and .log paths to singularity instance list json formatting, added -l, --logs to display logs in regular format 765027afd 3.6.0-rc.5 CHANGELOG entry 34c1e47fd Bump github.com/sylabs/sif from 1.0.10 to 1.1.0 (#5393) 91496e6f3 Disable globbing in clear_env and restore_env function within action script to avoid wildcard evaluation which may be contained in environment variables value, it fixes a performance regression issue observed in #5389 when the current working directory contains a large number of files/directories. 8745d0acf Use new opencontainers/umoci location for umoci d8de24849 Don't -failfast by default in tests 0f318d24a Bump github.com/containers/image/v5 from 5.4.4 to 5.5.1 (#5387) 7f0ee3a8c Fix ECL file descriptor leakage ec5611d21 Improve ECL tests 98466b15c Reorder for consistency and readability 77a012879 Bump github.com/apex/log from 1.3.0 to 1.4.0 (#5382) 1dbce00e0 Bump github.com/sylabs/scs-build-client from 0.1.3 to 0.1.4 (#5378) adfd48164 Improve tests on non amd64 architectures f6df3c4ae Raise `max loop devices` in e2e/config test e50cd3fc4 Check correct descriptor for e2e encryption tests 3ef01be8a Bump github.com/sylabs/sif from 1.0.9 to 1.0.10 (#5366) 7de3fe758 Use provided arch in library pull acf39f8f4 Give RPC server CAP_IPC_LOCK for cryptsetup a84060593 Use new multi-arch docker images for tests 0da30c925 Add Arch test requirement function 9e1ed0568 Bump github.com/sylabs/scs-library-client from 0.5.4 to 0.5.5 (#5349) f49b8a81e Bump github.com/seccomp/containers-golang from 0.4.1 to 0.5.0 (#5343) 4dd111f54 Update CHANGELOG pre-release version for 3.6.0-rc.4 22269f9fd Avoid redundant userns check loop in setSessionLayer 0d6336278 Fallback to underlay in %test invocation in user namespace 94cdfedd8 Test for issue 5135 - fakeroot %test regression 3d23b3d56 Bump github.com/sylabs/scs-library-client from 0.5.3 to 0.5.4 (#5326) 4b9ff1135 Bump github.com/spf13/cobra to 1.0.0 d41b2574e Bump github.com/buger/jsonparser to 1.0.0 476c81e09 Bump github.com/blang/semver from 3.5.1 to 4.0.0 2fc918bff Bump github.com/apex/log from 1.1.4 to 1.3.0 (#5321) 1bf7ee6f9 Bump github.com/opencontainers/selinux from 1.5.1 to 1.5.2 (#5318) 66a00d8c6 Bump github.com/seccomp/containers-golang from 0.3.2 to 0.4.1 (#5311) 48053a770 Adjust container capabilities based on latest capability available fe527e2ac Fix missing warning when using --writable-tmpfs with underlay. 5aaf379d7 Document removal of check command 25d784bf4 Bump github.com/pelletier/go-toml from 1.7.0 to 1.8.0 a9b8b9489 [e2e] Pin to a 0.5.7 version of img in DockerRegistry.def dd572a8dd 3.6.0-rc.3 CHANGELOG 08ef8502c Bump github.com/containernetworking/plugins from 0.8.5 to 0.8.6 (#5289) d30940f1b Bump github.com/opencontainers/go-digest from 1.0.0-rc1 to 1.0.0 929ed4564 Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 b8047645a Update CI badges 85e69259c Bump github.com/containers/image/v5 from 5.4.3 to 5.4.4 (#5283) 1a1c4fac0 Add Dependabot configuration 72a7a523c Mark GPFS is incompatible for overlay lower and upper ea18261c4 Bump mvdan.cc/sh/v3 from 3.1.0 to 3.1.1 (#5275) 20293148e Respect available caps when setting privileges 52d18c393 Handle SIGTSTP to send SIGSTOP to master process after sending it to container process to notify parent process with SIGCHLD and correctly handle CTRL-Z case. 1349a3473 Fix regression when using `--writable-tmpfs` resulting in mounting overlay in read-only mode due to a fallback in kernel overlay code not being able to create work directory, before rework of RPC server privileges it was required to mount overlay as root user by switch filesystem UID/GID, now that RPC is running as current user with a set of capabilities the change of filesystem UID/GID is not required anymore and fix this regression. 80d8b2bc2 Update CHANGELOG.md for 3.6.0-rc.2 ee9559fd9 Update --fusemount help. Fixes #5255 2c5469042 Use fakeroot profile in issue5211 regression test 27c2f2f49 Use CurrentOriginal to determine getHomePaths result 50b89cb94 Return HomePath for --fakeroot so /home/dave correct even with --contain 5d2515965 e2e test for multi-line, invalid env vars 33d1bb7ce Handle invalid env var keys and multi-line values e1e567c63 3.6.0-rc.1 markdown doc changes 8adeae817 Add failing test for $HOME with --contain --fakeroot 39169ea5f Add 5211 test case to e2e actions suite 9caf7612b Shamelessly add sloretz to contributors file 904234de6 Add regression test for 5211 0cc329c35 Don't mount home when using --fakeroot and --contain a60715597 Correct e2e noninteractive cache tests / remove --name 7904242e4 Simplify time.Now().Sub(..) to time.Since(..) 579900f16 e2e tests for cache clean --days b95f8f871 Option to clean cache items older than n days f0a650599 Bump github.com/sylabs/scs-library-client from 0.5.2 to 0.5.3 (#5247) d1b76995d Bump github.com/sylabs/scs-build-client from 0.1.2 to 0.1.3 (#5246) 13f63115a Bump github.com/apex/log from 1.1.2 to 1.1.4 (#5241) 740dfd716 Use official Golang containers for go113-{stretch,alpine} jobs 456663f66 Remove unused YAML anchor b6cdf8cef CI: remove redundant build_check_and_install step cf7c8e927 CI: simplify check_go_mod 528bdaf02 CI: use public Go module mirror rather than CircleCI for caching adaf76504 CI: use checkout step rather than get_source job b485a1570 Ignore SIGURG in MonitorContainer (#5231) 7f8ce7d86 Ignore SIGURG in StartProcess (#5231) bc173cb1f Use buffered chan for signal notification 6f3d6ebce Update test to reflect updated library://alpine:latest 454c37f0a Update CHANGELOG with more complete 3.5->3.6 changes d5c3f1347 Don't attempt impossible home mount of '/' 2f8a931c1 Bump github.com/sylabs/scs-build-client from 0.1.1 to 0.1.2 (#5226) 6541b42ac Bump github.com/sylabs/scs-key-client from 0.4.1 to 0.5.0 (#5225) e21165c12 Bump github.com/sylabs/scs-library-client from 0.5.1 to 0.5.2 (#5224) b398267dd Bump github.com/containerd/containerd from 1.3.3 to 1.3.4 (#5213) d1e5dde4a Handle correct public/private key check for build/actions e96b5c024 Simplify duplicate mount point warning message 2ef130059 Use subcommand in usage messages after #5208 66b251d3f Use context cancellation for CLI -> Client download cleanup 237fcb69c do go clean -modcache before removing old build root d1e24db53 Bump mvdan.cc/sh/v3 to 3.1.0 3a0affc5e Remove setns compilation check and define custom setns wrapper to not rely on setns libc wrapper anymore. 688699ea3 Export SINGULARITY_ENVIRONMENT to container for shell/exec/run/test action commands. e87cdc378 Do not unset SINGULARITY_NAME/SINGULARITY_CONTAINER variables during container environment variables handling. 1b0c26e8a Bump github.com/containers/image/v5 from 5.4.1 to 5.4.3 cf4510229 Bump github.com/opencontainers/selinux from 1.5.0 to 1.5.1 735230984 Process appinstall sections in order in build 05915b823 Update Go and Singularity versions in INSTALL.md 39eae7f64 Fix citation link 3daa8b7b2 Add scs-library-client CHANGELOG.md entries e3a3ee5c9 Add #5034 fix to CHANGELOG.md dd5fc05eb 3.5.3 CHANGELOG.md updates 789af4b3e Reduce warning showed when 'user bind control = no' fc7a2b644 Improve namespace error message in C starter code 3d165c844 Move internal/pkg/sylog to pkg/sylog 8e0b5a79e Remove http_proxy environment variable handling from yum bootstrap and delegate it to yum command directly as we pass current environment to yum bootstrap command. 5831bd349 Bump github.com/pelletier/go-toml from 1.6.0 to 1.7.0 a71398128 Honor insecure registries in /etc/containers/registries.conf 0dfc7ee07 Bump github.com/containers/image/v5 from 5.4.0 to 5.4.1 6b170cb06 Bump github.com/opencontainers/selinux from 1.4.0 to 1.5.0 1f1d911fa Change image->sandbox in overwrite message 288056e66 Fix issue triggered when using a FUSE image driver and creating writable overlay layout with fakeroot hybrid workflow, upper and work directory were created based on stat call done from master process running in host user namespace leading to permission denied error and falsely reporting upper/work directories as not existing by `fs.IsDir` call. A Lstat method was added to RPC methods to get information from RPC process living in user namespace. 6544769fa Ensure that sandbox build directory has a Singularity image layout before asking for overwrite and invite user to use `--force` if the sandbox directory doesn't look like a Singularity image. d4823771b Allow to specify a buildcfg parameter to get parameter value directly. Show SINGULARITY_SUID_INSTALL value. 6b346599e Fix user bind logic when binding devices from host /dev to container /dev: - binding a device into container /dev requires that both source and destination are identical - if `--contain` is requested or `mount dev = minimal` is set, a check for already mounted devices is done by precaution and show an explicit warning 0f0f0f02b Bump github.com/containers/image/v5 from 5.3.1 to 5.4.0 f3bbc45d3 Bump github.com/containers/image/v5 from 5.3.0 to 5.3.1 008065754 Bump github.com/spf13/cobra from 0.0.6 to 0.0.7 0e296a7f0 - Rework sylog package - Don't enable colorization if stderr is not a terminal - Disable colorization via the log level to be usable by both C and Go code - Modified C code to disable colorization if requested by the log level - Moved apexlog specific code in oci_unpack_linux.go 868bf9574 Fix resolved path check error. Some systems/filesystems combination trigger this error so far two cases have been observed: d0abb1116 Remove build engine 6fdc3f456 Log scs-library-client to sylog.debug via DebugLogger 36f19867e Bump umoci to commit with xattr error suppression 43f73f8c7 Check PEM is valid before starting encrypted build 15e0cafb4 Remove go report badge (service misbehaving) 509a45a79 Couple of fixes for inspect: - Move JSON metadata structure in a separate public package - Fix JSON structure to list multiple apps - Show more environment files content and store them within JSON as a map : - `/.singularity.d/env/90-environment.sh` - `/.singularity.d/env/91-environment.sh` - `/.singularity.d/env/10-docker*.sh` - Add `startscript` inspection - Add `--all` option to display all metadata in JSON format - Inspect data without chroot if image is a sandbox 3311bac13 Wrap run-help command around inspect command e0ac67849 Bump github.com/containers/image/v5 from 5.2.1 to 5.3.0 ec7fef55a Bump github.com/gorilla/websocket from 1.4.1 to 1.4.2 5ebc37ffa Fix configuration parser for empty slice and default value 4752939a2 Add e2e tests for --config global option ed582b11e Add e2e.WithGlobalOptions to specify global option for singularity command 113477ed8 Allow to specify another configuration file 28e0bb5c1 Add VFS for session layer manager 90cd028f8 Fix ECL error message 6c02e5161 Mimic CWD mount v2 behavior e8794413c - Use image package for SIF plugin code. - Store manifest along with binary object instead of the whole SIF image to save some space. af4ad2360 Remove useless image driver support configuration 364ccce6d Add runtime plugin configuration 56be5e6ca - Disallow image bind if `user bind control = no`. - Don't remove image bind from BindPath list. 25562aa62 Bump github.com/opencontainers/selinux from 1.3.3 to 1.4.0 d22797eff Wrap docker environment variable value with double quotes d452a9765 Fix backslash escape with declaration builtin in shell interpreter 9f8c682aa - Reduce variable names conflicts in the action script. - Do not clear SINGULARITY_SHELL environment variable. - Add hash builtin for shell interpreter. babdb621a Allow app name with non alphanumeric characters 61215cc78 Fix rootfs umount error with sandbox image 72b09f23b Handle existing old-style cache entry directories (#5098) b3fee0a7d Bump github.com/vbauerster/mpb/v4 from 4.12.1 to 4.12.2 (#5093) df3893ef3 Cache & client rework stage I (#5088) decac12f8 go mod tidy 2a83a2793 Bump github.com/sylabs/scs-library-client from 0.5.0 to 0.5.1 e1e1e4894 go mod tidy 5a3742dcf Bump github.com/sylabs/scs-build-client from 0.1.0 to 0.1.1 d8229ae5c - Keep track of mount points for image driver and encryption code - Add new configuration directive `image driver support` to obtain information about capabilities of the image driver without requiring to load the plugin - Fix plugin example to set `image driver support` during install 98593a8d6 Use base metapackage for arch bootstrap d5fcc8f15 Fix configuration parser regular expression to exclude newlines and carriage returns e88996491 Remove singularity_source symlink in plugin examples 18150ac2f Correct installation guide link ba75e719e Bump github.com/opencontainers/selinux from 1.3.2 to 1.3.3 fdd5917f0 - Fix image driver start where a driver is started too early before the session is created. - Rework privileges handling in starter, RPC and master process now keep the original user/group ID and keep only required capabilities, it's necessary because when we are using FUSE mount points the access control in the kernel check if the real uid/gid, effective uid/gid and saved uid/gid are identical to user_id/group_id FUSE mount options, so we can't use setresuid/setresgid with setuid workflow because the saved uid/gid for the master process is 0 and the effective uid is 0 for the RPC process. - Fix condition by adding image driver check on image conversion when using unprivileged workflow. c04331cc2 Bump github.com/vbauerster/mpb/v4 from 4.11.2 to 4.12.1 274fdbf69 Update progress bar deps in go.mod|sum 67ea8ca8d Correct net/pull var names and switch progressbar b8b5647c7 Switch to github.com/vbauerster/mpb progress bars 957bbcf92 Fix e2e test broken by #5064 3b3636808 Remove log of expected error in TestCryptsetup a1c428b63 Specify required cryptsetup version if older version found 4813e0621 Nicer encryption error messages 59edc2403 Fix missing newline on starter fatalf 8adb48880 Use cp -H symlink behaviour in multi-stage Copy c5ae866c9 - Add an image driver interface to handle image mount setup in place of loop devices and optionally verlay - Added to `singularity.conf`: - new `image driver` directive - new `driver` value for `enable overlay` - Plugin callback to register image drivers - Few fixes and a bit of recfactoring for the fuse mount code - Add an plugin example to enable overlay mount with user namespaces bda9ad96c Add embedded shell interpreter 73d69bebb - Add new symbol `PluginRootDir` variable for plugin API allowing plugins to retrieve plugin root directory in order to concatenate with the plugin manifest name to determine the current plugin installation directory. - Remove --name option from `singularity plugin install` for now, at best if it needs to be changed this should be done at compilation time but not at installation because manifest name differ from the one used by Singularity internals and could lead to confusion during debugging by example. 85bf2d633 Bump github.com/spf13/cobra from 0.0.5 to 0.0.6 0f10ada7d Bump github.com/opencontainers/selinux from 1.3.1 to 1.3.2 357bd32a2 Add a short-integration-test make target running only network integration tests without CLI for circleci. Integration tests are actually very redundant with e2e tests and are consuming a lot of time for basically the same tests. 6a37fad3a Temporary fix e2e instance profile race bbfd8b3e7 Updated scs-library-client version 5631b3a30 Remove implicit --pid and --ipc options for instance start command a32a734c7 Bump github.com/containers/image/v5 from 5.2.0 to 5.2.1 5ad50bd31 Bump github.com/containerd/containerd from 1.3.2 to 1.3.3 1fbc3b730 Bump gotest.tools/v3 from 3.0.1 to 3.0.2 01f63eda6 Move comm name for setuid workflow only during instance join as it avoid to join instance started with --boot. 2a15caa09 Fix SINGULARITYENV_ variables to always take precedence over host variables because a SINGULARITYENV_ prefixed variable can be placed before a host variable which is supposed to be overriden (eg: SINGULARITYENV_FOO must take precedence over FOO) and this behavior leads to some inconsistencies. 6157abe52 Remove accidental changes to go.sum files and add a note to the config file noting the version of squashfs-utils that introduced the mem option. 6eb46f654 Bump gotest.tools/v3 from 3.0.0 to 3.0.1 1253f33e3 Fix variable assignment in build sanity check 39a7b3895 clean up comments 14f553a69 Fixed an issue with the implementation of the processor limit. 608fcea15 Add image bind support. 33d9b8085 Bump github.com/deislabs/oras from 0.8.0 to 0.8.1 ab0f06860 Bump github.com/containers/image/v5 from 5.1.0 to 5.2.0 1b0288156 fix previous broken commit. Did not handle case of MksquashfsProcs not being set in previous conf file. 027ac66ff Add Apache license and notice ef1c91e0f Replace github.com/opencontainers/runtime-tools dependency 878060db6 Convert MksquashfsProcs from string to uint 49ea364ab Fix travis Go install dependencies 0049b5fb3 Add options to the config file to allow admins to set limits on number of CPUs and amount of memory used by mksquashfs to create sif files. f6f80e001 Reorganize singularity engine configuration to get rid of non public struct fields and remove package dependencies which grow plugin binary size uselessly by almost 7 Mbytes. 7846442a7 Add file base name to sanity check message 92abbf91c Add build command sanity check to close #3502 6bfa0ace3 Bump github.com/apex/log from 1.1.1 to 1.1.2 47fb4867b add myself to the CONTRIBUTORS 980ee8b1e Update nvliblist.conf with the new cuda 10.2 libs 2c4f7953d Remove obsolete libuuid and libssl build checks 88be890c9 update ce4dd3707 Fix broken links and tidy README.md d46428cc8 Move to latest go mod versioned containers/image v5 b3c5a9306 Bump libseccomp-golang to v0.9.1 fe29860f5 Update dependencies d73577c53 Fix build post section issue if /etc/resolv.conf and/or /etc/hosts are not present or are dangling symlinks 93135ecfb Allow 0x or non-prefixed key IDs/fingerprints 55389df60 Automatically handle overlay read-only option based on filesystem fd5047248 Fix a logic error when 'allow setuid = no' with a privileged installation was forced root user to always fallback to user namespace. Add CAP_SYS_ADMIN check for root user to automatically fallback to user namespace if the capability is missing. e04ca65cc Fix CLI command root user check for unprivileged installation ce2ee1ac2 Fix post/test section parameters regression 0945be2b3 Fix e2e instance test race 2019a5fbc - Compile plugin outside of Singularity tree - Enforce check during plugin compilation with runtime.Version - Add Singularity runtime callback (fakeroot, monitor, post-start-process) - Callback autoload mechanism (callbacks are registered in meta file) - Add an install callback (for plugin setup, configuration ...) - Add singularity plugin create command to create a skeleton plugin directory - Add e2e tests 690505d3c Bump gopkg.in/yaml.v2 from 2.2.7 to 2.2.8 4058bd332 Bump github.com/containernetworking/plugins from 0.8.4 to 0.8.5 091c54f22 Cleanup FUSE code a5a3e231b Bump to 0.1.1 tagged mtrmac/gpgme 310c7de8b Change to test action from exec to build. c058d657c Add e2e test for issue #4943. 67eba314f Ensure build rootPath has owner write permission eff3f5f2a Embed action scripts in runtime and create them on-the-fly in session directory. We don't bind action scripts directory anymore into container to avoid issue on some CRAY systems reporting 'srmount error' when accessing action scripts from container and making singularity unusable. 716e59abf Remove reference to unavailable 'bc' package (opensuse example def file) bbf59696a Fix typo b1cee12f7 Bump github.com/containernetworking/plugins from 0.8.3 to 0.8.4 c826e08eb Bump github.com/pkg/errors from 0.8.1 to 0.9.1 775ee07d9 Fix nvidia persitenced socket bind mount error with --writable dc42ce57c Fix setgid group inheritance during make install 00234e193 Fix a logic error when sandbox image is on a filesystem not compatible as overlay lower directory and both overlay and underlay are disabled by configuration. 6ce7ab29c Bump github.com/fatih/color from 1.8.0 to 1.9.0 eb0f187ae Fix regression in e2e coverage command introduced by 4924 77b73df70 Bind /etc/hosts with contain flag or create a minimal staging hosts file if a network namespace is requested with contain. d1812556d Replace +dirty by -dirty to be compatible with semantic version 86bad1c35 Defer CLI commands/flags registration to get rid of init call order and do initialization from a single function initCommands, it will allow CLI plugins to be loaded after all Singularity commands have been registered. f4026ca3e Bump github.com/fatih/color from 1.7.0 to 1.8.0 6e2f91490 Add ceph to filesystems needing st_dev workaround 220b1ba49 Fix e2e config test with grep match ef5f944bb AllowSetuid no test requires user namespace to succeed 6774e5ef6 Call require.Network correctly in e2e ACTIONS/network 4398ea02e Fix e2e security capabilities regular expression match on old kernels 65f44d365 Protect tests needing CNI bridge on RHEL6 3ed083e06 require.UserNamespace for e2e xxxUserns action tests 92b35b8e0 Update CHANGELOG bebf73bd8 Ensure genericOciMount test helper requires overlay ed31325e7 Fixed CentOS versions, Ubuntu 18.04 in e2e c6e969a17 Do not follow symlinks while coping between stages 1c3543c59 Use img instead of docker to run e2e tests registry on RHEL 6 84c91bd22 Fixed OS versions/kernel req in TestDockerDefFile d7bee011b Skip testPersistentOverlay if no overlay support e3095995b Kill helper process in network_linux_test on error 3f43d2c7d Correct nc args to fix TestAddDelNetworks with OpenBSD nc 89b6067a7 CircleCI fix 6e772000d Compile all tests as user but run them with sudo 48e7fab83 mconfig: move network chunk before runtime to install setuid binary at the end of make install step. 489e79900 Updated to sif 1.0.9, and remove unnecessary function 87f86944f Check for userns availability in actions_test.go 165ba28ed Avoid use of overlay when not available in bundle_linux_test/TestFromSif a10d33c4e mount_linux_test.go/TestImport, avoid overlay when not available 247326dc0 Return current UID instead of error in namespaces.HostUID is /proc/self/uid_map is not present cdfb3b33c Naive parallelization of e2e tests bd82280cf Bump go version to 1.13.5 9f2dd32f7 Check symlink and bind overlay for CWD f6aa36904 Use statfs by default to retrieve mount options for bind mount and fallback to /proc/self/mountinfo method in case of failure. Add overlay filesystem to handle st_dev wrong value for /proc/self/mountinfo method. 180ecff2a Update CHANGELOG for 3.5.2 2cda49818 Fix insecure permissions 5d611a8b5 Fix --disable-cache not effective with build and actions commands 350ca5f90 Update CHANGELOG on the way to 3.5.2 6a4cd8b28 Allow to force E2E run via FORCE_E2E in should-e2e-run script 7635a8879 Use nil pointer for noop DockerAuthConfig d7a5401fd Wrap run-help around singularity exec command and make method generic to be used by inspect/run-help command. e0f676795 Fix regression with inspect command not accepting old image format like squashfs and ext3. bf30d53b9 Address kernel bug issue on RHEL6 resetting mount propagation flag b6fc289b9 Add regression test for issue4823 a20b05a5f Use a sensible hash for http(s) source caching 6f6503837 Add regression test for issue4823 b8b142b6e Use a sensible hash for http(s) source caching 35cffe851 Fix build issue with section script creation e2ec53f99 Fakeroot may fail to set file/directory ownership when building a sandbox on some network filesystems which are not aware of user namespace, to address the issue the build move to a temporary rootfs inside $TMPDIR and copy instead of moving the final rootfs sandbox to the final destination. a891a9c7b Fix useless error when an element of the current working directory is a symlink 3778d924e Return a message warning users to compile Singularity with seccomp support if fakeroot build is used without seccomp. ea2aedb38 Fakeroot may fail to set file/directory ownership when building a sandbox on some network filesystems which are not aware of user namespace, to address the issue the build move to a temporary rootfs inside $TMPDIR and copy instead of moving the final rootfs sandbox to the final destination. da6e6782f Fix build issue with section script creation e8865e6cb Fix useless error when an element of the current working directory is a symlink 96f1e67bf Typo fix: 'helpul' -> 'helpful' 91aa8f589 Return a message warning users to compile Singularity with seccomp support if fakeroot build is used without seccomp. a12054e13 Add a travis branch safelist ee7070594 Update CHANGELOG.md for 3.5.1-rc.2 caa8f3db2 Fix sandbox overlay incompatibility fallback to underlay e67a08ac6 Cast Stat_t.Dev to uint64 for MIPS oddities fa1ef93af Re-hidden --no-nv flag 4c9d73204 Replace NO_SETUID_FIXUP with KEEP_CAPS to not badly influence container processes f978808b3 Updated Usage for sign and verify b2304fd7e Fix CHANGELOG on master for post 3.5.1 entries d681d2817 CHANGELOG entries for #4800, #4802 3f3136be1 Use errors=remount-ro mount option with ext3 filesystems only 366c158cc Fix wrong path while joining shell path 0913c28cc Fix underlay bind issue when the destination is a symlink pointing to a relative/absolute path. dd3a03365 CHANGELOG entry for #4796 c4e63fc61 Small Hotfix for Issue 2860 - All files in container owned by root cdfbd4785 Small Hotfix for Issue 2860 - All files in container owned by root 8fc91401f Check root filesytem changes when master process is joining the first container mount namespace because we could have escaped to the init ram disk filesystem or escaped a weak chrooted environment. If it's the case we are aborting the execution and notifies users about the weakness of their setup by inviting them to fix the issue. 0883c4d6e 3.5.1 CHANGELOG/README/INSTALL changes 28664d8a3 Wrap inspect command around singularity exec 975de5db0 Use temporary file to execute build script section instead of passing the script over a stdin pipe. 3e3145cfe Set default umask during stages build b86b2c1ba Ensure raw definition generates correct header 88882d25f Add exit/signals e2e tests 7b8f41dec Add a Raise signal method calling a C wrapper responsible of sending signal to the caller after resetting the signal handler for the corresponding signal. It allow us to bypass default signal handler set by Go (eg: SIGABRT). 65010db46 Fix disk space leak when building from docker-archive 15350bed8 Add e2e regression test for issue 4768 88d4ff265 Fix symlink issue with current working directory when the last element is a symlink pointing to a relative target. 054815087 Add more e2e bind tests and regression test for 4755 ad0e369c8 Fix underlay logic by avoiding duplication of overrided image directory. 8746218d6 Use temporary file to execute build script section instead of passing the script over a stdin pipe. 335b9f21f Check all partitions for image type check c20c4910a Add allow container encrypted directive f9f8b044a Add automatic detection of architecture during SIF assembler process by scanning container image tree to find an ELF binary file for inspection. 66d9097d3 Fix index shift during optional fields parsing in parseMountInfoLine 540156a70 Fix wrong st_dev/mountinfo for btrfs filesystem d01312cc4 Fix setLk build error ... again 5ee7dc6c6 Fix x86/arm/mips 32 bits system compilation error 78bb23406 Fix F_SETLK64 bad value on ppc64 arch with fcntl syscall a618ff6b8 Fix missing STKFLT signal for mips ebdf7ff80 Updated CONTRIBUTORS.md cc2c15d74 Debug sudo e2e coverage 5123d09b1 Integrate e2e command coverage report with CI 64c7e3b6f Add e2e tests for various configuration directives 1027a29d9 Check all partitions for image type check 89b085550 Fix setLk build error ... again 1d34fa5d1 Slightly improve help for sign/verify e1fd89fbe Add e2e regression test for issue 4768 e07971c5a Fix symlink issue with current working directory when the last element is a symlink pointing to a relative target. ac2834d2d Update go.sum for yaml.v2 574b3cbce Bump gopkg.in/yaml.v2 from 2.2.5 to 2.2.7 6e1fd9688 Fix index shift during optional fields parsing in parseMountInfoLine 196a8918e Add allow container encrypted directive c21c044f0 Add more e2e bind tests and regression test for 4755 b3153c6fc Fix underlay logic by avoiding duplication of overrided image directory. 7066861f9 Fix wrong st_dev/mountinfo for btrfs filesystem 803879443 Fix x86/arm/mips 32 bits system compilation error dadbf3b01 Set default umask during stages build 2fa9bfaa3 Wrap inspect command around singularity exec 941edc9fd Removed useless '--url' flag for sign 6408ea37f Show explicit error for wrong unprivileged installation 7b1070750 Ensure raw definition generates correct header d21494104 Fix F_SETLK64 bad value on ppc64 arch with fcntl syscall 7c61c80ca Add exit/signals e2e tests 88c503047 Add a Raise signal method calling a C wrapper responsible of sending signal to the caller after resetting the signal handler for the corresponding signal. It allow us to bypass default signal handler set by Go (eg: SIGABRT). b674b9bc9 Fix missing STKFLT signal for mips 679d5586b The stack size limit is reset to its default value when setuid workflow is used, so the original value is saved and restored before executing the container process for Singularity engine. f7726a370 Updated function comment 7958dc422 Fix disk space leak when building from docker-archive af8523c56 Changed function name from "ensureImageFlags" to "checkImageAndFlags" 6a3e90c18 Fix "build_and_test" workflow failure on push 24036601f Change '--groupid' to '--group-id' to match '--sif-id' e1a03c9cb Bump github.com/containernetworking/plugins from 0.8.2 to 0.8.3 ae7df4588 Correct sign --id deprecation warning in CHANGELOG.md 7b69854e9 CLI cleanup for sign/verify 4eacdbeee Fix "build_and_test" workflow failure on push da7a2547c Mention bind mount hard fail in CHANGELOG.md a61d16984 Add symlink bind e2e tests 244546246 Sync logic deciding whether to run E2E with release 3.5 d7dbb085b Fix overlay/underlay layers to correctly resolve destination relative to the container root filesystem, fs.EvalRelative has been reworked by replacing filepath.EvalSymlinks with os.Readlink in order to minimize false positive and follow links relatively to the root destination. ec9f0e788 README: Fix documentation links df1b6594a Move logic deciding whether to run E2E to its own script 735238e37 Move logic deciding whether to run E2E to its own script 009cd18ad Fix rocmliblist for OpenCL apps and blender example bafbf138a Bump gopkg.in/yaml.v2 from 2.2.4 to 2.2.5 be55176ef Fix current working directory symlink issue. The runtime resolve the current working directory for the destination mount point but doesn't resolve the source in order to be in the correct path when entering in container, the side effect is when the current working directory has symlink components in its path, the runtime must ensure the source is also available in container, so instead of bind mount the source to the same path in container we now create a symlink which does the same job without adding a superfluous bind mount. aa641c442 Remove deprecation/removal warning for --fix-perms 47dd18c2c Fix PROMPT_COMMAND evaluation issue 73d0cde1a Fix for a file handle that was never closed 3fdd19f3e Bump github.com/pelletier/go-toml from 1.5.0 to 1.6.0 9d85255ae Set version numbers for 3.5.0 8021f4a84 Update plugin docs 42a4f4ac9 Add CHANGELOG.md entries to 2019-10-28 cd61afcfd Add config global command to edit singularity.conf from CLI d52bc49e4 Remove the 'pull' overridden image at the last moment 278d478e5 Add instance --apply-cgroups e2e test 992fd9a19 Apply cgroups to instance joining processes 64eef3b4f Fix code comments for `--fix-perms` 55f0e39d3 Add e2e test for --fix-perms / issue #4524 8a8977b9d Information / option to fix restrictive sandbox permissions 2ee361191 ROCm merge fixups c4cf590f7 Fix rocm flag not being enabled in CLI b59fa15e2 Add rocm GPU support to Singularity 19711c94b Added code comments 97c406398 Get plugin manifest in a separate process 39cd22fbe Ask for the version number only once b73f0bfa4 [E2E] Add some umask tests for 'pull' 75eb012ec Restore vendor/ for release tarballs fecb6de67 Update umoci - minimize xattr warnings 0f1b18851 Updated test name to singularityVerifyAllKeyNum 663169242 Update github.com/Netflix/go-expect to a more recent version 44ecb9bf9 Update github.com/buger/jsonparser to a more recent version 26bc2fcb0 Update golang.org/x/sys to a more recent version 2dd412f11 Sign/verify the system partition by default 82ea27d8b Run E2E tests if go.mod changes 3dde0899d Upgrade github.com/containers/image to a released version 0480a7d17 Fix failure if there are no matching labels 5d0f12856 Add mechanism to run E2E tests using PR labels 665ac7296 Update golangci-lint version to 1.21.0 fae644639 Make uninstall plugin error more readable 278a4827f Handle restrictive perms on base_environment makeFiles 9407cd428 Make sure we use the same go binary in go-generate 4fb473c04 Properly remove bundles with restrictive perms 915f2985f Check plugin path exists before compile 93baac133 Respect plugin name during installation 4999b236e Remove plugin compile artifacts 782448a14 Fix issue with /proc hidepid option 1e63aeda1 Change e2e test image distribution by using alpine instead of centos to speed up test bootstrap. 7ae14510a Staging hosts and resolv.conf files during build 328020120 oci: Patched umoci for xattr issues 34667b320 Call handleRemoteConf() in init function, not in handleConfDir() 2fa05b38d Check the remote.yaml permission on runtime 53d344bf0 More improvements to the signing package c3ce09298 Add e2e binds tests e325e57c7 Fix nested binds with session overrided path fac1ca469 Remove vendor directory and associated flags a751866dc Use the freshly built singularity fda1f4ebe Splitted configuration parser into two functions: ParseData and SetConfig to reuse the code for `singularity config global` command. Parser code cleanup. 6b04dfb16 Fix overlay ext3 mount failure with ESTALE. A first run with a new ext3 overlay image succeed but a second fail with ESTALE error when overlay index inodes are enabled, so when we encounter this error we remount the overlay by adding index=off to the overlay mount option to disable this feature. bf13f51b1 Fix exit code for e2e sign tests 06eea2b87 Allow large user mapping range with fakeroot 30823afc0 Force PS1 through PROMPT_COMMAND to fix bash prompt 3dd10d2d3 Ensure the group partitions are verified correctly 947959517 Fix current working directory check fae9d7049 Add e2e regression tests for --home+cwd b6c716ced Make sure we produce a JUnit report if requested 5420f0bc1 Add JUnit output for e2e tests 539175675 Correctly handle group id when signing a group 2f687ff33 Fixed signatrueLink to work with group id 6148d3df8 Correctly handle group id when signing a group 887cd20f1 Pass --verbose to run-linter (golangci-lint) f873fbaa1 Change "deadline" to "timeout" in .golangci.yml d8f72f7ec Fall back to current working directory outside git working copy 0e5549a69 Remove leftovers from ealier version of run-linter 2a4468fca Add run-linter script 9536e50de Skip linting a file almost copied from the standard library 507e251bd Error if '--sif-id' is 0 5d67b39cb Use correct Go path is the user provided one 0addd5757 Improve messaging around Go version check ba0d1d56a Update goversion to require Go 1.13 78a9a21b6 Use gotestsum to publish test results in JUnit format 2fe5a4128 Update Singularity to use at least Go 1.13 efac304ea Add codegen make target 4aac659e9 Split TestSquashfs 80b2870e4 leave apex warnings with quiet option, set debug only at debug level fe079fedc Update go.mod for apex f8ef37848 only silence apex warnings with quiet or silent options, not by default 0a52400a4 set apex log level to correspond with sylog log level 89c338767 DRY up .circleci/config.yml 0b55792dd 3.4.2 CHANGELOG.md & INSTALL.md entries ba094f0cb leave apex warnings with quiet option, set debug only at debug level 7bd4c030f Use sif id pointers dbb618806 Update go.mod for apex 025efa89f only silence apex warnings with quiet or silent options, not by default 0d59a1c1f set apex log level to correspond with sylog log level da0e39beb Bump github.com/pelletier/go-toml from 1.4.0 to 1.5.0 670333f8c Add e2e build tests for fakeroot ada797f47 Bump gopkg.in/yaml.v2 from 2.2.3 to 2.2.4 05d012c84 mconfig: do not error out on missing cryptsetup c7c0011fd Accept common config in engine mutator 7937ba435 Remove extra newline in imports 30517c1fb Update copyright 9977ebc1e Run integration-test concurrently in circleci with unit/e2e 489a9ddf4 Rename util function FileExists()->PathExists() dc6674a55 Ensure cache tests clean up tempdirs 9545eca9b Create cache dir if it doesn't exist 316f0dc97 Bubble context.Context as far up as possible 3a520c72d Debug the version of Singularity when running a command 020b5da01 Move engine common config in a public package 68ea2ba03 Remove manifest gen bf0653a07 Fix @chmod makefile error at install step 90c8e72a2 Update mlocal/frags/build_runtime_suid.mk 689d1384a build_runtime_suid.mk 443f09899 Split internal plugin code into multiple files d812c76d5 Honor the umask when building a SIF a9f647f96 Verify all partitions, by default 9bede4eb5 Use image extractor for v2 images 17d68f68d Update example versions d4f2c234a Rename package engines->engine to match internal structure 9ed5784e2 Keep singularity.conf template in etc e23ff8d05 Fix race condition with shared loop device 37e072a4e Log error when plugins are not initialized properly 827397e44 Rename team and change example versions 712dadda5 Fix #4524 - set permissions on rootless sandboxes 90aa485dc Do some minor CLI cleanup 87960972b Bump gopkg.in/yaml.v2 from 2.2.2 to 2.2.3 167a531c0 Fix build after master merge 1382d3016 Do not export SingularityCmd (#4541) 6d095b1cb Rename util function FileExists()->PathExists() d787b155e Ensure cache tests clean up tempdirs 815af537f Create cache dir if it doesn't exist 93c8543d3 Rename cli.run to cli.runBuild f796dd48d Rename RuntimeMutator -> EngineConfigMutator 2b3dc52d7 Make Initialize return an error cf7c59796 Add E2E tests for few build/update sandbox cases e7d05ea0a Return explicit error regarding build with sandbox/update flags 84c3ef634 Fallback correctly to user namespace for non setuid installation 18d244762 Set useragent value from main function, not init 15bbd6153 Add get-version script to obtain singularity's version (#4534) 0f7ab18e6 Cleanup overlay e2e actions test c0b815d48 Ignore the app-labels in the label-partition 875bc32d4 Only try to connect to the keystore if we are pushing the key e2940e21f Fix a typo in the debug message in the plugin code 5f86ee51e Pass go's path to gengodep (#4515) 21e6d6765 Use go-generate script to generate config.go fffccef16 Add network e2e helper and few basic networking e2e tests a7cb1a791 Look at /proc/self/mountinfo to look for potential mount point under autofs control and open them in stage 1 in order to keep a reference in host mount namespace. Those changes make 'autofs bug path' configuration directive obsolete. d52c7c158 Use TLS server for tests 68a7fedf5 Update scs-key-client to v0.4.1 f625fda3c Update scs-build-client to v0.1.0 e93b98ed7 Verify all partitions, by default 21b12cc93 Update to issue template ef8ceb1a9 Use CommandManager in CLI mutators e7c948ca2 Add e2e tests for issue 4488 5aed40610 Fix image file descriptor leak 13c57479a Apply build tag for runtime plugin example 67f4bb00b Rethink plugin system 814dc9a88 Fix godoc 1b5d9b3af Fix regression breaking --net usage b6851ccca Added note in INSTALL.md to remove Go before updateing + bump go version 5eba3c03a Sign ALL signable partitions. Cleanup code. 3cf6587bb Bump github.com/spf13/pflag from 1.0.3 to 1.0.5 fdbf575b0 Get capabilities from /proc/self/status in E2E tests f22c87053 Bump INSTALL.md go version df8c8fc37 Sign all signable partitions 1fb1f806b 3.4.1 changelog entries 980722769 Removed gotos, and improved inspect code 3655b6889 Use buffer instead pipe; errors from lowercase b434440ab Fix err message when creating ecrupted container 43ec54a60 Add e2e tests for basic actions with all profiles b0952e4c1 Fix bind regression with sandbox and user namespace ca131470c Update to the ISSUE/PR template 0bf734d04 Remove tmp file from 'key newpair' tests bab943c0c Apply sugested patch from DT 64d4d0200 Do not remove test directory in case of failure 73d32729b Dump directory contents on failure b59907c97 Clean up cmdenvvars E2E tests aedf01bb6 Keep test artifacts in separate directories 9d0536873 Use a essential Ubuntu GPG key for external test f2be19918 Use a essential Ubuntu GPG key for external test 9c0df4cf0 Fix fakeroot build with pacstrap and partially fix debootstrap 9de4ed626 Update vendor after backporting #4439 1821f84d5 Update to scs-library-client 0.4.4 b33b16267 Pass Mac Hostname information to VM to be used. add50a014 Fix ioctl errno handling for LOOP_SET_STATUS64 012e7f5f0 Reformat imgBuildTests.buildFrom 94f6497c7 Add myself to CONTRIBUTORS.md fbf66f040 Fix arguments order 033405787 Add go-generate script 2f8af541d Fix FuseMount check causing to always set PID namespace 79845ef9c Fix mconfig seccomp detection on Opensuse 86cb421ef convert stat type to int64 in case not on 64-bit machine 7ff567f50 Fix fakeroot build with zypper bootstrap 959bab719 Add test for issue 4407 7714f8028 Fix ioctl errno handling for LOOP_SET_STATUS64 5e08a99da Bump github.com/containerd/containerd from 1.2.8 to 1.2.9 31eb13e37 Use tables to drive E2E tests (#4432) a83c274a3 Run singularity with --debug in E2E tests 2feb7c53d Ensure GetSignEntities() closes container on error 3052becd5 Dump debootstrap log in case of failure 118db263c Update to scs-library-client 0.4.4 f75a88e0a Fix fakeroot build with pacstrap and partially fix debootstrap 423c24dee Fix bind issues by taking original mount flags from the parent mount point associated to a bind mount, user namespace was affected by the issue when mounting a read-only mount point. f74e1f983 Fix @chmod makefile error at install step 931192d37 Update mlocal/frags/build_runtime_suid.mk e33a80f56 build_runtime_suid.mk 670bd3a0a Updated the --sif-id flag for E2E tests 88578900e Mark '--id' as deprecated; replaced with '--sif-id' 07332832e Support for 'inspect' to handle label a partition 06999469d Change method receiver to test functions to be a value, not a pointer 7c0c86325 Return error when oci section reader fails 714735080 Preserve parent OCI config 458173709 Improve e2e to use common fs helper function 2d313f9d8 Fix truncated gecos field when reading /etc/passwd (#4406) 525aebfdc Move internal/pkg/util/exec/pipe* to internal/pkg/util/starter and code to execute starter was refactored to remove some code redundancies disseminate in CLI and internal packages. dd913dc56 Update cmd/internal/cli/delete.go ac743adc6 Pass Mac Hostname information to VM to be used. c003b5b83 Clean only PATH and LD_LIBRARY_PATH 810fec292 Update tests to expect SOCIOPATH env 817128e87 Justify trailing slash in tests eda404748 Fmt 9f7dd7c44 Clean build destination path db22b75bf Run build tests as subtests 71301e58d Use not cleaned path for sandbox in e2e f88e3649e Update cmd/internal/cli/delete.go 66a3c624a Apply suggestions from code review bd5bdc77a Keep list of E2E test suites sorted 0f2a7108a Mark some tests as "not short" 48db7cd78 Refacotr 7aff53a5a Fix missing error check 8c959d5eb Typo 8e9915269 Add key import flag to specify if new pass needed 7f689f420 Apply suggestions from code review 997fbd62b Clean all envs that contain PATH 8e6ef19f2 Create rootfs in destination parent for sandbox 33cd4f123 Cleanup build things a bit 375ba6bbd Remove unnecessary prefix from file names 96da8d82b Update vendor daf1ee50c Update scs lib 59047c568 E2E: attempt to signed a non-existent groupID/ID 42a722dea Start flag descriptions with lowercase f88f8db3c Non interactive newkey (#4240) 21be67616 Don't prune integration and E2E tests by hand anymore (#4392) da5e60bf5 Add e2e_test to end-to-end tests (#4390) 6cac32b30 Add `integration_test` build tag to integration tests f83959e50 Separate rootfs and temp dir location in bundle (#4376) 0e69bdfa1 Take extra build tags in go-test 095fd3dbf Fix vendor 6a2653f69 Add myself to CONTRIBUTORS.md 8e7b13b3b Fix arguments order 3c07b3af8 Apply suggestions from code review 6c4a31bc0 Fix fmt 03d2e688c Save instance ip at start 6a9589d2a Rework overlay image code 596621ee4 Delete ghost instance files b6230c687 Update to gotest.tools/v3 1fbc9a278 Fix FuseMount check causing to always set PID namespace eaf1a26dc Update vendor directory b5fdf6a0d Fix scs-key-client pseudo-version 40ea440cb Minor cleanup of build related things 5ee1ad923 Move crypt cleanup before instance cleanup 1505f3727 Apply Cedric suggestions from code review 06d951145 convert stat type to int64 in case not on 64-bit machine d27885659 Remove libarchive-dev from packages to install in travis 29ff86a76 Remove gpgme as a dependency for building singularity 1460371c2 Document fakeroot engine 2402dfc0e Document imgbuild engine ab659be92 Document OCI engine 73aa3598a Update go mod 7a61e75de Document singularity engine d982ff817 Make timeout flag hidden aaae07ecd Update cmd/internal/cli/delete.go f04125a32 Update cmd/internal/cli/delete.go a1f701864 Update docs/content.go ca3e44ef3 Changes for release f80ce6e9b Also check stderr to make sure its failing correctly 2ff5aaa0a [E2E] Attempt to push to a non-supported transport 3761409f4 Add test for the help flag for e2e remote tests 52bccdc53 e2e sign test: make sure the test for the groupid flag is actually executed 33d4bbe67 Increase the timeout for the execution of e2e tests since i am reaching that timeout on most of the testbeds 885166fee Add an e2e test for the buildcfg command. Only the positive case at the moment in order to improve coverage. 458786edd Document engine operations completely 04307456e Slightly update comments 912020b32 Fix goimports a43b0b8d5 Fix vet 6caca0c7e Add copyrights 579939428 Simplify CLI EnsureRootPriv. d8330401a Add e2e for delete command 026a65207 Add singularity config fakeroot command to manage fakeroot user mappings 43df57a96 Add error wrap 2315e8b00 Fix mconfig seccomp detection on Opensuse bc569ae9d fix a bug introduced during my last PR for e2e run: a test with an encrypted container is expected to fail, not pass 904c0ac42 Pass --no-cleanup flag pull command 48cf11197 Fix e2e seccomp security tests a25b6c329 Apply suggestions from code review b0380bb26 e2e run tests: a little more code cleanup b7a1778de e2e run test: deactivate the passphrase test when the cryptsetup version is not compatible 802bd7ea8 e2e run test: fix the match for the error message when the wrong version of cryptsetup is available 8f1183b99 Document engine operations for stage 1 fe10cb69a Fix a problem with the e2e run tests when tests run concurrently and some code cleanup cb49fafc6 Rename engines->engine and put engine interface there 4bda59c17 Check e2e encryption build tests when cryptsetup is < 2.x d8cb45519 Add timeout flag 677ad0807 Docs format b7a2eed5c Add docs 15e404310 Fix fakeroot build with zypper bootstrap 91da2e759 Fix cli to use pem path envvar ed67234d6 Fix cli to use pem path envvar a42fe2120 Port e2e key tests to profiles and remove the code to set SINGULARITY_SYPGPDIR since we have a safer option already in place eab55ddab fix problem after accepting suggestions 662dd3070 Clean up abandoned files in /tmp f2bbb3055 Pass -v to go test 0cd6d424d Update e2e/key/key.go a49a33f85 Update e2e/key/key.go 43a3441a3 Update e2e/key/key.go 669b02043 Update e2e/key/key.go 574116fff Update e2e/key/key.go 92078a378 Update e2e/key/key.go 3f412a91f Print stop instance progress to sylog 6d5698532 Add buildtag to instance functions 175a4ff2b Update instance list docs 457387b73 Move instance list and start logic to internal/app 18513afa2 Add go-generate script 674c65ca0 Updated scs-lib ced1b0fba Quote instance name glob in docs 04c52080e Change pid file perms to 0644, use NOFOLLOW flag 3e5a7d41c Change pid file permissions to 0600 387a76b38 Update instance list docs 66b3fabe8 Add pid file flag to instance start command 2a098fae6 Add name to the instance list command ff818ccce Added delete image command 1839e70f9 Introduce e2e profiles and port tests to use them 269e327fa Bump github.com/containerd/containerd from 1.2.7 to 1.2.8 d6c487520 Bump github.com/gorilla/websocket from 1.4.0 to 1.4.1 51e711ea2 Apply suggestions from Cedric code review 46aae2ebc Remove double import ebd866dad Document shared starter config 67c9c49a9 Lock ext3 image partitions and prevent them from concurrent writes 747afec1b Update runtime comments 07011ff20 updating CHANGELOG.md to prep for 3.4.0 release 0478747b8 Add e2e tests for the key newpair --bit-length cpmmand d5742d94d e2e test: make sure we skip a test for the run command when the cryptsetup version available is not compatible 26036ec9a e2e test for encryption: revisit the code to avoid a problem happening with CI f522b5cb2 make --fusemount hidden from help 3bac3653c rename --fusecmd to --fusemount and add container: prefix db717493e Document atribute constructor in starter.c c4c133620 Update e2e tests for cache 81d5a77bb Add e2e tests for the run command of encrypted containers, as well as all the supporting code d582b48c3 Fail fast for a nonexistant PEM key 07afba5c0 Small tweaks for encryption CLI 23717bf56 Fail if trying to push to a unsupported transport type 45a3a494e For the e2e build encryption tests, use the long flags instead of the short ones to ensure that the coverage tool will pick it up. 1aba1a811 Reorganize the e2e test code for exercising encrypting with PEM file so the code to generate a PEm file can be reused 7e5679ed1 Add a few new tests to e2e for the key command, tests to cover the --help flag 3db77364b Added TODO comment for expectOut for stderr + uncommented other e2e tests e0be546f9 Improving tests with c.pingImg, and new expectOp 59745025b Update internal/pkg/util/fs/helper.go 021a88512 Updated godoc comment 8efd030cf Use defer func to remove the file if necessary 8588e453b Add e2e test for building encrypted containers with PEM file; add a e2e test to capture an invalid case where a user tries to specify a passphrase from the command line. d433a2cc1 Remove 'to' file if io.Copy fails 49e53116e Remove prompt for dry run cache clean f16a0a1c6 Check overlay lower/upper filesystem compatibility for sandbox images/overlay 52b4113ad Ignore nil SingularityCmdResultOp to avoid panic 4f1ce4a18 Update CONTRIBUTORS.md d4c5322bd search: Print the container ID if theres no tag 9de200c97 Update e2e/imgbuild/imgbuild.go a14fc2a16 [e2e oci] run the tests for the help flag as subtests fd2fcc3c1 Improvements and bug fixes for #4179 e6aadc2fb reactivate all e2e build tests 1fa52ceed update the e2e build test for encryption to support systems that do not have the correct version of cryptsetup (necessary for CI) cb9158325 Removed the | grep and use e2e.ExpectOutput(...) 2eddd0170 Update README.md da758d7ec Fix a few remaining issues with the e2e tests for encryption 1787ace4b Split up encryption material into two flags 9faea79f2 [e2e oci] add tests for the help option b6eef1c6d turn failure to create ~/.singularity from warning into debug c9b30829a Disable build tests that use debootstrap 20bcb7c5f Do not restrict non root suid on RPM e1123761c Fix #4264 use compatible scs-library-client 0.4.2 07fec977b Update mlocal/frags/build_runtime_suid.mk 228bbdefd Abort suid install if not root f3c3f3a18 Fix a problem introduced while resolving a conflict through the web interface 52849da77 Do not set blkio cgroup limits during test 89165d7f8 Added working tests for SecurityConfOwnership + finishing up tests (removing debugging) a661706aa [e2e build] prepare code for checking whether an image is encrypted 8a4d6c687 [e2e build] Add the missing -e argument when building encrypted containers 3dde40ad1 Basic code for a e2e build tests for encryption 030cecbde Fail for encrypted containers w/o key material 39a8a31c7 Add --encrypt option to build command 2f62bce0d Remove unecessary call to user.Current in cleanEnv to prevent Go from loading and mixing NSS library with container image and host libc. Also add e2e regression test for issue 4203. 7d52bc8cc Install debootstrap so that tests that depend on it are not skipped 0452d4464 Minor modification to clean up the code, the list of e2e tests to run 4707e82df Make arch a pull method parameter 0d61321e5 Don't bind directory set by --pwd flag 5284adc64 Add arch in error when image is not found 3669ade51 Use session home directory if user home directory doesn't exist 61764f2ae Solve conflict manually 05da01a00 IsWritable() is in fact portable across all UNIX-based systems so moving some code 7b78684af Update internal/pkg/util/fs/helper_linux.go 250084cb5 Added tests for testSecurityPriv e6232e1de Re-activate a e2e pull test that i de-activated for debugging purposes 43bf2252b Move IsWritable() to a unix-specific Go file for consistency with the rest of the code 7b1155f7b Revisit the implementation of the IsWritable() function and update the unit tests ff018c454 Add a few e2e tests to make sure we will track the case where the target directory for the image cache is not writable 8daf8ee36 Modifications to make sure that the image cache is automatically disabled if the target is not writable ec4f5ee1d Fix pullDir comment case 26be8cbf3 Bump github.com/opencontainers/selinux from 1.0.0-rc1 to 1.3.0 10375ce26 Updated err as suggested e18dbd241 In export check if key encrypted before trying to decrypt it d70c7e035 Update Go to 1.12.9 28819afc8 [E2E] Port security tests (take 2) 38077da3c Removed the bit length checker 2cc0d7eaf Use CryptoMessage descriptor for ciphertext 362f9e434 Bump up sif version to v1.0.8 4ef8de292 [e2e cache] fix a structure initialization problem that was not caught on my system 96e41a133 Bump github.com/containernetworking/plugins from 0.8.1 to 0.8.2 277c279d4 Make sure the cache is never touched in the context of a pull --disable-cache command 6a0740986 Bump github.com/opencontainers/runtime-tools from 0.6.0 to 0.9.0 6fa99be23 Finish the implementation of e2e tests for the cache command (positive cases only) 13a4aa26f Removed unnecessary err in mrKeyList struct + added more comments 724d0b13d Split the loop into a function to get all the key info eb9ad4a73 change fatal error to warning when .singularity directory cannot be written c838fc858 Make NewLibrary accept library config rather than client f4408ff09 Invalidate cache handle for library pull when cache is disabled 8bafaea1a [e2e sign] switch to a generic email address when creating a new pair of keys 991d7db1a change the type for the new cache api from Context to Config to avoid confusion with Go Context 6b4e83f99 Remove currently unused interface 131850a4f Move file copying to a separate function 172a40b3e Do not encrypt pk if pass was not provided 98233746f Improve coverage of the e2e help test. f3344b652 Add e2e test for the sign command 976a83995 Fix a problem introduced in my previous commit for cache management 0bb6ba1fa Change the interface to create a new image cache handle to use a context (extensible structure) instead of a single string for specification of the base directory 5afed563d [e2e pull] Do not create temporary directory that is not required and make sure the directory that we want to use as image cache is correctly used during the command execution. c91db2d6d Add a e2e test for pull --disable-cache d629af717 Added openOutputImage helper function & change perm to 755 9c0ec0efa Pass buildArch on Mac/Darwin too 9502b91c5 Remove file if overriding 41f5e7985 Send arch to remote builder f558f631e Enable seccomp during oci mount testing 0955d2e21 Rollback libseccomp-golang version to v0.9.0 592290d1f Update pkg/sypgp/sypgp.go 3ef17da05 Update pkg/sypgp/sypgp.go 80d13133e Allow users to specify the key length of newpair 7893279a9 Update pkg/sypgp/sypgp.go ea00d1812 Bump github.com/opencontainers/selinux from 1.2.2 to 1.3.0 cbf2cc4f7 Bump github.com/containerd/containerd from 1.2.6 to 1.2.7 5fffa7480 Improving 'key search --long-list' to use tabwriter b27a01736 Implement support for multi-stage remote builds d4d0498d9 Use different packages for darwin vs linux 6095504da make consistent use of "e" instead of "engine" 4044a9f00 vendor using correct image tag f2fd9c4a5 vendor from within container 5a7ef07d6 update vendor 608786196 update vendor a74c35cdc freshen up vendor fb8c77bf2 uniform error messages 3c533d1b4 Move from image-tools to umoci for OCI unpacking 6acaeffca Bump github.com/opencontainers/selinux from 1.0.0-rc1 to 1.2.2 0c0f2f981 Bump github.com/seccomp/libseccomp-golang from 0.9.0 to 0.9.1 5231218b1 Add systemd drop-in to pass dockerd options 3fe26cd05 Use systemctl to restart docker 069b2343b Update the dist from trusty to xenial 7dac2919f Added back missing code from #3789 066f79d93 Ensure image permission of 777 when overriding the image d9efb6cc0 Inline all the code setting the environment of a e2e Singularity command to avoid a problem i do not want to track right now 3c7b1642c Another set of modifications to better handle the SINGULARITY_CACHE_DISABLE environment variable ee5ffcbe1 Better handle the parsing of the SINGULARITY_DISABLE_CACHE environment variable while handling the image cache f47a6428f Fixed panic when 'key search' on a open-keyserver eb842d86f Added 'c.env.KeyringDir = c.keyRing' before 'c.env.RunSingularity(...)' + uncommented the other tests a42485ab6 Add helper function buildConsoleLines() to build the console lines suggested by mem + added tests for 'key search' + improving test coverage 1ee641f38 rename the constant associated to SINGULARITY_DISABLE_CACHE to have a more consistent naming scheme 07597b227 Ensure that the image cache is not used when SINGULARITY_DISABLE_CACHE is set 85ee60028 Simplify error check in library pull 81d8cd514 [e2e] Add a test for the SINGULARITY_DISABLE_CACHE environment variable 996ac2914 Fix library pull with cache 03e470ce5 Introduce registry interface for pulling images 636acd2e7 Added missing copyright header f0005690a Removed docs for "exit 10 if pulled container is unsigned" 28d0531cd I cannot spell worth a dern f554b21df added clear warning to admin when using 'capability add' so that they will know that can result in priv escalation 66df35d9f [e2e] Updates comments to the test for SINGULARITY_SYPGPDIR to reflect changes made in the previous commit. 05c047d24 [e2e] Simplify the test for SINGULARITY_SYPGPCACHE, it now just invoke key list and check whether the expected directory are actually there. c059944f6 [E2E] Modifications to let a developer specify the value of SINGULARITY_SYPGPDIR 384b88fe9 Now using shared sypgpDir with all 'key' tests 84a04a684 Update internal/app/starter/master_linux.go 22c64cc2b Update internal/app/starter/master_linux.go b42ad37fb Store path to singularity.conf at build time dc1fd4f11 Store path to nvliblist.conf file at build time fc0116ae7 Make LibraryPull accept context c1c74c6c8 Add -f shorthand for force flag f3ad7ed2d Remove from build_runtime so remote is not installed twice on a unix system f2fdfdfd6 Add remotes definition to CLI build 7427b73f1 Pass sylog messagelevel to VM 67902a074 golangci-lint wasn't happy with how it was previously 6f9da0fbf Add check for setuid on xhyve binary eafcf81bd Add in networking code 23c23cd81 Filter for signatures when verifying bdc4148d5 Bump up sif package to v1.0.7 0ead2de82 Check pull force flag once edc8e1280 Correctly set image cache dir in e2e tests 2d01e274f Update tests d89d23e26 Pull no longer failed in case of unsigned images. Mark allow-unsigned flag as deprecated 516107601 Gofmt suite.go after merge conflicts 76020a613 Use e2e environment cache directory f309abae9 Gofmt e2e oci 4871d6d30 Fix failed build fba679f5a Add missing copyright 8b18bf34c [e2e verify] Make the tests a little more robust and efficient ad993c3a0 [e2e verify] code cleanup f9af41e33 Bump github.com/pelletier/go-toml from 1.2.0 to 1.4.0 (#4152) 34fa0abc4 [e2e version cmd] Improve the check of the output by switching to a regex 0d1451a28 Fix a typo 486f54488 Modifications to the e2e framework to let e2e test developers control the SINGULARITY_CACHE_DIR value when necessary 746e46ab8 Fix typo in debug message 7a355c4ce Fix ldconfig lookup error handling 3e167f12a Return from Paths when an error other 00312027b Add missing import 71576047f Additional changes for the review 37b104f4d Bump gopkg.in/cheggaaa/pb.v1 from 1.0.25 to 1.0.28 (#4140) b6078bea9 Update e2e/cache/cache.go 12b2cbaf3 Fix cache clean e2e tests 6411f6929 Improve e2e coverage for the verify command 94a68f2c9 Improve debugging comments b2ea82f0c Bump github.com/pkg/errors from 0.8.0 to 0.8.1 c7b4a1b50 Add a e2e test for the singularity version --help command 5238a892a Add some comments to the code path when detecting an incompatible version of cryptsetup 909ea09d6 Encryption/decryption: detect errors due an incompatible version of cryptsetup 7ed4c89e4 Update the machine executor image from ubuntu 14.04 to ubuntu 16.04 9f627c502 Bump github.com/kr/pty from 1.1.3 to 1.1.8 (#4141) 5cf091874 Now using text/tabwriter package to format output 616109124 Add "Profile" as steppingstone for testing --fakeroot 7fbd3477a Add cache clean e2e test case 5f83e2a11 Implement the default creation of a temporary keyring for every e2e tests. Having the creation of such a temporary keyring allows us to not have to clean up keys and keyrings between tests, simplifying the implementation of most tests. This also makes the e2e framework less likely to have thread-safety problems. At the moment, it does not allow the sharing of keyrings between tests. 714e5fa95 Fix a problem while cleaning the image cache in the context of privileged e2e tests f0a4118c9 Create a temporary unique image cache for each e2e tests cc7b3ab9b Add '--long-list' option to 'key search' 88ba3ed62 Update pkg/util/nvidia/paths.go b2be41278 Revert changing ctx.TODO to ctx.Background 323b844e8 Update scs library client version dbb7b5406 Restructure cache clean file 203c7e836 Improved documentation for 'pull' 4ad7dc93b Cleanup pull CLI, get rid of unused pull parameters 099608918 Fix typo 59776da87 Return errors instead of fatals f40604a5f Add user prompt to clean cache 63658aa6e make sure the fusecmd options stay in order 54fd7b7af use new FuseInfo structure cc14c4366 set PATH for the fuse command 109144c5e make --fusecmd imply --pid 953c7f92c add enable fusecmd config option 18d1fafbf Add --fusecmd option 8c74d1f85 Remove the invalid ownership changes to GOPATH 630333023 Use curl instead of wget 0bb0dbbb1 Remove the dependency on homebrew to install go 9f07e379c Fixing syntax error 9c12a1626 Updating the patch 47cd8462d Change cache clean force flag to dry-run a92eddde6 Add notice output about cache clean dry mode 185d4909d Rename imgbuild engine receivers e370fc62b Rename singularity engine receivers to be the same 35c3f48a2 Rename oci engine recievers so they are all the same 1bea4554c Add comments about the channel that is used to synchronize threads. c009e822b Deactivate a specific crypt_dev unit tests that is creating too many problems. There is a deeper problem with testing crypt_dev (issue 3983) 02a98bfdc wait for fuse command, and queue signals until later 325320af8 Better handle the path to the Singularity system configuration file 2968a0e79 Another workaround for CI since we still have configuration conflicts 12b4d0390 Add unit test to crypt_dev.go c5f7b8fd9 [3.4] Fix issue when exporting a key and the keyring files do not exist b5ea63331 Add support for mounting FUSE filesystems in the container f21de4af0 Add "fuse" to the list of known filesystems cb87ca5a5 Update sif to release v1.0.6 f63c05031 Store temporary archive in the parent destination directory for squashfs unpacker bfbce5777 Update CHANGELOG.md 00d319ec6 Check ContentLength if -1 before compairing it with downloaded image d901db71c arch in disableCache code paths 793d68761 Fix review comment r.e. public flag var 8dbfb94d7 Add encryption support to instances b7c92c381 Fix cryptsetup hang when running from a container IPC namespace 2ed3657da Make sure the JSON file is correctly created when gathering the Singularity commands 0a147151a Fix another set of duplications in the code to gather the list of all Singularity commands 28906c8ef Move instance detachment in Singularity engine and get rid of isInstance generic check in Master. Add RPC/master socket checks while converting file descriptor to *os.File pointer. Remove now useless call to runtime.LockOSThread, it was previously required to workaround issue with Go runtime <= 1.9. Remove unit test for Master function for now and explaining why. Remove engine nil checks, not reachable code path as there is a check in main_linux.go for that. 88fda4480 reorganize a test structure to please the linter and add an additional unit test and a slight modification of the original code to avoid a failure with the new unit tests 3738500f3 Add some unit testing to internal/app/starter/master_linux.go and reorganize slightly the code to do so 89180afce Fix fakeroot and SELinux issue by remounting /sys/fs/selinux read-only 2737e74f0 Include Go tags and Cgo files for go list in gengodep fe9a21462 Fix scratch mount and remove false skipping mount warning 9f554a36d Add recursive mount flag for /tmp and /var/tmp in build engine for user namespace issue aa22f12e5 Show unsquashfs failure output ed5d8a73f Fix command duplicate problem and improve comments b511066f6 Singularity should not rely on environment c017a2e46 Change "Build complete: " to point to target (instead of cache) d25703757 Attempting to fix URI issue with custom registry subpath 658185cfd Fix broken fork_ns on aarch64 by allocating a larger stack de1ed60ad Move to cryptsetup v2.0.x compatability aa3562bad Add max port value check 9653e1977 Check SIF squashfs/ext3 partitions at load time 9b9b94f73 Fixed shub URI issue a470d1350 Cache Shub images by commit hash 79a3dd326 Add unit test for pkg/util/crypt, at the moment mainly the error cases 0209ee076 Add basic code to implement a e2e coverage functionality d40ee71bc Add basic code to implement a e2e coverage functionality 122fd8267 Add test ef1290ca9 Add the apt fix to the e2e_tests job 05b2de952 Do not fail if nothing is using the lock 819f6400a Remove comments and list all locks 35f4e025c Kill the apt processes that start on boot but do not finish before CI steps 698476a7f Fix port handling de79ae1c8 Ensure login flow does not occur for global remote 81b9ba050 Update integration tests 3645f1c81 Add automatic remote login flow to add 7c9d4210a improve remote help docs 87119e24f Update remoteWarning to be more explicit 8797b2274 Cleaned code & added comments + added a couple fail import tests d0c1c3e55 Port e2e inspect tests 4d97a80b4 Fix integer overflow on 32 bits system in fakeroot package a066ffcb6 Merge bug fix for 3.3 e8401b0e6 Remove naked returns, enable linter 65227288d Update go to 1.12.7 in CI (#4004) 40331a5b1 Fix --contain issue with both overlay/underlay and writable flags. ea3603622 Update golangci-lint from 1.15.0 to 1.17.1 01318ad1f Remove copy/paste oversight in fakeroot engine 31afb5aa9 Add 'SINGULARITY_DISABLE_CACHE' 75197ad4b Add stack traces to test errors f3bbb9ed1 Add check to ensure gzip compression 9100b3741 Adding/improving tests ebf384928 bump scs-library-client to 0.4.1 d86e779f8 Adding/improving tests c3c5e5edc Create a new utility package to correctly get the path to the system-level Singularity configuration file 03c8660e5 Update internal/pkg/util/fs/squashfs/squashfs.go a85735a9a Update internal/pkg/util/fs/squashfs/squashfs.go 44fbf52a5 Update internal/pkg/build/assemblers/assembler_sif.go 4ff748de6 fix an unrelated spelling mistake that is blocking the PR dc7e0c10b Move the new util package for squashfs to be internal affea0af7 Reorganize code to avoid duplication when creating a squashfs file system 4f8974f4d Fakeroot configuration package cd79b4dba Compile only compatible engines for starter SUID binary f0ba064c7 Migrate to scs-library-client 0.4.0 10547dc2b Update the e2e push test to match the new API 79cfbe1fb [E2E] tests for 'key' (take 2!) ec3737362 Update e2e/push/push.go f55236783 Run E2E suites in unspecified order 7d4e5410e Add mandatory argument to RunSingularity to specify binary to use b4603720a Add e2e.AsSubtest to request running singularity as a subtest 9f72ad0a7 Add a comment to the e2e push test 119315a62 Simplify the e2e push test by handling explicitly the test's exit code f9e779b5f Fix typo a8fea92a6 Update go.mod & vendor/modules.txt 86fb5943a Update CHANGELOG.md & CONTRIBUTORS.md 1a64b35ba Provide testing for SLE support in zypper packager 82c212137 Add unit tests for zypper installation on SLE ee819a499 Improve integration with SUSE Products 148f63f1c Add support for numbered variables ae666ea2e Support multi-line bootdef settings 496fdc114 Handle zypper error code correctly 9d16f8303 zypper install: Fix dbpath for newer versions of SUSE Linux 39185e497 Port e2e push test 5b9887671 Use --quiet instead of redirect cd80e862d Write wget output to /dev/null 9d322338b Remove output order requirement in TestExpandPath 5366415c1 Port remote E2E tests new exectuion context 568b1a184 Port E2E instance tests. d0cd99cb5 Use PULL_ARCH instead of ARCH as env var 971543af7 Fix buildLocalImage so that it does not step over itself 5deadc5f9 Added tests for '--local' flag + updated test names + improved testing + removed extra t.Run() dbf3ba164 Support opening images using a private PEM key 6142868dc Add support for public keys when encrypting images 2a90361c8 Use []byte instead of string for passing keys around 980c1e628 Use newuidmap/newgidmap as fakeroot fallback for unprivileged installation. 2b5e0eb9c Basic arch specific push/pull 7e6c20d59 Use newuidmap/newgidmap as fakeroot fallback for unprivileged installation. 96f4414f3 Update Makefile.stub. 5baaa08b8 Change man path in spec file so man page does *not* need to be compressed with gzip eafaf85bb fixed name format on test files for oci adae142e3 fixing testSingularity test 1c714231a fixing testSingularity test 9bfeb4167 fixing testSingularity test ed2d8c6ba fixing testSingularity test 4bd1339d4 removing dot instance cmds 949144bd6 adding missing commands cbbae290e removing create command 32655b4c5 Fix a stupid mistake when trying to set a temporary keyring for the e2e/pull test 808313010 Apply suggestions from code review 41cd1fdb3 removed check cmd 82afba1d4 modifying args from cmd 1cfdba738 Add a missing commit that extends the e2e env structure to include location for a keyring eac1da7c3 Port e2e pull tests fa288eae6 Library arch specific tags - push 0d7995434 Fixed a couple misspells 8afd7c43f fix additional args 3879f3c7a fix additional args e54269202 Remove unnecessary messages from sypgp that were added by mistake 9fcf35359 Remove debugging left-over from the new internal/pkg/util/interactive package dd85fa606 Update internal/pkg/util/interactive/interactive.go a5adf6494 Port e2e env tests 3f89f6a9f Changed 'Local' => 'KeyLocal' 1c7621aa8 Update internal/pkg/util/interactive/interactive.go 3daf09a56 Update internal/pkg/util/interactive/interactive_test.go ba72dce8e addressed reviews from cedric 128c371a4 Added helper pull function + updated library images to use busyboxes 83b7264a2 More efficient testing + Added tests for 'Signatures' + Improved command error + New containers to test + Use 'RunSingularity'! aa6fc5a88 Fix and expand incorrect comment re: LUKS overhead 98a10d59c Misc cleanup 4ee554ab3 Remove duplicated code to open the crypt device 4f7b1d1b3 Close temporary encryption device before attching it to a loop device 5c2b3dd30 Use smaller sizes for metadata and key slots 5ea055dc4 Rework copyDeviceContents to deal with short reads and writes 1bfb26e33 Rework retry logic in Open function 5180d9ee5 Rename GetCryptDevice to Open bc4421a18 Pass the full path to the loop device to the RPC server 0cee5051b Rename FormatCryptDevice to EncryptFilesystem 1fa914bc8 Support getting the encryption key from the environment when running 82a14b10e Clean up FormatCryptDevice to take a key as argument 03471869b Obtain SIF encryption key from environment 9305c06b3 Wip, adding e2e tests for verify 8ac2f5287 Improving the json output for 'verify' 50faf9ed0 Create a fakeroot engine to fix build issues with fakeroot option. 0d63da6ac Add few basic e2e tests for OCI commands f7a16b1f0 Move internal/pkg/test/exec to internal/pkg/test/tool/exec 2d0274641 Create a fakeroot engine to fix build issues with fakeroot option. a8c09334b improving test commands flow 31deab6d0 address reviews from cedric 1e4167951 address reviews from cedric 2085733d1 Updated the copyright for updated files 090148bb3 Json output for 'verify' 56e70c1a7 Change ALL error messages to un-cap 4e794e3b0 removing bootstrap command deprecated dba6cd0bc removing apps command deprecated e5a56d0f8 porting help tests on new execution command 24b0f0f93 porting test failure 91efe014b adding test help oci content 8b93e14d9 ported testCommands function c0ed21ae0 change param on withargs fc0f5320e withcommand -> withargs e291f4054 withcommand -> withargs 67a3baa54 Remove a sypgp unit test that cannot easily be fixed. It will be reintegrated once the code fully refactored. 1c09d5e96 Propagate the move of code to interact with users to a separate utility package (why did make testall not catch that?) 82ef6949c Avoid code duplication in unit tests for internal/pkg/util/interactive f0385d922 Move code to interact with user out of sypgp to a separate utility package 01bb2930f Add a match argument to ExpectOutput and ExpectError to allow three match type: contain, exact and regex. 352856820 Rework cgroups helpers and add cgroups freezer 74d8541a1 Remove Root() method that can move cache location 336357953 Add separate cleanAllCaches() tests 9eeb61bfd added review from cclerget 1e5c1e363 adding equal test version 9da4f43ed porting semantic version test version 6d11d0e46 Execute e2e tests inside their own pid and mount namespaces. f82fda403 Modify sypgp to not have to use SINGULARITY_SYPGPDIR in unit tests. For that, a new function is introduced for the create of a handle that represent a keyring; make it possible to create new clean keyring, including temporary keyrings for testing. 91cd1aa75 Added "is this a image" check to build command This will re-allow you to build a sif from a sif without root. 818282370 Check for cryptsetup at build time e576e1de4 changes to fix lint issues 47c1200ab removing shub tests while shub is down 3de5d3d29 Remove the compare-url orb and replace it with a git command (#3907) ae1bdcd53 Quick E2E test fix f016735c1 Add some non-root build tests c8382a7a1 Improving the output/workflow of 'verify' and 'pull' cd1b55997 Improve test coverage for the image cache package 5a6891627 Simplify some code and make an error message more explicit 75264579a Add few test helpers in tool/require package: 3d2436d19 added changes from commit 484378a (in master) manually since the cherry-pick conflicts so badly 18a1ab91a fixed an unintentional reversion to the older version of the handleOras function 054fe0228 Attempt to remount bind point with user namespace but ignore permission denied errors returned and warn users if the bind mount need requested to be mounted read-only. 64bf3ed3b Avoid having the 'INFO: environment variable SINGULARITY_CACHEDIR not set, using default image cache' message displayed all the time while using the CLI 713cb1d14 Remove a reference to the image that is not necessary anymore and create a failure. 39f33542a Remove deadcode in the ORAS cache code after revisiting the overall implementation of image caches 789e98b53 Revert updates to the copyright since we ended not modifying a few files 8bd9fd3fc Remove an unecessary pointer to the image cache in the sandbox assembler 92b28f0ce Update parameters for a call to imageBuild() from a unit test that went through the cracks during a merge f46ab5e62 Fix a few issues that i did not catch while solving merge conflicts related to cache management 92c82a623 While using an image cache handle, avoid checks that are not required to make the code more readable 2799edf95 Avoid code duplication while handle image caches in unit tests and make the code more readable 4f160b1d7 Avoid some code duplication related to image cache management and as a result make code easier to understand 01727e6f3 Make sure the image cache documentation will have the intended formatting 2e3b291d2 Move the image cache handle from the build configuration to the options and as a result avoid having to extend the conveyor interface 318d4d362 Correctly return an error instead of failing when the image cache is not set properly 6f76becc5 Clean up output generated by the image cache management code and tests 9093fabb9 The sandbox assembler is not supposed to use the image cache so remove the image cache code management code that is not necessary b1142206c Fix an incorrect os.Exit() when the image cache is not defined and instead correctly return an error 64ef486ba Make the management of the image cache handle easier to read in the context of the CLI 364874df4 Do not export the BaseDir field of an image cache handle since it is not meant to be modified after the handle is initialized and instead provide a function to get its value cd46140fa Remove a unwanted message from the image cache management code baea75db7 Remove a TODO comment that seems to be outdated 3a4b71b65 Rename the function to initialize a new image cache handle from HdlInit() to NewHandle() 8c1fffde1 Rename the image cache handle from ImgCache to Handle 491e1dfdb Revisit the implementation of image caches to make it thread-safe, ensure the configuration of the cache cannot be changed by mistake during the execution of a command. ed636814c Added "is this a image" check to build command This will re-allow you to build a sif from a sif without root. 020385e3f Filter all unauthorized capabilities after user/group checks f66c2d005 Added 'cryptsetup' on install section (#3878) a838fde10 Skip e2e tests for pull requests based on their changes (#3890) 484378a0a Fixed panic when export-ing a key when keyring is empty b77404256 Moved MakeTmpDir in e2e internal package as fs helper package and also added MakeTmpFile. 54e7263af Port e2e docker tests to use new singularity execution context 82eadc174 last update on env vars ce0a7150f Port imgbuild tests to new execution context ee7bea302 Network CNI plugins update f724e24e7 update descriptions on env vars 42a714ae1 Remove call to e2e.PrepRegistry from toplevel test b70fadaeb Move defer file.Close() closer to where it's opened 6e0659e54 Rework RecryptKey to take a passphrase 6ed56bdb5 Move common code out of SelectPubKey / SelectPrivKey 677398ffb Rework RemovePubKey to use the new functions bbe725bd4 Add removeKey to handle removal of keys 8399cce7d Move storing keys to common functions d42b6764f Add createOrAppendPrivateFile to reduce code duplication 27db5236f Add test for findKeyByFingerprint 1d6047f89 Add test for CompareKeyEntity 8529c6bb7 Add the `no_output_timeout` option to the `Run E2E tests` step in the `e2e_tests` job f8088013f Improve testing on pkg/sypgp.go (#3705) 8426733f1 Move call to e2e.EnsureImage to the tests that need it (#3872) 3bc1e0301 Encrypted File System inside SIF (#3729) 5ef6ef3b6 Changed SINGULARITY_NAME => SINGULARITY_PULL_NAME This variable name was interfering will 'SINGULARITY_NAME' when shell-ing into a container. This is a problom if you are running singularity in a singularity container, because every time you pull a container, it will be the name of the contianer you are shelling into, (unexpected behavior) 662ae2945 Prepare xyve VM for networking. 5fa147ffb Use NewTestConsole instead of NewConsole 9fa84da5a Skip PersistentOverlay test if mkfs.ext3 is not available a75eac2aa Update e2e/actions/actions.go 9a5b78e1d Add workaround for false-negative in ShellExit test 0ce7e0b61 Disable tests or test cases that access singularity hub 2867ef939 Fix the dates in the copyright statement 4b8a879ed Always check the return of the Scan() function 92efc2bc9 Pass test environment information as function arguments 0c92a273f Attempt to remount bind point with user namespace but ignore permission denied errors returned and warn users if the bind mount need requested to be mounted read-only. 82738ce0d Clean up code related to loading keyrings 82650fd5d Add script to run e2e tests 5d8611466 Remove the non-e2e privilege handling package. a10239b25 Update the sylog unit test to return the UID in a manner that is inline with the sylog code. This avoids a problem when running 'make testall' f86f5ae93 Extend the unit tests for sylog to catch what is pushed to stderr and compare it to that is expected. 7b092d2d1 fixed typo e8f3f2f31 Do not use generic error 64d2a0b11 Return ErrArchMismatch if SIF arch is incompatible with host's 259369f26 Fix bad pull library URI variable introduces during CLI refactoring 173b05b46 Add parent user namespace detection to alter workflow accordingly. Build engine could run from a parent user namespace running in rootless mode in order to build images without root privs and without requiring Singularity setuid installation if users choose to not use native fakeroot feature. f7b429fd6 Fix parent process signal propagation 12479ec2c Fix user namespace mappings size and change minimum value for fakeroot base id, so users will have a true 65536 range and root 1:1 couldn't be overlapped. ef34b308a Update the help for remote commands that use a default value for the remote name 3a1884e79 Update help docs to include oras transport c9a60e07b Use oras context package to discard output 916b31599 Add oras push completion output cbe16738e Rework cache listing and cleaning code 516e69ffe Compair => Compare, as @gvallee suggested :+1: 0a26574f8 Add wildcard support for %files section 378379d0e Add parent user namespace detection to alter workflow accordingly. Build engine could run from a parent user namespace running in rootless mode in order to build images without root privs and without requiring Singularity setuid installation if users choose to not use native fakeroot feature. 00bfd7d2c Fix bad pull library URI variable introduces during CLI refactoring 7cc99c6d4 Add cache deletion code for net and oras. b7c780351 Fix user namespace mappings size and change minimum value for fakeroot base id, so users will have a true 65536 range and root 1:1 couldn't be overlapped. ba0a251d3 Update the circleci config to version 2.1 eae372721 Added buffer to interruptCleanup function, as mem suggested 054ca36b0 Fix e2e tests privileges escalation issues by removing test.WithoutPrivilege in ImageVerify. e7b500a12 Fix parent process signal propagation 491a71716 Rework of privileges management for e2e tests, most of the code is now executed as non-privileged user unless it explicitly call e2e.Privileged method which is the equivalent of test.WithPrivilege, test.WithoutPrivilege is not required anymore. fbf81ca0f Use '"' instead of '`', now it will take the expected output without changing anything! And removed extra code fce34fa6b Add the inspected output to the table + instead of parsing the whole expected output as JSON b8936898c Slightly change the sylog.go code to enable better testing and add unit tests 6743d132f Changed 'test.WithPrivlege' => 'test.WithoutPrivlege' 8862bc740 Unexported InterruptCleanup(), suggested by @mem + fixed type suggested by @gvallee (theres => there's) 403908dd8 Update the help for remote commands that use a default value for the remote name e70e29d92 Use oras context package to discard output 5adcbf544 Add oras push completion output 499c1d408 Changed function name from "SignalHandlerInterrupt" to "InterruptCleanup" as IanK suggested e4595f800 Removed extra newline, to be consistent I'm also trying to use less commits, but thats not working out very whell. Theres always something to change :/ 4668becb1 Added godoc comment for SignalHandlerInterrupt & updated error check for that function 870219c0c Added the "if err = cache.ErrBadChecksum" to oras ebac905fb Moved signal-interrupt to a common function + ErrHashNotTheSame to ErrBadChecksum & moved it to dir.go 3af6a198a Uncaped/fixed typed error messages 788fcf0eb Removed commented code ba36f29f1 Fixed spelling + cleaned code + added interupt check for library 0f789b540 Removed commented code 1d8a3542a Remove the half-downloaded cache if interupted while pulling ee5c61ba7 Update help docs to include oras transport a7176da50 Added newline after file, to fix CCI 95eaffb1f Trying to revert instance_test.go This PR is not to improve the tests, so I'm trying to revert that file... 4a7e5e64b remove one line: Westley's review 87f11516a Avoid having the 'INFO: environment variable SINGULARITY_CACHEDIR not set, using default image cache' message displayed all the time while using the CLI 8f4d02737 Remove a reference to the image that is not necessary anymore and create a failure. 1efd38839 Remove deadcode in the ORAS cache code after revisiting the overall implementation of image caches 59edbd561 Revert updates to the copyright since we ended not modifying a few files 50d16765e Remove an unecessary pointer to the image cache in the sandbox assembler d03425012 Update parameters for a call to imageBuild() from a unit test that went through the cracks during a merge fe69d02f5 Fix a few issues that i did not catch while solving merge conflicts related to cache management 9bc1cc33f While using an image cache handle, avoid checks that are not required to make the code more readable 093c348b3 Avoid code duplication while handle image caches in unit tests and make the code more readable 30ae240cc Avoid some code duplication related to image cache management and as a result make code easier to understand a9ece8317 Make sure the image cache documentation will have the intended formatting 2eeb50dd1 Move the image cache handle from the build configuration to the options and as a result avoid having to extend the conveyor interface 086e443cc Correctly return an error instead of failing when the image cache is not set properly 4e3e3fb24 Clean up output generated by the image cache management code and tests 4da59411c The sandbox assembler is not supposed to use the image cache so remove the image cache code management code that is not necessary 82d66d581 Fix an incorrect os.Exit() when the image cache is not defined and instead correctly return an error 3539f8901 Make the management of the image cache handle easier to read in the context of the CLI 393422107 Do not export the BaseDir field of an image cache handle since it is not meant to be modified after the handle is initialized and instead provide a function to get its value 17a083780 Remove a unwanted message from the image cache management code 74ae8f4ed Remove a TODO comment that seems to be outdated 26481bebd Rename the function to initialize a new image cache handle from HdlInit() to NewHandle() 882224949 Rename the image cache handle from ImgCache to Handle c5011b8ec Improve os exec cmd traceability in e2e tests: Version tests (#3733) e0cd48f35 Err, that file was not suppoestd to change Not sure why that changed, so I just reverted it back to master... Hopfully 88fcd4782 Removed copy-right that I added before. After some talking with JMS and Dave, I removed the copyright thing I added before. 1dc7e8b30 Updated to the latest go version 5422f4efb Revisit the implementation of image caches to make it thread-safe, ensure the configuration of the cache cannot be changed by mistake during the execution of a command. 9a9b58924 Update CHANGELOG.md db0e695d8 Update CHANGELOG.md c9437e13e updating version in INSTALL.md 3fa4ff22b Removed "if file exist" check for actions commands This was causing a problome when you exec a container from the library://, or instance://. 68ff3a3da Added some debugging for Travis: print the "command that failed" - FORCED_PUSHED!!! 9f00e9d96 Added some debugging to Travis; "print the command that failed" - forced-pushed! d25e64b64 Maybe slightly "improved" base environment This updates the copyright thing for Sylabs, also adds a extra space before comment. And changes the "no tests found for this container; running !/bin/sh true" or however it goes. 72346f4da updating golden txt files to fix help test failures 5e3a46cb9 Check if the container exist, and print user-friendly error if not Adds check in 'cmd/internal/cli' to make sure the 'container' exist and is a plain file (non-directory) only for verify. For all other actions-commands, this will only check if a file, or directory exist. Because you can 'exec' a sandbox image (witch is a directory). 8d04c2a02 Removed extra nil check ad3574704 Added a couple more tests for 'labels', now RFR! a99380efd Fixed main package name, DUUUHH! 2885b54ce Fixed var names DUH! + use testenv.CmdPath instead of calling "singularity" 18753c92d Fixed json => JSON (golint) 5925ababc Updated the test container + fixed suite.go e4e920987 Updated test container name + added def file for that contianer + updated tests for reviwers d808f8366 Update docs/content.go 4ceba8d8d Update docs/remote.go fd4984e24 Update docs/remote.go 1db764ea0 Update docs/remote.go 13e11fe5e Update docs/plugin.go 18d18901c Update docs/plugin.go d11489cfe Update docs/content.go a71942e7d Added more inspect tests e5384ac0a Now using table tests 72d853ed7 Fakeroot feature 4518cf7a7 The start of E2E testing for inspect 796ab20ef Added same debuging message to def file build 2edd90f92 Fixed return error on pull. Print the image that does not exist d55e48ed9 Fixed panic when exec/run a container in the library that does not exist 7ab0d0023 Convert CNI results to maintain cni versions compatibility 4ab09ce0a Fix SELinux unconfined test (#3723) ad86e1a04 addressing reviews c2363829d Clean environment by setting variables to empty string rather than NULL. See issue #3703 for details. 77eec12a6 Fix pipe socket buffer size check 6ae01f64e Fix configuration bad default value and remove old configuration template file 2b3098e2e Create /dev/tty device by default with contain/minimal dev a8b0935d6 Split starter stage functions. Add descriptive comments. 5b212457f adding back in some whitespace that was erroneously deleted cde5d9803 DRY internal/app/singularity/cache_clean_linux.go (#3698) e3bda824a Update busybox URI in examples (#3713) 727651382 Rework namespace join 8f569dca3 Add SharedTag mount for shared mount between master/container processes. Rework network setup. 116acb917 Simplified apply_container_privileges logic. Remove now useless setup_userns_identify. Remove automatic set of target uid/gid with user namespace mapping. d68cf18ee remove changes from vendor lib 9c4d8ad00 Add oras e2e build tests 8b0bb5d3c Support oras transport for builds c6c4e1ac0 Add e2e tests for oras actions 51e80654a add oras support for action commands b4ae38656 avoid modifying vendor lib d4808184b format regexp 5b9935b69 add machine readable format ea5fd63bc declare and assign in one line c70a568c4 adding some comments bb80edd1d adding some comments dc919de19 deleting unused libraries dd22555b2 unused libraries from html 29d8f7328 displaying user emails on key search f9853a6ef Fix problem with internal/pkg/build/sources/conveyorPacker_busybox.go (#3708) 7a1b4e35d adding some logic on the formatting, need to update the user emails fae33077e Remove an unused check for the golang version (#3702) 926a392d2 Fix wait_child by exiting if status is not equal to zero. Fixed fsuid for hybrid workflow. Fix user namespace instance join. Fix hybrid workflow. Fix setgroups setup_userns_identity. Restore current working directory due to build issue. 0bdb6227d Added debugging and debugged some bugs + bug fix 61a625119 Call cache.Clean() in case statment 05c1d6e80 Fixed type ba519fbbc []stirng{""} => []string{}, and updated debug message bee65e394 Loop thought and remove only the cache directories that we created 7dd456180 Reverted tests 1359b114c Add caching for pulls with oras transport 4dd1b3c4d Update to latest scs-library-client 4724e900f Fix mispelling occured and reorganize wait_child a bit. 13f937841 Address Michael's comments. Add more comments, fix missing newline. 5f0ebb0b0 Check if running with suid workflow before loading overlay module d8e71646b Combined cacheClean* to switch clean function 87aa5e815 Added back overide output file check 57af85863 PullShubImage => PullShub 750e72a71 Moved PullShubImage to singularity package 7d4b4b65d removed redundant function to determine user's conf directory location b653f5a76 Change the location of the cmdtree command d4669b869 Add a command to print the command tree for singularity 24900bd96 removed period from verbose message 7b7c730cd test was incorrectly expecting user home directory when home directory was supposed to be /root 34f544622 Set working directory / after master initialization d53908a06 C code starter cleanup and enhancements b2e8d9c35 adding dependencies f23031c38 adding deps ef52151c2 removing additional lines 11cbbfe94 removing additional lines 96abfacf1 cleaning format to look as expected 41666b162 update to 3.2.1 6f3a8286b Updated shub pull to 2 functions, one for cached pulls, and the other for actions pull, like exec, shell etc... Maybe theres a better way to handle this :thinking: 49543f7ec Update docs/remote.go 1c1c28b21 removed all html tags, need to reorder key descriptions d90d26383 Update remote.go 167e28bc7 Update remote.go 5ce4cb527 Update remote.go dbc290ba1 added some unit tests for the functions that create ~/.singularity 756286c51 fixed issues with inconsistent whitespace and line wrapping in help 5bcd8e7d8 Split createConfDir() workflow into 2 functions based on feedback from gvallee. Also reused some existing functions. fbcb1caba rename data_dir to dataDir to fix lint ba1ae4d36 singularity command will now create ~/.singularity if it does not already exist 1faaee68e Added missing err check -> CCI ab2358bda Support for Shub cacheing when using 'pull' 7115b84ec Add 'shub' to cache list/clean + improved '--name' handling cc3fdec7a Remove useless code and cleanup 95381813b Remove unecessary Go environment cleanup and fix issue in starter C code 9250e6f14 Avoid session final directory to be screwed by user binds. Use fchdir instead of chdir with sandbox image. 40c9eda35 Split starter configuration strucuture into smaller and descriptive structure. Replace chdir/file descriptor sharing magic by explicit call. Rename prepare_stage by apply_container_privileges. Rework few functions prototype for better readibility/understanding. d096097fe Updated + sorted f43f873de Fixed unit tests to pass e21800144 Create a 'cache' directory after 'SINGULARITY_CACHEDIR' is set 9b714ba8c Catch potential nil pointer panic 27f1e0810 fix docker cred flag f1c9d7145 Mods to support scs-library-client v0.2.0 a12b94692 trim spaces on version 71e37b239 adding reviews from WestleyK and IanK c9add677c Merge pull request #3640 from GodloveD/redate-changelog 1f48d1ccf updating changelog for point release 496490cef updated CHANGELOG.md and INSTALL.md for point release 3b0066624 updating changelog for point release eb0278fb2 considering semver until patch 620137c93 Use the same k8s/client-go version as in cri 8c8bb20f7 Add missing readonly flag to loop device 67d9ca17f [E2E] Tests for version (#3566) 2f5e89bac Fix panic for builds using invalid library source b7ecf6354 vsoch review 706adb6bd Add sif(siftool) command line tool to singularity ea9ce46fd Added missing 'the' f3901dfb8 Removed 'remote' in error messages df60c0bd1 Use ok bool to check if exist 3d84268fb Fixed panic when pulling a container that does not exist e0ef2267b adding scif apps content 13c788cc0 chery pick c0f9abf5d9877372bff12127fd7294c2e962e1ab.patch 3cf5b1943 updated CHANGELOG.md and INSTALL.md for point release 0a2175e77 Automatically bind nvidia persistenced socket with --nv c380e1fb2 Fix instance join regression with root user (#3586) d9e289c0b Copyright notices update d3f02d048 Better signal/exit status propagation ecbec19e5 Create process group for instance and forward signal to process group d2e2f2783 Remove signal proxying/terminal control and assume kill by process group id eb70430a5 Update copyright notice 04ed58f9e Fix false warning when seccomp is disabled e26598878 Updated for reviewers bbcb12ea6 Update modules.txt da8405403 Add more invalid oras pull tests 0d277bfe6 Add e2e tests for oras push eafe0ed89 Ensure only SIFs are used with oras transport af9d50148 Move icmd wrapper to internal/pkg/test/exec (#3598) 7cc58cc21 Allow arbitrary locations when pushing to oras 6c907dbb5 Fix cgroup test panic 3ee72a130 Slightly improved help for 'search' d00708aac Removed Extra TIP pointing to sylabs.io/docs when pushing a unsigned container 816e114d1 Fix instance join regression with root user (#3586) 3615b62db Automatically bind nvidia persistenced socket with --nv 795071165 Add a README for help content tests (#3568) ebc34edb3 Don't call naked singularity (#3583) c8f3cf6e5 alpine linux: adding singularity-3.1.1 and singularity-3.2.0 5d9305e9d Use strings.TrimPrefix() instead of doing it myself d213cde9d return more descriptive errors in pull.go a42a7b5a4 Fix module name 19221e197 Simplify library ref parsing a3563338d more descriptive comments and errors, use of os.Open() for file that already exists 8fbd1f32a Removed redundant variables (#3577) 0158619ee Fix to handle image download without tag 473b70f19 Fixed comment typo 435e319b4 Configure the 'sypgp' dir with 'SINGULARITY_SYPGPDIR' (#3575) da85620f0 Fix linter warnings cacfc53d1 Handle legacy library refs in pull requests 2d34def74 Create scripts/go-test script during build (#3574) a1836fd50 Change default log level to info d3b4ac3c1 Fix OpenFile() flags cfabb15a5 Minor context tweak 1a7c280aa Port to scs-library-client e9b6e895a Remove unused import ceb9b5b11 Replace use of local library client 1c181c324 Replace use of obsolete functions a0fe12325 Updated go.mod/go.sum b4680d8e1 Mods to support scs-library-client b6567d94a Fix the man page installation for custom install prefixes d58b7811e Change direct references to .singularity to syfs.ConfigDir() c3f0bb978 Add syfs.ConfigDir() to obtain singularity's config directory 857629d0b Extract genKeyPair from GenKeyPair (#3541) 5372b76ca Fix a problem reported by a linter by recoding if statement through a… (#3556) cc30bb6f2 Initial move to using scs-build-client (#3562) e196e6f21 Add a logger Close method and fix logger test sync issue (#3551) 3a427e659 added breaking change to CHANGELOG.md (#3560) a12f65ac4 fix up error messages d24a94fad remote login/status should use default remote when no name is given 6dcb583ff refactor push and pull CLI commands b19d97b81 fixing up changelog for 3.2.0 ga 704c20655 More comments. Simplified instance list loop f2ac006d5 Store instance files in user home directory. Rework/consolidate instance join code for Singularity engine. 3642fae63 Updated warning message per @jscook2345 request b87389477 Update tip on pushing an unsigned container (#3522) 8ed39ade6 fixing up changelog for 3.2.0 ga f9d846146 More comments. Simplified instance list loop 618c9d568 Store instance files in user home directory. Rework/consolidate instance join code for Singularity engine. b625aefe9 key service client minor version should be v0.3.0 plus the specific commit 0d5890735 Remove macos testing from travis (#3543) 0569cbf9c Clean up DecryptKey (#3542) 6ddd3b416 Mark TestEnsureDirPrivate as failed if it passed unexpectedly (#3535) 50283fd57 Add notifications to slack for failing builds (#3536) c44221e75 Add DropPrivilege / ResetPrivilege in sypgp_test.go (#3534) 2258c11ef Add PrintEntity and PrintEntities tests (#3537) 3dabaeeee Add askYNQuestion to ask y/n questions (#3538) fdfadc740 remove whitespace in import statement 63e681272 Break up PathsCheck to make it testable (#3524) 15c95a21e Pull public key by ID (Last 8 characters) (#3523) 117293d60 put go.sum in the format go1.11.9 expects 90c205cb9 set config mediaType to appropriate value 240367b0a update vendor/modules.txt b54f1cff3 formatting to make goimport happy b16f7b118 change layer mediaType to reflect that this is not compressed with gzip b2a47cdc8 add info message for oras pull 3edbedf9b add test for oras behavior ceb364f73 move oci registry setup outside of docker tests in order to allow pull tests to leverage it aeedd0550 remove redundant switch case from rebase 77ed8a79d ensure image has correct perms de9a1d76a prevent panic from spec.Hostname() by catching it early and failing 21c7acab7 set default tag when none is specified cb47c7384 remove unused config mediaType d2959da03 update oras to v0.4.0 79ecb98bc Fix error not being checked 563d27de9 Remove logrus output and pull to specified name 0a77df031 Update to latest oras package, tweak push/pull functionality cda9a00a9 Add initial support for pushing SIF to OCI registries 55b424c1f Add another unit tests to internal/pkg/client/oci 130b832d7 Add content tests for the oci help commands (#3497) 0e8db8392 Add an error case for a slightly better testing coverage (#3516) 078ca5a51 Add test for internal/pkg/client/oci/transport.go with 100% coverage 6cd9ce83b Removed Unused, dead code 49be9eb73 Improved error when pushing a unsigned container 666f912af add hostname to definition file c5c1a0a43 fix defaulting to print labels a15e70eba add global flag for remote use command ab2e3cfc6 Key import ascii formated keys (#3393) 8b3cfe296 Updated debug message f973e9af3 Fixed panic e1bd60fc4 Fix CLI env parsing ab59ee987 reintroduce persistentPreRun for singularity command in order to set log level and color d44d36c0d Ported env test to e2e bc1741744 add -v shorthand for --verbose 62d6e72cb Port help test to e2e to fix #3353 f9f28e878 remove libexec package 5902c734b Updated cache clean docs (#3469) 031ed067b Add missing oci state commang back in CLI d7ba11d55 Reset default shell to /bin/sh. 3ac3d6a33 Add better checks on shell architecture. f496fe9ee RPM Spec fixes (#3462) 1d590f583 Resolve merge conflicts to fix #3470 0c85da25e Pass -mod=vendor to go list to avoid downloading modules (#3482) 33e0700b4 fix incorrect ImageVerify calls 39e3bf017 generic function to create and populate temporary files eec8f3056 remove left over debugging statement 052e6256a Make sure Go modules are disabled when checking Go version (#3481) e68a21f84 add header comment for depricated tests d44acaed5 change confusing test name f4a9c347b always test for labels instead of conditionally b2ead336f go fmt! (that's what I get for doing a quick edit with vanilla vim) 6a0091c68 updated tests to reflect that we are no longer passing SINGULARITY_* vars into container 9aebb43b4 Added hidden flag 3fd85eb95 Switch two calls to sylog.Fatalf to returning errors in order to avoid code to exit during testing 17b5eb6cd Return error instead of calling os.Exit() in order to improve testing coverage fd846855c Warningf => Infof 62648d109 Fixed warning message 52e917b70 Return error if image is already in the library a62e349ed Moved functionality of remote_test.go to E2E framework to fix #3350 90bb9ae45 Add deprecated notice in old test file. c1110033c Add a corner case test to get to 100% testing coverage 8fc0a00ea Order structs by size to optimize layout. 89eb2c2fe Update cmd/internal/cli/inspect_linux.go 142b27ea6 Minor changes I missed the first time around. e19122556 Migrate existing instance tests to the E2E framework. ff7a1924f Allow use of custom --home with 'mount home = no' 2ce7d3182 Check the Go compiler during mconfig (#3431) 8e8401179 code cleanup as suggested by WestleyK bf41709f5 Removed extra imports b50f8b2d7 Fix typo in INSTALL.md (#3443) e16256bdc Update formatting of error message as suggested by WestleyK 14b7597de fix mistake and rename test function e435e7511 update changelog 9ecdb0410 tidy up the CHANGELOG.md 5b2bcc9f5 port definition build tests to e2e framework 966c9d9e0 Update copyright notice dbe9b3316 Removed extra comment daeb08b73 Added --alow-unsigned 07002b93e Fix out of bound for starter GID array (#3423) d0674b6ad Add EnsureImage function to make sure a test image exists (#3429) e709fea6f Updated tests name++ 571942651 Added godoc dab255651 Updated/bug dockerPullTests 15996a0ae Ignore the e2e directory when doing unit tests f7f07c1d6 Trying to make CCI happy ad6888363 Uncommented tests abd8ad0d6 Added the extra tests 8a8fe358c Added docker stuff 6952aceef Fix minor typos 029966d7e Fix private mount propagation 10be691bc Rename command error type to be more generic 60815badd Fix false warning when seccomp is disabled 20e80940b Add adequate calls to handle privilege level 1db0eafbf Migrate cmd/singularity/pull_test.go to e2e/pull/pull.go 2892f9c6e Updated tests c9278e503 Updated tests cba078653 Exported var, & %v => %s 5a5ceaa2f No invalid remote name (except empty names) and revisit the test cases from there 15bc7a389 Adding tests 5f16c905b Revert to panic for SetCmdGroup since it's called from RegisterSubCmd and RegisterCmd 932e678ce Add InvalidCmdError type to help during print usage a2e0c9f72 Return an error instead of calling os.Exit() in order to facilitate testing. The callers are already checking for errors and appropriately calling os.Exit(). 60b6caba7 Explicitly drop privileges for the tests 4b4710ece Better document function. Remove interspersed argument. Rename RegisterCmdFlag to RegisterFlagForCmd 91b3710c8 Update the expected result for more tests based on the current implemenation 2b3c0aae8 Update the validity of the cases does on the current implementation 94c76db8b Add comment about string slice sanitizing 117173a05 Fix test error message 480b70006 Saving point a4f1031be --path => --dir in tests 2c1348af4 Path => Dir 6c8a9783e Deactivate another case that does not work with CircleCI bf98b7bad Just a saving point... 1a312079c Deactivate a test that systematically fail with CircleCI because of the way they deal with users. 4e3994689 Update error messages to track a problem that occurs only with CI 610024e8d Use os.Open 91642d9cd Fix a hardcoded path to a command that i forgot to fix in my previous commit, as suggested by cclerget 2da2d9092 Correctly handle cases requiring root privileges; remove unecessary code; avoid code duplication; based on comments from cclerget 06fdbaa84 Fix recorded version of github.com/opencontainers/image-tools 74f4f3e33 Improve e2e driver error reporting ee535d7ca Update some of the expected results based on modifications that were just made to internal/pkg/remote 3faab174f Fix typo reported by ikaneshiro 746efd29b Switch to a bytes.Buffer instead of file when testing invalid YAML data, as suggested by ikaneshiro e7d193314 Update a copyright statement i forgot to include to my previous commit 83a490a19 Update copyright statement and simplify some code, which addresses comments from WesleyK 0b442e9a0 Update error messages to something more meaningful as suggested by Ian Kaneshiro c4b1ec54c Make ReadFrom() fail when the YAML file does not the appropriate structure, as suggested by Ian Kaneshiro 2f39ab72a extend the test for ReadFrom() to cover the case of a YAML file with an invalid structure 550b81625 make the linter happy even if it removes a nice abstraction that makes the code easier to extend and understand de3a67194 Address some comments left on the PR and make sure we do not have duplicate cases, as well as add some missing cases. 38ebf07ba Change plugin API CommandAdder -> CommandHook 1d60ec69c Add a README which includes an example of how to add a test (#3384) 1f58adef3 Updated var name: PullPath => PullDir c0c62e4c4 PULLPATH => PULLDIR fb424eb32 Removed extra code 32f5a5842 Add additional tests for RemoteAdd() bd3f8b79b Add testing of RemoteRemove() and improve testing of RemoteAdd() 01b5ebc0c Create empty mount destination file when source is block, character, fifo or socket 3b57c4196 Display all CLI command manager errors adae54f54 Moved home destination determination to cleanEnv() to fix #3377 880102c97 FINALLY working! e2908add7 Removed extra file b0701bc3b Merged apps with inspect b64e08bb2 Add a test for internal/app/singularity/remote_add.go 79199874b Set the Home directory during image build process 48ed042c2 code clean up 6bdf8f68d Add test code for all functions of internal/pkg/client/oci except NewImageSource() ea5c186b8 Remove dead code 7be1a2ede Image path bug fix ae2b48bac Added more testssss f530f13a3 Fixed some bugs... 07ee96c4a Update vendor/modules.txt because squash commit 278abc2 did not contain change 5bc064bda tidy up the CHANGELOG.md fb516be66 Fixed for review 5105f75e4 Limit line lenth to 70-80 chars 921605577 Updateding key help 2f6fdd02e Updated typo 0e2cb3da9 Updated for Justin suggestion 7650db2bf Updated docs 54a409e5b Creates parent directories before copying a57fb5f61 Add scripts/check-vendor and update .circleci/config.yml to use it 587209b08 Add the vendor-check target to our code checking steps in the circleci configuration (#3267) ad1aa7ced update multistage definition c110586d4 multistage example 446fc6da6 Remove deprecated plugin hooks (#3301) 455dbecca document fact that --contain ignores bind paths e350f1370 Use Output instead of CombinedOutput for instance tests 651fa95a8 Throw a warning if seccomp is used and not enabled 5215bc5f5 Remove reliance on basename command to generate environment headers. bad3dc430 Armor flag support on key export command (#3281) 32ce25c4b update remote docs d3968ed2c Download default key before running tests 31137c9ff Removed extra filepath.Join() cebb63a31 Updated tests -> @ArangoGutierrez e7bab70a8 Creates parent directories before copying 16b6f1125 Split the e2e-test makefile target into two targets so either set of tests can be run by themselves. affd45260 chmod +X e2e/testdata/runscript.sh (#3366) 230e16784 Fix go-cli-lint thing... 4bd24f5de Make the testing makefile rules more consistent (#3362) 8df8b2de9 Check for empty configuration 278abc263 Add scripts/check-vendor and update .circleci/config.yml to use it 24e618eff Update vendor/modules.txt 5e129c39c Dont autogen a key pair b8e766488 Added SINGULARITY_PULLPATH 200f0054e Addresses all the comments provided on the PR 0ccecca31 Catch flag parsing error explicitly 7de9b75e9 Copyright notices update 84ab500e8 Better signal/exit status propagation 85af3391d Create process group for instance and forward signal to process group 6cfe114ab address @jscook2345 comments f230036da add env to triger e2e tests 778b7833a fix lint error 52126ce29 last minute fixes 20b16ff51 update vendor c06d2b5cd add e2e test to makeit and circleci 06312dcc1 Add the vendor-check target to our code checking steps in the circleci configuration (#3267) b0534493e Copyright consistancy a045d326e remove duplicated build test b03e23860 enhance master def file 4873b3389 add kelseyhightower/envconfig to go mod 38a514c52 Fixed specified 48472b370 Updated copyright year ce1b2ec60 Removed tabs/newlines from error returns 8284d88c2 Dont verbose when pulling from docker 815dc8e20 Add some missing error checking 2b9789d3d Make sure that dealing with unsigned images does not make the test fail 6b24e4d4f tidy up e2e 30eb77dd3 Fixes #3303. Improve test coverage of internal/pkg/client/cache. coverage: 82.2% of statements. 0b4a72e04 base e2e framework a4981b9f3 reduce build time for debian example d84146936 Moved 'download oci image' to its own function abd24318c Added verbose when pulling from docker 94878d23e Added verbose messages f01e8f9ed Updated names when pulling a container from a name 49c5f8236 Remove the root test case since the result will depend on the context of the test, which can be controled (it succeeds during CI testing but fails with Travis). 994a0b4ef Moved convertOciToSIF to its own func 5235d4f95 Updated vars & error messages ea889bbdf Expand the AuthorizedGroup test to avoid defining a test as root as a valid test (problem reported by CI). 0de6378c9 Change the way we test AuthorizedOwner since it would fail when testing the current user case while the user is root (problem reported by the CI). 116c50d77 Remove deprecated plugin hooks (#3301) 80d5cb686 update multistage definition e5779b792 Format virtual block devices in a slightly different way to see if it fixes the CI problem 6370c7912 Still tracking a problem that appears only with CI 42a1c6564 Track a problem that appears only with CI 8c0b2cd74 Remove signal proxying/terminal control and assume kill by process group id dfc0eae04 Remove reliance on basename command to generate environment headers. a74c4abe4 Fix a few problems reported while executed make checkall 9656e7bba Armor flag support on key export command (#3281) 49faeda10 Add code documentation and clean up the code 88f4e3319 Add tests for pkg/image/squashfs 878c1975a Added info cache message 9ca321218 Removed extra func b477cfbff Removed debugging 7bbc74010 IT WORKS!!! fef148971 Fixed for review d72480ece Limit line lenth to 70-80 chars bde5ba89a Updateding key help 3d61b500f multistage example 420b6411e Use Output instead of CombinedOutput for instance tests 9d9059060 Improve test coverage for pkg/image/image, pkg/image/ext3 and pkg/image/sandbox 909df5ceb Fix typo b7669118c Throw a warning if seccomp is used and not enabled 501adacc8 few more tweaks afed9ce51 update remote docs f7a241e86 removed a few lines based on suggestions by MB 9616e0bc2 bumped version number 85f46b4d8 updated CHANGELOG.md b23652641 document fact that --contain ignores bind paths 37e41eae2 Remove unused dependency. Fix darwin nil command with instance a73ffb093 Added error string for 500 code to fix #3283 f0ac7e97d Converted the remote command status code to readable string to fix #3000 84e8dd5eb remove installing dep from ci configurations d1d9dc5cd Fix and cleanup 383a9caa5 Update mount_linux_test.go d5f7c34bf updating URI to remote 0811f135a dont resolve remotes if doing local verify 364e7be7f Fixed the formatting errors and implemented feedback to fix#3265 3a5c8de38 Add few tests a9675f351 SYS -> GLOBAL in list command output bdbfa72cb Refactoring 3088364c6 Add README.md for examples/plugins/test-plugin 53189a615 Update plugin compile documentation 3e4ce5da4 Ensure we are building plugins from singularity's source directory fa34333a6 Move singularity engine config package out of internal 78a39fbbe Use the same trimpath value when building singularity and plugins 137db95ea Pass GO111MODULE=on and -mod=vendor when building plugins d929a3ebb Add debug output to plugin compile command e74e9d753 Remove leftover debug code from manifestgen 91e41b513 better error message 74ade04a5 return errors instead of fataling b3e8c2c06 remove unused function b644666e4 update help message to help user set up token for key commands 839304c65 Let's run security test 813ba69f1 Cover more command with remote endpoint behavior (#3261) 68d173b21 Updated tests 9c60b084a Key export command (#3117) 21d8cabca Fix a problem reported by lint 6ae8478ee Document more precisely the current situation of multi-architecture support 96a9f1166 Updated Verify() godoc comment thing d1255047d Exit 1 if no local key found c030218d4 Added local to singularity.go 0ae0c95f1 Shortend info message with no local keys e7a4e4fe6 Removed extra block, & updated info message 03cca6e16 Updated info message a073a3b32 Added --local flag 4cda11dfd Fix instance tests and apply minor method modifications b41f6d646 Add tests for internal/pkg/instance 2c0b29c0f Disable TestConfigure because it's failing in CircleCI 7f06e7321 Fix security test d4aa659a9 Add png and svg logos to repository 183d828f8 Fix apparmor tests and loop skipping 3dd929ba8 Additional check and return error in case of failure bb5e44de2 Fix apparmor test and use t.Skip 03bda24ae Cosmetic 3a24549c8 Add tests for internal/pkg/security ab4627001 fix remote login 09caac4ba Restore the branch filter for the `integration_tests` job. 5aa5308e6 Remove some extra spaces in the environment variable setup step. abf7145cd Temporarily remove the branch filter for the `integration_tests` job. 8a01bb71f Remove the `GOCACHE` environment variable from the circleci configuration. 442030599 1. Updated the help for "singularity push" command with actual remote endpoint instead of URL to fix #3197 2. Added myself to the contributors list 3f453fab5 Provide instructions for installing golangci-lint f1310efc1 Strip the scheme (transport) part of URI before saving in remote.yaml to fix #3173 b50451fee trim whitespace before shebang check and reorder pipe writing bff2e30fa check for existing golangci-lint before installing it fa06d2a7b move golangci-lint install to make check e96fa0881 fix spelling mistake f946aa837 Respect args in definition section 0bdf1799b Make parser changes to allow shebangs 3dc87a968 Fix issues reporte by lint c6c7d9754 Fix a few issues that look like copy/paste mistakes 214c87042 Addresses issue #1488. Perform basic architecture check in the starter 3116a38ab Build sandbox after remote build download bb059074f add newline at EOF 43c3a14bb fix typo b041b8686 update default name to be more descriptive 804c9dd67 update remote waring message 6b07dba89 add flag to login from tokenfile 213d832d7 Automatically log in to default remote if tokenfile found ce88b2b72 install system config at build time be3564098 update remote add to differentiate between system and user config 6613ca75b update remote package to fix some behavior 0469eb404 Avoid code duplication by having a single function that checks for root privileges for all commands fcc281dda Fix a problem highlighted by CI; the JSON example was invalid fa952ca7e Add missing bundle argument requirement for oci create/run help commands ec816d195 Fix resource typo c351c540b Add capability warning if unknown or not authorized are provided 15f801ab2 Ignore nil command and fix darwin compilation 102346f65 Add missing pwd flag for actions b1a85eb6c Remove old env handler 40ce71c4e Add oci command accf0211a Add required flag support and fix badly named function cacd77d98 Add required flag support a015c0aa9 Key command 63a7d9b80 Inspect command 7ef6f7756 Move cache command. Fix pull flag. Remove env handle from capability flags ca524c078 Most commands move to new CLI manager 01cdd91b1 add check for rootfs 381e011f0 Add missing rootfs presence check 25313e716 Fixes #3134. Improve Plugin Command Errors for Privileged Operations 0f5b63b6a Add OS constant e54616500 Add OS exclusion 12e6d365a Set EnvHandler automatically 95dee83b8 Updated messages 1c9af4b27 CLI rework PoC 102102c0b Removed extra comment 1bbc2d3f1 Removed extra code 9ff0e6338 Updated for comments ee84a976b Use Image package to extract Squashfs from SIF in image build system 46ba81b3b Use constants to refer to plugin.so and plugin.manifest f9cf93af4 Change plugins to use fixed names inside SIF aef3f435a Implement unit tests for plugin helpers 3923348d0 Run go mod tidy 0edaa499b Update sif dependency to 1.0.3 7550d0c99 Pull key also with non-root ae2c7c272 Pull the Sylabs key before running 'go test' 16e9d4df5 Updated typo 84b118f63 fix copyright headers 19217d4d0 Rename HasRootfs to HasRootFs 6a3211b91 update formatting ce8502a03 Adds the old definition struct and parser back 77a05a291 Updated for Justin suggestion 159e6603b Prealloc slices where possible 5f5f16b19 Move partition allocation into format handlers 7af2ef67a Clean up building of CNI plugins e2b74111c Switch to using go modules 50f06fcf2 Update Go to 1.11.6 3eba2bfec Up build verbosity in CircleCI e710295b2 Consolidate image package and make SIF image code more generic 7b8c131b2 Change how max bind mounts is determined 7179f555f documented some removed flags d2cf966a6 update CHANGELOG.md to reflect an accurate release date 6cc608809 Added container check 1960741e1 Wait for dpkg lock on CircleCI (#3192) 8fe3c07b3 Removed extra comment 6245cf5f8 Exit 1 if no local key found 0a7137e0e Change action test script to default to non-interactive behavior 084345907 Check if an instance is not started from another one and display an appropriate error 7ade62048 Fix warning when adding already assigned capabilities or dropping non-existent capabilities. Fix unit tests. ffd158b0e Add an options section to the usage for the oci kill command ca4ae14d3 Formatting cleanup a990daf18 Update Bind Mounts b7000b63c Updated docs 5f6db804e Added local to singularity.go 589e8a6a7 Shortend info message with no local keys acf8af630 Removed extra block, & updated info message 48ac86953 Track problem reported by CI and that did not show on my system. This will hopefully fix it, a few details were off. 0f785c893 Use temp directory instead of regular directories and restructure the code for easier future extensions b6ce9c0c2 Remove early debug output in internal/pkg/plugin ac803d36b start sentences with a low-case word for consistency 95a489c7e return error instead of fatal call 0d181c799 Start the beginning of the sentence with a lower case word for consistency d39f9f99b fixed more error messages 557d625f5 Generate 9p Mount Tag on Bind Mount 1c08f660a Support Sandbox Image on macOS 03597a970 add info messages when converting from SIF and removing temporary converted image (#3172) 344f53587 Updated info message 66589c83f fix comments 782e2404c fixes #2986. Refactor singularity help pull options text. 0682efa27 Added --local flag 5482b8f49 removed accidentally added file 485bc6a74 Updated pull message c18c741bd fixed up changelog and bumped version in install d63cb877b Improve sypgp error handling 89211948f Improve sypgp tests 4cc525be1 Def parser fix to append multiple %files sections 0ed156bf5 Store temporary image in /tmp instead of HOME/.singularity/cache for now. Will be implemented further with cache support b8c83d9df Remove all subcommand in short use helps 8d6ce5163 fix formatting to make linter happy ad540e596 Some e2e testing for multistage builds e78451a2c Add sudo in capability add/drop example d4e45dc71 Fix strings.Split side effect and return explicit error message while listing avail capabilities e57a36b4f capability help refactor 90c36db65 Fix error message 969dde0af Help refactor. Add capability avail command and move description to this one 3d6f96204 Fix grammar 4c39b9c53 Remove options for capability list ceb877ee5 Return when using --desc e632846a0 Remove root requirement for capability list fef113a62 Fix typo while managing caps 75c4fdd4e Add caps alias for capability command 6e112673d Gofmt file 8a5d0e6a7 Add missing quote 45b130231 Mention SINGULARITY_CACHEDIR in list cache command 65f2a2400 Use a better wording to describe cleaned cache c533ff855 Fix typo c717ed146 Document blobSum cache option 14dba6bb5 Update the message shown when oci kill is run on a container without a state of created or running 256e9020f Update the message shown when oci delete is run on a container without a state of created or stopped 8ea730b6b Update the message shown when oci start is run on a container without a state of created 32139770d Fix error message for oci state f368c6fda Add sub directory notion for instance helpers 37b5b087a Improve oci create error messages 84b83f913 Update format string f06a2ab8c Check container status in oci exec command 0fdf7237a Fix pause/resume with exec command and move pause/resume control in master process 4d41968d5 Fix overlay directory not deleted caused by defer evaluation e9ea894e9 Check container state before attach 66bbf3796 Fixed extra long hash image pull f6133bf47 Unessary to change file 17db021e6 Always verify the container 410c65112 CLI integration and some edge case checking aae55d237 Add ability to copy files between stages a9844cd2b Add All() function to parser ca1e004e2 Work around MacOS build failure when downloading golangci-lint f4e1071ce changing cmd to cmd.Args in inspect_linux.go cd99102bc fix gofmt error 9115f46f7 change new test cases to reflect changes in parser package 919963a98 comment fixes 3b53e9a7d Adding ability for multiple files sections a7c81e1fd Changes to Definition struct to allow section args 8e752976b Store temporary image in /tmp instead of HOME/.singularity/cache for now. Will be implemented further with cache support b54e49f2b Remove all subcommand in short use helps 02952376e undoing changes to vendor file 2a2ab60ef Quick test fix (#3136) f1e0c1748 Quick test fix (#3136) af4afb727 Implement plugin inspect command 5a05960b9 Improve testing coverage for the build/types package. Addresses issue #2559. dfa1599c8 check for existing file before building docker based continer during pull (#3075) c7cb83b19 clarify confusing rpm build instructions 962042cbb Fixed copy-paste error 58afd0d2a Updated handlePushFlags / handlePullFlags fa45f391e Add sudo in capability add/drop example 6293a1275 Fix error message for oci state 1089129a1 Add sub directory notion for instance helpers f4a3d309a Improve oci create error messages 3ffbdba6b Update format string 69ae219f4 Check container status in oci exec command 3ca97492d Gofmt file 7368f92a0 Check container state before attach f9785db0f Gv/2938 (#2958) (#3085) 0f7bf8b88 Add a shared library error if all else fails. d57863e93 Add check for image architecture match. a7c4519a5 Move shell check to early in checkExec. 2f103f09f update remote command documentation to be clearer 891d40979 Do remote build when builder flag is set (#3028) (#3081) 3ef15510a Updated CompareKeyEntity() 625571370 Updated for other PRs d213eb5a5 Updated workflow e3760666e Make the code Lint clean, fix a test condition and add another case when test doHeader(). This addresses all comemnts from Cedric. 40946e231 Move a deferred file close up to avoid a file descriptor leak during a corner case e2b3e89f9 Update the message shown when oci start is run on a container without a state of created 506086f2b Update the message shown when oci delete is run on a container without a state of created or stopped fe3ee2c5f Update the message shown when oci kill is run on a container without a state of created or running 7541ff6d7 Updated comments b5a2e4f80 Fail if we dont have a public key 38b147dcb Fix pause/resume with exec command and move pause/resume control in master process 9edc1118c Update the message shown when oci commands are run without root privileges 1d1cb934e KeyID => Fingerprint 861a79380 fixing up comments c79fbed89 Fixe panic caused by `remote list ...` command e42425e4c Add missing quote ed9fe70ae Fix overlay directory not deleted caused by defer evaluation 781a10be6 Fix strings.Split side effect and return explicit error message while listing avail capabilities 595393c61 fixes #2927; refactor singularity commands test de6574034 Remove duplicated singularity 9bdad0a5d Refactor singularity help run-help text 1cff982e0 Removed "extra" cobra Args a73125ab4 clean up extra spacing 8f4e43178 adding first check that an app exists when we inspect, exit if not 50c88d8f4 Change message when no help is present 6b93f701b Fix instance list help typo 5a69dc44e fix error message typo (#2920) fd2bb45c8 Removed y/n (#3079) 5ca116734 Improve package test coverage (build/types/parser) f0b530bd1 Change directory from main thread with sandbox images (#3023) 8d563e7e5 Mention SINGULARITY_CACHEDIR in list cache command 0793c813f Read link from main thread (#3022) 636aae476 Add user-defined cflags to library checks (#3074) 9a8bf6bb7 Use a better wording to describe cleaned cache 4356813bb KeyId => Fingerprint e9c4d6d1e Removed unsued code 356f05a6c Combined listLibraryCache(), & listOciCache() to listTypeCache() 73b91e049 Use PACKAGE_NAME in --version output b17a1d4d5 Fix RPM spec building on SLES 11 (#2942) 3dd83442c Change "oci blob" to "blob" to prevent confusion (#3073) 349ad8940 update comment and copyright info e5b6c01ec Fix typo 13290206b Document blobSum cache option 9111da577 Refactor singularity help push text 8b8d1ae06 refactor options struct to use less memory 1523ea7d4 Remove duplicated singularity 93dc93036 inital refactor a6ae52414 Refactor singularity help run-help text 5820cdd6a Change message when no help is present 3476cf994 Fix instance list help typo 961482d1e capability help refactor 827e0e45a Fix error message f2a267821 Update cobra vendor dependency acbdb9656 Help refactor. Add capability avail command and move description to this one 28c6f58c1 Fix grammar 4547a6b60 Remove options for capability list 7f2655e71 Return when using --desc 3ce0b25d7 Remove root requirement for capability list c9d880831 Fix typo while managing caps 66d3bbed6 Add caps alias for capability command 574c12596 Updated errors, And strings, and function d3de5fd51 fixes #2927; refactor singularity commands test (#2962) ddc27491a fix error message typo (#2920) 955c60ceb Enable "gosimple" linter (#2973) 57763a199 fixed typo oncache help (#2960) 0076fcd5b add info messages when converting from SIF and removing temporary converted image (#2955) aed260cd1 Move Go version checks completely to build time (#2891) cb3f27b4c fixes #2928; show examples of subcommand help in examples section of singularity help (#2970) 6992c8f75 Documentation for Key Search with Fingerprint (#2777) 3a9f95665 fixes #3020; fix a typo when clearing an item from the cache that is not there (#3025) 887756fe9 Gv/2938 (#2958) 4de3bf06c Split CircleCI workflow into integration/unit tests ba90b804f Opps! wrong branch! 8f192f139 close resolv.conf file descriptor (#3045) b57cccce0 Updated tests dddce8e49 Change directory from main thread with sandbox images (#3023) 88286696b Read link from main thread (#3022) 4788987d6 Removed extra var d9eb98209 Fixed tests 521a374bb copyright update ccc0fd0fe Updated docs ce29ea76e Added 'key remove' command 44c600b66 check supported OCI transports instead of only looking for docker 112ce905b Do remote build when builder flag is set (#3028) 55bcae55b Adds detection for invalid URI transports a2adcba50 Use PACKAGE_NAME in --version output 3977f77f8 Use string builder. dd0ac578e Fixing CCI's issue fe59cf6d6 Use sypgp.AskQuestion() 3049f243a Remove duplicate KeysCmd code and use Aliases instead f9c628373 Updated funcs comments 6d0c9cb24 Updated listOciCache comment c917a08ea %v => %d 2be4177db Updated --sumary flag to be compatible with --type= eb0f21ab7 fixed typo on cache help command 2d1874acb Print usage information if an invalid flag is passed to singularity 0b1e7df37 Fix RPM spec building on SLES 11 (#2942) 36ac90d9f Refactor inspect command to include nicer parsing format, nicer output, and only print JSON labels when requested. 1c3834650 Change global var from 'keyServerURL' => 'keyServerURI' 35271f8df Moved askPassword to its own function 42945ddd4 Fix loading of plugins 117acf10b Saving point; WIP 097b7149c Updated helps + typos 9f005a7a9 Removed extra function f4a6473f5 check for existing file before building docker based continer during pull c7206b256 Trying to fix KeyServerURL... 1f81912db Added allow-unauthenticated 68d93ce0a Updated date 094acd39f Added newline fa424b829 Remove old internal/pkg/image/* files that didn't get removed 7134d80f6 Fix imports 6d2d9a1ee Fix Image structure comment 132510f0a More descriptive error message fcf43ba79 Remove code redundancy in section reader. Remove useless sections from SIF image. Fix comment oversight and cleanup code a bit. bb9b0f50d Add section/partition reader tests 5ed2eb0ff Add squashfs unpacker 964814b6c Add static error for comparaison 2e29e6e30 Add image section/partition reader helper b916aa959 First enhancement for image package de5a5961c Remove plugin import d5e35e728 Removed extra commented code e20d1ec4a Updated bugs! 745167c13 Cleaned up code 3a2b2816a Make image package public (#2854) 90fdb712f Updateing for list summery 14e6572b1 Added list summery c2729479b Print appropriate error when /bin/sh is missing. 354edb24f PR2890 - Sasha ea04e3daf Include mount point source and dest in returned error 6d2ecfcd3 Small spelling/grammar fix c50ee2734 Fix read-only/masked path issue. Relax error on non destination mount point and display warning instead. edc84d5ac should be ErrMountExists cfd2ad263 trying update to test 2917586ed removing empty line 0e314e0e2 fixing error message 5341b7724 attempting to update test c690d6f5c fixing bind warning 37de1d29a Warnings => printf 9a88d04e2 Cleaned up code/exiting 2d025cdb3 Reverted file; unessary to change it 0830ea0e8 Unessary to change file a87012813 url => keyServiceURI 47cbda988 Take SINGULARITY_CACHEDIR as second configurable location a430fdccb Fix typo c832f5ac0 Add tests for URI and user namespace b5e130787 Get SINGULARITY_LOCALCACHEDIR value for v2 compatibility ad1308b8a Fix URI + user namespace 86d046c84 Updated signing.go 9948cab4f Updated for key push after newpair bcace76b9 Ask to push new key 8afe5a9ca Merge pull request #2837 from cclerget/master-oci-mount 93804a31a Handle root requirements more consistently (#2816) e8429f0dd PR2815 - Cedric 6dd8cc75f Fix bug where error occurs if system endpoint config isn't present f30d27156 passphrases => passwords d3c1e2496 Update remote list to indicate if endpoint is system-wide 3a1bfb030 Add system endpoint config support to all remote subcommands 6b37184a3 Add remote.Config method SyncFrom to merge two remote Configs dc30fbd61 Introduce support for remote add/remove --global flag 842c21d59 fixing "unabled" errors 5b5f69595 Delete OCI instance files if creation failed 66b22ed7e Rename log format default -> basic 10267843f Use bundle absolute path instead of bundle argument 91f70d59e add name to oci-config json partition a986296d0 remove workdir defaulting, let runtime engine handle this 720139101 add workdir to default oci runscript and oci config json to SIF if it exists 2b1c5d50d properly initialize bundle JSONObject map 432aa4e66 Remove warning when CWD doesn't exist on host e91d13ca0 Pull request template has broken links 45cba8554 fixing docstrings for oci usage, missing "oci" in several 318cb7392 Set 0755 permissions for upper dir 68cf6fdd0 Fix variable export 53a89ab86 Add compiler option checks. Support CFLAGS/LDFLAGS/CGO_ variables aaad18d5e Prevent PostStartProcess from sending bad state for create followed by kill command f8b5db900 Add hidden buildcfg command to display compile-time parameters 5646ae764 Set PATH to default before action commands, not main command (#2885) 7f84d16c4 Make CI happy with struct size optimization 05f6d3343 Addressing marcelos comments d90fbc027 Add full paths to `sh` 4228042cf Remove the installation of golint 59b60c6fd Add golangci-lint to travis as a replacement for `go lint` c52b7a214 Switch to golangci-lint 670ca9bc3 catch os.ErrNotExist in sylabsRemote() (#2908) 9ad121e9a Updated comments 9d213582a Added some content f0dd3692e Add user-defined cflags to library checks 452119b52 Remove dead code as reported by linter a9b5b4d59 Clean up imports using goimports (#2898) 7e50d9372 Fix ineffective assignments as reported by ineffassign (#2902) a24d996e1 Add until function to list nvidia devices aa5760fa7 Fix issues reported by maligned (#2901) 02e26d12b Fix `go vet` for macos (#2884) 51cd539c9 Fix some misspelled words 73e9aa02d Run gofmt -s on a few files that can be simplified 66ad25b05 Give user 2 chances to type password cb1833307 Create parent directory while creating devices fc944fc17 Do not list ipcs in nvidia bind list (#2890) 163ae40c9 Remove duplicate commands from the circleci alpine job 20ffc50a0 deprecate sylabs tokenfile and related flag for 3.2.0 630ebf63c Retype password cc3627491 CheckLocalPubKey() return bug fix ca4a993b8 Updated tests d893b460f Using sypgp.AskQuestion() ca0986f1e Go back to sylog.Fatalf in plugin enable / disable 667c717b0 Include mount point source and dest in returned error 1d0d19229 have library uri's for action commands use remote if set e47096cc9 Change sylog.Fatalf to sylog.Errorf in plugin enable / disable 2d668d0d1 Implement all the plugin enable / disable functionality d8bb2380f Common Travis! 0ba137ae2 Add missing DisableColor when building without +sylog (#2865) 7a4ed1435 Fix error string to start with lowercase letter d76272afd Updated for reviwers c3f02fd05 missed an error message 06fed31ab added missing return, comment fix dddc9a6d6 fixing error messages and adding some comments b9b47b046 ran dep ensure -v 0a9deacde Add handling for passing our CWD (#2859) e3e120a38 clearer logic 88a8583dc fixing a typo 5cce25bf7 Remove use of test.WithoutPrivilege() d9c5d4fac Error fixups 5ff235494 Improve testing 25b39d2af Use scs-key-client for PGP search/fetch/push e6d4372ea Advance json-resp to v0.5.0 9f98ce902 adding Westley's review a662b6404 adding Westley's review ced1a01c2 Don't override existing environment variables adc882c52 added config flag to specify config location and e2e testing 49ab3360e Do not list all plugins when uninstalling 8d47ee667 Make image package public (#2854) 9e10d5eb1 Small spelling/grammar fix 467de96fa Join. It's Join. e0d6dc25b Modification requested by bauerm97 82eae39af Formatting cleanup. a7682b8f2 Kicks Travis... e96838605 Hypervisor fixes be93908c9 Updated bool return | mem comment 6b4f49c94 authok => author 21f7a6c7b Fix read-only/masked path issue. Relax error on non destination mount point and display warning instead. 0b97487c0 Updated for review 34b8f4d5b Describe plugin naming scheme in Manifest.Name comment a73634692 Dont store any key when verifying 6f5449a67 Use sylog.Fatalf instead of fmt.Printf to report errors 9fdc49555 Fix linter errors aa72101d9 should be ErrMountExists 8a1dea9de Report human-friendly errors from plugin subcommands 2178639ab Rename pluginCmd back to pluginCmd 8c99df081 Fix Uninstall documentation, second try bb38b17ae trying update to test c94bbc60e Document plugin.Uninstall 3a5106aa5 removing empty line eedda2048 go fmt c8758ee38 fixing error message aff977850 renaming public/secret file path variables, using serialize w/ no signing involved f0ae9e6ca review from mem 2bbdd9848 Take SINGULARITY_CACHEDIR as second configurable location 6973b5299 Fix typo 56655c3ad Add tests for URI and user namespace 6b3cd8969 added CLI documentation 5c34a38a2 change remote.yaml perms to 600 so other users cant read it 07eb7d24b fixed and edge case and added unit tests 295a14dec attempting to update test 774a7b8ae fixing bind warning 4d47ce177 Rename PluginCmd to pluginCmd, no need to export it 4697c8e22 Document plugin.List method a6c494f97 Implement uninstall subcommand for plugins 3452e0dac Converted sylog.Infof() outputs when using cached images to sylog.Verbosef() for the Library and Net handlers. This will reduce output during normal use of cached images 4adbf3d17 addressing bauerm97's comments 2cb73befc only check for remote for local builds that use a library source cafe50ea5 Move ListPlugins to its own file d0467526c Updated docs 6d353fa60 add yaml.v2 to gopkg.toml, fix comment to make vet happy 78878e5bd Implement plugin list 47395e504 differentiate secret/public keys on import command 50a688b98 Updated tests with controled signed/unsigned containers 4e1ecc72d Remove debug statements 0e2f3db1b Use value instead of splitted ef26418dd Get SINGULARITY_LOCALCACHEDIR value for v2 compatibility 595a5601f Fix URI + user namespace 2a2414f72 Update OCI runtime configuration based on OCI image configuration 8961afa19 updating go 8ea1c2032 removing type for var 50f85e75a removing On from setSylogColorOn 9c6da7a8a Updated var name (url => keyServerURI) && updated IsSigned comment 4a889efe0 removing empty line, simplifying function 07e6087ac Implement plugin install and uninstall functionality 9c4444392 fixing linting errors 5aa3e4d21 adding argument --nocolor to disable sylog printing of color 971a6956a Updated URL && reverted Verify() to master d78e0136a Updated error message 0b71f08e3 Fix Image structure comment fcd6b4495 Remove debug output from plugin_manifestgen 133832f90 '-' => '_' && added comment for unauthenticatedPull 7370abcb4 '-' => '_' 6ff99acd9 Added comment for unauthenticatedPull bool d2753aedd More descriptive error message e25440e83 Update copyright header in plugin files to be current e9593a22e Remove code redundancy in section reader. Remove useless sections from SIF image. Fix comment oversight and cleanup code a bit. 819ec27f3 initial scs remotes 466fdbd22 Clean up compile code and handle GOPATH corner case 086caeb3a Handle root requirements more consistently (#2816) 49957a4ce Add section/partition reader tests 794ecb152 Make NVIDIA utils public to reuse in device plugin e4d3e2f77 If we are missing files, add the URL for more information. d6b1c92c9 Update plugin compile code to use -trimpath 820d09899 Fix uncaught error in plugin compile cobra.Command func 9dc4bae99 Move manifest gen main to cmd/ f40060be4 Updated open file arguments 3d3d3d507 Moved clearsign func above key pull 8d504efb1 Updated error return messages 33e708505 Pup => Pub - typo fix 70973d2a3 Remove ALL extra code 104212aab Removed extra import 4bf5723e5 Clear file upon opening it 6e7f7184d Updated function comment b3a9a6520 Ask to store new key after verifying the container 237a8105e Updated godoc comment & return true/false ab8ffdd29 Cleaned up code + removed extra info message e1065372f Removed debugging messages + extra commended code 1bb179c51 Cleaned up extra vars & comments 41445299e Removed extra err return/check cdfb25007 Fix scratch issue (#2815) 460f3f3bc f5 - quicksave. lol 70441f314 f5 - quicksave 5025ff67a Add squashfs unpacker e26293015 Add --timeout and --force flag for oci kill command 5cd8170ab Saving point... again! 98ae193b4 A enther saving point a88d4d297 Saving point 30eab17bf Delete OCI instance files if creation failed 50db795fb Rename log format default -> basic c10abd70a Use bundle absolute path instead of bundle argument 10548a280 Add sylog doc.go 47cba38b0 Add static error for comparaison f43e4ff05 Add image section/partition reader helper 636145c97 Provide a common execStarter implementation for unsupported platforms 24506414d Remove resolved TODO 590bad94d Enable --vm option if required by other options eeab7dcb8 fixing "unabled" errors 2f0461f4e Reorganize execStarter / execVM e1d27c92e add name to oci-config json partition 181a82121 remove workdir defaulting, let runtime engine handle this 633c9a57c Set -trimpath flags in appropriate sections of mconfig c9912cbfe Tidy up startVM for all platforms b95ebec7c Tidy up darwin's startVM 42f91858f Log command used to start VM 632e77000 Move handling of VM options to a common location 09612a3af Hide --syos at the place of definition 8bac75894 In handleShub(), changed Infof() log message to Verbosef() when the requested image is in the cache. Reduces the standard logging messages. This same change will be applied later to the other handle...() cases in a future PR to make the behavior consistent 80928c7a5 add workdir to default oci runscript and oci config json to SIF if it exists 5845ad7e3 properly initialize bundle JSONObject map 4aad27916 Fix panic in execStarter c631c42a6 Remove warning when CWD doesn't exist on host 593b5f24d First enhancement for image package ff8b5dcf0 Pull request template has broken links af7137e6c fixing docstrings for oci usage, missing "oci" in several 407b55baa Updated info message 58b36b604 Ask to store pub key after showing it + updated warnings f4f2ebbad Add support for platform-specific default values ba464bba9 Pass our current user information along a991140bd Add --no-cleanup flag to pull command. And go fmt ... gotta do go fmt ... 5954992af Block off unusable flags 43d8be0b5 Pass image name to VM 01831e5c0 Modify argv[0] of xhyve execution c2160c170 go lint can leave 8c3c695f7 Make --syos hidden 6ae3156a0 Get working gofmt version aadb29e0b It really does help when you use the correct format ... 94991300a Fix Copyright date range 1d72f08f1 Add --vm-err option to attach os.Stderr to command 29815b4f2 Update error message when kernel or initramfs do not exist. d3bd510e6 Pass Binds as a Kernel argument ddd407ac5 Change isSyOS -> IsSyOS 8c24e6940 Move from internal/app/singularity -> cmd/internal/cli 15070129b Bind mount processing 6622f3aad Additional CLI options 704f08543 made more consistant with linux version b779e2804 startvm_linux.go 25ab7265f cleaned up serial console code 276439467 initial merge w/2575 dcd290b91 serialize secret and public key 31b335795 Updated comment 86676d189 Set 0755 permissions for upper dir 66c8ccbc6 go1.11 fmt a5fd16ab3 Uncap a error message ba0bd991d Fixed formatting 133c34029 formatting 2e409dcd6 only path needed as param 48b7beaab updating docs content c5e036b6e cleaning up import command e16d70a49 remove default value of full path for key on import 3d1b02a7c import done, starting with export now 0ddb5fcba obtain keylist with matching fingerprint 8344f2599 Added name to contributors list 7a1618bc6 Add logic to check the local cache for SingularityHub/Sregistry downloads 94d805907 Print userinput to stderr 0787d1f2f initial key import e7d8764e9 make the release date accurate 584eed284 Removed extra commented code + kicks Travis 1e51a65b4 Updated comment. 0dbc50f96 Added tests for --allow-unauthenticated flag 5c32b9395 Implement ground work data type for plugin management commands a30c09924 Add Config interface to external plugin API aea4a2486 Fix variable export 5c43e3c92 Add compiler option checks. Support CFLAGS/LDFLAGS/CGO_ variables 2171237c0 Skip TestAddDelNetworks tests on CentOS 6 188967674 Added key pull e23e94e71 Add CentOS travis dependencies c8a8d40f1 Updated hash bf57b0781 Bug fix for hash 034e141b1 3.7 => 3.8 5d9572d76 Updated verify message + unhappy travis/cci 4e24d0f01 trying to make cci happy... 3f76d4168 Updated comments ff8da9c8f alpine:3.7 => alpine:3.8 again... 212db56fd Complete network unit tests 569a126cc alpine:3.7 => alpine:3.8 becuse 3.8 is signed, & 3.7 is not signed 232e5a8fa Removed commented code 85f0f8a13 Updated push unsigned error de283e85b Updated IsSigned() less dups of code 5d1fab94f Add NewSetup/SetArgs tests 58fe843ef Remove some code redundancy 4a319906f Prevent PostStartProcess from sending bad state for create followed by kill command 3d63706b4 Start network unit tests ee806f751 Update year notice a8a0be3d0 Sylog dummy functions 49b0e015d Set recursive mount propagation d5deb4f22 Add a comment describing what `go_import_path` is used for in .travis.yml 42d1ba6e6 Double quote default values d224b1af2 Removed extra commented code 9ebefbf84 Added --allow-unauthenticated flag to push + pull fc1a71085 Updated errors/messages + link to userdocs to sign a container 628825e44 Add `go_import_path` to .travis.yml so user forks will build successfully for all platforms. 45c1b14ac Update example plugin to satisfy new design pattern 430fcad8f Fix unintended function rename by VSCode ebc60a2cb Update interal plugin API to use new registration pattern 138e248ec Change plugin API to use interface based registration pattern fe347eddb Add hidden buildcfg command to display compile-time parameters 33ba3954f Updated BUGS!!! lol. Updated push/pull aa8e5614f always update base environment when building de3239b50 Updated comments / extra code 91964fec2 The start of verifing when pulling 96363d9a4 Update example plugin to include --test-flag flag hook 3dd78b157 Enable usage of flag hook plugins for the action command group cebbc0427 Add support for String/Bool FlagHook plugin types 33f0f8868 Fix panic with empty passwd/group file in container image b7060372b Add optional name flag to install, remove unused variables in compile CLI 3701cd32e Update compile command to use image in library and fix use text 2e0fd8086 Move example plugin code to examples/plugins/test-plugin/ afba18521 Return an error if no user/group specified f1775f740 Fix race issue with status. Also fix instance start issue 08e532590 Print => Printf aa3572b8a Updated prompt message f3ba1111a Added user prompt if pushing unsigned container 9340fe5b7 Move sifPath helper function to cmd/internal/cli as intended 55ceed695 Update feature-plugin branch code to reflect new repository layout c25cb324f Removed warning message in verify help bc36c6ec8 Updated comment message + unsigned error ca4a84ca2 Now only check if signed when pulling from library dd599c873 Do not forward 'SINGULARITY_'-variables c11b18b86 Ian's wording change 2fe32f746 Updated copyright date, & updated if/else cf27fb6f9 Formatted stuff 7506bb8c7 Fix update state race. Explicit messages/help about root requirement. 2a6dbff14 Fix cgroup path override e3b9450dc Few enhancements in image build preparation 484776c24 Fix shared mount for %setup %files during build 9ae56ada7 Removed extra code d82f25457 Cleaned up comments 4ed2594d6 Fix oci kill command 1e83682cb Add none as mount type exception fd3fa9050 app labels envvar c6ebf2943 add a link to the EPC blog post ddaf9bec9 Remove redundant file owner checks 7617ddaaf eliminate backslash-n printout on rhel aae37fbc8 add defining _mandir for RPMPREFIX on el6, and _localstatedir for el6 and el7 4eb48953f Added some stuff `:` 5d98f00c0 add test for pulling without transport protocol 78e2b18f9 must also prepend library:// to destination file Name if no transport protocol specified 7b5df8fe8 Set OCI default args to execute runscript (requires /bin/sh in container) 09804c026 Kill container before deletion f256794e3 Pass terminal file descriptors only when terminal is false. And fix stream duplication when used with terminal is true fa1e91b7a fix use of imageName and uri.GetName when transport is empty 1866c6075 Revert GC fix as it breaks OCI engine and doing that directly with syscall doesn't work b65528755 bumping version in install.md 0d2172ee3 updating changelog in prep for 3.1.0 504953995 Update INSTALL.md 3618979fe move alternate location instructions to a more logical place c316897be isolate RPM to a single section and fix typos 94736d5c7 Explicit error messages 9ef2ef2e3 Remove seccomp filter for CI 227e2354f To check test error 05016a517 Update Create for oci mount 3a9142435 Remove stdout/stderr in test bda43a46c Add unit tests 217924c9c Add copyright notices ab4650b31 Set process arguments to execute runscript by default 4001fbd67 Cleanup ... 688c012c0 Best effort when it fail with overlay abf80e233 Best effort when it fail 17f89e94c Move CLI code to internal/app/singularity. Rename Driver to Bundle c93bd73b3 fixed and activated apptest test d9c15151c implemented apptest b2b5effcd Bug fix for cleaning type name c7ebd16b5 Updated error message 7895024c8 Updated error message (log) dea099375 Updated verbose message f1c7e8146 Updated func & U => u ff6b99ab5 Added CleanCache & U => u e828505c8 add default label for app name e72ecf773 activate app label tests 9f2f8d0fa implement app labels d4bdd21ca run pull test without privs e4decbb4e Fix /tmp and /var/tmp permissions when used with contain flag 815904179 fix test table order e4ad075e9 fix copyright header on actions.go 78f013f95 force the -f flag during pull_test ffcb86778 add docker and shub pull tests 3e99a690f Add missing shell.Escape 3468fe7ba Added default mount point: /sys/ dae516387 Added default /proc mount 91184d913 Added /dev verbose default mountpoint 379730f86 groups => group e728b1031 Updated verbose message 9b311d211 Updated default bind message + more verbose 65be84f4f Special case for PATH 2ca2447e3 activating appinstall and apphelp cases since fixes have been merged b59aebbc2 Fix bad empty initialization 0892d53ec Allow docker environment variables override ee36879aa Create OCI bundles from SIF images 81be9a0fd app helpfile doesnt need x perms ea770800f remove unnecessary definition object from build struct b7ee5f8fb better failure message 65cab6f06 app testing 08c1fa749 spaces in comments 675d0e788 have test script check for apps existence in the same manner as run 8b46db195 have test command call action test script so that env is sourced 75bc4f3d2 adding 2.6.1 and 3.0.3 8cf8883db Reverted to default, again... cfb334893 Reverted file - no changes nessary eaafe81ee Removed help bind - content tool long 5af26712e Added verbose message for default mountpoints 30ee303b0 Added default bind d45eb2dbd Avoid panic with "key pull" 2e1b333da Better os.Remove error return 9e8d7f765 Updated if(s) for listAll/cleanAll 02d25b328 Updated err return & len() fix b74b2d9f6 Switch DOI to preferred resolver cdd19c67d Bug fix for cache clean --all 4ef36fc8d gofmt! 60bcfd4d4 Updated flag type for clean a786ace98 Updated flag types f181e66b6 Capability manage/list application code is only relevant on linux systems 940facecb Catch non-existant run-help file and print message cleanly 9cc0ef542 Add pull test that builds a sif image instead of just downloading one c19ca1669 Add a basic client search/pull test e80147326 Remove tab characters from .travis.yml bb2688bc4 Move macos build and test commands from .travis.yml to .travis/macos shell scripts 2d1ff3ee2 Add osx_image xcode9.2 to travis build matrix 3de11a92a Use help sub-command to show all available commands 98d12587f Add osx_image xcode10.1 to travis build matrix c2a9f72c5 Hardcode libraryURL in actions d5847abab Monitor OS signals in Pull command for termination db9ce24a7 LibraryImageExists func is now returning if valid cache file exist or not 1eec1f15f Make ReST docs use :ref: 3a5f9f37c Fix overlay size for root user, causing / to not appears with df command 15a706f3c LibraryImageExists will return if cached file is valid or not 0f061ff59 snake_case to camelCase f1c63c2b3 Create documentation functions, fixed various wording, added directory access test ae5afdf6d Updated error return 41e506be0 Put cache.Clean() back where it came from! 901d16049 Moved some files, and added _linux.go to them 388930df1 gofmt! c776a30ed 2017 => 2018 f17a024e5 Added switch, moved cache.Clean() 3b308b4d4 Added switch case, remove dir before cache 331d9548e Bug fix for kb list a0e9446ac Validate Hash of downloaded file c47c55918 Adding Kumar Sukhani to CONTRIBUTORS.md 7823ce06c Added check to verify cached file hash e3ad1a95e Specify clean will only clean blob cache by default a02b969bf use minimal defines for RPMPREFIX 861517c11 add full list of %configure options to mconfig 2e7c0cdc8 2018-2019 3f2f42c1a Only clean blobs by default 59187b8e0 Fix copyright year e6340f033 Removed extra comment lines df294e853 -t => -T 9026a671a Nevermined, fatal if an error occured... d61823604 Dont fail if a small error occurse, just warn & keep going 2335fcfbf Updated return err/message ddf980167 gofmt some files 1e513353c join() => filepath.Join() 159f9d3e4 join() => string.Join() eddb7c34b Removed extra commented code 0611e86bd Check, & return err 2af85f34a Now return more err(s) bf715180d Updated if/else for name clean 3537d8890 replace _exec_prefix with bindir and libexecdir 68cd01a78 use $(BINDIR) instead of $(EXECPREFIX)/bin 0ed39e522 Fix unchecked error in filepath.Abs calls 474d06b6b Fix issue during container link evaluation b930c07fd Updated content 72674bc1f add RPMPREFIX 71d77e427 reduce mconfig parameter settings to minimal 40a0b2a26 Removed extra newline 4ef91ef41 Updated content & removed debug messages d5a7bf576 files section support in apps 2cbdd6b40 Added content, saving point 1135676ef Remove obsolete sections 79551ab19 convert stdout to string before printing 2a2835329 Update INSTALL.md dc558d7cd Set runscript arguments quote for evaluation ffe9cdc83 Add --apps flag to inspect command 931d5d3ec Fix Makefile 01ea69ef2 Add singularity apps command to list installed apps in container b5972b61c Removed extra Library in help 4c3bb6b60 Updated file placement for recent merge b0ba08a16 Fix typos in config_test 42b8ae7ea Update usage of pkg/util/capabilities across the board to the new API 3c108916d Update API of pkg/util/capabilities to use more standard Go interfaces 2a05aae92 Move code dealing with cobra.Command objects into cmd/interal/cli/ 0faaadf86 Move bash completion generation binary to cmd/bash_completion 1782df8da Move man page generation binary to cmd/man_pages 18725f6c0 fix error message 31ae0aff8 bug fix 339ec0fd8 Update CONTRIBUTORS f68d31c6e Convert the makeDocs script to a cobra command. Allow production of markdown and ReST docs. 0a5dc27b8 capture and display stderr with error massages in build package dc270ad18 pring string instead of bytes 19a9e0d72 Set constant size instead of defined PAGE_SIZE, should cover most usage dc2394e43 better err handling c07fa04dc updating copyright year 93104df78 use regex for mirrorurl parsing 37fe0d9f4 Fix rule to install action script folder correctly c09cea2eb Split Makefile.stub into smaller components based on function 909e3dc45 fix newBundle() call 82e600e8e Update copyright year notice 865057f74 Updated blob message 08e4383af Updated blob message e1f362e95 gofmt format fix bd6b9b63f Fix potential GC close issue 1a7b46910 Keys => key. How did I miss this... 5014a431e Updated docs for cache 4e268495a Variable fix 392c03111 type=all capable, & list total blob space 8ab710de3 Use open syscall for exec pipe package d605cc8a1 Use open syscall to hold container network namespace reference 70b2b87f6 Use open syscall for loop devices af1d7014b Use open syscall directly to avoid GC SetFinalizer issue 796dee2f6 gofmt! 3e268095a More comments, cleaned more code! 6c44e8f91 Cleanup code + formating 24424cbcc Formating fixes b46e96831 some basic definition based build tests c42efec19 fix metadata script perms 99206cf33 Apply Adam's patch for copyright notices update cf871a97b Allow pulling docker/oci images from darwin 06d135c54 Sorten the blob number c76448cc2 List total blobs default 094356e26 Image pulling from darwin 393934749 Removed extra conflict junk a3aa83ad7 Added verbose message... 9c4eaa961 Updated docs, list --all, clean/list blob(s) 670323d0a Flag bug fixes & warn if nameCache not exist 932174e67 Bug fix for clean --type 97171db2b Now can specify more the one type, eg. -t library,oci 7d86c2225 Bug fixes and --library => --type=library 168363c98 Updated docs 536a35867 Now can specify a cache name to remove 266dab3e2 Now can clean library, (--library) & oci (--oci) cache f269cd5b6 Only list library cache with -l, and oci/docker cache with -d 4b2de132c 2018 => 2019 7d076fc93 gofmt some files! 7aa0b17da update wording as requested 8e08d97ec keys => key 97f9f3819 Changed name & updated copyright fb907546b Update README.md e550f4478 Update README.md c76ae7220 clarify userns help related to sandbox images 77713e813 add note about only sandbox images with setuid disabled 277f2d7e3 generalize Debian statement 3c49f8060 Added new command 2f385dce6 Updated copyright 988a18ce2 Updated fatal message, & tmp vars de398bd85 Cleaned up code b6f7b6468 Now list oci-tmp cache 2e0696bb6 Cleaned up code 498711400 Slightly updated help menu 1fd26cc7c Updated decimal point + range thrught Kb, Mb, & Gb a778d29c6 update CentOS/RHEL build instructions for golang rpm 80a75fb23 Updated output list a2d02522e Updated name, & list cache librarys 4cade8a89 Happy lint 13f368010 Changed some things up, new command `cache`, with subcommands: `clean`, & `list` fb15f0f1c Fix tabs and end newline 206db1531 Remove linux build constraint and rename file instead 4da37bbba Remove `wget` as a build requirement for the RPM. 1dd65d1b6 updating release date on CHANGELOG.md 1ec59ad7a Removed extra debug 2f8631f4f Updated content 15d218061 Updated copyright, and content c71f06a1d Added some content for clear cache function e4acd0372 Add missing files 912ca96e7 Fix rpm build issue e7c4ff8fa Fix client image pull race 0ed997234 Add without-network/without-suid as mconfig option 7c62d6841 Rework segmentation between darwin/linux 4f6327802 Add tests for pkg/util/unix package 9cb0ba0d7 Add test to start instance from URI 34f35ab73 fixed issue warning on run/exec should be on sandbox only 5928e36d5 fix space to tab gerbage 6f1292726 initialize docker CLI vars 11a049968 Instance test cleanup. Fix killInstance by watching on parent PID instead b98a9a851 fix space to tab gerbage ebab6ec8e initialize docker CLI vars 8c7e86efa Add test comments 16f458ca5 Fix copyright year 4e49bce54 Fix copyright year 5785049bb Fix test error and copyright year 1740fdebe Add tests for pkg/util/loop package 39c09680c Return line copy to avoid lock exposure 111f0f919 Add tests for pkg/util/fs/lock package f98aaf61a Add tests for pkg/util/copy package 19ed0b52f make allow setuid = no imply using user namespaces 0c92c9b20 Run ownership checks when SUID is enabled 98ea111fe fix comment on line 322 ee0a5ff3a Fix check for conf file ownership ca1d4e642 Run ownership checks when SUID is enabled f3fe821a8 fix comment on line 322 a8364e1e9 Add example Singularity definition files for "Bootstrap: scratch". 6d22c32c0 Add support for "Bootstrap: scratch" in Singularity definition file. b92c9bf2f Fix check for conf file ownership 744c2d138 Call FreeOSMemory just after CreateContainer 4e5d986a3 Added Install from the RPM 8edae2b93 Added missing squashfs-tools package for yum 61d3fdd89 Get rid of eval for exec instead in runscript 4c03e3d50 check cache before pulling library image for pull cmd 6ad07e9e0 bump version and update CHANGELOG.md d58ebd79a Use IsOwner() func 2e4ae1080 Uid -> UID to satisfy lint 5eb9a2bba Attend Cedric's comment move the code in actions.go to internal/pkg/runtime/engines/singularity/prepare.go and execute check when starterConfig.GetIsSUID() returns true. Add additional checks on owner of capabilities and ecl.toml files 079f31fff use sylog instead of log 12e1bd169 Check ownership of config file 3a30135de use Dup3 instead of Dup2, missing on aarch64 19ffb22a0 prevent failure when architecture unrecognized fdcafd16c exclude ppc64 96c951766 License new year 0d2330a0d Add parser tests 2257a57e3 Fix variable scope in parser causing issue be439a768 change 8 spaces to tabs 04a453106 support suse go rpm de8cf0cf9 no use for go_version anymore e24fcd075 remove find warnings from gengodep ec9fd1925 fix setting of short version 5f309aa26 goversion no longer needed 23f22920c install epel-release before golang f46a8f956 use golang rpm ac0c9ecb7 use golang rpm instead of downloading current version b9022ab39 open /dev/console with minimal /dev 9ff8049a8 reduce in-loop indentation 9f687e419 if /proc/self/fd/N link is bad, try /dev/console ee41b6b88 use less functional readlink of /proc/self/fd/N instead of C ttyname e247565f2 survive unsufficient privs for devpts, and use /dev/console with minimal /dev c50da6cd1 override using old config values with make old_config= 5f80da72c Respect uppercase proxy env pass-through d837719e7 check cache before pulling library image in library converyorPacker 9e068768c Use IsOwner() func d293d7a99 pad additions to env script with new lines 7cffb3e67 Removed extra . & Compile the Singularity binary => Compiling Singularity 0cd403389 Adds "--app" flag to run-help command Allows users to see the help information for a specific app. b0c14502d Add SetEnvPath method 3985e1e12 Allow empty network to take first network by default 89e12ba3e Revert to master to avoid conflict 731fa4182 Uid -> UID to satisfy lint c930d5633 Attend Cedric's comment move the code in actions.go to internal/pkg/runtime/engines/singularity/prepare.go and execute check when starterConfig.GetIsSUID() returns true. Add additional checks on owner of capabilities and ecl.toml files ea6945def Add few network helper 9713fa424 make allow setuid = no imply using user namespaces 3ffc01035 Make network cleanup error non fatal and display error instead cee6a9474 use sylog instead of log 92b71b293 Check ownership of config file 648cac63b Fix starter indices ac7ac3824 Remove useless idMapping struct within starter 431e7f624 Make loopback network interface setup optional d1fa69cf3 Fix closed IO streams by pointing them to /dev/null b9daf73ca Spell fixes 6311add06 Small spelling fixes 243575117 Updated go download commands and content 402638a0c Fixed wget command 2d00502b4 Removed console syntax 7123ddfda Added console syntax cd8d47f2c Updated syntax, and other cool stuff 5ff95c2ee License new year 1b31e4c68 Add parser tests cebde4cf8 Fix variable scope in parser causing issue f6cb09efb Use standalone json-resp package c9185414b Add skeleton structure for plugin install command e8f6b8424 change 8 spaces to tabs f4c456d6c support suse go rpm 28349c55a no use for go_version anymore ae428b4b4 remove find warnings from gengodep 6cec6c5bf fix setting of short version 61845b050 goversion no longer needed 79290f6fe install epel-release before golang 2e0896001 use golang rpm e71766688 use golang rpm instead of downloading current version 7a478a4fa use Dup3 instead of Dup2, missing on aarch64 29b884c8f Free memory as soon as possible 8be4660c9 prevent failure when architecture unrecognized 75fdafef4 exclude ppc64 fbdf769b8 Set/restore terminal control based on stdin 86bb481e9 Checkout v3.0.0 => v3.0.2, to avoid conflict... 8cd639b0a Fix seccomp test. Output GO_TAGS to better identify error. Fix bad frags host for linux and use unix instead. 5b4237e77 Minor optimization during loop search while using shared loop devices 871797d2a Fix badly named setSlaveMount function a18298db3 Generate plugin manifest file after plugin object is built 2c2d7506e changed date to reflect actual release date 58997882d Add shared loop device support b9d33a6ce Add cgroups package test 70b7ff7a7 Fix typo c8aa5826c Make util/fs/proc public package ad39cde57 Update capabilities import path c5601534a Fix dep check 5e7548c79 Move stopSignal to killSignal ab85a8349 Add oci pause/resume commands 4ef6d0bfd Add missing stopSignal variable 82765f4cf Add oci update command for cgroups resources update 81b6e44aa Added singularity version check after install 47a9728cc Added `` around pachage 9f5cfa558 Updates for darwin/macOS build 4a9b36837 Add ipRanges network capability f397f47d8 Added {} and stuff dc4904b5a Added bash hightlights 21cc90cd5 updated content 0dcfa04bd reverted to master 1e60222c4 Introduce proof of concept code for packaging plugin objects as SIF files 864df1bfa override using old config values with make old_config= 965250e3c Run goimports on files changed def74df3a Add Normilize function that accepts slice of capabilities fe0e70bcd Only check already mounted point for CWD. Change mount order to allow user bind to override predefined binds 435ba4ff8 Make capabilities package public 79a9c6b5c Fix race while waiting child processes d114a1900 Update help for startscript arguments 01ed90019 Pass arguments to startscript b4dcb0e4d Fix instance directory permission for privacy and exit when container instance doesn't contain processes a10d735a2 Apply Sasha's suggestions and fix merge conflicts 7d0c1e2ae Store new public key by default when prompts disabled bd7398fee append to env script if it already exists 6e176f80e no-cleanup message fix d26c84359 Add plugin and plugin compile commands to singularity d935fafbe Add missing comma in CONTRIBUTORS 45c913216 Respect uppercase proxy env pass-through 52b7895e0 clean up builds unless noCleanUp is specified a342ad6e4 Add test plugin 54e4b3fed Add initial groundwork for Singularity plugin system implementation 4b40268d5 Update references to cmd/singularity/cli -> internal/app/singularity 9a5fc0988 Move cmd/singularity/cli -> internal/app/singularity c74a49383 Update CONTRIBUTAORS and CHANGELOG 89225c2d4 Add no prompt parameter for image verification 945df3082 open /dev/console with minimal /dev 78f5cbc8e reduce in-loop indentation 54faf6ac8 if /proc/self/fd/N link is bad, try /dev/console 75103899f use less functional readlink of /proc/self/fd/N instead of C ttyname 31798e4fe survive unsufficient privs for devpts, and use /dev/console with minimal /dev 95a34b327 Add Go version check. And speed test failure with new -failfast option 589b7104c Fix SELinux context mount test 6979b0063 RC mconfig update a5b8cdd71 committed to a date for 3.0.2 rc b20aec9db Fix go formatting errors 19985f663 Move content of src/docs -> docs 6fc0aae1b one more change e1649ea11 one more change 99d3b2c00 forgot one change b541f2dde forgot one change 269399fda edits to changelog based on feedback from MB 4fe680e79 change WriteDefinitionFile to non-exported, better named function a6c591034 formatting change 40233d710 bump version number in INSTALL.md 2c3e5dd8a update the changelog for 3.0.2 be3c44310 change rawDefData to just raw, and WriteDefinitionFile now uses raw 8822def6d install app files in correct directory 4b0985180 remove current plugins, apps will be part of the build system for now ab359b1d7 updated dead link to join the community 62a894225 fixed typo on installation section 5f4ee32b0 Set shell to "/bin/sh" for all scripts in "/.singularity.d/env/". b85186439 Fix SELinux context for bind mount 854165d7b Fix seccomp test without condition support 44c7edf5f Fix/simplify seccomp tests c29560cd7 Set errno value for seccomp errno action d827ad20e Honor --keep-privs with --boot flag b5ed08232 Enable `golang', of course. b395c6812 short_version and go_version added back. d1877470f Rework mlocal/ as well. d02d7b3bc Start makeit refactor and enhancement work. 358219e78 handle returned errors in busybox conveyorPacker 4b406d3f8 search for file inside squashfs when doing multiple overlays c04f62911 fix typo in line 429 b8fed4bcb fix copy/paste typos on err msg 0d38b583e Fix error typo 54422c145 Add missing cgroup symlinks bc3c7a901 small change to trigger circleci 2d7ca77c6 add e2fsprogs as a test dep 98b3fa31a dep no longer needed 10f6e5573 remove abs path to mkfs.ext3 e1e71ea62 better formatting and remove comments for dev testing 4f64f33f8 add ext3 and squashfs overlay tests f65607883 Removed sandbox error... branch testing 2c26a284c Add SetCapability for network package 4d90c3e8e Add test for overlay flag 91711cd8b Fix SELinux mount context 07b600870 Network package refactoring 0621f75c5 Remove timeout by default for OCI CLI kill operation 9a383ef5d Update SIF package vendor deps. 17cdd3745 Revert namespaces creation for build engine to include those changes in a separate PR 816921875 Fix description for assembler test functions. 9e9b672e5 Fix typo in help of "singularity build". ce93c0a7a Trying to fix new fork issue... 78779f705 Cwd fix fcc70e3b5 Added get cwd 1b0342f1c Add Gert Hulselmans to contributors. 1eca0c6bb Fix file system variable name in help output. db140ebf0 Make network package public 312c0e392 Fix comment 81750ef51 Fix typo 87eb80d99 OCI engine log fix b43c4a7e2 Update cgroups package dd20b0e60 Security enhancements for instances and image access bb04ebbac debug -> warning de771ee6c finishing touches 3c51ea57e allow for false values in bool env vars 45191e30c Silence progress bars when appropriate flag set. 27810c3d4 Print multiple environments from inspect if they exist. 6ad43cbaa envbool() error fix 189bd4522 some refactoring 49e3612b7 Fix C size type 3e3975225 Fix typo 3f4d4a087 Display warning if unix socket buffer is too small 37e9eb788 Starter cleanup. Use unix socket for CLI/starter communication. 994d2e05b Use shared memory instead of unix socket communication for stage 1. Few fixes and cleanup 9aabd0338 Nicer error message 7352efaec Update vendor cgroups package 52305d7d5 Fix sysctl to set value from container namespace 309cb3572 removed extra type import f3fe61cda Return code 1 when instance stop is not complete. ad70a3085 comment type fix f6aca1e37 use cmd flags when generating credentials 9c8788f9e add interactive prompt for docker credentials 39d9903ea Make some overlay image unbindable cc7d78cfa Add test plugin 87582cf84 Update error messages for consistency aa46d5e50 Allow multiple binds. 8724200a6 Respect writable flag for SIF images. 6ba9a9d8f Revert changes. b719a7bf9 Respect a read-only file mode. da400815c look for OSVersion with regex d52a30056 Apply formatting ed3b271fe Use cleaner variables. 0e0286388 Added error if remote sandbox fa076af76 Honor --allow-setuid when used with writable-tmpfs 15d70900f Check MAX_ID_MAPPING 8293832a0 Regression fix for singularity engine 9b0223fc0 Fix user namespace identity when entering namespace c0adfa30e Add initial groundwork for Singularity plugin system implementation 5c7ca97ce Run dep ensure to remove unused image-spec 9ad175f9e Add comments for OCI rpc methods arguments 8adaedd77 Fix cgroup package test 298f91435 Fix broken exec a4d58562e Fix mount package tests b34984db0 Add some CLI help 82d4ec9ca Fix stuck issue in starter. Fix synchronization for OCI commands. Fix for OCI runtime validation (mainly with user namespace). c9f8a8292 Update tests to expect failure for incomplete commands. ae5c96394 Return error status on invalid/incomplete command. 6134bacb0 Minor fix for hook execution 66b4f0957 Fix hook by removing annotations for OCI runtime validation 716720104 Fix synchronization, container lifecycle. Enhancements for OCI commands 663e143bb Fix/enhancement for terminal handling 833a8a1f4 Remove underscores to conform to naming scheme. 0da340d5f Add more complete instance tests of various flags. f7814a621 Keep defined no_new_privs flag when seccomp enabled 263ad4d35 make sure RawDefData is always populated 65f315691 Fixes OCI requirements 97605c6bb Fix masked/readonly path ac37ad702 Set log format by default if not specified 2d2f7e6cc Update Makefile.stub a19f8a175 Verify number of running instances. 5d1efc9b6 Add basic set of instance tests. 73a196a29 Don't break source install just to fix RPM 13ff86f36 fix types import in pull_linux.go 94b9541c7 sytypes -> types ca2330d86 store raw deffile data in definition struct 749dc130c rm dev comments 4946a216c add additional scif apps tests 6f2891179 Add --pid-file option 6636d7a8f Remove JOKER from the game adab6cc6f Fix starter exit status condition a75175ef5 Move some code into package. Cleanup. Log format support. 3b693ccff add Scif apps tests 95f8c9155 Fix shebang mangle 24721b980 Fix network namespace usage for user and remove none reference from network package 7031caa86 Support stdout/stderr log splitting when no terminal requested 4ae4e16db Add user defined bind test a7645d780 Attend requested changes by @jscook2345 70dd5aabc Use unix CreateSocket for run socket 4e2850bbf Add check for terminal resize d98c5d673 Make unix package public for CRI use 8305ae768 Don't allow master write without terminal c03ff77b8 Add basic echo server instance. a489a5678 Fix RPM spec 769afb5d7 Add option structures for start, list, and stop. cc36faed8 fix typo on line 231 856df57bf forgot to add the action command flag 9261bc4e9 rm falsePwdPath test aabae96a1 parse SINGULARITY_TMPDIR for builds b55607c04 rm merge conflict comments 54dab4745 Uncomment tests non in dev mode 82fd5b080 Port 32-action_options.sh test script to 3.0 go test suite 7468d3836 Fix closing file descriptor due to bad privileges 4c6a7550e allow username/password docker auth 794ffb789 Fix Listen/Dial unix socket path length limitation 5cb2997fe Add exec/log support. Terminal resize. Enhance attach command. d6e75b766 Add myself to contributors. a1adefb22 Add tests for --app e7fb0aec8 Update cgroup access for default devices 30756f7bf Update namespaces path after creation 370d4d5a7 Tech debt ... 3835e873b Add RPC chroot method to choose between pivot_root, move or chroot. Follow OCI commands spec. 7cf267917 Add default devices with cgroup devices 71a3f9143 Fix use after free with starter configuration ef3b16c9b Fix default devices setup 45c803379 Fix pid/mnt namespaces join. Rework/fix C starter code. 430d16038 Fix cgroup. Remove broken OCI validation. Join namespaces if requested bc6ff289c Add resource limit support 71f2a8c91 Set hostname c2491a46e Use same umask as v2 087342252 removing commented line 1f8a0a735 Cleanup StartProcess a bit 8dcc7b875 allow pulls from arbitrary shub registries 5655f878f Add user namespace support for OCI engine. Rework/cleanup C starter code 4019a5d6a Fix gid duplication f5667f079 Add cgroup mount support f1fd4e35c singularity-2.6.0 and singularity-3.0.1 d59db9920 Add sysctl support a937283ce Fix OCI mount convertion 9bcc4c136 Handle relative source mount point c3fd8c86b Fix symlink resolution for SESSIONDIR f73e5f280 Add OCI validation. Move master specific code to OCI engine PreStartProcess method 0e1ec47e8 fix path to client/net after path modification ae0ce53ba move pkg following new structure 5194967b1 Honor PATH environment variable for command lookup 9a6f6bc1e Fix additional group be7176bf5 Add current working directory support d4e003fe7 Add SetOOMScoreAdj helper method 393bdbb06 Use EvalRelative before directory creation a9bd1073b Fix default configuration parsing 6bc32692b Read configuration file when only necessary rather than in init() function 95dfca10b Fix symlink resolution impacting /proc traversal. Add missing mount option flags b834bcf14 Change to preferred capitialization for Slurm. 5bb31c2c6 Remove RPC configuration parsing and pass max loop devices as RPC method argument c52352b88 Fix build engine signal handling c69a40c2a Additional check with parent group. Fix signal handling issues 7fee80664 missed some import statements b5f399f3a adding test case for multiple scripts 1fb174748 Added WestleyK ec67f4bcd remove goroutines because parsing order matters with multiple scripts a2e51731f Added output file for pull command 109368c23 move test data directories to parser package 1389e57bf Distinguish configuration parsing error 18b2f3bdb Check process group 58228eee5 have additional sections be appended together 0ea41eac9 Set default rootfs mount propagation if empty 0f14f42ed Add more mount debug messages 1cb0f7535 Create /dev if it doesn't exist 42946d789 Make loop pkg open d7d2c7846 Make library and shub clients public 52f8999a3 Make sypgp and signing open 0b7bb40f3 Make user-agent not internal 5f7c034d6 fixed package imports to reflect changes 0c25a1b76 moved types package to /pkg 9ec6bc7d9 refactor parser to not depend on plugins 147ba6704 Fix push for SKS server d15c9c9a1 Don't resolved for each call 8aedd35ca Fix no new variable 9855fb603 Test if GetGrNam is responsible of CI failures 33444dccf Preserve root:disk owner and default permissions a91500106 Explicitily initialize engines and don't rely on Go init() 20cf56adf Fix loop logic 58b0ac6eb change Http(s) to HTTP(s) e34962638 Set user namespace starter config conditionally d7567724f Move internal/pkg/jsonresp -> pkg/jsonresp 117173a90 Add mount propagation support 75f86a80d Add starter sharedMount behaviour efee1e474 Remove useless default terminal sizing 206feecfd Fix attach code b2ca1762b Rewrite session and add device files 244958850 can set description when push image 7d0cf1214 Add sync unix socket for oci state command bda41c820 add contribution info 2a3170a7b check in cache before downloading again bcb1c0d61 fix naming of image in case of http/https pull fd3cbefe5 Add support for http/https downloadof an image c280cb8aa Fix spelling in a few places 45e5a9ec6 bootstrap tweaks bf15b57bd change flag key 2c572ca74 Starter refactoring 6adffd69a Apply security configuration for empty container 6d7b35f75 expose nohttps flag 328b8c4d1 removed dubugging println 7c9609879 make pull respect the nohttps option aswell 10ef71e14 fix issue reference to use sylabs instead of singularityware eb18ac9e8 Add attach command/support. Provide exit code and description with state annotations 9db3a51b1 Add sync-socket and empty-process support cc732ac0b Use the Getter function instead of raw access. 31c5a8ace Fix a few remaining package locations 5df723918 Fix go fmt errors due to new alphabetical order of package imports 21f867f05 add build requires for gcc and make 6703877bc support for nohttps option 4d903e9ec Test with run and terminal e1ca0c9c0 Update changelog for v3.0.1 release 17d31f6e5 copy/paste typo db6a250d0 Avoid race condition by doing all step in parent process ac2e652b6 move security tests into a diff file 4a9f88a55 libseccomp -> libseccomp-devel e8bdbdcc8 add build tag to security tests 22ae72fbc Fix comment d963640e5 Set container processs as terminal foreground process 0738a2214 Fix chroot argument 21a4651a3 add libseccomp to rmpbuild_test 148067508 Add all OCI commands. Add CRI socket communication 1c7d40a51 rm White line 577ea38ab Add test script for security options e270022de Update .gitignore b09f1dd8d make symlink in builddir instead of parent dir 2dd99b221 change path for singularity.spec d8b0411e6 add check to make sure singularity.spec exists bdcb3b085 make $RPMSPEC relative to $sourcedir 5c8a08a6d Unset PWD to force syscall getwd d95dda69d Evaluate symlink for current working directory 0e9582ae5 User capability test use builddir c69949862 Stop process addition 6c5779190 Enable PPC64 builds. 0c8b4f683 Update c include references in cmd/starter/... ac14717db Update c include references 6dd343efb Fix src/cmd references a9b2c8e1d Fix mlocal references to src/cmd and src/pkg 5a49c0970 Update mlocal/ and util.mconf to reflect new locations 8266c6b8e Update all src/runtime imports -> internal/pkg/runtime 50b9ead30 do not depend on GNU tar's --xform 9cae699ed Update all src/pkg imports -> internal/pkg dae27fe25 move singularity.spec to top level 181fa554b remove dist/rpm/buildrpm, replaced by make rpm cdcbc92fd create debuginfo subrpm 523198589 build SRC rpm in addition to binary rpm 62324a09d git config no longer needed b811abd9d use git ls-files instead of git-archive d712c2957 read Version and Release from singularity.spec instead of recalculating defaults, make VERSION file non-empty 53fd817cf clean out old %{name}-%{version} for developers 03186fc14 prevent reset error from dev files from killing make dist 2be343116 Move src/runtime code into internal/pkg/runtime/... 65e6a7b27 Move all packages from src/pkg to internal/pkg (temporarily, externally useful packages will be moved to pkg) a1c0164f6 Move starter binary main() to cmd/starter ab0459e0a Move src/cmd to cmd dcad4afbb Handle oci mount 26ab11c3b replace new lines with spaces for better formatting 21c3f84fd Handle mconf list correctly. 5ad7e956d Cleanup in makeit file and directory naming. ab2caccdb Remove older examples. 0fa2ad730 Set makeitdir consitently with other dirs. 27c4bb9f0 capture stderr output of mksquashfs for better error debugging 1a9992475 Add dist/rpm/singularity.spec to .gitignore e565a3e93 Fix filesystem UID fddd32282 Add MS_MOVE chroot method and fallback to it if pivot_root failed 2cf8079d2 Minimal OCI engine 95cf92dae mark test builds as complete with non-zero image size b624bd80e Check remotebuilder.Build errors and log 2527dcfba Do not attempt to download remote built image of size 0, more debug cea899fad Use starter_SOURCE rather 7c6073ced Add intermediate rule target to clean go cache when only C code is modified cf2fa2b0e topdir is too general: makeitdir is what it is. 527a71049 Use a "what it seems" more standard way of parsing ec4b70e52 Remove SingularityWare copyright and update Sylabs one 142fac54d Force starter compilation when starter.c is modified fda62b95d Fix user capabilities detection 08aea6931 do not require previous fsuid to be zero 32204848a Fix RPC mount propagation to honor mount slave = yes/no c2709a88b Fix copyrights mistake 5d8327118 Fix configuration generation tests 1c54d387b Rework C starter message and fix missing newline 041eda81c Remove 'allow user/root capabilities' directives 7163d9947 Really get rid of debug output... I hope dc14eca01 Remove git fetch 1dcce4445 Add in a singularity-[ver] root in BUILD that is used e58eb275a rpmbuild_test 382e72934 Try rewrite to use heredoc 8f2a0c986 Debugging fun... 8aa98bcfd Update make-dist.sh script bcdd05bc5 Escape quotes 40c276ef4 More debugging 103dc0978 More debugging info 7b0caad0d Add git in as a package fc34dd0cc Some debugging 9b6b764ad Change version naming 64ce64642 Clean up versioning 88d81c752 Comment adjustment e1eb7740b Add EvalRelative tests e84ced8d2 Add EvalRelative to fix overlay and mount point issues. Enhance multiple overlay with automatic detection for read-only layer. 5ac39c16f Test hard coding version 54ff00719 Move fetch line 9222fd725 Fetch repository df6d62fbe Add some debug help 34b371568 Update make-dist.sh f4106b776 Use SHORT_VERSION in tar.gz name 0b71c1ea2 Test RPM build fix 7a2f9e4ea Add short_version. 79771174c Modify rpm build target 1f9315dd2 Remove %setup, and move steps around 9aec85eb6 RPM Spec fix 7d59bd514 Allow local build definition spec for remote builds 4f18abf72 Packaged spec file needs to be located at root. c85b50421 Reversion the package and tree versions. cc88ae237 Report the full version in range only. c6ad986db Add singularity.spec in the dist. 618cb2b42 mconfig will not ask before replacing "builddir" 5f56ffddf Make sure the script is ran from the source tree. 7c13201c0 Plug in the make-dist script. a8a9b2cc8 Add make-dist script. c6bf22089 Changed to IsValidDefinition() and removed canGetHeader() 5ee201aa7 Fix rpm spec typo. dcb6f1283 Really this time. ef37630e8 Fix variable name collision. c87b826f2 Use right location for man pages. 80131aadb sbindir is not /usr/local/sbin (default) 963c5dc64 fix panic caused by definitions with whitespace before the first section d39d012ca add finer grained tests around definitions without headers 6145e0097 Fix typo. d08372bdf Populate all install dirs into Makefile. 94b14466e Update config vars with new GNU install paths. 4cf7d5bee Add the new GNU install locations. 38ba2db57 should return errors instead of bombing out dc8f4a984 escalate warning to fatal da49c3d37 commit before movingto VM b03594ebe Remove Println 7198129ac Don't be too pedantic b85df57cd Force nvidia binaries bind into /usr/bin 04f8e2c6f improve rpm building instructions 5309ae9f2 add libseccomp-devel requirement when not on el6 830c89a09 disable debugsource package, for Fedora 9c6c5f8e6 Support push/sign/verify on macOS 4d58b2ed5 Fix indent ee56fd049 Rewrite CNI plugins compilation 16648272c Fix PATH search order e3c9ae7a8 Update help and validate single letter options. cbeccba3e Remove all refs to paths.stub. 089464216 Add command line optional install paths. 966535757 noheader definition should end with a newline 7197cce92 adding helpful error message for definitions without bootstrap: specified 801a9e03a include % in section token to uniquely identify them 228586073 test for comments before header and headerless definitions 7ca81b2fe remove URI from uri pkg function names fc5d95e3c use make rpm for travis 80ca70c9d use same go version for rpm as set for travis b0a02e4cf change make rpm message to be like others 1d2a66b44 use same go version for rpm as set for travis a9b15d45b Close rpc connection in smaster on success only d031ccc17 Check if /.singularity.d/actions exists to support old image format e5c301179 Set flag annotation on push cmd, not pull cmd b23f1e12e Fix USER_PATH by appending default singularity PATH 8e85e0e14 Check if filesystem uid is already set f5e8ca543 Polish runtime a bit ea8c1ed92 Fix ext3 image detection 77ae63fae Update compiler tool paths checks. d1db7a7c0 Get rid of platform dependent shackles in Makeit. 8aac63555 Start work on darwin build support. cbc5cd93c use explicit $(SOURCEDIR) instead of .. aadaa345d add instructions for building rpm ff5a4593a add rpm target d5a96c800 make sed apply to everything in package version pipeline 571b8d7a4 Fix travis 2cb723e07 Add missing vendor files b097299f1 Vendor commit 0df98b2b1 Fix file system UID for RPC server 7d04be52b add test without transport with colon b715ada29 support colons in image names with no URI transport cbb6107c8 move IsValidURI to util/uri 44bb83d87 fix typo d41e309ad Remove release-stripped 9dfdc20f3 Linter consistency with run names f11d7e9d1 Don't reset capability set if already set dd0cda5d4 Don't close file when working with file pointer 8a5978cf3 Generic signal handling. Let WINCH, CONT, TSTP signals with default handler 0e5a6ec59 Fix install location for starter-suid 12c31fcaa libarchive-devel is not required d81670ac3 singularity.spec.in 637d18d52 Makefile.stub modifications 9d7c18f6d Make values from paths.stub availible in Makefile a43fa3776 EXEC_PREFIX already set in base.mk 4742bb6c3 Use macro's value on make install 3c4eb7645 rm white line 2f19d2033 Honor related RPM macros 7e59b729e RPM .spec.in changes 082a0fe3f Enable circleCI machine exec 8e211aeeb support 'name' flag for macOS 04771c7e1 add newline 4857ba2fa Add escape line avoid to scroll off of the screen e3f4ef8e5 add missing copyrights; update comment for matching godoc d0455b14e Initial hacking to run on Darwin 65c9d1d2f Add pull name flag to flagEnvFuncs map b6051dafa Add pkg-config to ubuntu deps bb2ec4ff3 Update missing dependencies on INSTALL.md cb20cb4ab link the env var $SINGULARITY_NAME for consistency c8f6edfce Add --name flag to pull cmd 36f05c8c1 use -B link option instead of stripping 9bba58bcd use $(go_OBJ) as the dependency on check instead ab60567bd also add $(BUILDDIR)/config.h as a dependency of check 8d820022e add $(libruntime) as a dependency of check for go vet bae911f0f remove commented code 106ff66cc add travis support for centos 6 and 7 rpm 0b5d865b8 Fix sylabs.io pro link in readme b53678d27 Fix sylabs.io who is using singularity links 95da8d76b Fix sylabs.io community portal links 1cbcd0af1 First set of sylabs.io link corrections 1b930cc2c Update changelog and release procedures for 3.0.0 32eab3994 Remove cd - from command f15933ddc Updates 8da60da17 Remove vendor dependency 2a14b59b8 Add dist target e34233841 Update makeit for release tarballs which include VERSION file 61c12dd32 Update release procedure to reflect better version procedure 0b651419d Add vendor check. Run vendor check with testall b7fe5a6ca Update release procedure (renamed file from RELEASE_CHECKLIST.md -> RELEASE_PROCEDURE.md) 3ced99cba Standalone vendor target. Remove vendor-done references 42352fb3f Fix comment dd6c2bc6b Really remove unused make variable patch_vendor_done 6f9640ee9 Add VERSION file for mconfig to fallback on when not in a git repository 968a58f61 Cleanup references to patches 9993187ca Update patched dependencies to grab source from sylabs forks f0afdd83e pass force option to remote builder 9c7d3b9fe Fix one more reference to latest docs 5a843a924 Add purpose note to CHANGELOG.md file 40d6b4b19 Update user and admin doc links to point to latest d9abbeaa9 Update README to me more concise and INSTALL to reflect new 3.0.0 procedures afb41d9fa changes suggested by mb 1c65251cb Update CONTRIBUTORS file to have cleaner formatting and include sylabs.io emails 6158f15da change opensuse example to a newer version that will work with newer zypper versions 9aa728c70 Restore vendor in gitignore 2eec2abe9 Update INSTALL.md bc027bf60 Remove dep/vendor from CI 314dcfac1 Add target patch-vendor. Renaming .... Remove useless gitignore lines f47b942a5 use parser package to parse definition file 44746139d Prepare vendor commit d4dce848b Remove unused capability configuration file dfa4fde73 Allow to specify all with --add/drop-caps df768abc3 Fix log chown. Enable no new privileges with --no-privs 959c7a491 Fix missing no-nv in lookup and handle env. Fix empty libs mount. b953a4c64 Fix URI in RB detached build output 290921202 Fix rootless --remote from deffile e1f60119f User default Alpine location for CP Library test 9773dcebc Fix broken Library URI in documentation 8c66cef20 Update file headers 3b4fc33f0 Use JSON response package in RB client ba7a68c22 Add JSON response package 61e8e12df removing writable tests since that option has been removed from build command 7e1ada0d7 Re-add APP env 198717a29 list actions files instead of using wildcard 2dad6e8e1 cleaner remount call bdb3a3f3b Fix app environment variable f1c21af3f mount with flags to prevent script modification from container, includes necessary remount call 55232ebcb install action scripts to host 81db4bf75 mount action scripts in runtime bed4f4599 commit action scripts within repo /etc 2549294f9 Make sure testdata/runscript.sh is mounted 5a1386cd1 Travis test bcf03619f Add selinux and seccomp dep constraint 604f4420f Add configurable buildmode 0de753050 Allow configurable build/install paths. ae1434bc1 Need to display result. 531529982 Addition of config profile, overall cleanup. 0967e5fad Add a seccomp config profile. 54172540f finished polishing up help docs b1efb0db9 Adjust the needed command line parameters. cfdcec234 Add new go profile mk files. 5b6e9d920 Be as verbose as possible when requested (-v) 19ad3b233 few more changes e182fc54e Abort when mount error occurs for filesystems 3e1fd2d1f few tweaks to main singularity help e77e2084f get std out & err before cmd.Start() e3981fd01 Fix bug introduced by PR #2155 a4e5b8419 just kidding! fixing MORE italics in README.md 4fddb0477 fixing italics in README.md 984c6a216 execOpts -> opts fdce2bf9b adding Kundan28 to CONTRIBUTORS.md 2ac476bbe comment fix 70b6e3961 use 'mv' command instead of a combination of rename and copy bdc9b92fd wait to clean environment before post section be74315c9 Add CLONE_FILES too, RPC server may need to open/manipulate file descriptors for stage 2 08b16c24d Add URI handler for instances e37297253 Add apply-cgroups for instance start 32c74baa6 Add containlibs for instance start efb7a5d9f Add missing CLI options environment variables e93d67e27 Use filepath.Join instead of concatenate. Check if resolved path is absolute. d6831c7d8 Fix comments and variables name 31f7fff7e Allow to search in user defined PATH. Optimize nvidia libraries search by opening only matched libraries. 986777481 Honor always use nv configuration directive 8756d8b2e Add CONTAINLIBS environment variable ad8d109a2 Set CLONE_FS when forking RPC server process to propagate chroot/chdir to stage 2 8ee2f7467 Revert "clean build environment" b6647df35 Update CHANGELOG and and PULL_REQUEST_TEMPLATE to be formatted similar to previous CHANGELOG file 2d22e57d1 check for err on os.Chown() fed0bb5a9 add warning if more than 50 bind mounts required for underlay 8cb325396 syntax fixes and extra error message 2bdf5ad2c add -w ldflag to cni go build 48a96f692 fix cni for rpm build 246118f2c Simplify getMksquashfsPath() logic f832dd2e1 removed commented out code 155384f2e clean build environment 350a11c9c Resolve symlinks during mount operation c0d4a66fa print name of built container upon completion 51e987a49 Rework process loop for instance stop. Change SIGTERM for SIGINT by default 1feed0128 Fix --boot regression bb3fc899d Fix log file permissions. Move info to verbose ee910616a Fix Debugf format arguments 5b3e653b9 Rewrite nvidia stuff. Fix --nv with --writable 2dc4cbd2d 2.x->3.0 Test (31-action_uris.sh) 2f12fd13e rm singularity image cmd test cases f5e515601 Remove Import/Export tests 85a4c7134 test port 31-action_uris.sh to 3.0 71f37d633 Fix if statement logic on line 149 1f9340561 Handle RPC fork error correctly 34814176a break nested conditionals and use Warningf f1b6ce090 Fix description 7c90e5e3d Update contribution guidelines and PR template af84fba06 move chown bits to a local func changeOwner() 40b7c5a56 extra error handling 812f7db78 getting a parser error a7c787ea1 Fix config parser being unable to handle string fields where any value is authorized [tag "authorized" == nil] 79e22a27a Fork RPC server to ensure capabilities/privileges are applied to all threads in stage 2 07430445a First draft at a CHANGELOG.md file documenting functional differences between 2.6.0 and 3.0.0 6babf9ed6 Update README.md 4ae2011c9 Update README.md e97b9eab4 Update README.md aa22c1be4 Fix bad arguments in Verbosef 9d3097c60 Go fmt again. Wrong Go version ... 4d8e2f066 Fix fmt errors and update files test 73f453442 Reproduce target UID/GID behaviour from v2 for root user e2d67a538 use all-root flag for squashfs when building as a user 9ba97f3ad Ignore unknown GID 24e59effe Change for exec.PipeCommand. Remove redundancy in exec pipe code. Remove hardcoded fd. af560e183 remove anything at build destination before building SIF c55b51edb fix error handling and messages 542f253aa moving file inserting to build engine so that it can take place between %setup and the chroot 3cca11172 Fix occassional panic when checking if build spec given as directory is a definition file 36666f89e Fix apps trying to parse all section names as an app bc50a79ec check USERNAME --> SUDO_USER 78daa8984 Update tests calling func imageExec() f721ad58b Update imageExec() for general test usage d6c3569eb Fix comment 98f5672bb nvidia-contiainer-cli fix 5bc415756 Line192: capability (typo) bdfffcb79 Line99: Should (typo) abaace0a6 Line300: receives (typo) f46189ef8 Line131: environment (typo) 013437a4b Line 281: "existant" (typo) Line 769: "unkown" (typo) fa7499ae3 Line79: response (typo) d64e0d662 Line 59: "stucture" (typo) Line 220: "specifed" (typo) Line 528: "concatinated" (typo) 6dbb290af Line 535: containes (typo) c2207b154 Line 46: developpers (typo) 1b1c6a712 rm unused func at instance_test.go 1d82cc2f3 Fix TestInstace() test adce38b73 Remove extra whitespace ea8351e1d Fix copy/paste typos on test names fba2a8116 Add test suit for actions cmd 7ef6e1f21 Add singularity run tests b68e58d2a Remove unexpected ) e72252cf1 Revert to the example busybox definition file for basic instance tests 3a227b23b Allow /dev bind with --contain 617265aa9 Update to sylabs/singularity c5170eb67 Add basic start/list/stop instance test 3663b602b Add initial skip test for instances 3519e2dc5 Handle case when calling user is root aa46b280f Add Library def file example 0791695a6 Update Library tests 423d54097 Add LibraryDefFile test to TestBuild() list 0e7f9b0c3 Fix resolv.conf not mounted with network namespace. Honor --dns flag 87afec7ad Use ioutil.WriteFile, remove unused commented code fd94fc96f Chown images after build with sudo 26355d0a3 Add support for direct usage of shub uri d29449e65 Add support for direct action from library URI 08029d153 Add shub cache helper and further improve test coverage 8876c4c25 Add library cache helper functions and improve tests 8600562ab Add CircleCi report Badge 4bb598c99 Makefile: fix CNI configuration file permission 936d600b7 Add missing shell option with shell action bf3ce5c0b Add comments for clarity 9754d4976 Fix description af6a301e4 Provide debug output for instance and information status 3ea6ef58c Honor max loop devices configuration directive 638fd4a6c Add commented configuration directive for CNI 23aadd3cc Fix option description for network namespace 7a6f75c30 Apply missing MS_NODEV mount flag with overlay 51f044c69 Add actions script check for old formats ea8a2b855 Fix instance with user namespace 07767abf6 remove unnecessary specific error message 6aa07587e respect custom library in library cp 4e4c35f4a Return no error when a namespace doesn't exist 550d6b3aa Remove skip now that all tests are passing a144f2966 Fix missing merge problem 3defe507d Fix some merge conflict problems 73366e88b Fix incorrect _test.go file references to old package name 5c6f6e51f Update apps to use plugin-like architecture through static linking 2dd580e0e Experimental support for loading lib using pkg plugin e1e6e504e Commit to be ammended d0f451a8e Enable first rudimentary build of SCIF apps structure in container 0d47b1aa9 Def file parser passes each sections to apps package 63b47801e Update deffile parser to return arbitrary section contents 9a8c8152d Add comments. Remove useless method 32b17f380 Add cgroups example and remove duplicated file 826ab97d5 Add cgroups support ebce1d08f move metadata insertion out of assembler, to be handled by the build system d3a72bbf3 move script insertion into assembler 09deb8b72 Update SIF dependency. fec986658 Implement signing optional ids and groups. 16d8c1b53 Fix the path to the yum definition file d05c3fb68 insert environemnt as part of the assembler 6c8f04c26 Implement an option to choose a signing key. bc763158b comment fix 15a6c132b rework of inspect to allow for json output format 70052a9c3 Update go formatting 1bef095ff Update lock file for version of SIF to use. 2e581f276 Use version 1.0.0 of SIF 9df616a60 implement optional desc and group id verification 5f4638ed8 fix error handling to not cause a panic 392e7e53a add a datadeffile partition 1bb3061aa Add go1.11-alpine compile test e6de58e50 Update CircleCI job names to be more descriptive of the base distribution e2bb6169b run go fmt 92ee946e7 fix lints on err checking cab05d164 capitalize TestCmd 9e8e11f52 enhance Example help for test cmd 9d7f222d0 Implement the test command 4b441c257 Add CircleCI workflow for testing deb compile with go1.10 & go1.11 8d17430a7 go fmt indpect.go (evidently vscode is not doing it's job) 8d1908703 dropping privs on cli tests f44b24040 comment styling cbdc2a25e set base-arch for centos-7 def example 7e7bf008e rm white line c3bc7269f Fix Yum conveyor e65f26524 fmt comment styling cc3258608 fix copy/paste typo 4598527ad update Eduardo Arango mail bc60247c7 missing LICENSE -> LICENSE.md replacements 30351bd0c merge CONTRIBUTORS.md in from 2.6.0 f1e03ff60 fixing comments 8218df6ca sanitize path at beginning of code execution 00cb47409 moving to new go fmt standard in 1.11 e7e65e03f add tests for src/pkg/util/env 6636109ea LICENSE -> LICENSE.md 56df42d3a Fix environment clobbering to close #2053 fd64d7fe4 Fix a formatting issue 06a6be350 Add a flag for skipping tests with issues 048d8a2cc Skip the tests by default, but allow a way to execute them with an environment variable c8050733f Add tests that interact with PATH and SINGULARITYENV environment variables from 25-enviornment.sh 375968b7b ensure priv at very start of libraryunit test 33b9cbd9a fix for handling labels from definitions 337c3f2ed removing white space and checking for priv at very start 2837f4c66 removing unneeded concurrency bbd54d8ec ensure priv during unit test 3700c4341 need priv for test cases f20077c10 delete extra line 2514462d2 fixed formatting error 05bbc1493 nvidia --nv centralize processing of binary files dc6faa9a8 some debug output and unit test url fix 3aec091dc fixing library test case c074e9d51 initial library conveyorPacker and tests, required change to NewBuild() function call 27c1c48e0 fix typo on line 21 65784d72f missing statement on Makefile.stub 4ed62b850 fix some lint errors 39834743c install nvliblist.conf on prefix on install 700af2671 check that conf file lines are NOT comments a9709d706 fix path in warning e4ffac2c3 misnamed var 950229922 code style changes 915ed4123 remove stderr redirect from dep, and make vendors-done a dependency of check 594531471 removing extra whitespace 5dff27525 updating ref to LICENSE.md 1a26698d9 removing white space 0522866ee special PATH env vars were not being appropriately skipped from container env d6ec242b5 adding default build flags b512b853c change singularityware to sylabs ae063f962 send go fmt message to stderr 6dde162ad improve go fmt error message cda416165 restore some accidentally removed parentheses e067a3442 use go fmt -n instead of gofmt -l 96abfb5cf show diffs for debugging e0da08c69 add message for when gofmt fails d75467d7d include all non-vendor dirs, not just src ac6d6142c quote the output from gofmt 53d6603d1 avoid vendor directory for gofmt be6c10da3 fix go fmt check a2447675b fix go fmt format 3ae878281 change singularityware to sylabs ef301fd35 Enable travis on personal github repos 0582d3e08 adding user controlled path via env vars f1d1db620 changes proposed by godlovedc to 3.0 --nv option ac15c66f7 resolving paths for new repo location 0878863e7 Add GoReport Badge a8a2be7f4 LICENSE -> LICENSE.md 345c8c128 make escalate warning to error and clean up redundant sylog.error() 16c35b037 zypper conveyorPacker 2d8b6ee05 Change OCI spec package to master branch dc083af4b Early addition of toml config parsing for cgroups. efb5ea4f1 Start working on variable section signing cc8242edc Add cgroups package cc1075a65 Add default seccomp security profile 8e4280c79 Remove debugging statement. a25359ddc Remove useless code d7aaae6a8 Fix additional groups a12594557 nvidia --nv refactor for using either nvidia-container-cli OR nvliblist.conf 71753f93d updating URL in help to point to real docs cbdabe220 adding env vars for inspect command 0d40f9a8c Re-organization of security feature support e1f7b23a4 Help with installing an auth token. 61c2293e8 nvidia --nv defer file close 5c36d66e1 nvidia --nv updated error returns f148229b4 Add seccomp security profile 172a90051 Use more descriptive error messages. 0c6388383 singularityware -> sylabs 18a0a1b27 Update CONTRIBUTING.md to reflect new documentation locations 2b559eeec Manually fix a few inconsistencies after the rename 048554934 go fmt to fix import order 5b700fc41 Replace references of singularityware with sylabs b370aa2ff inspect command using singularity engine 29c3b7268 nvidia --nv broke out nvidia-container-cli function 26432cc9a Add --security flag support (WIP) 2499eb9be nvidia --nv addressed some PR comments 65b0ebea4 Fix go formatting for go1.11 4225eb70b Fix image name format when omitted from pull d8c754909 Better singularity pull defaults and improved uri testing eff2e35ed Parse URI into transport:ref and name in src/pkg/util/uri d742487ef Use Dup3() instead of Dup2() for AARCH64 ed4aa9b46 Remove useless code 1cc74308b update to go1.11 2e5013d0c label.json beautification a98f3f573 Display warning when both writable flags are specified 42fac7f26 Add SIF overlay support 672f0e753 added self to CONTRIBUTORS..md cb4851211 nvidia --nv minor optimization 3e4da8415 Revert "fix tmp sandbox naming" 0286719f7 Merge platform detection scripts. dc5de5d77 fix tmp sandbox naming e63c901c0 Remove util/fs from includes 4d70cba46 nvidia --nv bind so.1 files d9be3005e Change LICENSE to LICENSE.md 387c3caf2 Fix initialize typo 6e6eab821 Add --writable and --writable-tmpfs flag e247cc1cf Move the check earlier in code path. 366dada04 Add the ability to test ECL from an opened SIF 20441d1e6 Format blob conversion output more cleanly, fix container name being unreadable fae9eda64 Add Clean() function to cache and include src/pkg/client/cache tests 3d72f221f Fix pkg cache not respecting SINGULARITY_CACHEDIR environment variable 7091de595 update Gopkg ca996e65a update Gopkg 755e8ad93 nvidia --nv fix nvliblist.conf path 2dcff98cf adding testing for new env var functions 73e3ad904 Fix building across devices not working properly due to os.Rename error be5422fc6 Update singularity pull to support pulling from oci-uri -> local sandbox 7cc6a5bd0 nvidia --nv cleanup 18b6ba4c1 Write function to replace uri argument with cached image path 8ccac2ce1 First working version of singularity action uri:ref 3b4ea55ad Rename src/pkg/[library/shub]/client -> src/pkg/client/[library/shub] 2c71f1480 Separate handling of cache directory resolution and oci ref caching 1d1b40b75 Move handling of cache ref from oci conveyor packer -> src/pkg/client/cache 7d590cee7 Move resolution of CacheDir to src/pkg/client/cache package 59ce475c8 Update Gopkg.lock after dep ensure c03a5b92c nvidia --nv dev_snapshot 3eccf2aa4 removed some leftover commented code f0d288620 since setting multiple env vars for same flag can cause clashes, prioritize preferred vars b87691494 adding env vars to flags of other commands 913efea52 remove export of package_version, not needed bbce86aa4 set default package_version earlier d795e501e make comment and variable more rpm-specific as yhcote requested 1daff1b42 add bash completion file a4e968fcb add setting GOROOT 10bf5616a remove unpriv packaging as requested b5ee71e24 add back required libraries 49196b2bb allow for no dash in version number 09401c6eb update for 3.0 2670e15f7 add -e and -V options, and generate singularity.spec d4a297f32 support exec_prefix, and accept package_version 84f0a78a9 support EXEC_PREFIX, and include "src" in man path 4f3553ee8 install first version of buildrpm f3bfb95df added flags for build command 02fcf5cc2 Replace path with filepath and remove separator 69077d311 Use C comment 8680496c0 Add sched_yield to fix cwd stage1 change bf40f5693 Open autofs path from configuration directive 4d6eedb7c use filepath.IsAbs and correct format 885d453eb dont need to declare err here 122edec07 nvidia --nv dev snapshot 66c9bac29 missed debug statement a89debf3e support old images without /.singularity.d/actions/exec b4f0a66be Update Gopkg.toml and Gopkg.lock after running dep ensure afcd11b81 Open and keep file descriptors for autofs bug path 638f9f22f made error fatal instead and forcebuilding into a sandbox if updating d849aabca Update dep meta. c03203af6 Improve the key encryption patches. 1a1357fc5 patch in key encryption patch a8a386656 Encrypt private key by default when creating new pair. 6b4d358ae Force smaster to kill child process since PR_SET_DEATHSIG has no effect f1bf44c64 Fix user agent test 99c853115 Replace Fatalf with command Usage() c282c755c Remove useless Port variable. Minor change in makefile to copy CNI configuration files c4d7322db Fix function description and remove useless condition 6c06c8b70 Always reset MS_RDONLY flag in loops 7cc0b5ca1 Save current working directory to restore it later. Fix bind relative source path eb979549f help cmd | man (#1981) 02f3b3f92 Remove flag "-vendor-only" dep ensure. 94dde8a96 tweaked error checking on env var functions and added a bunch of flags 37ecb5944 Switch the pulled image from ubuntu to a smaller alpine image that will help conserve bandwidth and shorten test time a60413a6c Fix the license statement 78bc4470a Add pull tests from tri-adam e06b14d43 Change error message c39327995 Fix instance stop command preventing stopping all instances 0f8eebd72 compare parsed def against an empty one to make sure we actually parsed usable information d63029a76 comment fixes b4e19f763 part of my comment fixing bender dd8944bf7 handle case where response ptr is nil e4e796bda Fix merge conflict oversight bc212a00f more comment fixes 6f0e48b4a adding another function to handle string and slice flags 5f0116890 dont create 91-environment.sh by default d1062d16d comment fixes 2220ce1e3 logic error fix d3e48c092 fix yum conveyorPacker to fit new interface 0e658f689 removing commented out code fb8f6d1ab --nv dev work dd0b44702 comment style 6afffcfbc type 87c09230c check if user is root before allowing build from definition 12c97c7a2 making bool change of cli with env var work properly 8c9483235 trying to add function to change bools according to env vars db6517a9a do the remount if privileged 69dd22051 Update test packages to use useragent 37924a548 trim white lines cdc434c28 add yum as a valid case on getcp() 171f07411 Notify parent process of error during instance spawn caac2906b Update LICENSE -> LICENSE.md 763c7c153 Remove useragent dependency on buildcfg package 1bf6d02bb Initial nvidia --nv development 72a1362e8 Remove env rule on travis 84c53515d Set SINGULARITY_CACHEDIR with the current UID 7dc31c8d8 control logic error when checking source type 183da8e77 dont need to get cp if we are just updating the container be5c881fc ability to handle section being first thing returned by scanner in the case of no header ccc950019 parse the file to check if its valid instead of checking for a header 45c7ccb2c Check for SINGULARITY_CACHEDIR c0c1ceaa0 Change the int-to-string conversion method to use the strconv package bd679e5e6 Set the HOME environment variable when setting different privileges during testing b5d6ef7ad change spaces to tab 0534c1800 set default PATH for older images 881ec46f3 Move Remote Builder Request/Response types to package types fd7c85b6b fix unprivileged sandbox mode by removing remount f93309041 Initial PoC commit for binding env var -> flag a7a6113f9 Initial attempt - caching in OCI builder bb9b7b6ee library: ensure tag list is sorted for consistency 4a37f2431 moved files and resolved conflict a61a8e34c library: doc string and comment typo fix 315c8b824 add go_tag for building bash_completion file 93520110c fixing comments 3923ff9b7 removed a comment f8ce55283 small syntax fix 6363fdf88 shouldnt be creating bundle in shub conveyorPacker 03e190a79 added definition history d695daa7d remove etc/bash_completion.d/singularity 334832840 Restore user capabilities when joining instance fe64b5808 add a missing build test for zypper bootstrapping d2e9e1669 library: address pr comments 9fe97cfb7 Add / to /dev/shm and /dev/mqueue to allow bind mount of these directories 1b78c6178 Add /dev/mqueue with minimal /dev or --contain when IPC namespace requested 207e2d400 Clean up environment handling function 208ecd76e Better formating of make file install bash_completion f5a1a1cee better formating on make file bash_completion 2756bde9b Always mount underlay final in RO 5032cb296 use @rm -f on line 86 Makefile.stub a803e5e36 Remove extra spaces on line 48 of Makefile.stub a882effb2 Use SINGULARITY_NAME on shellFileContent 82d987cd7 Restore MS_NOSUID on system mount point a02b158ec Honor --allow-setuid flag 3f10677c1 Add HasNamespace RPC method to compare host/container namespaces b87661020 fix typo ae3b9ebbb Add SetFsID RPC method to alter filesystem UID/GID. e9e8f698a Rework dev session mount. Ignore user bind control when trying to bind devices. 239ec8fdd Fix build bugs. Move network setup into create function. Remove network setup for users. 9bcc43941 turn new spaces into tabs 44d119ee0 enable UserNamespace if starter-suid is not installed 11b461fbc Force LANG env only when using --cleanenv flag 5f42ba472 rename CleanEnv to SetContainerEnv 2908072c4 Set SINGULARITY_* CONTAINER and NAME vars properly 85ebfc875 fix out of bounds error 89fb74130 getting rid of some redundant code in capability sub commands f34ccd771 added update option to build command 1b64596e6 changed help and label errors to warnings ebc45c90c Fallback to read-only mode when user don't have write permissions e472f53cc better formating on line 49 Makefile.stub 27dd615e4 mv bash_completion.go to etc/bash_completion.d de6362530 mv bash_completion.go to etc/bash_completion.d ed188d745 use go run instead of go generate 81d05f145 use instead of /etc/bash_completion.d a007b1686 remove etc/bash_completion from .gitignore 9f82c1450 better format on clean.go f20b49948 Add SINGULARITY_CONTAINER and SINGULARITY_NAME env vars 107c9d713 Pass --no-home flag value to CleanEnv() 8333311f8 Remove white line on clean.go a04c314ed Small typo on line 94 of conveyor Packer_oci.go d79b09c1f Use path instead of name when creating new file from file descriptor ccad924fb check for existence and force flag when inserting help script and labels a891f4988 Display warning rather than verbose message 692e74d76 Skip mount for all errors ef707b361 framework to build over existing container and force a bootstrap with -F a6793e6df add missing argument to sylog.Verbosef call, fixing go vet issues 295cfcbf7 add formatting argument to sylog.Fatalf calls, fixing go vet issues 5111abc43 add formatting argument to sylog.Errorf calls, fixing go vet issues 64c1d09fc change to conveyor interface d9d50e7dc fixed typo on SetPipe function comment 6785a4046 library: test console output of search a7f1a7955 library: Tidy up basic api tests e7e8aa222 library: working search cf5fb3f7c library: update library model fields dd95f1a95 This should have not been in there! 27fb49b67 This is redundant. ad08d08ec Comment accordingly 3e3a763e8 Implement whitestrict and blacklist modes. f604c3055 Add special handling for /dev in userbinds 4ac9b4653 configure the ECL config file location 9a6daa76c Install default and example ECL config file. ac86f36b4 Improve and document base ecl config file example. 7f8f41ff9 change bash_completion install path 27181c729 Display warning rather than returning an error for non existent sources c62c12635 Move CleanPath to ResolvePath 3ddf374cb jms was wrong about the CLEAN_FILES rule 10cdfc766 Completion files are sourced, not executed. 505c888b6 remove bash_completion from CLEAN_FILES rule at Makefile.stub 2f20c02b6 set LICENSE header on bash_completion.go file a153da196 Add bash_completion file to the Makefile.stub b7d56f64f Auto gen a bash_completion file 6171b0663 Add etc/bash_completion.d to .gitignore file f04843f4d Capitalize can't on CleanEnv 6d0d18ae6 Use util func CleanEnv 508ae0ac5 Create a CleanEnv func under util pkg d77f51c6c Add mkdir RPC method. Add close on exec for loop device. 448925a92 Add sylog.Writer method to return io.Writer for appropriate log level 48b4735d5 Rework and fix image package to match new behaviour. All processes works with same file descriptors. Rework loop device attach. 03e94103a run_singularity to end in new line e15a50c42 don't set run_singularity file on make CLEANFILES e28f91b37 use shub client package to download image 4bda83e00 Deal with unset dirpaths rules. 5b84f84f2 use full build by default and remove commented out code 9f64cdea4 build output format tweak 127d4f840 Move OciConfig from config.Common -> EngineConfig 1867a87ed Fix addHomeStagingDir comment b483721ed Remove starter_OBJ to fix go source files deletion 51e2c0ecd add run-singularity to the list of files to clean cb7af9db9 Fix home mount with contain 8fe52d797 install run-singularity script ab19880f1 create run-singularity script 80fbfe0ab Rename all occurrences of wrapper -> starter 873c2e5a2 attend requested changes b945be199 better handling of env transpose 709245736 use AddProcessEnv on line 285 2d87814ad avoid 2 loops 6c00da5c3 Add capability.json file installation c918b5bd5 Transpose environment with SINGULARITYENV_ prefix 58d18bf4e skip any variables prefixed with SINGULARITYENV_ f386802bc use the cached env var 81ba061da Copy and cache environment 6bd7c4af8 Finalize capabilities support d64a3792a quick fix 4c0e2ad0c func name typo 1f8c73645 better formating 172600cd5 Img -> Image on function names 2e02ad365 pull from shub support 06c894dde break PullImage for diff URI's d6e37d169 regex I hate you f17e42564 Dave T help with regex 2c7ac490e set digestRegexp regex for SHA1 f8badc4bc fix sylog fatal before a return line 52 ae347fcda fix sylog fatal before a return d878209e6 use user-agent on get manifest and image aeee7c40e Pretty print API debug 0c55fba71 Use URL.Parse f2e7b58db Force -> force f91cc6c23 remove defaultReg bool check ef44c3dfd remove defaultReg boolean and spit defaultRegistry const c193f8378 update pull_test.go c0659144f update pull.go b9eac9e9e attend requested changes to the shub api.go e4c460c2c update util tests 710ed8000 split shubParseReference into 2 funcs e2a1a76e7 remove white line b8272426e update pull test e5944b74d function paroty with library client 35e7069b9 remove fetchimage() func 9dd28adb9 small typo a955d73cc LICENCE --> LICENSE.md missing b4e550f3e test DownloadImage from shub d0c606189 create a DownloadImage from shub 14fa6c0b8 test parser func a2b662e78 create a shub parse func as a util 4a0cf7168 Create an API handler for shub 7b7c97d1f Change the whitelist module to ECL. 9a37fd596 removing println f09d10a7a ability to build with specific sections 6a318cbe2 Remove useless code in SetHostname RPC method 20942d282 Add resolv.conf and hostname mount. Add RPC SetHostname method 70a72f167 added flag passing to skip test section 85017df9d removing unused functions and comments 32e534781 more CLI beautification a60ee7f98 inserting as much as i can before test script is run 95dbd47f5 Fix boot instance by dropping capabilities. Fix instance log file ebdae9b01 Fix instance stop 7d474d534 Add list/stop instance command. Instance files management. e3be6c13a Insert white listing module in runtime. 9cac5ea1d keep a config example 51b2459ac Add a few more containers to test. 34a7da744 Add new test containers. e4bc61c5b A basic working whitelisting module. 3c3dd3fc4 Only output script info is it exists cb26aeb19 Fix build package spawning imgbuild engine with incorrect loglevel env var 7869b1a10 wlconf needs the golang toml implementation de64f828e Move the example file as a test input file. 358e12ccf Singularity container white list 18c28a9d1 Seems like we don't have any positional args here. 8f6187429 Fix the magical Cobra # of argument usage. 9ae8afbbf Improve the output of multi-signed verifications 386dcfde2 update to current sif and use descr.GetData() 92a0926ba Define descrToSign() with future argument options. 7570bb8c7 Use the work OpenPGP throughout (comments) de630239c Fix the use of cobra params. 57c521756 removing skips in build tests because of comment issue 3f9161afc removing new line from error 2d7e7589a Minor output improvement. d4e6f992f Simple fix for handling comments in lines of headers and error checking fix at CLI level 23547bf07 params to client and doc cleanup. 78c5f5357 properly expose env variables e14d67185 surface some env variables during script execution 95fecca3c Improve messaging. 49ce274ab making test definition jsons match changes to definition struct 3324f472c bug fix and removed extraneous function 0afac35b3 removed commented out code d8d0bc4df removed debug print statement 8fe29ea26 inserts definition used in build into container 818510ca0 added startscript parsing and insertion 7427d8f1e building SIF with .singularity.d for now 78982eebc Fix typo fdde6fed2 Add FetchPubkey test 497d8b9fc Set User-Agent header in build sources package 3bb9c4633 Set User-Agent header in library client package 815f9fb91 Set User-Agent header in sypgp package 7dcdd9b02 Set User-Agent header in build package 367f8076a Add user-agent package e8f1270b2 Trim 'v' from version, remove long option 0110931e5 Set PACKAGE_VERSION/PACKAGE_STRING using git tags df5588057 Start working on multi signature verification. b1304925b Better verification flow and some cleanup. 7e2b1617b Better the Sign workflow and general cleanup. adbda850c Export AskQuestion() routine 1ee234c6a Aim at last SIF commit. 9de9c80b2 Various code cleanup. cae6540b8 Use the askQuestion() func to cleanup code. 4af38e38f Look and fix key store file mode if necessary. 9d306c264 fix typo, use gid map instead of uid map 451cf38a7 change go version from 1.10.2 to 1.10.3 195790adb Clarify install instructions to be more concise 7f4941251 Update INSTALL.md to reflect proper build/installation instructions c2d69ee6d Replace getpw/gr C functions and wrap user identity around os/user functions 373b87aed Add check for already mounted point 1c8249526 Use new sylabs/sif features to simplify code. 59bcb41b7 Use sif updates. 771debbfc Fix bug where color doesn't properly reset, show euid instead of uid in debug message d4f9c1676 Add proper Sylog level handling function for all commands, fix formatting on non-debug level messages 3752eb6e2 Add mount propagation configuration 09d8fb1c1 use sylog instead of fmt 96c003a44 better arg len handle 79da98c88 Update content.go pull section c759419eb WARN about shub not supported YET 4316476f6 Use namespaces path rather than pid 8f913f30d Add PostStartProcess engine operation d25bf658a Modify pivot_root with libcontainer/LXC idea 940655b62 can now build sandbox with definitions a246b10e0 Add error check for WritePayload 8f36dc35b Add C wrapper configuration helper for Go 1aae392a2 initial placement of functions to run def builds to sandbox 56ee1ec04 comments actually formatted for godoc 3efb04ae9 comments formatted for godoc b3832896c In line comments for components of build struct f0b72df6d removed home bind and added tmp and var/tmp bind to imgbuild engine 05a180a8c added some comments to build/build.go 65be449ba Add shim process and replace Fatalf with proper error return in StartProcess 9929b9524 doh! gofmt 56b31657c cleaning up some cruft left when we were trying to include dot versions of sub commands 4db92132d Accept full URL to --builder param 91ea6a363 ignoring errors from trying to parse a file that isnt a definition e10592c9e dont need to fetch and checkout development-3.0 now that its master 1b11da03c tgt_arch needs to be wordsize here. c4ab69672 Add arm detection. bb700fa5b update urls e597b317a some tidying up c25088bac use rename to move sandbox from tmpdir to final dir d3199a845 changed the -f flag to -F in build to be consistent with pull flag 899500bc3 using bundles as tmpfs from start to end of building 8e8dcff15 removed erroneous start entry from top level 0f2c363fd PR's against master f5cc78391 minor typos 0fbc0dcdb some path fixes e17a06d86 cleaning up engine config to compile and reverting remoteBuilder API for now f266176d5 updating README.md with instructions for branch reorg 2c8606ad6 small renaming changed and a reverted function call for remote builder f1ac48025 added refinements to sources package ed87fad13 Reduce memory footprint 46c506a9d Fix SHARED/SLAVE mount propagation e33acb936 Ensure dropping of privileges is done in main thread for stage 2 777a84ba2 Add missing exit(1) line 54c62e4d9 Fix imgbuild engine to set correct mount propagation before pivot_root bc7398c67 Switch RPC server between SHARED/SLAVE mount propagation 137088b2d Improve readability of home directory mounting code 648d5bcf5 Move session layout creation to separate functions to improve readability 38cd1dfc3 Always open sandbox as RDWR and block images as RDONLY 5b2f8b268 Restore mkdir RPC methods required for overlay upper/work bb848015d Fix instance join, mount namespace must be the last namespace while joining 77c3e4859 File descriptors cleanup. Fix error missing exit. Formatting b674b9899 Fix /proc/self/auxv permission denied during tests 507c57d36 Share file descriptors between scontainer stage 1 and wrapper to avoid passing file descriptors over unix socket. Add mainthread util to run function requiring to be executed in Go main thread. 187bb4386 This should have been updated sypgp -> keys d861a368b updating yum tests to fit newer framework and removed a print statement from ConveyorPacker cdeb47622 Remove useless RPC mkdir method b38869cde First step to spawn instances 9bf0b2158 using a defer to clean up tmpfs 3976899f5 Make some more changes to use new package names 125e6c856 skipping some conveyor tests for short runs and added cleanup for debootstrap tests cdf013044 Update build package to use new package names e94f56979 fixing typo in deboostrap packer test 0ecf94014 Update types with new package name 17dc6eee2 Update sources with new package name a33d77b40 open SIF as read only 5fe329455 Update assemblers with new package name 55770c408 Add first metadata type implementation d5327d97f Adapt lookup function to new SIF lookup semantics 9835695b3 Remove debugging statement. f21ca23f2 testall rather than alltest and modify travis command line e6e009486 implement key 'search' subcommand. a7153a806 Rename sypgp->keys var and function and update docs. part 2 c2125273f rename sypgp command keys. part 1 f2a312c00 Separate test rule into check and test. 178215523 output errors when command fails. 0a7674eff reflects command name. 641c5574e Cleanup post sypgp command addition. d90bc28eb rename pgp -> sypgp (command line) 432f73277 early dev. but working versions of pgp push/pull 50cc3f6e5 commit build api for move to laptop 7bda9a945 Capability CLI alive 1c649c4fd Fix overlay issues 6a593b345 Sync sylabs/sif repo. bd18e5281 Move assemblers to ther own sub-package 1a54f5114 Move sole packer files to the sources sub-package b45b277c5 Move conveyor/packer code into sub-package 4e735130c Move build types to their own sub-package 775ecdc1f Skip failing tests for now 3d4e141a5 Remove build_docker test script 383d84000 Add Docker Registry tests b846e20cb Port whiteout of symlink test eb4c22bbc Port user permissions test 7d701c9e8 Port AUFS sanity test c9317a446 Add non-exist test 96747e5ed Add BusyBox image path test 28f1640ae Add Arch test 01d3f82cb Add CentOS test c4a4823b2 Add Ubuntu 16.04 test fa4075c81 Port 21-build_docker.sh tests 1ace72f80 Skip failing tests for now 3534bd63f Remove build test script 9ad8edafe TAR/TGZ tests 23eb59110 Port two more multi-stage tests 26d1a5841 Add two localimage tests 7ee5a0047 Port three multi-stage tests 987342261 Yum test b83260e03 Debootstrap test 66033a6dc SHub URI/DefFile tests 433ca353a Docker URI/DefFile tests b670683fc Bad path test 0acb4d0a0 Port 20-build.sh test 7c5a1c610 Add import/export test file 6a3b9166e Add deffile test file fd62edbe7 Add test temp directory create in TestMain a4b7954a4 Add image build/verify routines 58e273c13 Add image exec routine 766f70736 Add -run_disabled option to CLI test suite 4173a2e99 Update sandbox assembler to use filepath.Join 98288820e Skip failing tests for now bd29025cd Port 10-help.sh test 6b5d446f3 Remove test timeout 4e459b770 Rework capabilities management and add some tests ade052162 Remove unecessary destination check in addCwdMount 555f2ef68 Remove useless /dev remount. Remove redundant bind from underlay. Remove user namespace check on /tmp remount. da9cda9e3 Make docs a bit better. a807f829d Start adding pgp push/pull commands. f9f24e3b7 Reset FS uid to current uid after privileges esacalation a8f375596 Fix issues reported by Michael c6b163eda Premise for CLI capability management ebcd149ba Fix build engine by replacing CONTAINER_FINALDIR with SESSIONDIR b38bb6b18 Fix underlay directive default value in configuration template 0d46e8552 Fix seccomp test failure 79d4d44b2 Add fs helper tests and fix RootDir bug 5e3f6dadc Use of filepath.Join rather than string concatenation in Manager GetPath 3300711d7 Remove unused installation directories 26d31c2a8 Small output improvement 684d581ef Code around pgp list is done. 48f3fdcae minor changes c19339eea packer for SIF 93c93dd3b Fix dependency order bug 9aa15dfa6 Add config generation using config template and parser c7814e07f Fix underlay bugs ed7188c36 Create passwd/group files after overlay setup 98694d051 Fix oversights in some mount checks f0ca13e9d Fix smaster bug e9026bfa7 Fix panic when image path doesn't exist 3fcd3fdb3 Remove bugged code 24690a564 Fix remount. Add image checks. Add overlay image ro option e603450f8 Relax remount with user namespace for testing. Fix no-home. Disable overlay and userns 93556c195 Finalize home bind mount c28cc1bfe removing 'local' bootstrap option 2260364a3 file setup 3230985ff allow localimage def files 4b8432f7f Move overlay upper/work handler in container.go 61894fddb Replace os.Mkdir by fs helper one e380780fd Overlay cleanup ac17e05da Add default temporary overlay upper layer b0086804e Fix writable image support 75d029f4d Reordering mount tags 65205c640 Start working on the "gpg" command. 2648eb01b Matching sif implementation. 13a1387a7 Input descriptors are now in a slice. 08cddb225 Replace old OverlayTag by LayerTag c8c411902 Add hostfs configuration check b162b8c41 removed unneeded concurrency, added priv testing framework to yum tests, bumped up test timeout because these bootstraps take forever 8c965a129 adding parsing of updateurl to definitions and some extra output 8b152cd00 fixed parsing error 22069c31f better rpm rc parsing f9ceb82f7 Fix wrapper ambient capability loop 47d1b4b17 Bind system. Bug fixes 554b36851 Remove python tests 41a0f637b Remove commented legacy tests 829ea3d12 Port 15-selftest.sh test 9c08a04c6 Port 01-sanity.sh tests 89d9ebbc7 Lock Alpine version for environment tests 9d3e153f7 Sync 2.x tests to 2.5.2 release branch d0e7e0561 added yum conveyorPacker 35fc1dd1e Fix bug causing payload flags to be interpreted by cobra e350c3bf7 Remove sif subcommand 0aadacbe0 More binds f82539f46 Save UID/GID for use in ResetPrivilege(), and maintain real UID in EnsurePrivilege() c4030671e Mark wrapper functions as test helper functions 9a619d945 Use 'which' to locate go binary in sudo command e4da5755f Use test package in dummy tests 456d5eb47 Use test package in util/user package 4c4789ea9 Use test package in util/fs/proc package 4f9e55b1c Use test package in util/fs/mount package a4d7173d4 Use test package in util/fs/layout package 4113f68a7 Use test package in util/fs package 0f3102bcd Use test package in util/fs/files package 3eb29b848 Use test package in util/auth package bb249ef59 Use test package in library/client package 0a65ac982 Use test package in build package bb87068be Run go test with sudo in Makefile e87c349c3 Add test privilege helpers a20d54913 Need to track most recent sylabs/sif changes. 830b2ddc3 Session tmpfs size. Remount proc/sys 099f33177 Remove useless session layer method 6d0a2fe97 Complete passwd/group mount c9d77a61a Add overlay/underlay layers for session 8a9e47ffe Replace strings.Split by strings.Fields as suggested by Michael 577d0f321 Fix overlay file/directory creation bc42b3089 run before overlaylower rather 012c6b220 Remove buildcfg reference and use session directory 417ced665 Working prototype with overlay and userbinds 0b0669b9d A proto things 59af67d46 removing invalid i686 architecture option 109e80582 adding install for paccache for example def file 4927d3745 Clear umask before creation. Add DirMode/FileMode Manager's parameters 25a0c9a3b Add filesystem layout manager 2aa58d388 LICENSE -> LICENSE.md d8ee8c8d4 Add OCI mount helper 48e45b7ac Add mount system 329808006 have tests return if not root to pass CI 8ca655921 tidying up runscript creation e1bc86019 fix license comment type 7ead2343e Using WriteFile for runscript insertion aswell 349142ae2 using writefile and cleanin up bundle in test case ec77aaf3b arch conveyorpacker working with tests 7d61d8f05 use Fatalf() instead of ErrorF() 287eafec9 Add some /proc filesystem helper 0fc7b5adb use sylog on makeDocs.go c2be4fefb Fix instances bug. Rename instance_socket by master_socket for multi-purpose. Add master connection for PrepareConfig and StartProcess. Clear environment variables in Go section because Go use its own duplicate environment variables stack. 6d317f7ed Remove flawfinder test 9f730abab Move -fPIC from release_opts => common_opts 8b593fa13 Add type definition for Musl a7f1e2a8c Remove dependency on -lgpgme 9ac2a855b Add -fPIC flag to wrapper 3c6a88849 Move wrapper in CGO to avoid c-archive avoiding use with plugin c64074537 Add thread lock before applying configuration 60f5f3129 Add SELinux support and wrap security modules in Configure function 83e90ebfd Quote ENVs inside of double quotes 2c5132d8f Escape ENTRPOINT CMD ENV for OCI 500d2e0b5 Add shell escape routines 1c2205d19 Fix gitignore and add prepare.go 77a3a3cfc Add IsAllowSUID engine operation and rename CheckConfig into PrepareConfig 2ec0b0911 Fix smaster exit bug b22f7322b Update the version to use for sylabs/sif. 856356fb8 created arch converyorPacker 4f02cc85c give recipe to correct bundle 458e12bd8 hand off definition to bundle dec444465 made file paths more readable ae41f2d3a Base environment created by conveyorPacker, added tests 3d02fb23f added busybox conveyorPacker 0d1e305e3 Fix mount context bug b59d2e6d3 Tag support for singularity engine mount points 483653fa9 Rename RemountTag to FinalTag 9d013a4de Add RemountTag 8d7c17ead Add tag support to easily manage mount points 2c3bcc4d9 Yannickesque error messages 645b61dfe edited error message formating ef8fd6709 cleaning up cruft and returning original error 11980f4bb Add function to set PIPE_EXEC_FD containing config JSON c678c17c6 improved debugging output 1dc6137d1 Ensure %post script runs with full capabilities when running as root e68fa7cdb Fix loop not returned in internal options with ConvertOptions 44cf01bdf Use strings.Join and and SOCK_CLOEXEC to wrapper.c b338b756c ensuring rootfs has 0755 perms after debootstrap download 6a2ef3a24 Remove code comments referencing old SIF subcommand b6e60c833 Add behavior comment to scanDefinitionFile function 83e684403 Prevent imgbuild engine from running when not building as root user 7d57b246f Update imgbuild engine functions to match new interface signatures 0d29b3b84 Update singularity engine to utilize new mount point helper ed73dc85f Update imgbuild engine calling code to respect new oci.Config name 6efe02856 Update oci.Config to remove naming stutter 5e54a6533 Add Image Build engine to support running defintion file script sections during build process 60ea72c64 in process of adding proper scripts to bundle ae7ea82b5 Fix definitively cni plugins build ded41539d local packer now uses go native image support f68548223 changed def file header names to be correct a9eb55697 added debootstrap to build CLI a78da9455 calls to debootstrap work 70031eb4d Another attempt 1e9e92a45 added tmp dir to build in cc40d8151 beginning debootstrap conveyorPacker 134c196db Move cniplugins after cni plugins exec target f46c0734a Add cniplugins as phony target 7941b1623 phony test #2 0622eac8f phony test 906d5c1e1 Is make all work better ? 65a540d8a Travis make attempt 8515f301f Fix a few issues. ee468168f Attempt to fix travis make build 9932efcf4 Creating SIF files now uses github.com/sylabs/sif f12fa8289 Cleanup. Remove unused rules in Makefile.stub a8dc22ac1 have uri start with two leading slashes b8e99533a anchored shub regex c5b0e645e ensuring temp dirs are cleaned up during tests 9c38b9fe5 Add Sif image load code. 3071a62e9 removed print statement from definition.go 9c04fe3e3 Fix cni plugins install 88cfe4bd0 split up http addr for client struct format 6f2e91cd8 Fix make install for CNI plugins 2d0491dca removing execute perms from .go files... and a random image e5fde2683 cleaned up output and some unused structures 720b4bc38 Better naming. Fix bug with argument parsing. Integration in singularity runtime engine. 1eb93ddcd Remove unnecessary C files. baa0d70cb added custom shub uri parser along with som e tests 388f467b9 Fix some smaster bugs/cases 800125cfb Add privileges escalate/drop helper functions f7e86bbe1 Add environment helper function dd8210cf0 Remove test/debug code in smaster bd649ea2b Fix pipe handling 1f143160e Use the go package image instead of C image lib. ee7e2c1b1 This is replaced by Golang counterparts. 585c95edc Do dep and patch as real targets. c0e133b13 Run dep and patch only once. 9c77cf991 relative paths won't work here. 9f1ccc9cd Update a few build rules. 578e85b00 Separate 'patch' and 'dep' rules. 917726447 go_OBJ depends on dep. scratch previous patch. f2b7950d5 all depends on dep. 0ddefa5b5 Added simple check to make sure image was completely downloaded a34bb9ca4 Handle error in configuration parser e4a3d3be9 using an image I maintain to ensure reliability dc0b5883c surfacing http const for easier viewing 72fc2abb7 Stop there when dep ensure fails. 272b00ddd Fix shub test change lost in squash merge d6a06f6dd Fixed copyright header information 232fadd00 added comments 88e1ff8d9 Merge remote-tracking branch 'upstream/development-3.0' into localbuild_dev ab06a9171 fixed error in shub packer 8b693812a created a localPacker for both local and shub builds to leverage 782d9b5e9 Improved error handling 4c50838b1 removed arg from sandbox packer initialization 869a72a09 more debug output e6046d79f added sandbox assembler test fafb464ec added proper cli detection of def files vs local source 87a97b877 added CLI check for overwriting preexisting target de82397aa added sandbox packer 903dfb516 building from shub and locally works, cleaned up related tmp dirs after build finishes too 60ddf5edc building locally works, shub is very slow 11d4d88e3 restructured some code, build fails to make valid images though bb707ebf5 actually added support for building from ext3 ebdf582ea use dd to cut off header, then unsquash to get fs instead of mounting 43ca4d55e edited copyright header and added support for ext3 from shub 90fcc2b11 shub building using a copy into the bundle rootfs from a temporary squashfs image mount 044564fa0 can mount .simg, make bundle rootfs immutable though... changing that soon de29bb23d Merge remote-tracking branch 'upstream/development-3.0' into shub_dev 5dbef8dd9 in progress 60de18209 Merge branch '3.0-pullFurnisher' into shub_dev 438c41c6b modifying shub test 784ab24d2 Merge branch '3.0-pullFurnisher' into shub_dev b0f9e9fff still moving shub stuff around c471c4258 started changing up shub conveyorPacker ee2dd4b3c renamed provisioner to match new metaphor 9c21d2735 renamed provisioner to match new metaphor dfd64591c adding last function to extract, will need to maybe use already existing functions? 9eae73478 download of file is working! 76c7203b0 updating shub provisioner 55a366370 tweaking url to retrieve manifest 061380455 still errors, but adding WIP! 366e1d86a Fix stdout poll bug 6a122fb42 Handle non-root oci-archive case without matchine UID/GIDs 274608dbc Fix typo 6a042277a Pass custom home directory in Passwd a101edc35 Allow to tag and categorize mount points. Remove name option 856b3af40 Ruh-ro typ-o 668dddc56 Add oci source tests c99cff4b8 Fix bad call to Group in test 76161713e Run scontainer stage 2 when joining namespace 9903139d1 Add sif magic detection. Refactor ext3/squashfs initializer to expose header check functions to be reused by SIF. b2d4e4f6f Function arguments convention 80e6040fe Flag mount point by name. Add some helper functions 6ede59f55 Add file generation for passwd/group/hostname/resolv.conf 463240a9e Move register into same file. Display returned error for each initializer 8ac2f4a61 Add size field for SIF partition. Add authorization helper 71aebff59 Correctly return from MonitorContainer when there is no child process ec1526201 Move CreateContainer into smaster. Wrapper smaster/scontainer sync with eventfd. Drop privileges in smaster. Remove PreStartProcess. Rework smaster goroutines and fix bug in wrapper. Handle child signals in MonitorContainer. Map requested capabilities in scontainer stage 1 for wrapper. 8a60b2c2a move the pgp local key store: .sypgp -> .singularity/sypgp 2fa5b60f1 Use https for keyserver URI 38ce7d63f Add scheme to keyserver URI 7eb160609 a bit of cleanup an polishing. 712b9bbfa Fix fingerprint. 999b11e55 Update sif version dep. cffe61109 Add authToken to HKP keyserver requests 9bb150f05 Update SIF dep version only. 7f6d33c3b Update update versions -- master. 2787bfc53 Add Get/Remove by source and destination 298780a84 Add sizelimit option for image mount point 7e0f769db Update deps to include our SIF repo 431a5bee9 Add newlines edeaf5eb3 Be respectful with lint dictator 97ff3817c Test if there is a name conflict with GOPATH for CNI plugin compilation 8cbbad213 Fix vet error for CLI build command b9a8796ec Crappy network code in smaster for testing/debugging purpose 78bb80b80 Add network code. Bring up loopback interface when network namespace is enabled fc4a7ca29 Add network CLI options. Add configuration directive to specify another CNI plugins/configuration location a39890799 Add network configuration files. Add CNI plugins compilation/installation. fe75e43ce Add CNI dependencies e87cd30f0 Fix comments 8c7aafbbd Fix SIF FromSandbox c44287a2a Nullify image create/build/expand operations 798b6a949 sif format detection to be implemented 5c795a95e ext3 format adjustments 6ad8f29f1 Add squashfs format detection f4ad1ee2c Add ext3 format detection a140fd9a3 Simplified interface with minimal debug 9d46fb9f7 Interface for image detection 4e3ba4dae First pass at replacing C sif. aa4c0b2c8 Add support for --cleanenv command 40f41051e Version pinning to support docker-daemon source 10ca5332f Add docker-daemon build source 2e355db59 Fix existing tests 6cb6e486a Fix ref prefixes in build cmd c488ef944 Support additional build sources 9484aa36a removed commented out lines in build.go 5ad8ce18c fix help msg format f08001703 on help msg library-url to library 586d83a48 typo d67bbb8bf recover the detached after merge update 9847f98f8 fix rebase conflict isJSON 3c68568c4 browser URL should be on a newline b4036deb2 consistent flags across cloud services deae8e02c take the LibraryRef first 3c5b2429a add raw lib ref 1e036a5f0 remote library ref from 3 printf 3896ec2a6 help msg formating url 64a96b7c3 more printf formating 25936f5a8 pretty format to help msg 0ca181718 missing new line 4fd439ed0 fix help formating bdd57ea5c fix typo 9003a648c detached help msg 34c9f3618 prettify print build id 3.0 b90ef77c4 prettify print build id 2.0 7c5c3764c prettify print build id 0a864302e print build id e094446cc add cobra flag detached 0f2efa334 made the run func of the build cobra command easier to read 37ac9bf4f better commenting on assembler, using sylog where appropriate, and fixed test cases 93c1bec03 passing definitions by value f41a274c3 Check setfsuid return to avoid compilation error with old gcc 51258c254 treating remote builds as a separate build process af78a43d2 Point keysigning at a real URL 68e043df2 changed the build command run func a little 117d73c1d fix imports 554ddab03 Replace current incomplete OCI runtime configuration helper by runtime-tools from opencontainers 94c6601e5 increased testing timeout because of image downloading from docker adf214902 Fix function return. Fix file config parser bug. Remove redundant initialization of singularity.conf. Remove runtime parameter from SMaster and Scontainer. Change smaster processus name. 833ef7ab3 added back building from JSON 918bfad5d changed Get() to take a definition instead of a source string 373cc03a4 leave the cmd also 1e0bc3e8d use cobra version struct 184f76f71 LICENSE => LICENSE.md on license header 0b70b995d git version bdd39429f Patch image-tools for extraction perms as non-root b7f5280f1 new line after version 276ac7017 fix missing import d3acf425a version cmd 6b1018aa4 add version cmd 67e7efe2f Fix go lint for @tri-adam. Very useful d00ab50e3 added Docker->SIF build capability from CLI, JSON and def are not impl'd 0886f465b Fix reference to old config name 4871a14a7 Finish renaming and re-organization of configuartion data types. Compiles and runs e2b2c5dae added back files for remote building f51237f8d Fix function typo b21968fc5 Check if libseccomp version support conditional rules bab56bc7d Be more respectful with cAMELcASE 883e1f9f6 Remove commented code line ea850acc7 changed type names to match new metaphor 56b302309 changing file names for new metaphor c9f654691 some discussed changes b7c6c5ff3 fix auth token checks on build and push 664b5b61e fix auth token checks ec21dc6e5 update c2e6f91fb remote build bails if authToken is empty 47a5a975e check if token path is a dir 79c82ce3c Remove RB pull image 1aed59d22 Add Library reference/URL to ResponseData, pull from Library 11fc1fdee Use temp file for RB tests 6519aed84 Add Library reference/URL to RequestData a897ff767 First commit of Configuartion data rename, does not yet compile 5f5f65f85 Re-factor authorization header 1f8f021ae Use octal constant for perm 19c9442b5 added SIF chef and a sanity test d37398a6a changed license comment type 0edfc6118 removing old build system 317a50fe1 Added first attempt docker PullFurnisher and some sanity tests 3fe877e3e declaration of PullFurnisher, Kitchen, Chef types e0007c54e Add seccomp library for travis 48444c84b Add libseccomp-golang dependency 6ca2c03f4 Change ambiguous error messages aaff8f204 Add seccomp and apparmor support 274eca52d Expose IsLibrary{Push,Pull}Ref funcs a84c64c97 Add selinux mount label support d9eb1c8dd Fix licence header comments 0197f89aa Update dep lock file 8a9e2bc1c Remove detached flag from RB request/response d5a3462ce fix var local scope df3b867f7 Add mount helper 6c7fbb1d6 removing debugging cruft 4f99013b4 env var without tokenfile 3c04a13b5 reverse define defaultTokenFile outside init() dd213c6e3 define defaultTokenFile outside init() ef7ba1537 get defaultTokenFile on sylabsToken() 2610b8b4b PreRun sylabs token 446bb1232 != -> == line 66 at src/cmd/singularity/cli/singularity.go 99b9b2e42 typo fix ed4ca9ff7 revision for default_file < env < file_flag 39cb75a4f default_file < env < file_flag f2411d793 Slowly remove runtime words from structure/fields name b11da6ae9 authWarning handling on remote e0f14ecd4 authWarning handling on pull/push 6ff09dd06 var -> const 197ba2775 remove test for long token e5ec21003 warning vars for a better handling 98ee42beb warning handle a0d78abce fix an issue with t.Fatal message (which strangely was not raised in delve) 72023b853 commenting out some debugging lines a23f19180 adding testing for scanDefinitionFile() ac5e60c8b tokenFile -> authToken ff2514fb7 fix test token missing on api_test ffb185a6b move Test_ReadToken 0e3254b7b fix some typos 7430e3cbc Global Auth Token var 1aef75acc Integrate change from PR #1591 4e5adca7a Simplify src/runtime/engines tree b21d36eb7 Initial pass of renaming and reorganizing engines. Renamed Engine -> ContainerLauncher and Runtime{} -> Engine{} b9c7bcc74 fix merge error d465c4703 moving 2.x* back into docs/ and deleting docs/man b/c we now make our own man pages 0b06380fa change buildcfg.SBINDIR + /sif => singularity sif on src/pkg/sif/sif.go 602ff0589 add SIF long description aff2700ed [cobra] sif short description 2cc780583 VSCode removed buildcfg import from src/pkg/sif/sif.go 3127509ef fixed a copy and paste error 366a91613 moving docs to src 7c6899a91 Using Cmd.Run() instead of Cmd.CombinedOutput() ed462fea5 forgot some lines on argc -> argv commit 7de807a26 argc -> argv 1b940d4a1 uuID -> uuid 4b966bb7f remove empty examples 8c24843e5 fix unexported names c8b5da29c fix typos when exporting const from docs 23a3f9205 fix typo on line 193 da8022853 fix typo on line 149 68891a694 apply goimports to src/cmd/singularity/... 07697cb41 Move {Use,Short,Example} string values to docs/content.go 07b6290e0 Move C startup files into a separate folder e7c7697dd Move src/runtime/c/startup C files to src/runtime/startup d966b04e5 fix SingularityCmd issue 2d764b4e3 remove white line 7c84ac95b sif cmd help 2e1217607 sif create and list subcommands 33c603aad cobra long help f6ae2b248 sif example 35d91746a Errorf to Fatalf 0393908ce remove hiden:true 699c551f8 getting rid of builder_local.go aswell since its also not needed ed407ce9e Removed unused definition_parser_json.go file ad74ba712 attend requested changes b1e2c9ba8 pr ready c0ce3f608 pre PR polishing 1.1 1d118dd00 pre PR polishing 4ed9e53e8 remove args from cobra sif cli 9624559be Remove code graveyard from builder_sif.go 53a09ac4f omg AddCommand sing to sif :facepalm: cc6171d15 raw test 66efba8ac Output error message when provided with bad JSON input 4fac8ce49 handle cmd output 4c30ed574 raw implementation of sif create 6ce17bfdc some small format on args declaration 6dfd08600 sif pkg calls CLI singularity sif cmd 748fe1091 Remove traces of sbuild as it is no longer necessary 09b9986ba add build tag to go vet 92f0803d8 add build TAG to make test 477026426 set PACKAGE_BUGREPORT to support at sylabs.io 4db8ce3d7 sif header 9d0a18eb0 Update build package to respcet new methodology and update CLI to match c8a190c58 Add base environment creation testing 55e180212 Generate contents of environment.tar programatically 46d30d657 Remove lint 64981bf2c Fix lint in docs/templates.go 9cde654ca Replace LINTY with full-coverage golint 9d9cccce6 Fix pull/push merge errors 686a59676 Fix UseTemplate runtime error b0d0d0737 stop writing header info to buffer twice 4430746e2 Remove lint from sif package 093598ac8 Remove lint from libexec package d742c433e Remove lint from the OCI config package ae0501eda Remove lint from workflows config package fae2d9c81 Remove lint from workflows package 2aef5b3b0 Remove lint in CLI 77eb2a3f6 made suggested changes 6c39be53a Use lint-friendly const names d2c9ba0ac Remove lint in loop package 3f2a574d1 Remove unused file ab388ab4e Remove lint in image package def7d22e3 Remove lint in build package ec4750c01 Remove lint in buildcfg/confgen eedc9e04b Remove lint in SyPGP 8f7c3038d Add documentation for capability map cf4a26361 Remove redundant 'capabilities' package 1b235309c Smaster shares mount namespace with scontainer d5cc2e94c remove white line src/cmd/singularity/cli/signing.go dc83ffd8a remove src/pkg/buildcfg from .linty.conf 8f0a5e817 remove /src/cmd/sbuild from linty.conf 67703f158 Line comments are the norm 0fad2af6c Print error if LINTY is run and golint is not installed ad6c280cb Remove lint in runtime startup package b6d8ce1f7 Remove lint in singularity RPC package bd9024939 Remove lint in singularity workflow package 5a985c67d Remove lint in RPC package 1e7c6c9aa Remove lint in workflows package 1dfcbee8f Remove lint in RPC server package 2cac9b7eb Remove lint in RPC client package f910335ca Remove lint in config package f0236c5c3 Add LINTY d27c53c20 Exec runtime rather than fork/exec, add an exec.Pipe helper. Better signal handler in smaster. Pass user environment variables to container process. Minor runtime cleanup. b8d6a066b Library - send auth token 776243793 Use = instead of := when it isn't a new variable d1811be1a Add missing newline 6ddfae1f6 Use sylog instead of log. Fix build issues 92859ffc1 sylog.writef behavior change 61273e58e missing copyright header 037b2aa44 Add copyright header 16eed9d6b Changes suggested by Adam 593d191b0 Use sylog and ditch log. 733bdefed Rename helper_test to run test only on Linux platform ef96d7f87 fixed a few errors in the INSTALL.md 1698c573e go fmt ... ce425523c Add user/group identity mapping functions c087ff644 Filesystem function helper 4521359fe Remove leading 'D' from define on config_add_def line a10ca83c9 Fail if NO_NEW_PRIVS is not availible on build system d340af50b Library - address comments 840ae16c6 Library - review comments 1c17903ec Library - fix go vet and one test 3be906e0f Library - format code 056e03e78 Library - push test outline 57b33c7a9 Library - pull test f96daa972 Library - further api client outline tests 201d01c1a Library - further api client outline tests d4af0c394 Library - allow 201 on create 5f135b9a5 Library - add basic apiGet test outline 1b03e7d63 Library - util tests 998d7049a Library - Fix regex error in hash check 53ed7615d Library - create ouput after we get 200OK header 4e1e8f547 Fix gitignore d182fb12d Use Only Maintained MongoDB Driver 3e6b2addb Trivial change cought be gcc 8.1 956976ce4 minor cleanup 4b2e4d94c go fmt ftw fb63e470c finishing cli/docs cleanup 2b465e659 pulling docs out into a seperate file to clean up cli 67598649b tweaking template for nicer help 78de0db2f added a (tweaked) usage template back into cli 3a227ba6e Library - change default URL 7ec271087 Library - allow pull from shortened URIs 8b5b28d75 Library - refactoring 9181849eb Library - drop unneeded model funcs from client d298a1082 Library - correct model tags cdd44245d Library - add more debug statements fbb6f16df fix two new lines introduced by d3e6131 2cfe35788 missing new line on printf at line 114 547afa5ee Use -cover instead of -coverprofile cover.out 84efa14b0 Update .travis.yml to use make test target 1ffc20e87 Add make test rule e30c87ba0 Library Raw body upload with content-length 22c7c8ef9 Cleanup 'signing' into 2 packages: sypgp, signing 6be011367 Fix cgo path when building outside of makeit. f20a18e31 Fix cgo path when building outside of makeit. f86b08104 go fmt ftw 2a10b751c still resolving broken paths 8b4c96764 moving stray cmd df483d42b Library Raw body upload with content-length 9c24d4de7 fixing some bugs introduced by merge 64a6b2deb Update paths for runtime startup files 83eb77401 Update JSON test files 357b899e7 Clean out some lint 7bc998c8a Add struct tags on Definition members e11e1af26 fixing some debugging kruft b79d43ebd added more commands and ran go fmt 8711fd9a5 Re-format struct initialization ac2bf2ccc Remove lint 4e22cca75 Add race condition in Travis CI config 715d32d92 Refactor DefFile parser, fixing race condition 58f11f03e Add "go vet" to Travis config b7cf135d1 Fix issues found by "go vet" 747ea295a Removing race detection until race condition is fixed in DefFile parsing test ac7ae6ff9 Remove commented code and nil err print 8336b4272 Remove junk at the end of JSON files 8c35681fd Switch to sylog, close DefFile ce88c4648 Measure code coverage, add race detection, and set a reasonable timeout 5d6d0a224 Remove unnecessary log lines from DefFile test 04c6ed3fc Update .gitignore to include default build path, and use default builddir in Travis config b702b9652 Remove one piece of lint 674f952cd Check for context cancellation in websocket read loop 43ef996c9 Set CGO_CPPFLAGS/CGO_LDFLAGS in environment b17d8405b Widen 'go test' coverage net 01d8b75f7 Fix 'main redeclared in this block' errors 431b82e2e Fix a few issues found by 'go test' b5e27adcc Update test data 0f0c824f9 Refactor deffile tests 9ca189a1b Add more testing and other improvements dd343c400 Add context to Builder interface a6dbfff86 Re-factor remote builder and add partial testing d48abfa7f Library - some go vet fixes 487e8fc77 Library - pull shouldn't overwrite existing images by default 48ee21739 Library - Make filename optional for pull 04d394231 Switch to sylog logging d09d23560 Library - show tags being replaced, don't allow multi tags in pull ccfcf1800 Library - setting tags ba7614a99 Library - pushing with hash as primary identifier 00b449d94 Library - Drop unimplemented related Gets 58f2ea798 Library - convert other mgo/bson to globalsign fork b7eb301a1 Library - update mgo.bson dependency 307d0dc45 Library - update models and copyright headers 02a288512 Some format fix 40fdd0cec Add the main file to the list 9ce5e5030 Faster version but with larger file dependencies ... 9c1bb98ec Take Go files modification during rebuild (slow version) 47125a4f6 Clean up output a bit 4be6a84d3 Fix build URL f0738833c Improve error handling dd2ec3cf7 Add auth header to remote build requests 74b9126e5 Fix UUID/BSON ID mismatch 25098fe7a Runtime files cleanup 3d6513a91 Fix image directory mount 6ff4235b4 Update Go logging to new interface, update calls to use new interface, and fix lint 02b43fba5 Initial commit for sylog to improve go code logging output 4594c99c8 Update build instructions. 31b7e8341 Attempt to fix build dependency for Travis 526b5f978 Remove wrapper.mconf and compile wrapper from Makefile.stub. Fix go vet issues reported by Adam. File cleanup for startup code 43dfab825 Add "go fmt" to Travis config beaf73cd9 Fix issues found by "go fmt" f64fda474 Rework C runtime to call smaster/scontainer/rpc as function from a static library rather than execv because once a instance mount namespace is joined, binaries are unreachable from instance namespace. Generate GO build constants from makeit config.h 80508a38c Remove unused dependency. 1c6c54c5e Add to cleanfiles and add a dep ensure rule c1988a246 Update tests to check for proper installation of Singularity! 971929688 Fix CLI not having subcommands 7a9114c4a Simplify install rules. fdd5f331f Adjust paths to fit new tree structure. 69f9886ee Remove compile.sh de2a4347d Simplify tree structure: pass 9: "runtime" -> workflows d3a37bc24 Simplify tree structure: pass 8: cli out of internal 9ea39406a Simplify tree structure: pass 7: SIF out of image. d0a0256fe implify tree structure: pass 6: create "runtime" space. 402b834cd Simplify tree structure: pass 5: remove (more) unused files. 7db5649b8 Simplify tree structure: pass 4: update go imports. 9e23c542b Simplify tree structure: pass 3: simplify sif tool d7c17a07d Simplify tree structure: pass 2: remove unused files. e8f51f732 Simplify tree structure: pass 1: create src/ 93839bccf Fix unused fmt import 8afb8531a Fix path lookup for singularity binary and travis build procedure 30f8079e1 Fix environment.tar not found 2f569328d Update travis to use new build ssystem and ensure directories are properly installed c4534a33e Update makeit and build system to appropriately use build configs, and to allow installation bdfd1cc59 Update makeit's use of readlink to be more portable 05a847739 Update makeit frag to successfully build 3.0 Go binaries as well cd5987375 Update *.mconf for new location of mconfig a7ef49337 Move makeit to top dir 8da03b126 Update makefile to ignore rm warnings cc1776036 Add package to autogenerate go file with compile time constants from config.h. Use Makefile to drive build process 6c6607ea5 Start work on simple Makefile to drive compile and install f946ceed8 Test travis with (correctly) failing test e22ce32c1 Add gpgme package 4cd32a800 Install dep in travis 3e4885679 Add dep command 96d1e9631 Fix typo 305eb99d8 Initial commit for testing Travis CI Update 2a02aecc7 A few best practice fixes. 4d0713f26 Update dep 66e068690 Minor changes. c75d45378 Start interacting with key management server (sykeys) 40a843aeb Add code to selectKey() and decryptKey() 9239c5d0b Add a routine to output key rings. 862bb1969 improve the key generation path. 622ae89f8 Signature descriptor now includes signer fingerprint c7a5d22ef more incrimental progress toward a complete doc system for cli f45fdcac1 and some more... 02889bfd5 still adding meat for man pages e67028c7d clear up a few bugs 7f382e94a adding the actual text 019412e56 clean up makeDocs and add some smarts to compile.sh 8c21509e8 mlocal check to use aarch64 also 933ef4184 Check for aarch64 only, not arm and 64 bit void* a3aff688a Fix compilation and execution on Pi arm64/aarch64 34ba9f844 Make Definition internals private, so that reflection libraries can access all members ea033a44b fixed building e0b76845e Correct ENTRYPOINT + CMD behaviour 7349fc432 Fix golint issues 9110580fd provisioner_docker - restrict untar to inside dst e3ca8ce87 added check for directory existence and writability 1e88f7e54 exported cmds for use in makeDocs 7855c35c1 moved makeDoc to a function for non-repeating 132f0968d Fix some remaining MESSAGELEVEL regressions 4fbe93cb3 Fix library related package deps 134bdb380 Remove close on uninitialized variable in core runtime wrapper d083f984d Use SINGULARITY_MESSAGELEVEL instead of MESSAGELEVEL 4f490d5e7 Fix error regarding hardcoded mount location c17248281 Catch upstream Reverse Proxy errors and display nicely 50c808615 Upload speed on push too 351c52922 Speed and timeleft on library push/pull 701d4ab26 Fix errant import of glog ae0b51650 goimports b92150f1e Correct library ref parsing and server error output bb5f732c5 Fix bug stripping 'ar' from 'arhughes' entity name 19e6ff05d Default library port 5150 646b2c324 gofmt it 6a901c408 Minimal library push and pull cd0825546 Base for library push/pull 549b7a1b0 Add initial sbuild binary to separate build component from CLI to allow clean output separation dbeac00e6 First commit to restoring output to builder 85fa38c3e Fix typo 374569e7a Remove line not meant to be uploaded a8cbac4fd clean interface file 411d5a1df legacyBuilder also returns err cb95c350c b.build() returns err f0553f013 Start repaying tons of technical debt cleaning everything up e035c1bde Added support for generating and displaying man pages e026e50ce First commit merging Cedric's runtime patch into makeit build system 59499a644 Fix returning error correctly. 59c97fadc Add sign and verify commands, rough cut. 66d492241 adding generate_docs to setup.sh 9952f612f Add cli function stubs for sign/verify commands 97db38baa Add sifcore wrapper file for SIF calls. 54b482196 update INSTALL.md to include instructions for building go code 991da24bb WIP trying to come up with a framework for automagically generating man pages d759e77d1 Generate PGP Key Pairs if needed. 3d318daac Modify some parts in core/lib. Exec/Shell/Run actions call wrapper support namespaces and debug/verbose flags. Runtime mount for ext3/squashfs/sif/directory images. 0d623fcf7 Remove runtime/cli binary from previous commit. Add missing config.go. Replace socketpair by pipes. Add runtime/setup.sh into compile.sh. 03b5ee07e gofmt ... 075663685 Runtime engine. Start OCI configuration API. Configuration file parser. 08e4ca988 This removes the dep on gpgme f417b3910 Add better checks. 7ad2fe66d Not needed anymore, see "compile.sh" 7077ad800 More code to run singularity ! 6b0e906fa Update dependency management from trash -> dep 6dcca949c Update Gopkg.lock and Gopkg.toml from clean GOPATH 67a86078b Fix import path 3cfbb9384 Not needed anymore, see "compile.sh" b15f824d1 Put end binary inside core/buildtree for now 6b8faf060 Connecting the signing code into end-to-end case. 086392f43 Add a rough stub for the signing code. b23928486 "nproc" may not always be present. 31ced1c27 Capture ALL logging! 9ca3c74c8 Update builder to stream output better fa6447fa1 Redirect all output for sifbuilder to b.Out 70d21d04b Update to build SIF from docker as URI in CLI or as definition file 72630ae25 First working commit for building a SIF image directly and natively in 3.0 5673ff11d Initial commit of working download from docker URIs 58314900b Add compile.sh and build a proto singularity 276dbbd70 A bit more work on cgo 8fb59f273 Fix parsing empty definition files causing infinite loops 6a0a92e57 Update deffile parsing and testing to be more comprehensive 7255c80cb Add correctly marshalled json files for output comparison 39da28e82 Fix infinitely looping error e15c89833 Fix definition file parsing when only header is present 1ac21c457 Make sure file names aren't changed 33eccf5a7 Update example with current configs. 7ec39ae4a Build problems with Centos 6 and strict warnings 610c7030c Add an option to include an external uuid to SIF 8e87a3ae9 Initial client side remote builder commit d992b89d3 Hard coded definition file parser 2b59db465 Singularity doesn't require a c++ compiler. 6ca4b8cef Move basic system checks to basechecks.chk. 1ba633ac1 Can't use -DDEBUG, DEBUG already used for messages. eefd83cd9 Complete shuffle from upstream project reorg. 5b236510a Update from upstream reorg 8ce3da1ce This is not C! 5616ec33c we need extralibs and not ldflags there... 8de194a0a Add more tests ab8ddad0f Build a combined libsycore.a for easy linking in Go. 441128c82 Start adding specific checks. 9945f35c9 Make sure warning flags works on older compilers. ad92e2c40 Singularity doesn't require a c++ compiler. b3800864c Move basic system checks to basechecks.chk. 654d2c9c6 Can't use -DDEBUG, DEBUG already used for messages. 0cf596acf Complete shuffle from upstream project reorg. 921a31dd3 Update from upstream reorg 1bfb38e19 This is not C! 4c4fa6960 we need extralibs and not ldflags there... 0ccee99c5 Add more tests 3955473b3 Start remote image URI parsing code 65abdbda6 Build a combined libsycore.a for easy linking in Go. 22545ec45 Start adding specific checks. 2fbc92785 Start adding specific checks. f36f71dac Add more command stubs to CLI, add start of pkg capability 7c2bebc11 nameing conventions cc203e65b Update license. bfa25842c Add the 'mount' bin to the makeit build system. 29a2b334d Add libruntime to build system 716cc0509 Add libimage and libutil to the build. 712b4fbb5 sif program depends on libutil deaebe1a1 Move util to lib/util da87c2c5b Few fixes. Include sif.mconf for sif program 897f7a3f0 Build signing and sif libs with makeit. a04dc2ba9 Initial import. 07b906ea9 Move forward on CLI autogeneration formatting and templating. db82d0779 Remove unnecessary code fe20c5ed2 Update output to be better formatted 497959b28 Return error on bad definition file 18042356a Rework templates into something functional 36a08488c Fix deffile error finding 532b02a72 Fix merge conflict mistake dc14cefc6 Fix def parsing to run from io.Reader without copying af437ee57 First work on CLI help template 971e05e1d Update CONTRIBUTORS 5e8910357 Accept io.Reader rather than os.File in ParseDefinitionFile 116769b3a Remove comments on debugging via fmt prints 758232efb Remove unnecessary var 55b46d9a3 Fix copyright formatting on some files 881ee017c use cobra pointers 6edc4ea87 Fix header parsing 648b69469 Remove extra debug output 6278130c1 Quick and dirty definition file writer just for demonstration purpose d374621d6 Declutter debug output 6e7c433db Update name of parser to ParseDefinitionFile for verbosity and clarity 0a62601ff Complete Header parsing, parse entire definition file into Definition struct 0f45e4040 Initial commit of new deffile parsing methodology df46bc78d Add files section to Definition struct 90e228eac Licence update. Remove verbose compilation 60abe471f Back to shared library for RPC server. 918807590 Fix package name typo and copyright header formatting 5b16639e9 Remove redudant build from struct names and better clarify file intentions 5c57084f1 removed comments from libexec cmds 618b5e05e Fix help messages 8c512c0d6 Make fixes and updates to enable go build cmd/cli/cli.go to succeed 911df0fa7 Move build_definition input types to their own files 995b6b958 fix TYPO on cmd/cli/cli.go 15dd9c29c Separate builder interface from implementation in builder_local.go e3960fb2a Take Adams advice and make isSIF take io.ReadSeeker 1adb255b2 Move build definition structure into build_definition.go b2f1ab5e3 Rework pkg build into builders and provisioners 62cc94104 Use io.Reader for parsing Deffile 08835ee9d moving cli commands to directory suggested by mb 607a4ab25 moving commands into CLI in response to suggestion from eduardo 14caee25b silly go fmt c04b8ee3b putting a framework in place for cli 3da34fe37 Initial Golang commit 5b0d9075b Move man page to docs dir a3526c82c Remove old bin dir 026778b44 Move rpm spec file to dist/rpm/ 61fc0a422 Move scripts to appropriate dir 5d762fa02 Move src/ -> core/ 4edd79623 Remove libexec/ a06e3d13a Remove all build tools f8e6bbbae Move debian/ & alpinelinux/ to dist/ d0f41ea75 Update changelog 1551b8fc7 Add delay in cleanupd before removing runtime directory 556509da6 Fix indent - no #IF indent, 4 spaces code f96149458 Apply review remarks d580fa366 Changelog updated 1a88bf8b9 Use helper function is_dir ce49bb3e4 Close all file descriptors pointing to a directory 3eb63ae44 --disable-suid must allow non-root config file owner 889cf50c3 add myself to contributors 454bfe0f6 Fix compatibility with non-GNU tar 5f529e83a Remove priv_escalate forgotten during cherry-pick f9ac563fe Don't modify user groups 46e25c3a0 Changelog updated 50bd2c8a8 Remove duplicate priv escalate 0e970c6f5 Move privilege escalation for mount in singularity_mount function 758009780 Set filesystem GID accordingly to bind mounted group directory f1eb6c868 Update CHANGELOG c8089a88d Use _mode instead of _perm for old libarchive eb134b608 Test for #977 docker user build perms 3c71d0d51 [docker-extract] #977 force write perm for user build from docker 07ff67f51 update based on Gmk & jms review 6ecdd7215 docker-extract ABORT on all whiteout failures 1dac57b10 added help for instance.list --json, added short (-j) option, changed env var to be consistent with inspect, and changed 2 space indents to 4 space indents b1880e52a License update to Sylabs, Inc 2018 e9f8508c8 Update instance.list.exec 59cca7632 Fixed typo in image.import example b9477a0f0 Added the json flag to bash-completion 736ff8927 Fix tar magic number check 8a0e3008b docker-extract.c - fix locale encoding warnings 647fda5e6 docker-extract.c - fix failures where whiteout target doesn't exist e9b1ad336 fixing inspect in README 4abac7eed requested changes on PR #1191 5128546fc Allow to change to directory with --pwd option even when --contain is specified 88f53db98 triggering a travis build 58b1e26df Move suid allowed check into boolean function 912f76b76 fix unbound variable error 6299355b2 "" quotes added cf6fe802d Update CHANGELOG.md c38e0cc08 Changes requested on #1191 c8baf0df1 docker-extract string handling again de59af092 updating the whole support f88224d3f Remove mksquashfs check from `configure.ac`. Print a message at the end of `make` that it is a requirement. 27f5548b9 Fix mksquashfs AC_MSG_ERROR message to closer match other output message c18073b75 Catch a couple more files on maintainer-clean 61e2ff787 Be consistant where specifying entries 20d3c5371 Remove trailing space... da6ab21f2 Catch more issues with Makefiles c34dfb57d Catch the .libs directory as well bdb5dd8fd Fix Makefiles so distclean works (Issue #1206) 6ba0a1b06 Add back squashfs-tools to rpmbuild_test script 1e57e2428 fixups suggested by yhcote bfd7c07fa Need -y for automated yum-builddep 8fdcd49a8 Add check for mksquashfs binary to configure.ac ffea95f7b aufs code review - string handling da80c4d8a aufs code review fixes - deps 63ae338c4 aufs code review fixes - style bea919eb8 fixing bug with slashes 90afea077 updating the example for apps, and a missed SINGULARITY_APPS environment varaible b79c7ba99 updating SCIF to have general environment variable names efe28514d changed default value from \0 to NULL based on feedback from yhcote 37a56e147 added changes to CHANGELOG 6590b5ba1 Added Divya as contributor. 076acca05 print human readable sizes 605b15390 Added print header command. c5a5a2da6 move image handlers to runtime 0be848444 Fixed permissions for hosts and resolv.conf. 8481056f1 Add the delete command 08c512bec First crack at deldataobj. d4a2730f4 Fix getting Arch keyword from definition file bdb1e2672 add environment containing to --containall help 670c70195 Force user namespace without requesting it when allow setuid is set to no 37d300c33 Add missing build deps to deb and RPM: uuid and ssl e00454a69 Put back the fallocate() to grow the file. 91881f758 Fix email 0c9e27632 Bump versions to 2.4.2 b628c1df7 Changes proposed by @GodloveD 23234ce8c and another stray line (sheesh) 1e6b7ecf8 cleaning up a stray line 90d45ba6c reset license info 3d8de645d adding new binary to spec file b6e504ce6 Trying to make compatible with latest changes in development c12debc5e Use Eleminfo througout and siftest.sh passes 0e823d4de moved control of --nv option to environmental variables acfd559d3 Add json format output to instance.list 985b9d0a1 Image.list info update db68195ee updated with fix info f8385cbeb fix unwanted removal of backslashes 761d811cf bug fix 035027db7 using get-configvals to check singularity.conf 62a2b2579 small c wrapper to expose contents of singularity.conf using established methods d2813f101 Fix autofs bug path (merge black hole) 2407e82d4 Handle libarchive versions/deprecation warnings 03346fcaf Add test for docker aufs whiteout 8dfb334f3 flawfinder sprintf fix d5675e04d docker-extract for rpm spec 5ecf90e1b libarchive-dev needed for secbuildimg.sh a1ae47582 libarchive dep for tests 6880c49b2 Tidying up, libarchive2 support d77e92243 Drop effective capabilities if user capabilities enabled 533a57002 Fix segmentation fault a686101ae Add option to set container hostname. Rename function to better reflect usage Fix minor bug when joining UTS namespace 2db877ee1 Fix autofs bug path (merge black hole) a4863c04a move wrapper-suid to runtime 388361b70 First attempt with libarchive a70acbade Use Sifdescriptor and Cmdesc. 20e250dbe Now fixing tar-pax for real (ref: #670) 82c2ea6b7 Reverting tar-pax addition to AM_INIT_AUTOMAKE (ref: #670) af211d35b Fix automake compat problem with tar (ref: #670) fa4b0a39c Fix privblock tests and getuid for TARGET_UID/TARGET_GID with capabilities 31bbc8f75 Add missing commit from feature-squashbuild-secbuild 5a0484508 Add missing UTS option for instance.start and set by default with boot option 9e174f5fa Fix suid init and boot instance Remove set securebits when booting instance d653b742b Add note about /usr/local in PATH to changelog 4e95527c8 Add Thomas Hamel to Contributors b910a6f0e init: put /usr/local first in PATH 651b07a39 Update Changelog for Boot/start instance (ref: #1032) 585c830c8 Fix shell syntax aed70f874 Fix close bracket 3bdf1fc37 Change instance boot behaviour. Fix merge oversights 7c117dba3 Update CHANGELOG 4ce661309 Minor changelog update 1aaeeaca8 Update Changelog bc8d7af10 Removing leftover NO_SETNS variables from makefiles f2d7795d0 Fix setns() checking and blocking bug on older distributions 979ca2529 Bump release/version 19e95e199 Updated CHANGELOG 2a118ea65 fix suse squashfs package name in RPM dep 115c06002 Fix terminal problem when using PID namespace and kill shell process 2fca87581 Minor fix for no setns 66d0a1455 offer Deb package nomenclature on build dep failures 1a0f5eb98 With union descs are of same size. 785b9676c Fix terminal problem when using PID namespace and kill shell process f3fb40757 Close ns file descriptor et add close for mnt_fd 61df1eee1 Update the SIF file example. b331a00f0 fix suse squashfs package name in RPM dep 0cdc2b74f join the contributors list 96bf3805e Improvements to Debian/Ubuntu examples 12faee4f2 fixing small typo to reset Travis 18d80da47 Adding more universal tar support 7c5e2b459 Allow all proxy vars for build 34c7ed0f0 Removed extra space e2de80c3e Properly ignore commented lines (fixes #1103) 1cb801ab3 more 2.4 fixes for alpine linux test, requires PR1045 ecf9eca2d change overlay try into a config option instead of compile time only a6353e95c tweak according to V's comments 404a3f674 CREATE to BUILD on build.info 1cdb5fb0d update changelog for 2.4.1 c7654cb68 Fix build errors/warnings 2c223e42f Revert "Make tar file creation reproducible" e7e2b684f Make tar file creation reproducible d3d1d1609 Revert "Make tar file creation reproducible" e4004498c getting rid of INSTALL.md in release checklist 4d7d62f1b reverting a test that was intended for a different PR c1a34b0eb Made INSTALL.md generic (no version #) so we don't have to update at every release 7bd1e25d9 testing bold inside of code block df26979d7 testing bold inside of code block 38fff2707 testing bold inside of code block 468f70e18 testing bold inside of code block 2e9b61f05 testing bold inside of code block 3fb37fe93 adding tests for incorrect parsing in header of def file 7c547a988 Re-added test_cleanup that was removed by mistake b6df8e5c8 Add test for comments inside runscript 54e8ca66f Skip empty lines in deffile 87774191b Add test deffile with multiple empty lines 7c3caddf1 trying fix for path issues ed47322fd Make tar file creation reproducible 61fa8e353 actually we want it in quotes b99c2d1ac fixing issue with cmd missing $@ 6aa4921cf CHANGELOG updates c7741d03b Dont' require local docker tests if docker isn't installed 45b80296f Check if overlay upper/work directory are symlinks 53494e415 Don't squash the http_proxy envar on bootstrap or runtime 592fffe89 Spoil the lolcow fun :-( 28bc43912 Style fixes, no functional change 3b772691b Fix parsing rules for tag and version 73e37ae15 updating changelog 681143b4e changes to enhance SCIF, exporting more variables for other apps 5bc15ce00 Add tests for @version which are currently misparsed 54901a610 Packaging: Explicitly include local state directories. cafc4eaa4 fixing env var in build help (#1130) aac257986 Properly ignore commented lines (fixes #1103) dc48c50cd Fix chomp_comments() when string starts with # 6f0b0eed9 Add test for #1103 a8216a1a5 Allow CentOS container to use host's docker for running tests 69c803f0b Move overlayfs detection code to test-suite. dd95f59dd adjusting env parsing for docker to allow = in variable name 98a637699 adjusting regular expression to only accept first = sign to split environment variables 1add56375 Remove useless include in src/util/util.c 20bbed82a Adding Change Log (#1109) 99e566fb1 Tentative fix for travis test on CentOS 7 769204688 Add mount wrapper called singularity_mount a0298b69e removing bootstrap and definition from help (#1027) 37b7dfa7e Multi-layer docker image fix c66cb8ade Added myself as contributor a7cf82bcd Added build tests with local docker registry 6c8552079 Allow empty values in build definition file 98725c99a Allow overriding default NAMESPACE with '' for Docker 4cc1fc55a Allow empty namespaces with docker:// URIs, added tests d042a17dd Added squashfs-tools as debian dependency 2aa756e39 RELEASE_CHECKLIST: Add note to update debian/changelog. f1068dad7 removing extra files c248b789a INSTALL.md version update 565b3e0c5 image pulled is default simg 0122f3bed re-enabling docker pulls, hopefully travis is fixed? 7cdf4606c Add SINGULARITY_NOHTTPS to the environment f438de7a9 Fix annoying error message 6e50ac2ea disabling docker pull tests until the travis issue is fixed d43c01c5d fixing Docker naming weirdness b41714977 fixing pull to honor user provided names 7e6c08ba0 Wrap mount function to set fsuid to current user (NFS + root_squash issue #1068) 81da27f4b Removed extra space 93d75e95a Remove --force from secbuild script 49e91372e tweak according to V's comments 2960d7b8a CREATE to BUILD on build.info bf866a6a2 Fix travis build b4e9ced3f update changelog for 2.4.1 38e022239 Fix compilation link for wrapper 08502cb38 Cleanup 43464fe09 Set capabilities requested at start when joining instance 30df6f639 Fix build errors/warnings 44d433e2d getting rid of INSTALL.md in release checklist 6b81eebc2 reverting a test that was intended for a different PR 9b3d6ca25 Made INSTALL.md generic (no version #) so we don't have to update at every release 1ebac3ba7 testing bold inside of code block 927dc52ea testing bold inside of code block 5d5cf8610 testing bold inside of code block 107842cda testing bold inside of code block 8d6391a0d testing bold inside of code block 2a33d881c adding tests for incorrect parsing in header of def file f5a266466 Add capability group command help a4bf48dd0 siflist needs to be packaged 4df4421c3 getting rid of INSTALL.md in release checklist 9545c145f sign and verify aren't binaries anymore ebd13303c Add travis centos deps 994381d53 reverting a test that was intended for a different PR 38dc7e40f libssl-dev f881e750e Made INSTALL.md generic (no version #) so we don't have to update at every release 23965c348 ubuntu package for centos builds. d4795374d testing bold inside of code block ccb14af7a Add packages libuuid-devel, openssl-devel cda7cecfd testing bold inside of code block 977da3453 testing bold inside of code block 4007be070 testing bold inside of code block 39d7267de testing bold inside of code block e695f52a4 Fix a few issues : 4aa6dd98e Need to deprecate as soon as possible. 2e091e133 adding tests for incorrect parsing in header of def file 1a955d321 Fix the obsolete path where TEMP_FS is needed. 1a63f9d18 Re-added test_cleanup that was removed by mistake 2e879886e Add test for comments inside runscript 56fa44126 Skip empty lines in deffile 7fc095749 Add test deffile with multiple empty lines c434a08be Get config directive value from shell scripts and add some sanity checks de6a02010 Check for needed libraries 840d3da77 trying fix for path issues 12704a41e Make sure size limit is 0 when raw image. 4a8816f24 Remove those unused files. a8d95097d Link in the siflist/sign/verify commands. c6eb72cb9 Remove uid check from singularity_capability_keep 6ec647843 ignore some flawfinder issues. 1395da0a3 actually we want it in quotes 9dbdec613 fixing issue with cmd missing $@ 6e6589503 Check securebits flags before setting them d878172b5 Fix merge oversight aaa2f01e5 Clean capabilities script 3b9de1701 Handle user namespace fake uid/gid e1d3227b6 Set effective capabilities for current process 4782bf316 First working version of verify f1481c206 CHANGELOG updates 2cab6b58d Dont' require local docker tests if docker isn't installed 693dd4f8c Don't squash the http_proxy envar on bootstrap or runtime f8bdb54e2 Spoil the lolcow fun :-( 8bae840cc Rework user namespaces, add user namespace support for running/joining instances and fakeroot options 0d77f5825 Style fixes, no functional change 79a0a6ae7 Fix parsing rules for tag and version bd0378420 updating changelog 22b1d4220 changes to enhance SCIF, exporting more variables for other apps 0385c666e Add tests for @version which are currently misparsed 5878d6264 Fix uid/gid mapping debug message 2d789aa07 Use getuid rather singularity_priv_getuid to match fake uid when using user namespace 5785468d9 Add --fakeroot option for user namespace 2f16881f0 Packaging: Explicitly include local state directories. bd92253d4 Add some compile-time hardening options add848ceb fixing env var in build help (#1130) fb83a4a40 chroot is not required when joining instance ff91d6c07 Add the dump command. 7578f536d working sif_putdataobj() 1f7e6a955 Properly ignore commented lines (fixes #1103) 256184ca2 Fix chomp_comments() when string starts with # 5786809f7 Add test for #1103 4640dbe93 Allow CentOS container to use host's docker for running tests 44acf989d Fix error redirection f54aff591 Finalized capability commands 909446e65 Add capability commands completion 091856433 Prep for a SIF desc. adjustable layout. ea10a611a Move overlayfs detection code to test-suite. 3e7bf82bc removing these files d5ba3ab10 adjusting env parsing for docker to allow = in variable name 6fb7b800a adjusting regular expression to only accept first = sign to split environment variables bed8a6409 Remove useless include in src/util/util.c 3dda9a9c1 Adding Change Log (#1109) 86be2db90 Tentative fix for travis test on CentOS 7 0d8a41339 Add mount wrapper called singularity_mount 4fc90e466 Get capabilities from environment variables 346a7561e Change sifcreate.c to sif.c 4632b3809 Rework for a multicommands program 852115fce Rename FROM environment variable into SINGULARITY_DEFFILE_FROM d99165f62 Added myself as contributor f7ca2b317 Added build tests with local docker registry becc370a1 Allow empty values in build definition file 8d31b109d Allow overriding default NAMESPACE with '' for Docker 5d4f4225f Allow empty namespaces with docker:// URIs, added tests b83d7633f Rework crypt to match new SIF impl. a0e70557c Add user capabilities 342bcea3c Added squashfs-tools as debian dependency 62264cfaf RELEASE_CHECKLIST: Add note to update debian/changelog. f73df2807 removing extra files ccbf7ccf7 INSTALL.md version update 1a5ba0053 image pulled is default simg 43efc3696 re-enabling docker pulls, hopefully travis is fixed? 333c3fa31 sifcreate needs links into signing lib faad28f3c Add SINGULARITY_NOHTTPS to the environment 8a2ac7720 Fix annoying error message 03bdf5b11 Start redoing the crypt code for SIF. 67044866b disabling docker pull tests until the travis issue is fixed 23bd64775 fixing Docker naming weirdness a2acd1564 fixing pull to honor user provided names eb6829c69 Wrap mount function to set fsuid to current user (NFS + root_squash issue #1068) 776a0371b Deal with parttype correctly 239640a21 Revert "Make tar file creation reproducible" 5bd2fba2b removing bootstrap and definition from help (#1027) 61a09e5d5 Process capabilities as unsigned long long a8ed65b5d silly Travis 2ae67a12e cleaning up debugging nonesense dc196ba20 silly Travis 89fc3d8e4 stripping comments before grepping singularity.conf dcab92ba9 etc/singularity.conf.in f8deee739 Add sifaccess.[ch] 4962f9895 adding ability to config location of mksquashfs 92d63abea Fix secure build and modify tests for root default capabilities 41a0a11cd silly Travis df877335d added env var for user to control behavior and more error checking c3e699900 Add configuration directive to select root default runtime capabilities 9e34aa4b2 Use ubuntu latest for secure build image instead of debian jessie f1b92e141 First changes based on @bauerm97 remarks f46979bac Localize things a bit, create sif and signing libs 8f5b9b778 'prepheader' is not needed anymore d24741dd7 Fix exec files to fit the new 'info' model. fe9dde6dd Check if overlay upper/work directory are symlinks 10c5322ed This is not required anymore. fc792fe44 Trivial cleanup. 8ae491ffd Add limit container groups directive 4eb70bca4 always use 'try' for overlayfs functionality. 6916fce9d Make tar file creation reproducible a71c2145e added caution for admins 26ae0ae5e Finish merging sif and sign branches. 430f2cef1 adding configuration to always us --nv in singularity.conf 818b64825 Add CAP_AUDIT_WRITE as default to fix PAM issue during build bc421e6bd Fix directory mount regression a28bbf7c6 Add lcrypto and fix info files. fd45158d7 Fix more merge issues. 9147dc76b Fix some merge issues. 7fd59b8c7 Cryptographically sign/verify container images. 6ad9c018f Cryptographically sign/verify container images. ba6021ed9 adding support for nvidia-container-cli if installed 6b35fc1d2 Limit container owners/paths db2492370 Remove docker comments in before_install script 6498198f8 small tweaks to the PR, let's go for a third green! e1f9084a6 Better chroot message failure f8b231cf0 I need to see this work once more for sanity... 9f8968e4b confirming that we can't have slash for image requests for api f3ee3da6f enforcing slash 845c92843 testing if adding www makes a difference e15ab2e70 Replace docker by singularity for travis builds d15dd6ccb Use pivot root and chroot to make container root filesystem as real root in mount namespace 489bad35e Set /proc propagation as unbindable to avoid binding /proc later at runtime a88385ff2 modified: tests/05-python-units.sh 8e052c532 unbreaking test 01c0e2aca modified: libexec/python/tests/test_helpers.py a09d470ac adding more verbostiry to pull test 4cc0ba71b use singularity_which instead of which 3cf068ef4 adding temporary file for building to sif from squashfs or ext3 e0f55f0ba trying updating the gpg key 675ea9000 permissions error 5f1d9b31b trying moving python units to install base e70f2f968 why is it caching? b2d5657ae removing test for size 8240809f1 making tweaks to test 7f0ddbcd2 updating tests with new (smaller!) image size b3135892a updating tests for singularity hub 2.0 e2446f7f4 Updated debian/changelog to version 2.4-1 05b47445a Try to fit SIF image creation in current framework. 365067640 Properly pass exit code of build subcommand in pull.exec (to development branch) (#1067) 1bd28a2a9 Check if secbuildimg failed 62cdb93ac Explicitly add autoconf packages d1521b82d Remove sourcing runtime environment during build 148906913 Add SETFCAP capability to default set fbc8c64f4 Display warning message about instance not supported during configure df8b45ba0 Disable instance tests in case joining namespace is not supported by kernel 54c957ff9 removing sourcing of env during build 868e82d6d fixing location of tmp file for nvidia 485192ce4 Start cleanupd before entering namespace 4b380d1d2 Disable instance if joining namespace is not supported by kernel ae22db769 Set CLOEXEC on image file descriptor 217367ce3 Close /proc/self/auxv 4ec5daed9 Add some capability tests 12b7ddb85 Multi-layer docker image fix 9ecd3b741 Detect what arch machine is creating SIF. 2f4b48b69 Use the real image type when creating SIF. f68799174 set fstype to pass to sifcreate later. 015b21de0 deal with flawfinder 2c34f98db Do not print but use siferrno instead. 32ce3912d Add sifclean to spec file. 9099d9f61 More SIF build integration 3fd4a1b5e Integrate SIF code and libs in source tree. 370fb7b0b Fix attempt for issue #1053 482048daa updating image handling for shub pull to be more speciifc in naming 780c84d91 Add capabilities to rpm package 9aee19aab Finish capability support Consistency with directory image and writable option 387146d93 First stab at creating a SIF file 29db554cd var not needed. db1243de4 Accept a SIF format container. 4f0797703 Fix reading auxiliary vectors for portability, use /proc/self/auxv b73d9e5d3 more 2.4 fixes for alpine linux test, requires PR1045 3645c8592 Back to secbuild.img directory with an environment variable to mount it read-only 05b68b659 Remove unused code deda7a746 Fallback to squashfs image for secbuildimg and copy resolv.conf rather than bind 20a55c763 Force NULL terminator into tf->filename to avoid buffer overflow 6a7ccbbd0 Fix oversight for environment variable with shub driver caa2f0e56 Contributors: Add myself. 190c5de69 Packaging: Add "python" as build requirement. e31bb749a Fix bad condition for suid tests in fork.c 8ab85ed19 fixing shub download bug d46e4b85c Force deletion of existing secbuild.img when rebuild d0106911d Use directory rather than image to not use loop devices ed5131257 alpine ABUILD for versions 2.3.2 and 2.4 511de0105 Instead of dumping stdout/stderr, put it into log file in /tmp/ 8b1462ec8 Add make_tempfile, make_logfile, and free_temp 833843217 Close stdin, stdout, stderr before running startscript e3c69f65b removing self from docs c316f8d05 Close proc status file 3faab8b55 Minor bug/typo fix 41b6be9ff Check owner against /proc/pid/status rather than stat on /proc/pid 94bc2f888 Fixed another minor bug that I just created ddaa93998 Minor bug/typo fix 2e0b21198 Don't delete sandbox directory bdfd1c9f4 Join namespaces requires privileges to open /proc/pid/ns 36b8d081b Display cleanup message for all cases 2746a7bf4 Add atexit bash function to register a function called when shell exit Register an exit function for build directories cleanup 5a3598ed2 Instance start execute /sbin/init by default Add UTS namespace, init system set hostname at boot 5c8ceb45c updating PR to download images, tests might need work 9aa890a1b Because of change to image-type, we have to do tar/*z test before image 387beb032 Minor change to return/exit on successful file type 86879f2f6 Fixes for Bash 4.4 1bda20c59 Seems like image-type does more than writing type. 221d3e482 Test image for compression types. c7a6449ab minor grammar fixes b9e6a9463 adding function to use file 0081b6ecb fixing issue with download links e73b88cfc missing include statement d4c5ce80d Modify path in secbuildimg script during Travis test, and a presence check for singularity binary in sebuildimg script aa435c0eb Add secbuildimg for rpmbuild_test and replace realpath with readlink e4d7ea7bc Use writable image and modify tests for 40-privblock as some host may not support overlayfs 97057a398 Add isolated tests and modify install_test to include make secbuildimg for tests ed6d9120f we force extraction, needs to reflect in test 6f706a1a0 ensuring that images are extracted only with tar.gz e480d9640 Revert the warning message for root running non-root images e8c783793 Bump release to 2.4 881aacfda Minor warning when root is running a container that root doesn't own. 1db09b18f tweaking checks command to not have conflict with -h (help vs. high) b0ba05b89 Minor usage change for --userns for clarity e91828be6 Allow root to use any type of container 7307f4fa8 updating tests caa96c191 modified: libexec/python/docker/tasks.py 1b5bf5e59 tweaking runscript to use sh, and add single quotes af3ce9136 Don't create CWD within container (ref: #956) ba071309a Multiple fixes to home directory handling (ref: #943) a99982eb5 Add good error message 342add43a Make sure that CLEANUPD_FD registry is never non-initialized 8afcf70be fixing pep8 67bbc0580 adding for shub too 7be503897 simple addition of namespace and registry to build for docker 4cacd86a0 Do not close cleanupd fd on daemon start c959bfd2c removing gcr.io, too unreliable, will re-address if we see these errors in production d3c986349 updating apps.info afa7fa01c Remove pipefail and sudo from 20-build tests 720885ed1 fixing error with runscript for apps e92fc6a8f Suppress error/warning message coming from docker tar pipe chmod 86eed76be fixing layer ordering - hopefully for good! 8a063c1e9 Fix indentions cf090eab4 don't delete sandbox when building from sandbox 802352161 Change ping binary for chsh setuid binary during 40-privblock test 3735af7a0 fixing docker variable environment quoting 56b413335 Fix indention 480902510 Daemon image could be a directory bde50f40c warnings are too scary compared to actual consequences 750aaeb02 Change warning to verbose message bc6ec110e Set program name to sinit and remove warning message if startscript missing bdce5a46c fixing sandbox message when building from docker 60f2910cf change debug signal handler message 26e0d908a Catch defunct processes d1219490c Prevent instance.start from exiting if no startscript exists in container 3af441969 trigger another travis build b1824510c adding --file opt to image.export bash completion 69d5c2779 Portability fixes for issue #994 11901375d Forgot one replacement FILE_NAME by DAEMON_NAME c314007ed Don't override program name in suid wrapper 545f51dbb Updated Debian packaging (taken from Neurodebian) 9fa88b1d1 modified: libexec/cli/build.exec 9b372458d Minor fixes for import/export c91ff7090 Allow import/export to take from a file as well as pipe (ref: #985) 20b8106e8 modified: libexec/cli/build.exec 27c881879 adding helper message to writable /root 85ead258b fixing inspect for help for apps a8ffe73d8 tweaking text for image.create / create 70abb14a0 changing pull warning message to alert user about docker pull 30bd0096d Rename AUTHORS to CONTRIBUTORS and update accordingly db0a44644 remove sleep in startscript 1834e5120 Add help about signals for instance.stop 5804598d4 Add cleanenv 470e6e9a4 singularity_wait_for_go_ahead return exit code 4da438e0d Fix variables use DAEMON_NAME rather than FILE_NAME 35687e292 Change signalfd for sigwait Daemon return exit code in case of failure Daemon file deletion is left to bash commands 9fabbd884 ooopsie! Removing stale line. b0feba064 added %startscript to docs and moved easteregg to run 2b3546535 fix permission denied in 20-build.sh 914f08b27 --secure to --isolated 440b66b15 instance.stop waits for default 10 seconds before terminating container 44ab514cd Remove debugging comments and such f33f433b7 Don't close sig_fd 66f5300d9 Instance.stop send different signals 82ce4e8d4 redirectory rm error to /dev/null 0482c14c6 Use signal.c functions for init process signal handling dee3aac23 Create signal.c/signal.h for init proc signal handling c5d5e0a0b Switch --paranoid to --secure ddc714f1a Add PTRACE capability for joining NS d5f599887 changing instance options and adding a surprise 593c05f41 fix travis and add runscript documentation f419a5d64 there can be only one df5f774de Change init process name 8bb4beeb0 attempting to fix travis build 3e4375f88 Only allow root to use overlay directories ef89c060d Add startscript definition section Set instance processus name to identify it (ps, top) 6cca7aa50 Add startscript ea1b0061f fix a bug with test help 415e34eb4 bring notice in line with others 90d7c0614 sh doesn't have arrays :( plan B 2a5f73758 completing command help tests 026f60985 fixing some bugs in help and adding content 775ad7cca Remove sinit and use start instead to do chroot e717f4635 Use zgrep instead of zcat|head|grep due to incompatibility with pipefail 01543ba4f Add missing double quote 692f57a22 Remove mksquashfs -all-root for root user ec7e32ed1 deprecated to legacy in warning b835be1d3 singularity.help is no longer used e4150f823 Make flawfinder happy, bypass check suid for root user 8ce215b81 change overlay try into a config option instead of compile time only 0b717aece config_defaults.h is now generaed b4d90eb37 rename config_defaults.h to config_defaults.h.in 2bf3e577c cleanup 034f60501 changing pull to a wrapper for buld (docker hub) 76f419a72 Add SIGCHLD signal handling to sinit to clean defunct processes 09a85de3b Suid check refactor 5cf6b0df2 More updates to help output 5acfa9c70 Update command help, usage and summary to be dynamic 1eda3418f trigger new travis build c43e198f2 Allow directory based overlays d87229be1 be more inclusive so that help works with sandboxes ea1cebff2 Add --uts option to enable UTS namespace for users, enforce UTS namespace for root user 4a7146efa Add curl package for secbuildimg, add rpmmacros in fake root directory a8e222eaf Change build from tar file to take both normal archive and compressed archive 1ce0368cc Remove old suid binaries from seltest and add wrapper-suid 09daeb02c ensuring app bases are sourced before specific app fe86e0e23 Allow or disallow specific container image types c37556154 Reverted the ext_attrs mount option 11fc1cd1a Don't use extended attributes if we can help it a478743e7 Remove unnecessary int retval = 0 line 0800bcef0 Do not allow --writable with squashfs image type b60b8db0d Clever error message 7919a48ec Fix issue #959 Fix second issue in #956 (https://github.com/singularityware/singularity/issues/956#issuecomment-331709084) 33e7a9140 fixing tests to reflect new reality (again) c17e2f95c fixing tests to reflect new reality (again) 05a6c79ff fixing tests to reflect new reality 37bddd5be --exist option is now non-existent :-) e66317287 give more helpful warning 886d2a480 stopped warning when root user creates sandbox 0e8976cb6 another few bash completion fixes 5bc96a906 made executive decision to use | instead of mixing / and | 5bb11b6a4 Clean previous installation in secbuild.img 6ce54d99a bunch of changes to docs and small bug fixes 9dafb73cd adding README for a little more help! 88063dd8d adding final bits to expose app DATA and ROOT folders c6195c610 Correct typo 33a4538e8 Add secbuild.sh to gitignore and use existing flag if image already build b5c21e390 Remove not needed if statement for build --force option d94925772 Add secbuild checks before use 9f84303f8 First prototype for secure build e87571b9c Fix non null terminated buffer with readlink 96dc18be3 Remove unnecessary second fork_daemonize function, and remove references to it 3cf7c8733 Remove redundant calls to singularity_*_init() functions from start.c 1a8fbeefb Modify src/util/fork.h to match proper function interfaces 3dafa397a adding force option for @GodLoveD!x c4fd31b62 Add CAP_NET_ADMIN for network namespaces 3c6233693 Add custom configuration file bd5369a86 Use of SINGULARITY_DEFFILE_XXX environment variables rather than XXX Remove eval in shell script which take environment variables from definition file a10e26990 Race condition fix for instance starts d41150bc8 removing some debugging leftovers 4f2a75644 scratch to warn without infinite loop 18d554005 bashism!! bad @GodLoveD. -1 cookie. 42366bcaa add selftest unit test 4738aecc3 fix selftest 4c0988cd4 make help smart about commands not installed a1ea5a150 move check command out of runtime 95235956d adding SINGULARITY_DATA 2b7eade85 need to be more consistent with variable naming, root over base 472c6cdab update for new paths from upstream/development aaab272be modified: pull.help 6e83326ae adding size to pull help for @satra 116c0d1bf Implement bi-direction go-ahead signalling 08b9805d9 Add some debug messages 7e9254f12 Fix capability dropping when compiled in a container b6ac057e7 Get/set processus capabilities Remove travis tests 74eac36d8 Check travis kernel version bdec9e3e5 adding set -/+ to environment during build 6a220ce1a Failed check for travis capability ac74d9fce Temporary workaround for racecondition bug in instances 65c3ba4b0 Check travis capability e2f730b41 do not disable network with --containall c71df46a2 use VERBOSE instead of DEBUG when skipping devpts 8a7a2cb6d skip mounting /dev/pts without an error when it does not work ad1efde52 Adding sleep, triggering rebuild 0981e96d5 Triggering a rebuild 1f633158b Add wrapper binary for make dist 169248acf Even more debugging! 1d9d027bd Fix make dist by removing old suid binaries 1cea9a54f Maybe a race condition? 3aa81c71f Fix securebits include 4b1bab352 Some more debugging build failure b32824f60 Minor oops 7cee9d134 Add some debugging trying to figure out travis error 9b4d0da39 finish the merge 5c1d3f009 Oooopsie c4c6289dd Forgot a return char 78af5f54b RPM Require for squashfs-tools 0fbc8fb87 install pylint from yum 66692ea64 need epel release before python 775946765 testing installation of python3 and pylint 9d2c709e0 Changed instance test slightly 5b0d6ff2b changing test line for instance 47ad90def tweaking pull folder for build 0fc944044 Make sure squashfs-tools is installed in travis (ref: #895) 3fba09835 Disabling SLURM to fix builds (ref: #895) 9e64591ec merge conflict configure.ac 429768768 Bump version to 2.3.9 (alpha) 8994deafa Fixed some build tests 91f7ab690 Update tests for instance name list 1e1fd83e7 Update instances to take lists of daemon names 94c9d1814 Support an array list of daemon names to glob ad98ee4e5 Minor change to remove 'instance' without the dot 3615e88d0 Fix keep-privs MS_NOSUID flag 8bca1c678 Ooops, forgot to remove stop-all references a5c22e99d Fixing up tests 71c63ecd9 A bunch of changes for instance support 1f7092935 Revert change for usability and permission check aa954009b Minor changes to support different instance model 858f4c2fc Remove the stop-all command (stop now takes globs just fine) 1729c611d found another error c14109194 missed a bunch of stuff in the first pass bf5853e22 Bump release version bc354c0f5 adding release checklist 8416b24dc updating bash completion for new commands e971ae371 adding labels test 549cc6edd Fix typo and add more no-privs tests 282e692b4 Check if command is set in suid wrapper. Add keep/no-privs tests. Fix help command wrapper a9b4e7586 Revert to lexecdir rather than bindir (dev branch) as it break tests. Make flawfinder happy b37a028fc Remove old suid binaries. Fix src/Makefile.am merge c6a32936c Remove keep-privs, no-privs from global options (duplicate) ccdf2ad7a eat my shorts, pep8 ead680710 modified: libexec/python/docker/api.py e7f78b22d addig tests for pull e65f32adb fixing pull and adding some tests d5db4bf8b adding notes to README 1dd6e6e29 adding support for manifest lists, and version specification b2ca8429d and cache tests! 6e6654709 updating tests for shub api b8af9153e test_shub doesn't exist 41e98a640 updating tests 7dbc9fffc tweaks to fix shub pull 5151fe442 quick fix for docker 70f3e1743 adding test b79747d58 Split build/bootstrap into 2 stages. Add --keep-privs and --no-privs options c0415def2 updated shub bootstrap for squashfs code ba0b1bc72 updating tests for manifest d287ef0ab Minor changes to action after merge ba4f3f5f2 modified: libexec/python/docker/main.py 139f138b4 modified: docker/api.py modified: docker/main.py 6ace64d13 Slightly different method for calculating help 52659a991 Minor fixups to build.exec 406cc1aa7 Added src/prepheader to ignore a7e2d34ac adding test for non-existent build-spec abc447df1 fixing license info 18a065b5e adding wrapper to support legacy create function 618b8dfcd First steps for build box 0f98c7550 pesky sudo 6e8caa7b8 pesky slash 2f22bc9ff added some instance tests 6f3cf7082 Adding myself. 85d25bbf5 Implement EXT3 image detection with or without launch string. e62dfc5ff check for magic skipping header in simplier way 1a38661cb Check for launch string in front of squash part. 5ef307a76 Add prepheader program to add LAUNCH_STRING. 346716565 fixing travis build errors 347f9001b fixing travis build errors 1d16eb473 fixing travis tests d45210dd4 fixing travis errors on help docs ac6dbd4e1 trying to fix help tests 494827ce2 fixed command groups with spaces help docs 40dafa906 unbound variable in message b3afcbf29 another bug with appinstall, going to not use get-section 1ef2b8fab pylint error, not sure why it didn't show up before? f8463c699 fixing file addition to correctly go into subdirectories a73a7ed40 fixing buggy section, replacing with bash to get section db9bcb9bd oups, we don't want to remove that! 3a59be272 cleaning up build help 25b6a2ae7 adding check options into build fe1b30cee adding working args (except nobase which is now default behavior) 600f543e3 classes to groups 392c6b3e7 Update command groups to use spaces as well as dots b0b32c6bb fixed bug and removed test for feature yet to exist 15cd74e54 fixing a bug in Makefile.am with gmk f025f4827 quick commit so that i can change branches b3b5ad6a3 rounding out tests a bit more 6c8bbbc61 enforce runnning tests without privs de58635a7 localimage can be a directory 93fbab3c0 Change copyright header ca43fec5e corrected some bugs with build from tar/tar.gz 1fc1b6231 if no modules.dep, try overlayfs but don't make it be fatal if not present d67bb0fa2 continue without overlayfs in some conditions 0543df603 Add UTS namespace acd404cc4 use quiet instead. The error message showed up because we changed the order 4d6d6bf9b calculating size twice! 3e7854bed install needs to come after environment, files c616b2a87 still working 851f4edb4 still adding tests and getting kinks worked out 5b9a77f13 add autogen.sh to make dist 3c2166ec8 adding a function to simplify build tests a25e705b2 derp 012936c43 set label overwrite to True 1da3367cb set OS_VERSION variable 665cd16e4 bypass test suite on centos6 8a502f36c enable centos6 build d3d539ab0 remove extraneous characters added in pr #902 f314d34bc fixing pep8 issue 5b7771041 tweaks to environment for inspect cd3bf3475 didn't mean to delete export of DEBIAN_FRONTEND 8a5e12941 tweaking tests b0b35ba49 modified: libexec/bootstrap-scripts/deffile-sections.sh modified: libexec/bootstrap-scripts/environment/95-apps.sh modified: libexec/bootstrap-scripts/environment/exec modified: libexec/bootstrap-scripts/environment/run modified: libexec/bootstrap-scripts/environment/shell modified: libexec/bootstrap-scripts/environment/test modified: libexec/bootstrap-scripts/functions c646084c7 making tweaks to appbase to better expose paths as variables c7864b6a8 Actually, we don't need any of it's output, just retval a984c0fcc Updated is_image to use the new image-type backend binary 19cf47df1 Check to see if we have permission to modify image ed289131c Test to make sure this is a writable Singularity image before modifying it a85a87471 Changed image binary name to image-type 0f0e9d3d7 Added an image command that returns the type of image it is 28d2ff25b Minor change to help d3e31e446 Update instances to use the command class 'instance' 49465e512 Don't trust the user's SINGULARITY_bindir (or libexecdir) 25745f6be fixing more things from review dc3dafb3b swapping cd for -C in tar commands ebc1b2a46 Conditionally call what functions are needed for join Vs. adhoc namespaces 8cb53dd0d Fixed error/warning messages about joining NS FD a98c5faa1 Fixed ordering of namespace separation b1b83c68b Clean/change arguments for start a2fe0f85c Supressing warning about no net namespace 0149ca517 Fix default macro a33606020 Updated to project default headers 9542dea44 Always init/open image, even when joining a running instance 0fcdcf78d adding docs and fixing bootstrap e0c582426 added docs and realized that I used an outdated version for bootstrap template 3c7384894 bugs found by Travis c9103bbbd renamed bootstrap for legacy behavior 1fbfa9262 allow users to bootstrap to the same file over and over... d01ce10e6 Fix sinit spawned 2 times and detach sinit from current session cd3244b4f Fix image_object segmentation fault when joining instance and run required functions based on conditional statement d6e4a39f3 fixed bug in localimage driver and some others 7acee3038 properly emulating bootstrap now 357071d15 Include appropriate option parsing for mount's overlay support 187cd7122 small bug 168b5f40d Properly define globals, and use those defines 36dd5e34b Don't cap the overlay size limit if being called by root 199a1c9d7 Include a persistent overlay if one is requested in the mount 876e6770a Unlink trigger in case of failure (eg: set SINGULARITY_CLEANUPDIR=/tmp) 6038a3b63 Run cleanupd outside namespace to avoid /proc escape within PID namespace. Open image before entering namespaces (see issues #714 #757) 525b8dae1 Enforce pid namespace 4bbf5aaf6 Add global defines for CONTAINER_* paths 83547d7d8 Minor verbosity fixup b8638584c Made the mount and final directories static per build 7b0e94c95 refactored to reduce redundant code c5da01a15 Initial support for persistent writable overlayFS image c00615195 Updates for new singularity_image_init() options b9abb7ad0 Support a persistent overlay image 1d640f92f Properly support writable images via init open_flags 46bafdb7e Duplicate/malloc the return string 1bd5b825b Cleanups to mount f6a69c139 re-adding pointer to yanick c62899324 /bin/sh --> /bin/bash (at bequest of gmk) c47125480 More robust image checking bb8efb671 Removed old sources 23e81e4ad adding some fixes that gmk suggested f835c5f8e removed -F option from bootstrap (makes no sense now) 80fcd4873 reimplimenting bootstrap (for the time being) a2c25e030 bc is not a given (not installed on Ubuntu) 52e340713 use full path 6cf2f0c79 added support for build from image or from shub fe28422e7 Pass any additional args to the helper c9d7f798f Cleaning copyright entries for copy/pastes of header d27a2de76 Fix bug in S_ISDIR return value dc6a47b7c Added debugging messages 9a0b801a7 Fix minor typo of structure name 088132dc3 Minor fixup 6ea4d192d Check for squashfs-tools 64972941d Racecondition fix for directory based image 3fab1c99e Forgot to include squashfs-tools! e847faf89 Lots of updates to tests for new image format bbcf97161 Minor fixes to environment files ca8b863ec Remove SINGULARITY image type mount requirement 5e40c1b21 Minor modification to allow arbiturary commands for runscript eee9960f5 Minor usage fixes e11a578ec starting on shub integration 9377d1bc0 Fix wonky 'break;' 5b1036f4f Fix standard help output 46464aeb5 Updates to build 5b972c8f2 Make sure we are mounting image as writable for import d85c1814d image helper doesn't need to check for metadata folder 7f1386bbf Bind fix (loop device must be opened with right flags) 2df8217da Minor ordering change on image check (always check dirs first) be819d7f9 Updated tests for build cec6d11d1 Support for the image command class d109140b1 removed $1 throughout 9b71103cc Allow non-headerized image files to be understood ffd466d7f added more checes to is_deffile 97b240673 Cleanups to image 5a73842e3 Cleanups to loopdev bind code d73ffc511 Add setns syscall for old glibc systems 4bb61371b bugs be buggin 1ee2e75cc still working on logic here 6267242a1 Updates to .gitignore 1af7def07 Minor cleanups to help outputs a88b188da Get rid of unneeded sources b299f704b Lots of changes for the WIP of the image library cleanup a7498e981 added some tests for file types ee226b356 fixing bug, metadata folder not being created da483bc19 added functions for check filetypes 1885677bf first past read with some cleanup a1aec26fc Support more build use cases a3a0f9d48 added test for bootstrap from shub cf0cc5209 added bootstrap from shub to documentation abab94b37 Adding shub bootstrap example e8562b629 adding support for bootstrap from shub 6036316ca remove temporary -vvv 248e8eebf add e2fsprogs 04a7ec168 temporarily turn on verbose on failing bootstrap 1b2138c84 fix up settings for /etc and /var 5f5553f99 install which 1575a1cca fix up sudo 155b9397d fix useradd usage 0b5ecae02 skip centos6 for now ac3172ac2 install and run test after build 25192d531 install make if missing 517728ebe add OS_VERSION parameter to rpmbuild_test 9871288da use /build instead of /app b127e7772 install libtool f7d9223a5 no need for sudo or PATH c57d08191 fix typo on centos7 d1d2d3616 add sbin to path da2ef39bb fix typo ba07450ab install rpm-build fb3c668fd fix typo c0c4ed7be add centos test 8dd3b71c3 add centos6 91dc22229 add default install and test dc2194b84 put back cpp language b7723a86d start to convert travis to two operating systems 8b3baf297 add apps cli adb221918 fix make dist after "Changing the implementation of SCI-F a bit" e58808d16 fix make dist after "Changing the implementation of SCI-F a bit" 1a29d8c5c Fix flawfinder error 8eb7acec2 Updates to `singularity build ...` and help 57377a243 Removed slurm directory as it is causing `make maintainer-clean` errors 6b662be44 fixing the variable. Bad @gmk! 3497627db removing support for lookup by id 5a7d8802a tests needed updating a2afa8353 adding singularity registry functionality to singularity! 92c481aba adding ability to use sregistry (custom) for an endpoint b3cdccdd9 Fix variable names 9745dcc81 Be a bit smarter about the calling UID 2ab119963 improve --contain help message 8fefd710c Make mounting devpts in containers with a minimal /dev the default. 17d08de4a adding test for apps, fixing bug with sinit as well ea61a3f56 Update help files for net namespace 97fc96191 Change options a bit, and add net to containall 7c8306b94 Conditional cookie on base OS build 3e20b0296 Allow a rebuild on an existing sandbox 209ab3d99 Also include the base app directory in the PATH a0496903f Properly exit out on unknown help request 3a8bd5a71 Minor bug/typo fix d32fedf52 Changing the implementation of SCI-F a bit 02ece0f3e Set CLOEXEC with fcntl rather than open flags d2a9c3c17 I see ghosts.... 167ba4178 Comments, wahoo! 6dd2f9ecd Moving more bootstrap specific functions to proper file 1c01b7fe7 Moved APP bootstrap functions into a bootstrap specific functions file 9f6ced4c4 fixing up help scripts f0a064a03 split out runtime parts of singularity rpm into singularity-runtime subrpm a3480dc93 Restore CLOEXEC for image file descriptor, issue #714 is implicitly fixed by commit a44d1932631e137326b280cae94cbdc0e107d4a4 445152390 Add configuration option "autofs bug path" to allow admins to add directories which generate "Too many levels of symbolic links" error in order to fix issues #347 and #757 a44d19326 Open image before entering in mount namespace to address autofs issue #757 980c04798 follow best practices of using one digit for release c6eecd0e4 add Dave Dykstra c366e297c add Dave Dykstra feb8f5351 add sinit, start, and start-suid libexec bin files to rpm 8ac3eae6c When opening network namespace, bring up lo interface cc9d5989e Add initial network namespace support. c1287cdc6 adding application/json to end of header list 483717770 removing C code so the PR is just for the handlers f3c2255ab Fix list indexing, repo is last word of list 0241547fe PEP8 fixes, round 2 e6e51fc9b PEP8 fixes 70940aa1c Add self to AUTHORS file c182f1310 Add support for multiple components in namespace deaed2539 Create a new configuration option to mount a new devpts instance in containers with a minimal /dev. Verify support in the kernel before attempting to mount. 4e2f2c0d7 help was doubled with merge 28f827266 quick fix from @cclerget for read only user binds 7a86e40be updating help docs for commands e957420d7 fixing pep8 issues before they come up a0adf0abd updating scripts to add execution, shell, test, and inspect for apps 7ef9d7335 Revert "Drop capabilities for hosts which don't support PR_SET_NO_NEW_PRIVS to" 38aee3c31 Use new functions to create SINGULARITY_DAEMON_FILE & SESSION_GLOB variables d2a024a98 Add functions to return daemon pid folder or file 1fe485fef Undo copy paste error ca36849ac Create daemon PID location in shell code, catch via registry 553d70067 Move daemon PID file to ~/.singularity/daemon//... 610986b47 when will I learn to test before commit? bbcc51292 style and format changes 9f1001977 Move process management fork into sinit.c 93263c98f Add dummy process to block indefinitely to avoid wait error f7d56ad07 Explicitly set permissions of newroot in environment.tar d8c0c5ec0 SquashFS/build support in progress cc9d84f81 Add test wait call into sinit 731588fae message when env changes during localimage bootstrap 09136b23e adding respect for --name as well 9811445d9 fixing bug with docker pull folder d1079339c Don't remount /dev to avoid clearing nodev partition's flag with a symlink race 67640baf4 Correctly set OVERLAYFS_ENABLED registry value to NULL if disabled or unsupported 814597bf8 Drop capabilities for hosts which don't support PR_SET_NO_NEW_PRIVS to avoid gaining privileges and restoring some features for old systems e3e396c79 Move PID file location from /tmp/ to /var/tmp/ 6a8e191a0 I'm really bad at Makefiles, lol ec846a34e made a mistake in makefile.am formatting on resolving conflicts! 116d10db9 Remove duplicate lines in spec file. 3215b6da9 Remove helpers/printer from spec file. 7221a9ee3 Fixup bash_completion for new help 9224ab5e8 removing help.py, adding checks in help and exec for image, and additional message if no help exists. 8d7e56e77 added archiving of old Singularity bootstrap files 07504c3b1 Removed FD to bind sources (ref: #757) 5e5be8a87 adding optional https to docker 927cd09da need to ensure that .gz is added to custom name, otherwise extraction fails d966ab608 need to updated tests 5643e9bf7 fixing pull 9e211f588 Fix --sh-debug / --shdebug. 2ed19c517 removing extra echo (was leftover from debugging!) 1216449f5 this will be needed for future functions with apps ac2514ac2 removing python dependency from help print, adding to inspect cfdc49293 modified: libexec/cli/apprun.help fd895a550 modified: libexec/cli/apprun.exec baaf3ab45 modified: libexec/bootstrap-scripts/environment/apprun 914c8779d fixing pep8 errors d1584e04f adding apprun.exec, apprun.help, and apprun.c, and apprun! e176c8e83 needs a new line :) 0ada64de0 adding apps list command (eg, singularity apps container.img) 2c48094c3 adding calculation of final size 00f040f08 fixing pep8 issues d0e9212f6 modified: libexec/bootstrap-scripts/post.sh modified: libexec/functions c8397fc4b adding label schema, etc. a78190c84 Add a copy test f832c4b99 Fix attempt/test to hold open autofs (ref: #757) 6602bd8e0 Fix for `singularity copy ... b5d93d437 Fix for `singularity copy ... badc6a2cb added a bit to help docs 839764032 adding get-config executable, and reorganizing handlers into folder ba20f5db1 changing .singularity.d folder to scif, and making possible to create app with only runscript f8f13bb04 Update stop & stop-all output messages e40df2d2f Add help file for stop and stop-all command fe47268c6 Update start to use instance nomenclature b26ead142 Update list to use instance nomenclature d6b5e8529 Update stop & stop-all to use instance nomenclature 9e51644aa Only escalate privs in fork if absolutely necessary 9c57ad363 Separate stop-all into its own command 2e3ce5391 Restructure stop.exec, add argument support 9c0a289e1 Unify start.exec argument options with the help file b8938ccda Make sure daemon join cleans up file it creates 68877245a Add list.help to Makefile.am 23beaaea8 Add help flag to list command 1516fdbfd Add support for options in list command, write help file 3f4d32616 No longer pass UID as arg to sinit, cleanup nomenclature of DAEMON_JOIN in reg 89ed90ea9 Implement proper handling of write error checking 88adc6ad7 Clean up compiler warnings caused by ugly code f4cda2fc2 Fix typo in start.help 5c46085c1 Add help for singularity start command cfd559d2c Edit list command so root user can see which user owns what daemon 0a2141cce Add comments to surpress flawfinder errors in make test a3c78c289 Rework new commands to respect new daemon pid file format f858712d2 Add --join option to action_argparser.sh 6f65b3b35 Update action.c && init.c to respect new daemon.c API fdcc19649 Switch to new singularity_daemon_init function 0b0b2b351 Update all copyright statements to what they should be 27e86018e Add skeleton of better daemon.c code 8b00f5377 Remove signal handler from daemonize fork 329fe7ac6 Move singularity_cleanupd() call after sessiondir() 2a98c6645 Update message to reflect SIGKILL e42e1814e Update singularity list & start to account for optional daemon name param 530316474 Write daemon name to daemon PID file 52df38d57 Change daemon.c functions to follow singularity_ nomenclature 7b6588f64 Install signal handlers in sinit process e6cce0529 Update makefile.am to reflect new command and remove status command d26361ebe Add singularity stop command to stop running daemon 79ba28644 Add singularity list command to show running daemons e4cf6cb45 Ignore flawfinder error fe7834264 Add error checking to call to open e0ada2ca5 Appease Greg 0c2c45589 Remove another missed DAEMON to DAEMON_JOIN call e7fd238cf Change all old registry_get calls from DAEMON to DAEMON_JOIN 4da9cd500 Only attempt to call daemon_rootfs() if DAEMON_JOIN is set ea0c03f9a If no daemon controls the file, remove it d541549c3 Remove calls to unshare in pid.c and instead use flags to singularity_fork_run() 4b3400f3b Check for DAEMON_JOIN in registry instead of DAEMON 49ad0e22c Change DAEMON to DAEMON_JOIN in registry set f580a4049 Move call to singularity_fork[_daemonize]() into pid.c ec0df8f8c Remove code for terminating sinit after x minutes a963e00b1 Clean up code and write rootfs to the daemon file 2f5242bd3 Pass the rootfs through to sinit for writing 2b0e87a2c Add void daemon_rootfs to get the rootfs for the chroot to use f79b393ac Call daemon_rootfs to set the rootfs to what is given in daemon file 86f1d0530 Move fork_daemonize call to start so proc mounts from pid NS 607637d63 Remove unnecessary second call to action_ready from action.c 9e2cd5c22 Move ns debug output outside of privileged execution 2a62f6d9c Update setns call to only join the specific namespace, instead of any e1929eac7 Move call to daemon join after userns and initial priv drop 9357eb99e Add _singularity_runtime_ns_mnt_join for joining when daemon exists 9d885d7f4 Add _singularity_runtime_ns_ipc_join for joining when daemon exists 2ca9a28b3 Run for two minutes 6e473a703 Add debugging output to DEBUG log 77c0b4d7e Add _singularity_runtime_pid_join to join pid of daemon d3a068dee Call _singularity_runtime_ns_join when daemon exists e6818991a Add _singularity_runtime_ns_join for when daemon exists 2df1ad14c Change LOG->DEBUG for messages before fd's close, write directly to file fd 83e1125f5 Reorganize sinit.c to write to file after lock, close open fd's last 5ccbae39b Update file creation mode in filelock to 0644 a10790740 Cleanup sinit inaccuracies, add comment info, make daemon file dir if missing fa6fca93f Add filelock function for better exclusive lock than flock() 1049ac203 Add daemon_join function, fix daemon_path, and update header to match 566dfa322 Fix singularity_registry_get() comparison to integer e9b4fb1d9 Fix singularity_registry_get() comparison to integer 722671d82 Include util/daemon.h in src/action.c 2df4fcf5f Add util/daemon.c to sinit sources in src/Makefile.am 92e21592e Compile with src/util/daemon.c 44fbbf9c2 Call daemon_join from action.c to initiate daemon joining procedure 5aac15d20 Conditionally run functions based on whether a daemon is running or not 45811e815 Split daemon.c into two functions for getting path or setting DAEMON in registry 65916fd88 Utilize daemon_registry_path() from sinit.c for getting daemon_file 0dc042076 Add daemon.c util file for handling of daemon registry vals 89e8d7aa7 Pass host uid through to sinit via singularity_priv_getuid() 32e11e971 Call singularity_cleanupd() from start.c fc9e14af6 Ensure that UNSHARE_PID is set in registry in start.c f3353f33b Add break to exit from daemon loop to prevent hanging daemon (debugging) 22fbf683b Add missing newline char in debug message 1d05fb5cc Call fork() instead of singularity_fork(); not safely handled yet 95e1e4c59 Add path to sinit binary for execv in start.c 2e67ea7ec Update makefiles and configure.ac to build start(-suid) and sinit binaries 9ec415c4c Edit .gitignore to ignore new build artifacts in src/ 88744c4e7 Add cli file for start command 9dc297930 Call singularity_fork_daemonize from sinit and add barebones daemon loop 6fbf3c8df Add singularity_fork_daemonize function to properly daemonize 19edbd9b4 Add sinit file for running PID 1 inside PID NS 7cdefb0f8 Add start.c file for singularity start 64958ae86 skipping /boot filesystem location when mounting hostfs 6be0eb319 updating app install to also save defile and calculate size as a label 7753d7c49 removed redundant checks on SINGULARITY_BUILDDEF 0a8e0a803 updating PR to have organization of apps and data under /scif 48d14f0a7 fixing copyright 9bb78cc32 needed a \ 461a18245 added driver to Makefile 5d7635fdd added a test for the new feature e9ce48fc9 added to bootstrap help af59f0372 adding support for 'localimage' Bootstrap: tag 5acba5512 Updated docs a20c2f1db Added as a contributor fe0503777 Fix to SLURM Singularity plugin 335ca4515 moving files into apps .singularity.d folder -like little singularity images! beec65069 adding custom environment %appenv to applications 20b68e05d adding labels generation fb4cc1919 adding %appfiles section 31ef417f4 fixing issue with app installation - now works! ba460b5df empty space eww 533ccc536 commenting out change of directory for now 9467fa19f modified: libexec/functions 8fc043bba adding basic requirements for an app install a548fddf2 Fix grep in action_argparser.sh c9f87a090 modified: .github/SUPPORT.md 0a4937728 adding SUPPORT.md to docs 8d9acde6f Only check offset for Singularity images (and relevant fixes, ref: #820) a0bcc3610 Fix check for image type before image offset calculation 9031649c7 moving $SINGULARITY_ENVIRONMENT to deffile-sections.sh 4ab978682 Only check offset for Singularity images (and relevant fixes, ref: #820) f85e7bad7 Minor indention fix 29be0ee9c Move test_init call below check for flawfinder executable. eebb26d2d changing strategy to something more sensible e7621e2c1 fixing a silly mistake 19cb53610 added env variable to post section for users to echo env to c0a7810f7 Fix check for image type before image offset calculation 4061bed2e Exit if flawfinder isn't found. 680d494ea Include support for `make test` in dist tarballs 674d93026 Include support for `make test` in dist tarballs bcc3275e9 Add missing MS_NODEV and fix code indent b0a194c0e Force OVERLAYFS_ENABLED to NULL if not supported dfbe57d0d Avoid host filesystems information leak 873c5a40e Remove unused sessiondir in import/export actions 80f70892e finalizing pep8 b835d1be6 fixing pep8 issues 04b11d660 adding check for ALL tags, using all will run all tests 9f62e747f updating license infos 99922365f don't need pep8 on travis 381bd69c1 fixing bug bfd64c5ca let's just use pep8speaks 42e5a9ecf we need to ignore old singularity folder fb7dde26c derp a derp fd68cface here you go, robot 3670e100f last changes to configure_transform ae17ddbe9 pep8 for tests 212e35c56 removing self bootstrap (this should be for another PR) 4dad293b5 modified: libexec/python/base.py f29ff801b more fixes for pep8 2771e38ef fixing up pep8 errors b3f87ac45 finishing up docker db1e1d51f fixes to shub, docker next! b337b4d97 finishing up helpers/json folder 050285f97 first set of changes for python/pep8 cadde68bc adding history and profile checks, and making "bootstrap" default tag for bootstrap 2e6c73462 adding checks to bootstrap,will follow with examples 024ac67f0 we need to NOT flag for bashrc and profile 61b4e4c33 redundant 5cb03f1a3 needs a space, lord am I typeA 806f4a609 leave in script name ! c8a04d2fe modified: libexec/functions 1305d7e9e adding docker (and sudo needed) example c9c726e93 adding tags check 19092ef20 updating docs, and fixing bug so we are running checks from SINGULARITY_ROOTFS 05ef6eecc adding example for cve and cache checking a68ae6447 WORKDIR and CONTAINLIBS requires NO_NEW_PRIVS support e87d10442 Drop privileges in case of error d70ee86fb Enforce MS_NODEV with mount c675a3fc2 Fix setting registry key values 49ccf898a WORKDIR and CONTAINLIBS requires NO_NEW_PRIVS support 94521d217 Drop privileges in case of error e2a8f7a99 Enforce MS_NODEV with mount 8f25a0391 Fix setting registry key values 0e75f50a0 Change fork_ns stack size to static 1M 00363365c If singularity_fork is called as root, don't escalate and drop privs before the fork ed4716bde Update calls to _fork() function family to match new API 69721ac21 Overhaul fork.c, use clone instead of fork, add comments fde1ea94b fixing test so that correct file is checked (again) 577318290 fixing test so that correct file is checked f80a65535 fixing link so that /environment is honored 37828acbc Better debug output for s_mkdir() f2b76cb4c Better debug output for s_mkdir() 5d7a0fd5b Replacing nested loop by grep -f 77c429bde adding level pass/fail printing and actually running scripts d7a98cb26 update to docker api to give error message before attempting bootstrap when errors present (and image doesn't exist) d7dcaf598 Adding nvidia-smi to `--nv` include (ref: #611) 48ea7e286 Always check whether mktemp was successful b60fe0d9c Honor $TMPDIR instead of hardcoding /tmp 8b0536fb7 making nvidia libs configurable by user bc64d661f Change installation directory to OS local packages. 90bebd3a4 Update installation procedures for Git repository cad053962 Update installation procedure to use 2.3.1 f0b8ef97a adding start of checks idea e5554ad52 modified: libexec/python/shub/api.py 41eabb65a fixing issue with download of singularity hub image not done being built yet 6a8a15320 Fix --nv option d2cbd515b Fix spelling of existent. ed16060df Adding inspect to singularity help 2141ef970 modified: examples/self/Singularity modified: libexec/bootstrap-scripts/deffile-driver-self.sh 5f7c7dab8 modified: ../../libexec/bootstrap-scripts/deffile-driver-self.sh 5c0221be1 updating driver to have exclude option 727a8ea98 starting test for self bootstrap af9e5052d Patch to fix slurm plugin build d6d33b578 Fix spelling of existent. a47422cc5 Comment the non-use of CLOEXEC (ref: #714) b1d0cbafd Remove FD_CLOEXEC option on image (ref: #714) e214d4ebf Bump version to 3.6.1 1200a71fe added inspect command to help doc a96b382ff adding example for raspbian 9dcd3a09d Adding arch variable to debootstrap cc8bfb2dc No need to create the base cachedir unless it is needed (ref: #763) a0ad26d6f Fixed placements of umask 34d6af20d Fixed bug with umasks e974d77a4 Change wording slightly ca3761fd3 Error out on duplicate bootstrap definition file keys (ref: #706) 4dd3bff6d Return more standardly in from envar_defined() 64041ee6b modified: libexec/python/shub/api.py c61f2adf1 adding fixes to download of shub container to close #752 af1475bc5 * Only set default SINGULARITYENV_PATH if it's not set in the environment * Add myself to AUTHORS file as requested in the PR rules 50bb1c9e3 fixing bug so that container not found on shub (404) prints user friendly message 1bd6d5a89 Fix install proceedure to include a release tarball (ref: #746) 14480c2a9 Change the order of bind directory parsing (ref: #743) 6755b2f4f Changing the order of %files and %environment to come before %post (ref: #674) 25cd7a1cf Adding nvidia-smi to `--nv` include (ref: #611) 7355eeec1 Don't keep FDs associated with parent when debugging cleanupd (ref: #731) f1a0bb01c Added ability to return current messagelevel 308ae8542 Comment the non-use of CLOEXEC (ref: #714) 2d0d1236e Udpate file.h header to match chk_mode function signature a47df0574 Update call to chk_mode with mask to ignore SETGID/SETUID 0c6ac0f8f Add mask support to chk_mode() 987900a4e Remove FD_CLOEXEC option on image (ref: #714) 7c02cb1f7 Resetting Docker username and password for bootstrap (ref: #726) ee5bc5917 Updated Arch deffile per https://github.com/czka/singularity/blob/master/examples/arch.def (ref: #454) 5862f16bf Allow @ sign to be included in path names Signed-off-by: Bruce Ashfield

linux/meta-virtualization.git/recipes-containers/singularity, branch container-cross-install

WIP: DO NOT MERGE. singularity update to go

singulartiy: update to v3.8.3

containers: adapt to UNPACKDIR changes

recipes/classes/scripts: Drop SRCPV usage

treewide: bulk update patches with status field

singularity: Drop explicit runtime dep glibc

singularity: fix build with automake-1.16.5

global: add explicit branch to all SRC_URIs

singularity: update generic "BSD" license specification

global: overrides syntax conversion