summaryrefslogtreecommitdiffstats
path: root/meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch')
-rw-r--r--meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch120
1 files changed, 120 insertions, 0 deletions
diff --git a/meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch b/meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch
new file mode 100644
index 0000000000..37d5ba47c7
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python3-werkzeug/CVE-2024-34069-0002.patch
@@ -0,0 +1,120 @@
1From 890b6b62634fa61224222aee31081c61b054ff01 Mon Sep 17 00:00:00 2001
2From: David Lord <davidism@gmail.com>
3Date: Fri, 3 May 2024 14:49:43 -0700
4Subject: [PATCH] only require trusted host for evalex
5
6CVE: CVE-2024-34069
7
8Upstream-Status: Backport [https://github.com/pallets/werkzeug/commit/890b6b62634fa61224222aee31081c61b054ff01]
9
10Signed-off-by: Soumya Sambu <soumya.sambu@windriver.com>
11---
12 src/werkzeug/debug/__init__.py | 25 ++++++++++++++++++++-----
13 src/werkzeug/sansio/utils.py | 2 +-
14 2 files changed, 21 insertions(+), 6 deletions(-)
15
16diff --git a/src/werkzeug/debug/__init__.py b/src/werkzeug/debug/__init__.py
17index 87e68c4..0302b24 100644
18--- a/src/werkzeug/debug/__init__.py
19+++ b/src/werkzeug/debug/__init__.py
20@@ -16,7 +16,9 @@ from zlib import adler32
21
22 from .._internal import _log
23 from ..exceptions import NotFound
24+from ..exceptions import SecurityError
25 from ..http import parse_cookie
26+from ..sansio.utils import host_is_trusted
27 from ..security import gen_salt
28 from ..utils import send_file
29 from ..wrappers.request import Request
30@@ -331,7 +333,7 @@ class DebuggedApplication:
31
32 is_trusted = bool(self.check_pin_trust(environ))
33 html = tb.render_debugger_html(
34- evalex=self.evalex,
35+ evalex=self.evalex and self.check_host_trust(environ),
36 secret=self.secret,
37 evalex_trusted=is_trusted,
38 )
39@@ -359,10 +361,16 @@ class DebuggedApplication:
40 frame: t.Union[DebugFrameSummary, _ConsoleFrame],
41 ) -> Response:
42 """Execute a command in a console."""
43+ if not self.check_host_trust(request.environ):
44+ return SecurityError() # type: ignore[return-value]
45+
46 return Response(frame.eval(command), mimetype="text/html")
47
48 def display_console(self, request: Request) -> Response:
49 """Display a standalone shell."""
50+ if not self.check_host_trust(request.environ):
51+ return SecurityError() # type: ignore[return-value]
52+
53 if 0 not in self.frames:
54 if self.console_init_func is None:
55 ns = {}
56@@ -411,12 +419,18 @@ class DebuggedApplication:
57 return None
58 return (time.time() - PIN_TIME) < int(ts)
59
60+ def check_host_trust(self, environ: WSGIEnvironment) -> bool:
61+ return host_is_trusted(environ.get("HTTP_HOST"), self.trusted_hosts)
62+
63 def _fail_pin_auth(self) -> None:
64 time.sleep(5.0 if self._failed_pin_auth > 5 else 0.5)
65 self._failed_pin_auth += 1
66
67 def pin_auth(self, request: Request) -> Response:
68 """Authenticates with the pin."""
69+ if not self.check_host_trust(request.environ):
70+ return SecurityError() # type: ignore[return-value]
71+
72 exhausted = False
73 auth = False
74 trust = self.check_pin_trust(request.environ)
75@@ -466,8 +480,11 @@ class DebuggedApplication:
76 rv.delete_cookie(self.pin_cookie_name)
77 return rv
78
79- def log_pin_request(self) -> Response:
80+ def log_pin_request(self, request: Request) -> Response:
81 """Log the pin if needed."""
82+ if not self.check_host_trust(request.environ):
83+ return SecurityError() # type: ignore[return-value]
84+
85 if self.pin_logging and self.pin is not None:
86 _log(
87 "info", " * To enable the debugger you need to enter the security pin:"
88@@ -483,8 +500,6 @@ class DebuggedApplication:
89 # form data! Otherwise the application won't have access to that data
90 # any more!
91 request = Request(environ)
92- request.trusted_hosts = self.trusted_hosts
93- assert request.host # will raise 400 error if not trusted
94 response = self.debug_application
95 if request.args.get("__debugger__") == "yes":
96 cmd = request.args.get("cmd")
97@@ -496,7 +511,7 @@ class DebuggedApplication:
98 elif cmd == "pinauth" and secret == self.secret:
99 response = self.pin_auth(request) # type: ignore
100 elif cmd == "printpin" and secret == self.secret:
101- response = self.log_pin_request() # type: ignore
102+ response = self.log_pin_request(request) # type: ignore
103 elif (
104 self.evalex
105 and cmd is not None
106diff --git a/src/werkzeug/sansio/utils.py b/src/werkzeug/sansio/utils.py
107index 1b4d892..7e7b4d2 100644
108--- a/src/werkzeug/sansio/utils.py
109+++ b/src/werkzeug/sansio/utils.py
110@@ -6,7 +6,7 @@ from ..urls import uri_to_iri
111 from ..urls import url_quote
112
113
114-def host_is_trusted(hostname: str, trusted_list: t.Iterable[str]) -> bool:
115+def host_is_trusted(hostname: str | None, trusted_list: t.Iterable[str]) -> bool:
116 """Check if a host matches a list of trusted names.
117
118 :param hostname: The name to check.
119--
1202.40.0