diff options
| author | Hongxu Jia <hongxu.jia@windriver.com> | 2018-07-27 10:49:00 +0800 |
|---|---|---|
| committer | Khem Raj <raj.khem@gmail.com> | 2018-07-27 13:49:48 -0700 |
| commit | 59a2da1668cb9edb56f42f100e89992466203aa0 (patch) | |
| tree | 86597cda0b5d2da12da3e58df39ce259becb7ba6 | |
| parent | 3dc82fc2ebb8d8e86f46c95e4dc76a230e03a1e8 (diff) | |
| download | meta-openembedded-59a2da1668cb9edb56f42f100e89992466203aa0.tar.gz | |
rsyslog: fix race in parallel builds
If libgcry.la is built later than lmcry_gcry.la, there is a failure:
[snip]
|../aarch64-wrs-linux-libtool --tag=CC --mode=link aarch64-wrs-linux-gcc
-o lmcry_gcry.la lmcry_gcry_la-lmcry_gcry.lo libgcry.la -lgcrypt
|aarch64-wrs-linux-libtool: error: cannot find the library 'libgcry.la'
or unhandled argument 'libgcry.la'
|Makefile:1049: recipe for target 'lmcry_gcry.la' failed
|make[2]: *** [lmcry_gcry.la] Error 1
[snip]
The LIBADD of lmcry_gcry.la contains libgcry.la, we should also add libgcry.la
to lmcry_gcry.la's DEPENDENCIES.
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
| -rw-r--r-- | meta-oe/recipes-extended/rsyslog/rsyslog/fix-race-in-parallel-builds.patch | 41 | ||||
| -rw-r--r-- | meta-oe/recipes-extended/rsyslog/rsyslog_8.36.0.bb | 1 |
2 files changed, 42 insertions, 0 deletions
diff --git a/meta-oe/recipes-extended/rsyslog/rsyslog/fix-race-in-parallel-builds.patch b/meta-oe/recipes-extended/rsyslog/rsyslog/fix-race-in-parallel-builds.patch new file mode 100644 index 0000000000..a1efe4d4bf --- /dev/null +++ b/meta-oe/recipes-extended/rsyslog/rsyslog/fix-race-in-parallel-builds.patch | |||
| @@ -0,0 +1,41 @@ | |||
| 1 | From 7f003e3a7d4d6dda1cbca1694b62754878c58df0 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Hongxu Jia <hongxu.jia@windriver.com> | ||
| 3 | Date: Fri, 27 Jul 2018 10:19:29 +0800 | ||
| 4 | Subject: [PATCH] fix race in parallel builds | ||
| 5 | |||
| 6 | If libgcry.la is built later than lmcry_gcry.la, there is a failure: | ||
| 7 | [snip] | ||
| 8 | |../aarch64-wrs-linux-libtool --tag=CC --mode=link aarch64-wrs-linux-gcc | ||
| 9 | -o lmcry_gcry.la lmcry_gcry_la-lmcry_gcry.lo libgcry.la -lgcrypt | ||
| 10 | |aarch64-wrs-linux-libtool: error: cannot find the library 'libgcry.la' | ||
| 11 | or unhandled argument 'libgcry.la' | ||
| 12 | |Makefile:1049: recipe for target 'lmcry_gcry.la' failed | ||
| 13 | |make[2]: *** [lmcry_gcry.la] Error 1 | ||
| 14 | [snip] | ||
| 15 | |||
| 16 | The LIBADD of lmcry_gcry.la contains libgcry.la, we should also add libgcry.la | ||
| 17 | to lmcry_gcry.la's DEPENDENCIES. | ||
| 18 | |||
| 19 | Upstream-Status: Submitted [https://github.com/rsyslog/rsyslog/pull/2882] | ||
| 20 | |||
| 21 | Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> | ||
| 22 | --- | ||
| 23 | runtime/Makefile.am | 2 +- | ||
| 24 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
| 25 | |||
| 26 | diff --git a/runtime/Makefile.am b/runtime/Makefile.am | ||
| 27 | index 56bc08e..5ada0c4 100644 | ||
| 28 | --- a/runtime/Makefile.am | ||
| 29 | +++ b/runtime/Makefile.am | ||
| 30 | @@ -202,7 +202,7 @@ if ENABLE_LIBGCRYPT | ||
| 31 | libgcry_la_SOURCES = libgcry.c libgcry_common.c libgcry.h | ||
| 32 | libgcry_la_CPPFLAGS = $(RSRT_CFLAGS) $(LIBGCRYPT_CFLAGS) | ||
| 33 | pkglib_LTLIBRARIES += lmcry_gcry.la | ||
| 34 | - lmcry_gcry_la_DEPENDENCIES = librsyslog.la | ||
| 35 | + lmcry_gcry_la_DEPENDENCIES = librsyslog.la libgcry.la | ||
| 36 | lmcry_gcry_la_SOURCES = lmcry_gcry.c lmcry_gcry.h | ||
| 37 | lmcry_gcry_la_CPPFLAGS = $(RSRT_CFLAGS) $(LIBGCRYPT_CFLAGS) | ||
| 38 | lmcry_gcry_la_LDFLAGS = -module -avoid-version \ | ||
| 39 | -- | ||
| 40 | 2.7.4 | ||
| 41 | |||
diff --git a/meta-oe/recipes-extended/rsyslog/rsyslog_8.36.0.bb b/meta-oe/recipes-extended/rsyslog/rsyslog_8.36.0.bb index 386ad32101..9737892018 100644 --- a/meta-oe/recipes-extended/rsyslog/rsyslog_8.36.0.bb +++ b/meta-oe/recipes-extended/rsyslog/rsyslog_8.36.0.bb | |||
| @@ -24,6 +24,7 @@ SRC_URI = "http://www.rsyslog.com/download/files/download/rsyslog/${BPN}-${PV}.t | |||
| 24 | file://use-pkgconfig-to-check-libgcrypt.patch \ | 24 | file://use-pkgconfig-to-check-libgcrypt.patch \ |
| 25 | file://run-ptest \ | 25 | file://run-ptest \ |
| 26 | file://rsyslog-fix-ptest-not-finish.patch \ | 26 | file://rsyslog-fix-ptest-not-finish.patch \ |
| 27 | file://fix-race-in-parallel-builds.patch \ | ||
| 27 | " | 28 | " |
| 28 | 29 | ||
| 29 | SRC_URI_append_libc-musl = " \ | 30 | SRC_URI_append_libc-musl = " \ |
