diff options
| author | Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com> | 2026-03-14 17:47:49 +0530 |
|---|---|---|
| committer | Khem Raj <raj.khem@gmail.com> | 2026-03-18 14:33:24 -0700 |
| commit | 9f5c6b28e33381c0530a338c6a3e90bbc1022d51 (patch) | |
| tree | b8a95b048a24ea7fb063f0f3d12b54c8e15fc0cf | |
| parent | c40a15d924e593c7ee3cb4e29de80c49035b20e2 (diff) | |
| download | meta-openembedded-9f5c6b28e33381c0530a338c6a3e90bbc1022d51.tar.gz | |
android-tools: add fix for strchr() conformance to C23
Building android-tools v29.0.6.r14 with glibc 2.43 fails due to ISO C23
changes to strchr(). Add a patch to update the affected libunwind sources
to use const pointer types to fix this build failure.
Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2 files changed, 28 insertions, 0 deletions
diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools/debian/external/libunwind/libunwind-fix-strchr-conformance-to-ISO-C23.patch b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools/debian/external/libunwind/libunwind-fix-strchr-conformance-to-ISO-C23.patch new file mode 100644 index 0000000000..4da65ea285 --- /dev/null +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools/debian/external/libunwind/libunwind-fix-strchr-conformance-to-ISO-C23.patch | |||
| @@ -0,0 +1,27 @@ | |||
| 1 | From d91f5324f809c3a5b0343927716e4b99bc31db53 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com> | ||
| 3 | Date: Fri, 13 Mar 2026 18:57:36 +0530 | ||
| 4 | Subject: [PATCH] libunwind: fix strchr() conformance to ISO C23 | ||
| 5 | |||
| 6 | Fix uses of strchr() to conform to ISO C23, supported since glibc-2.43 | ||
| 7 | |||
| 8 | Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com> | ||
| 9 | Upstream-Status: Pending | ||
| 10 | --- | ||
| 11 | external/libunwind/src/dwarf/Gfind_proc_info-lsb.c | 3 ++- | ||
| 12 | 1 file changed, 2 insertions(+), 1 deletion(-) | ||
| 13 | |||
| 14 | diff --git a/external/libunwind/src/dwarf/Gfind_proc_info-lsb.c b/external/libunwind/src/dwarf/Gfind_proc_info-lsb.c | ||
| 15 | index 77ed3d09..37eadf52 100644 | ||
| 16 | --- a/external/libunwind/src/dwarf/Gfind_proc_info-lsb.c | ||
| 17 | +++ b/external/libunwind/src/dwarf/Gfind_proc_info-lsb.c | ||
| 18 | @@ -248,7 +248,8 @@ load_debug_frame (const char *file, char **buf, size_t *bufsize, | ||
| 19 | |||
| 20 | if (*buf == NULL && linkbuf != NULL && memchr (linkbuf, 0, linksize) != NULL) | ||
| 21 | { | ||
| 22 | - char *newname, *basedir, *p; | ||
| 23 | + char *newname, *basedir; | ||
| 24 | + const char *p; | ||
| 25 | static const char *debugdir = "/usr/lib/debug"; | ||
| 26 | int ret; | ||
| 27 | |||
diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb index 74928ed171..3d4e95b496 100644 --- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb | |||
| @@ -22,6 +22,7 @@ SRC_URI += " \ | |||
| 22 | file://debian/external/libunwind/legacy_built-in_sync_functions.patch \ | 22 | file://debian/external/libunwind/legacy_built-in_sync_functions.patch \ |
| 23 | file://debian/external/libunwind/20150704-CVE-2015-3239_dwarf_i.h.patch \ | 23 | file://debian/external/libunwind/20150704-CVE-2015-3239_dwarf_i.h.patch \ |
| 24 | file://debian/external/libunwind/libunwind-guard-unreachable-macro-to-avoid-redefinit.patch \ | 24 | file://debian/external/libunwind/libunwind-guard-unreachable-macro-to-avoid-redefinit.patch \ |
| 25 | file://debian/external/libunwind/libunwind-fix-strchr-conformance-to-ISO-C23.patch \ | ||
| 25 | \ | 26 | \ |
| 26 | file://debian/system/core/move-log-file-to-proper-dir.patch \ | 27 | file://debian/system/core/move-log-file-to-proper-dir.patch \ |
| 27 | file://debian/system/core/Added-missing-headers.patch \ | 28 | file://debian/system/core/Added-missing-headers.patch \ |
