| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| |
| | |
lucianogdittgen/oelint-cleanup-10-recipe-metadata-6
oelint: Class/anon-python docstrings, image and packagegroup metadata
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move the PACKAGECONFIG block up beside the fetch variables so it
precedes PACKAGE_ARCH (oelint.var.order.PACKAGECONFIG).
Accept two findings inline: PV:append must join without a leading space
to remain a valid version string (oelint.vars.inconspaces false
positive), and the arm-cot/secure consistency check needs a parse-time
anonymous python (oelint.task.noanonpython).
No functional change.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For the dummy imx-test_00.00.00 placeholder, give DESCRIPTION distinct
wording (no longer identical to SUMMARY) and set an explicit empty
SRC_URI (it is an ALLOW_EMPTY package with no upstream sources), which
satisfies the mandatory-variable check honestly.
For imx-test_git, move FILES:${PN}-dbg above RDEPENDS into the canonical
variable order.
In both recipes the LIC_FILES_CHKSUM references the common-licenses copy
because the license text is not shipped in the source tree; this
intentional local (non-remote) reference is documented with an inline
nooelint suppression.
No functional change; pure recipe-metadata cleanup.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Expand DESCRIPTION so it is no longer briefer than SUMMARY, and in the
.bb move FILES:${PN}-crrm above RDEPENDS (canonical order) while using an
append so it no longer overrides the package file list.
The base DEPENDS assignment in the .inc keeps a plain '=' and is
documented with an inline nooelint suppression: the .inc is the canonical
definition of the library's build dependencies and the require sits at
the top of the .bb, so oelint's 'append after include' heuristic is a
false positive here.
No functional change; pure recipe-metadata cleanup.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |/
|
|
|
|
|
|
|
|
|
|
| |
Add a SUMMARY (distinct from the existing DESCRIPTION) to resolve the
mandatory-variable finding, and reorder into the canonical oelint
variable order: SECTION before LICENSE/LIC_FILES_CHKSUM, SRC_URI before
SRCREV, and EXTRA_OECONF moved below the PACKAGECONFIG definitions it
consumes (PACKAGECONFIG before EXTRA_OECONF).
No functional change; pure recipe-metadata cleanup.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
oelint-adv flagged a missing DESCRIPTION, a suggested SECTION, and the
INSANE_SKIP use.
Add DESCRIPTION and SECTION. The INSANE_SKIP is required for the
prebuilt PFE firmware blobs (foreign target arch, already stripped), so
accept it with an inline '# nooelint: oelint.vars.insaneskip' and a
rationale comment. Metadata-only change; the built package is unaffected.
oelint-adv now reports no findings for this recipe.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
oelint-adv flagged a missing DESCRIPTION, a suggested SECTION,
PACKAGE_ARCH after FILES, and 'cp' used in do_install.
Add DESCRIPTION and SECTION, move PACKAGE_ARCH ahead of the PACKAGES/
FILES block, and replace the recursive 'cp' in do_install with
'install -m 0644' (the upstream firmware tree is flat, so no recursion
is needed). Functionally equivalent; the same files land in /boot.
oelint-adv now reports no findings for this recipe.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
oelint-adv flagged a missing DESCRIPTION, a suggested SECTION, DEPENDS
appearing after SRCREV, and PACKAGE_ARCH after FILES.
Add DESCRIPTION and SECTION, move DEPENDS ahead of the fetch variables,
and move PACKAGE_ARCH ahead of the PACKAGES/FILES block as oelint
expects. Metadata-only change; the built package is unaffected.
oelint-adv now reports no findings for this recipe.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
oelint-adv flagged a missing DESCRIPTION, a suggested SECTION, and
PACKAGE_ARCH appearing after FILES.
Add DESCRIPTION and SECTION and move PACKAGE_ARCH ahead of the PACKAGES/
FILES block as oelint expects. Metadata-only change; the built package
is unaffected.
oelint-adv now reports no findings for this recipe.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
oelint-adv flagged a missing SUMMARY, a suggested SECTION, and
LICENSE/SRC_URI/PV appearing out of the expected order.
Add SUMMARY and SECTION, move LICENSE ahead of DEPENDS, and reorder the
fetch variables to PV / SRC_URI / SRCREV as oelint expects. Metadata-only
change; the built package is unaffected.
oelint-adv now reports no findings for this recipe.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY, expand DESCRIPTION, and move SECTION
ahead of LICENSE/LIC_FILES_CHKSUM.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and move SECTION ahead of
LICENSE/LIC_FILES_CHKSUM.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and expand DESCRIPTION accordingly.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and set SECTION in the shared
qoriq-atf-2.12.inc, covering both qoriq-atf and qoriq-atf-tools, and
expand DESCRIPTION so it is more descriptive than the summary.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE, expand DESCRIPTION, and
move SECTION ahead of LICENSE/LIC_FILES_CHKSUM.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE, expand DESCRIPTION, and
move SECTION ahead of LICENSE.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory DESCRIPTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and expand DESCRIPTION so it is more
descriptive than the summary.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory HOMEPAGE.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory DESCRIPTION and HOMEPAGE, set SECTION, and
move PACKAGE_ARCH ahead of the PACKAGES/FILES block.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE, set SECTION and move
PACKAGE_ARCH ahead of FILES.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE and set SECTION.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Add the missing mandatory SUMMARY and HOMEPAGE, set SECTION, give
DESCRIPTION distinct wording, and move PACKAGE_ARCH ahead of FILES.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Remove a consecutive blank line (oelint.newline.consecutive). No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Remove a consecutive blank line (oelint.newline.consecutive). No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Remove a consecutive blank line (oelint.newline.consecutive). No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
| |
Order DEPENDS alphabetically per oelint.vars.dependsordered. No
functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
meta-freescale used columnar alignment (multiple spaces padding the
variable name out to a common column) for tables of assignments such as
the fsl-eula-unpack MD5 sums and PACKAGECONFIG[...] entries. The Yocto
Recipe Style Guide and oelint-adv (oelint.vars.spacesassignment) call for
a single space around the assignment operator.
Collapse the padding to a single space on every flagged assignment. The
change is purely whitespace around the operator: variable names, operators
and values (including whitespace inside quoted values) are untouched, as
confirmed by an empty 'git diff -w'.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Where several versioned recipes share an .inc that already carries the
common metadata (SUMMARY/DESCRIPTION/LICENSE), set HOMEPAGE there once
instead of duplicating it in each .bb: imx-secure-enclave, secure-obj,
qoriq-atf, and u-boot-fslc-common. Removes nine duplicate assignments;
oelint-adv still resolves HOMEPAGE for every consumer via the include.
Recipes whose include carries no metadata (imx-mkimage) or is shared by
different upstreams (linux-imx.inc, used by both linux-fslc and
linux-imx) keep HOMEPAGE in the .bb.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
Add the mandatory HOMEPAGE to recipes whose upstream repository was not a
plain github/gitlab URL in SRC_URI: those using a source variable or an
included .inc (resolved to the real NXP/Freescale repo), and those hosted
elsewhere (denx, SourceForge, dpdk.org, freedesktop, jhauser). Clears the
oelint-adv oelint.var.mandatoryvar.HOMEPAGE error for these recipes.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the mandatory HOMEPAGE to recipes that were missing it, using each
recipe's own upstream git repository (github.com/gitlab.com) taken from
its SRC_URI. Clears the oelint-adv oelint.var.mandatoryvar.HOMEPAGE
error for these recipes.
Only recipes with a single, unambiguous upstream repo were set
automatically; recipes with multiple repos in SRC_URI (a main source
plus dependency/patch repos) were resolved by hand or left for a
maintainer, to avoid pointing HOMEPAGE at a dependency.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
| |
Change SECTION from "BSP" to "bsp" in five recipes; SECTION is
conventionally lowercase. Applied via oelint-adv's auto-fix for a single
rule (oelint.vars.sectionlowercase). No functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
Add the mandatory HOMEPAGE, taken from the recipe's SRC_URI upstream
(github.com/nxp-qoriq-yocto-sdk/fsl-tlu), clearing the oelint-adv
oelint.var.mandatoryvar.HOMEPAGE error. The remaining findings are
info-level suggestions (BUGTRACKER, CVE_PRODUCT, SECTION, BBCLASSEXTEND
on a machine-specific test package).
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Align the continuation lines of multi-line variable assignments, as
suggested by oelint-adv's auto-fix for a single rule
(oelint.vars.multilineident), isolated to one commit.
The auto-fix strips the leading space from a value's first line, which
for a ':append' is a required separator; those five recipes had their
leading space restored by hand, so ':append'/':prepend' concatenation
is unchanged. A few multi-line values (e.g. DESCRIPTION) gain internal
whitespace, which is cosmetic and collapses on display.
Build-tested: parsing all 2948 recipes for an i.MX machine reports
0 errors. A residual set (the restored ':append' recipes, whose
separator space oelint cannot reconcile with its indent preference,
plus opencv/dpdk where oelint's own fix does not satisfy its checker)
is left for per-recipe handling.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Convert leading-tab indentation to spaces in shell task bodies across
the layer. Generated mechanically by oelint-adv's auto-fix for a single
rule (oelint.tabs.notabs), isolated to one commit.
Verified safe: every change is leading indentation of shell/BitBake code
(no mid-line tabs, and none of the affected files contain heredocs where
a tab would be significant), so there is no functional change.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the stray space between an assignment's opening quote and its
line-continuation backslash, and the space before '%' in inline
${@...} expressions. Generated mechanically by oelint-adv's auto-fix
for a single rule (oelint.vars.notneededspace), isolated to one commit.
The affected values are whitespace-separated lists (leading space is
insignificant) and Python format expressions ("%s"% p is equivalent),
so there is no functional change; a re-run of oelint-adv reports the
rule clean.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Remove trailing whitespace across the layer's recipes. Generated
mechanically by oelint-adv's auto-fix for a single rule
(oelint.spaces.lineend), isolated to one commit so the mechanical
change is easy to review and revert.
Pure whitespace removal with no semantic effect; a re-run of
oelint-adv reports the rule clean. No build change expected.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
Normalize list continuations, append spacing, quote style, and simple
flag values so the metadata follows oelint BitBake syntax expectations.
Tested with: git diff --check.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
| |
Replace cp with install in do_install paths so installed files get
explicit permissions and satisfy oelint install-task checks.
Tested with: git diff --check.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
The NXP Wi-Fi firmware packages are used by boards with NXP Wi-Fi modules even when the main SoC is not i.MX. Commit 8e7ebc0 removed the machine restriction for that reason, but it was later reintroduced while cleaning up BSP metadata.
Drop COMPATIBLE_MACHINE again so package dependencies decide whether the firmware is used.
Tested with git diff --check.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
| |
The firmware is only used by i.MX BSP machines.
Set COMPATIBLE_MACHINE so the recipe is skipped outside the i.MX machine family instead of being exposed to unrelated BSPs.
Tested as part of the series with bitbake -p and yocto-check-layer.
Signed-off-by: Luciano Dittgen <luciano.dittgen@ossystems.com.br>
|
| |
|
|
|
|
|
|
|
|
|
| |
Dependencies listed via do_compile[depends] are invisible to the SBOM script
from OpenEmbedded.
List the build-time dependencies for imx-boot in the DEPENDS variable instead,
while preserving the required task order, allowing these components to be
automatically included in the imx-boot SBOM.
Signed-off-by: Leonardo Costa <leonardo.costa@toradex.com>
|
| |
|
|
|
|
|
|
|
|
| |
The scmi_imx9 source declares a tmp pointer that is never read.
The newer GCC version 16.1.0 treats the unused pointer as
-Wunused-but-set-variable. With -Werror, this breaks the build.
Add a patch to remove the unused tmp pointer.
Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
|