linux/meta-freescale.git/dynamic-layers/qt4-layer, branch master

oelint: Suppress noncoreoverride on the machine-gated bbappend idiom

2026-08-07T12:30:00+00:00

oelint.vars.noncoreoverride flags every statement in a bbappend that carries no MACHINE or DISTRO override suffix, because an unconditional override of core behaviour fails yocto-check-layer. The check is purely syntactic: it cannot see that a statement's effective value is already machine-gated, which is exactly how most of this layer is written. DRM-REMOVE = "" <- flagged DRM-REMOVE:imxgpu:mx6-nxp-bsp = "drm-gl drm-gles2" PACKAGECONFIG:remove = "${DRM-REMOVE}" <- flagged Neither line can be scoped. A fallback default cannot carry an override for the machines it is the fallback for, and the dispatch line that consumes it is a no-op wherever the helper expands empty. Scoping them anyway would damage correct metadata: weston-init reads HAS_G2D as "elif ${HAS_G2D};" in shell, where an empty value is a syntax error. Suppress the 58 sites proven inert, each with its own rationale. The proof is a bitbake -e comparison on MACHINE=qemuarm64 -- a machine this layer does not own -- with meta-freescale in and out of BBLAYERS. At every suppressed site SRC_URI, DEPENDS, PACKAGECONFIG, OPENGL_PKGCONFIGS and REQUIRED_DISTRO_FEATURES are unchanged; eight recipes show no effective difference at all. The helper variables are defined in the datastore but every consumer is override-scoped. For the 18 FILESEXTRAPATHS sites there is a stronger result: FILESPATH and FILESEXTRAPATHS are both in BB_BASEHASH_IGNORE_VARS, so they cannot reach a task signature. Two anonymous python blocks are deliberately left unsuppressed and explained in place instead. For those, oelint anchors the finding to the line before the block, so a directive placed above only moves the anchor onto itself: the finding survives and inlinesuppress_na is reported for the directive. oelint.task.noanonpython anchors the same block to the 'python' line and suppresses correctly, so the two rules disagree about where the construct starts. Upstream oelint bug candidate. The rule count goes 76 -> 18 and the layer total 548 -> 491. The 16 findings that remain are not noise: they are measured, genuine unconditional changes to machines this layer does not own, and are left open for separate fixes. This change is comment-only; no non-comment line is added or modified. Validated with bitbake -p (1166 recipes, 0 errors) and an authoritative driver rescan showing zero introduced findings in any of the 24 edited files. The residual override/outofcontext churn in the rescan is the known shared-metadata scan non-determinism and nets to zero. Signed-off-by: Luciano Dittgen

qt4-imx-support: Drop the stale outofcontext suppression

2026-08-03T19:12:50+00:00

The inline "# nooelint: oelint.vars.outofcontext" directive above FILESEXTRAPATHS:prepend no longer suppresses anything: oelint-adv 9.10.3 does not report oelint.vars.outofcontext for this file, and instead reports the directive itself as oelint.file.inlinesuppress_na (a suppression that is not applicable). Removing the dead directive clears that finding and keeps the suppression inventory honest -- a stale suppression hides whether the underlying concern was ever really resolved. The explanatory comment above it is kept, since it documents the fragment's purpose independently of the linter. Validation: oelint-adv rescan of the file; both oelint.file.inlinesuppress_na and oelint.vars.outofcontext are absent afterwards. No parse-affecting change (comment removal only). Signed-off-by: Luciano Dittgen

qt4-embedded: Use require for the i.MX support include per oelint

2026-07-22T14:16:40+00:00

Switch 'include qt4-imx-support.inc' to 'require' so a missing shared fragment fails the parse instead of being silently skipped (oelint.file.requireinclude). No functional change. Signed-off-by: Luciano Dittgen

qt4-x11-free: Use require for the i.MX support include per oelint

2026-07-22T14:16:40+00:00

qt4-imx-support: Order DEPENDS and document findings per oelint

2026-07-22T14:16:40+00:00

Move the DEPENDS:append above SRC_URI (oelint.var.order.DEPENDS) and correct the 0003 patch Upstream-Status reason from the non-standard '[workaround]' to '[embedded specific]' (oelint.file.inappropriatemsg). Accept the remaining findings inline: the FILESEXTRAPATHS:prepend in this shared .inc is suppressed with # nooelint oelint.vars.outofcontext, and the mx6-only kernel-shared-workdir anonymous python guard with # nooelint oelint.task.noanonpython. Each suppression sits on its own line since a nooelint marker only covers the next line. No functional change. Signed-off-by: Luciano Dittgen

global: Indent multi-line variable continuations

2026-07-12T08:14:32+00:00

Align the continuation lines of multi-line variable assignments, as suggested by oelint-adv's auto-fix for a single rule (oelint.vars.multilineident), isolated to one commit. The auto-fix strips the leading space from a value's first line, which for a ':append' is a required separator; those five recipes had their leading space restored by hand, so ':append'/':prepend' concatenation is unchanged. A few multi-line values (e.g. DESCRIPTION) gain internal whitespace, which is cosmetic and collapses on display. Build-tested: parsing all 2948 recipes for an i.MX machine reports 0 errors. A residual set (the restored ':append' recipes, whose separator space oelint cannot reconcile with its indent preference, plus opencv/dpdk where oelint's own fix does not satisfy its checker) is left for per-recipe handling. Signed-off-by: Otavio Salvador

global: Replace tabs with spaces in task bodies

2026-07-12T08:06:36+00:00

Convert leading-tab indentation to spaces in shell task bodies across the layer. Generated mechanically by oelint-adv's auto-fix for a single rule (oelint.tabs.notabs), isolated to one commit. Verified safe: every change is leading indentation of shell/BitBake code (no mid-line tabs, and none of the affected files contain heredocs where a tab would be significant), so there is no functional change. Signed-off-by: Otavio Salvador

patches: fix upstream-status

2024-06-18T16:15:31+00:00

OE-core enabled the picky QA check on Upstream-Status. commit b7fb91c797ab ("insane: add patch-status to default ERROR_QA") Add missing upstream-status respectively fix unknown 'unknown' state. strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE) Signed-off-by: Max Krummenacher

qt4-imx-support.inc: fix append syntax

2023-02-13T11:37:12+00:00

Change the "+=" in "=", we are using the :append Signed-off-by: Mauro Salvini

qt4-imx-support: fix typo

2022-10-07T10:25:31+00:00

Signed-off-by: Mauro Salvini