From 854fe440f253bd9dae68be93da20956c013aad23 Mon Sep 17 00:00:00 2001 From: Gavin Mak Date: Thu, 14 Aug 2025 19:30:06 +0000 Subject: git_superproject: fix AttributeError in Superproject logging Ensure _git_event_log is initialized before use in _LogMessage. This avoids crashes when _git_event_log is accessed before it's set, such as during repo info. Bug: 435317391 Change-Id: I3adc32d6a9377558e852bbb43f9cf82041fcf1bc Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/498521 Commit-Queue: Gavin Mak Tested-by: Gavin Mak Reviewed-by: Scott Lee --- git_superproject.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'git_superproject.py') diff --git a/git_superproject.py b/git_superproject.py index d808bb09..2ef6df16 100644 --- a/git_superproject.py +++ b/git_superproject.py @@ -190,7 +190,8 @@ class Superproject: message = f"{self._LogMessagePrefix()} {fmt.format(*inputs)}" if self._print_messages: print(message, file=sys.stderr) - self._git_event_log.ErrorEvent(message, fmt) + if self._git_event_log: + self._git_event_log.ErrorEvent(message, fmt) def _LogMessagePrefix(self): """Returns the prefix string to be logged in each log message""" -- cgit v1.2.3-54-g00ecf