diff options
| author | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-11 16:44:48 +0900 |
|---|---|---|
| committer | David Pursehouse <david.pursehouse@sonymobile.com> | 2012-10-22 12:30:14 +0900 |
| commit | 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582 (patch) | |
| tree | 3225695b9d2a97342a49127717ea5e2bc5935a63 /project.py | |
| parent | e98607248eec2b149d84efe944c12cbef419b82e (diff) | |
| download | git-repo-5c6eeac8f0350fd6b14cf226ffcff655f1dd9582.tar.gz | |
More coding style cleanup
Fixing more issues found with pylint. Some that were supposed to
have been fixed in the previous sweep (Ie0db839e) but were missed:
C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
And some more:
W0631: Using possibly undefined loop variable 'name'
W0223: Method 'name' is abstract in class 'name' but is not overridden
W0231: __init__ method from base class 'name' is not called
Change-Id: Ie119183708609d6279e973057a385fde864230c3
Diffstat (limited to 'project.py')
| -rw-r--r-- | project.py | 24 |
1 files changed, 16 insertions, 8 deletions
| @@ -724,17 +724,25 @@ class Project(object): | |||
| 724 | paths.sort() | 724 | paths.sort() |
| 725 | 725 | ||
| 726 | for p in paths: | 726 | for p in paths: |
| 727 | try: i = di[p] | 727 | try: |
| 728 | except KeyError: i = None | 728 | i = di[p] |
| 729 | except KeyError: | ||
| 730 | i = None | ||
| 729 | 731 | ||
| 730 | try: f = df[p] | 732 | try: |
| 731 | except KeyError: f = None | 733 | f = df[p] |
| 734 | except KeyError: | ||
| 735 | f = None | ||
| 732 | 736 | ||
| 733 | if i: i_status = i.status.upper() | 737 | if i: |
| 734 | else: i_status = '-' | 738 | i_status = i.status.upper() |
| 739 | else: | ||
| 740 | i_status = '-' | ||
| 735 | 741 | ||
| 736 | if f: f_status = f.status.lower() | 742 | if f: |
| 737 | else: f_status = '-' | 743 | f_status = f.status.lower() |
| 744 | else: | ||
| 745 | f_status = '-' | ||
| 738 | 746 | ||
| 739 | if i and i.src_path: | 747 | if i and i.src_path: |
| 740 | line = ' %s%s\t%s => %s (%s%%)' % (i_status, f_status, | 748 | line = ' %s%s\t%s => %s (%s%%)' % (i_status, f_status, |
