diff options
| author | Conley Owens <cco3@android.com> | 2012-10-25 09:51:06 -0700 | 
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2012-10-25 09:51:07 -0700 | 
| commit | e4ed8f65f376009f70fab0e7978fdfc223f23a76 (patch) | |
| tree | 00a9118857c613eefdd967d330bc5230ced01555 /SUBMITTING_PATCHES | |
| parent | fdb44479f8b99e7795021f1b8588a677dcf5fd51 (diff) | |
| parent | 4f7bdea9d24c4eb52f83ada2b67b88ad67cb57a7 (diff) | |
| download | git-repo-e4ed8f65f376009f70fab0e7978fdfc223f23a76.tar.gz | |
Merge "Add pylint configuration and instructions"
Diffstat (limited to 'SUBMITTING_PATCHES')
| -rw-r--r-- | SUBMITTING_PATCHES | 12 | 
1 files changed, 10 insertions, 2 deletions
| diff --git a/SUBMITTING_PATCHES b/SUBMITTING_PATCHES index cba67416..50e2cf77 100644 --- a/SUBMITTING_PATCHES +++ b/SUBMITTING_PATCHES | |||
| @@ -2,6 +2,7 @@ Short Version: | |||
| 2 | 2 | ||
| 3 | - Make small logical changes. | 3 | - Make small logical changes. | 
| 4 | - Provide a meaningful commit message. | 4 | - Provide a meaningful commit message. | 
| 5 | - Check for coding errors with pylint | ||
| 5 | - Make sure all code is under the Apache License, 2.0. | 6 | - Make sure all code is under the Apache License, 2.0. | 
| 6 | - Publish your changes for review: | 7 | - Publish your changes for review: | 
| 7 | 8 | ||
| @@ -33,7 +34,14 @@ If your description starts to get too long, that's a sign that you | |||
| 33 | probably need to split up your commit to finer grained pieces. | 34 | probably need to split up your commit to finer grained pieces. | 
| 34 | 35 | ||
| 35 | 36 | ||
| 36 | (2) Check the license | 37 | (2) Check for coding errors with pylint | 
| 38 | |||
| 39 | Run pylint on changed modules using the provided configuration: | ||
| 40 | |||
| 41 | pylint --rcfile=.pylintrc file.py | ||
| 42 | |||
| 43 | |||
| 44 | (3) Check the license | ||
| 37 | 45 | ||
| 38 | repo is licensed under the Apache License, 2.0. | 46 | repo is licensed under the Apache License, 2.0. | 
| 39 | 47 | ||
| @@ -49,7 +57,7 @@ your patch. It is virtually impossible to remove a patch once it | |||
| 49 | has been applied and pushed out. | 57 | has been applied and pushed out. | 
| 50 | 58 | ||
| 51 | 59 | ||
| 52 | (3) Sending your patches. | 60 | (4) Sending your patches. | 
| 53 | 61 | ||
| 54 | Do not email your patches to anyone. | 62 | Do not email your patches to anyone. | 
| 55 | 63 | ||
