diff options
author | Gavin Mak <gavinmak@google.com> | 2025-08-14 19:30:06 +0000 |
---|---|---|
committer | LUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2025-08-14 15:39:41 -0700 |
commit | 854fe440f253bd9dae68be93da20956c013aad23 (patch) | |
tree | 8b695fd5211de3b99618b11850d1a3bb33cdf78a | |
parent | d534a5537fd317cd769fed54eceb8248777db701 (diff) | |
download | git-repo-854fe440f253bd9dae68be93da20956c013aad23.tar.gz |
git_superproject: fix AttributeError in Superproject logging
Ensure _git_event_log is initialized before use in _LogMessage. This
avoids crashes when _git_event_log is accessed before it's set, such as
during repo info.
Bug: 435317391
Change-Id: I3adc32d6a9377558e852bbb43f9cf82041fcf1bc
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/498521
Commit-Queue: Gavin Mak <gavinmak@google.com>
Tested-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@google.com>
-rw-r--r-- | git_superproject.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/git_superproject.py b/git_superproject.py index d808bb09..2ef6df16 100644 --- a/git_superproject.py +++ b/git_superproject.py | |||
@@ -190,7 +190,8 @@ class Superproject: | |||
190 | message = f"{self._LogMessagePrefix()} {fmt.format(*inputs)}" | 190 | message = f"{self._LogMessagePrefix()} {fmt.format(*inputs)}" |
191 | if self._print_messages: | 191 | if self._print_messages: |
192 | print(message, file=sys.stderr) | 192 | print(message, file=sys.stderr) |
193 | self._git_event_log.ErrorEvent(message, fmt) | 193 | if self._git_event_log: |
194 | self._git_event_log.ErrorEvent(message, fmt) | ||
194 | 195 | ||
195 | def _LogMessagePrefix(self): | 196 | def _LogMessagePrefix(self): |
196 | """Returns the prefix string to be logged in each log message""" | 197 | """Returns the prefix string to be logged in each log message""" |