From a1d2ef6a8e1bc721e44640bdb85747deaf8edcca Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Wed, 19 Apr 2017 10:50:37 -0700 Subject: [PATCH] Fix warnings found with gcc7 GCC7 finds more type conversion issues | pkix_pl_ocsprequest.c: In function 'pkix_pl_OcspRequest_Hashcode': | pkix_pl_ocsprequest.c:92:60: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] | *pHashcode = (((((extensionHash << 8) || certHash) << 8) || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ | pkix_pl_ocsprequest.c:93:27: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] | *pHashcode = (((((extensionHash << 8) || certHash) << 8) || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | dateHash) << 8) || signerHash; | ~~~~~~~~~~^~~~~ | cc1: all warnings being treated as errors Upstream-Status: Pending Signed-off-by: Khem Raj --- nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c b/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c index 171a3d2..d5eef88 100644 --- a/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c +++ b/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocsprequest.c @@ -89,7 +89,7 @@ pkix_pl_OcspRequest_Hashcode( PKIX_HASHCODE(ocspRq->signerCert, &signerHash, plContext, PKIX_CERTHASHCODEFAILED); - *pHashcode = (((((extensionHash << 8) || certHash) << 8) || + *pHashcode = ((PKIX_UInt32)(((PKIX_UInt32)((extensionHash << 8) || certHash) << 8) || dateHash) << 8) || signerHash; cleanup: -- 2.12.2