From 4e2ac2afa94f014a2a015c48c678e2367a63ae82 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 25 Dec 2014 23:55:03 +0100 Subject: [PATCH] url-parsing: reject CRLFs within URLs Bug: http://curl.haxx.se/docs/adv_20150108B.html Reported-by: Andrey Labunets --- lib/url.c | 7 +++++++ 1 file changed, 7 insertions(+) Index: curl-7.37.1/lib/url.c =================================================================== --- curl-7.37.1.orig/lib/url.c +++ curl-7.37.1/lib/url.c @@ -3756,6 +3756,13 @@ static CURLcode parseurlandfillconn(stru *prot_missing = FALSE; + /* We might pass the entire URL into the request so we need to make sure + * there are no bad characters in there.*/ + if(strpbrk(data->change.url, "\r\n")) { + failf(data, "Illegal characters found in URL"); + return CURLE_URL_MALFORMAT; + } + /************************************************************* * Parse the URL. *