From 0d02e70b197c786f26175b9a73f94e01d14abdab Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Mon, 20 Jun 2022 10:39:31 +0930 Subject: [PATCH] PR29262, memory leak in pr_function_type PR 29262 * prdbg.c (pr_function_type): Free "s" on failure path. Upstream-Status: Backport [https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff_plain;h=0d02e70b197c786f26175b9a73f94e01d14abdab] CVE: CVE-2022-47010 Signed-off-by: Virendra Thakur Comment: Patch refreshed based on codebase. --- binutils/prdbg.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/binutils/prdbg.c b/binutils/prdbg.c index c1e41628d26..bb42a5b6c2d 100644 --- a/binutils/prdbg.c +++ b/binutils/prdbg.c @@ -778,12 +778,9 @@ strcat (s, ")"); - if (! substitute_type (info, s)) - return FALSE; - + bfd_boolean ret = substitute_type (info, s); free (s); - - return TRUE; + return ret; } /* Turn the top type on the stack into a reference to that type. */