From 79ef781499f5bf219dae338882eefe7d4f800304 Mon Sep 17 00:00:00 2001 From: Nicolas Dechesne Date: Tue, 19 Nov 2024 10:41:09 +0100 Subject: scripts: patchreview: fix failure when running from a different folder When running patchreview with --blame, the scripts runs a git log command on the analyzed patch. When trying to analyse a layer which is not in poky tree, we might be running the git log command from outside the git workspace where the file is located, which results in such failures: Missing Signed-off-by tag ([truncated]/meta-qcom-hwe/recipes-devtools/partition-utils/qcom-ptool/0001-ptool.py-Generate-zero-files-in-output-folder-when-s.patch) fatal: not a git repository (or any parent up to mount point /local/mnt) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). Fix this situation by setting the current work dir inside the git workspace of the patch when running git log. (From OE-Core rev: 8cc1c900b91d60e633f62bfe16a2ffc2d61c3f55) Signed-off-by: Nicolas Dechesne Signed-off-by: Richard Purdie --- scripts/contrib/patchreview.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/contrib/patchreview.py b/scripts/contrib/patchreview.py index 69ef14eb44..d8d7b214e5 100755 --- a/scripts/contrib/patchreview.py +++ b/scripts/contrib/patchreview.py @@ -51,7 +51,7 @@ def blame_patch(patch): return subprocess.check_output(("git", "log", "--follow", "--find-renames", "--diff-filter=A", "--format=%s (%aN <%aE>)", - "--", patch)).decode("utf-8").splitlines() + "--", patch), cwd=os.path.dirname(patch)).decode("utf-8").splitlines() def patchreview(patches): -- cgit v1.2.3-54-g00ecf