From 4e23e8f9d0e22cf534c19224cba0be9bedba0120 Mon Sep 17 00:00:00 2001 From: Darren Hart Date: Wed, 26 Jan 2011 09:42:33 -0800 Subject: send-pull-request: ensure a proper FROM header is included Commit 94629f2521711055b412f954af19e48b9bda6e50 removes the FROM header when sending via sendmail to avoid sending mail as the original change committer (as opposed to the local user). This resulted in mail going out without any FROM header, which some mailing lists correct by adding the *bounce address as the FROM. Correct this by reading FROM from the environment, from a new -f argument, or from the git user.name and user.email config settings, in that order of preference. Also display the FROM that will be used prior to the send confirmation. This has no effect if the -g (send via git) argument is specified, other than printing the git sendemail.from config setting. Signed-off-by: Darren Hart Reported-by: Saul Wold --- scripts/send-pull-request | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) (limited to 'scripts/send-pull-request') diff --git a/scripts/send-pull-request b/scripts/send-pull-request index c08b3be078..7f51a1b259 100755 --- a/scripts/send-pull-request +++ b/scripts/send-pull-request @@ -9,6 +9,7 @@ fi # Prevent environment leakage to these vars. unset TO unset CC +# allow the user to set FROM in the environment usage() { @@ -17,6 +18,9 @@ Usage: $(basename $0) [-h] [-a] [[-t email]...] -p pull-dir -t email Explicitly add email to the recipients -a Automatically harvest recipients from "*-by: email" lines in the patches in the pull-dir + -f Specify a FROM address, you can also use the FROM environment + variable. If you do not specify one, it will try to use the one + from your git config. This is ignored if -g is used. -g Use git-send-email to send mail instead of sendmail -p pull-dir Directory containing summary and patch files EOM @@ -45,11 +49,14 @@ harvest_recipients() # Parse and verify arguments -while getopts "aghp:t:" OPT; do +while getopts "af:ghp:t:" OPT; do case $OPT in a) AUTO=1 ;; + f) + FROM="$OPTARG" + ;; g) PULL_MTA="git" ;; @@ -108,13 +115,29 @@ if [ -z "$TO" ] && [ -z "$CC" ]; then exit 1 fi +case "$PULL_MTA" in + git) + FROM="$(git config sendemail.from)" + ;; + sendmail) + if [ -z "$FROM" ]; then + FROM="$(git config user.name) <$(git config user.email)>" + if [ -z "$FROM" ]; then + echo "ERROR: unable to determine a FROM address" + usage + exit 1 + fi + fi + ;; +esac # Generate report for the user and require confirmation before sending cat <