From 14d5932c204ff045bd66c343ca86281f2e5f627f Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Tue, 27 Jun 2017 17:33:40 +0200 Subject: yocto-compat-layer.py: apply test_signatures to all layers Software layers were previously allowed to change signatures, but that's not desired for those layers either. The rule that a layer which is "Yocto Compatible 2.0" must not change signatures unless explicitly requested holds for all kinds of layers. However, as this is something that software layers might not be able to do right away, testing for signature changes in software layers can be disabled. It's on by default, as that was Richard's recommendation. Whether that should change needs further discussion as part of finalizing "Yocto Compatible 2.0". As it might still change, the tool now has both a with/without parameter so that users of the tool can choose the desired behavior without being affected by future changes to the default. (From OE-Core rev: e4dce65ce604a74da0f09ee2742cf8b13cf96c8e) Signed-off-by: Patrick Ohly Signed-off-by: Ross Burton Signed-off-by: Armin Kuster Signed-off-by: Richard Purdie --- scripts/lib/compatlayer/cases/common.py | 5 +++-- scripts/lib/compatlayer/context.py | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'scripts/lib') diff --git a/scripts/lib/compatlayer/cases/common.py b/scripts/lib/compatlayer/cases/common.py index 2dfcbb1c32..a1cdbab51e 100644 --- a/scripts/lib/compatlayer/cases/common.py +++ b/scripts/lib/compatlayer/cases/common.py @@ -27,8 +27,9 @@ class CommonCompatLayer(OECompatLayerTestCase): 'bitbake -e') def test_signatures(self): - if self.tc.layer['type'] == LayerType.SOFTWARE: - raise unittest.SkipTest("Layer %s isn't BSP or DISTRO one." \ + if self.tc.layer['type'] == LayerType.SOFTWARE and \ + not self.tc.test_software_layer_signatures: + raise unittest.SkipTest("Not testing for signature changes in a software layer %s." \ % self.tc.layer['name']) # task -> (old signature, new signature) diff --git a/scripts/lib/compatlayer/context.py b/scripts/lib/compatlayer/context.py index 4932238798..7811d4ac20 100644 --- a/scripts/lib/compatlayer/context.py +++ b/scripts/lib/compatlayer/context.py @@ -9,6 +9,7 @@ import re from oeqa.core.context import OETestContext class CompatLayerTestContext(OETestContext): - def __init__(self, td=None, logger=None, layer=None): + def __init__(self, td=None, logger=None, layer=None, test_software_layer_signatures=True): super(CompatLayerTestContext, self).__init__(td, logger) self.layer = layer + self.test_software_layer_signatures = test_software_layer_signatures -- cgit v1.2.3-54-g00ecf