From 89d289ee85adbebf621619741b5fcd562ad9902d Mon Sep 17 00:00:00 2001 From: Jacob Kroon Date: Wed, 10 Jun 2020 19:52:43 +0200 Subject: features_check: Warn if not used (From OE-Core rev: 56c1fe3bc89af86a2524ed5b724fe74ba514acc5) Signed-off-by: Jacob Kroon Signed-off-by: Richard Purdie --- meta/classes/features_check.bbclass | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'meta') diff --git a/meta/classes/features_check.bbclass b/meta/classes/features_check.bbclass index 4ba827d4ab..b3c8047861 100644 --- a/meta/classes/features_check.bbclass +++ b/meta/classes/features_check.bbclass @@ -16,7 +16,19 @@ python () { if d.getVar('PARSE_ALL_RECIPES', False): return + unused = True + for kind in ['DISTRO', 'MACHINE', 'COMBINED']: + if d.getVar('ANY_OF_' + kind + '_FEATURES') is None and \ + d.overridedata.get('ANY_OF_' + kind + '_FEATURES') is None and \ + d.getVar('REQUIRED_' + kind + '_FEATURES') is None and \ + d.overridedata.get('REQUIRED_' + kind + '_FEATURES') is None and \ + d.getVar('CONFLICT_' + kind + '_FEATURES') is None and \ + d.overridedata.get('CONFLICT_' + kind + '_FEATURES') is None: + continue + + unused = False + # Assume at least one var is set. features = set((d.getVar(kind + '_FEATURES') or '').split()) @@ -39,4 +51,7 @@ python () { if conflicts: raise bb.parse.SkipRecipe("conflicting %s feature%s '%s' (in %s_FEATURES)" % (kind.lower(), 's' if len(conflicts) > 1 else '', ' '.join(conflicts), kind)) + + if unused: + bb.warn("Recipe inherits features_check but doesn't use it") } -- cgit v1.2.3-54-g00ecf