From 9872c3d2ae80933c89ac59cbe83203bb0671f603 Mon Sep 17 00:00:00 2001 From: He Zhe Date: Wed, 8 Feb 2017 10:58:46 +0800 Subject: ltp: Fix containers/userns05 failure for lib32 Backport a patch to fix userns05 case: <<>> user_namespace5 1 TFAIL : userns05.c:95: userns:parent should be not equal to cpid2 user_namespace5 1 TFAIL : userns05.c:95: userns:parent should be not equal to cpid2 user_namespace5 0 TINFO : Child process returned TPASS user_namespace5 0 TINFO : Child process returned TPASS user_namespace5 0 TINFO : Child process returned TFAIL incrementing stop Rename the previous patch to add a number prefix (From OE-Core rev: b96c5d18839cff345a3a2c4b952dd62aad119121) Signed-off-by: He Zhe Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- ...0039-fcntl-fix-the-time-def-to-use-time_t.patch | 28 ++++++++++ ...iners-userns05-use-unsigned-int-for-ns-id.patch | 60 ++++++++++++++++++++++ .../ltp/fcntl-fix-the-time-def-to-use-time_t.patch | 28 ---------- meta/recipes-extended/ltp/ltp_20160126.bb | 3 +- 4 files changed, 90 insertions(+), 29 deletions(-) create mode 100644 meta/recipes-extended/ltp/ltp/0039-fcntl-fix-the-time-def-to-use-time_t.patch create mode 100644 meta/recipes-extended/ltp/ltp/0040-containers-userns05-use-unsigned-int-for-ns-id.patch delete mode 100644 meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch (limited to 'meta/recipes-extended/ltp') diff --git a/meta/recipes-extended/ltp/ltp/0039-fcntl-fix-the-time-def-to-use-time_t.patch b/meta/recipes-extended/ltp/ltp/0039-fcntl-fix-the-time-def-to-use-time_t.patch new file mode 100644 index 0000000000..f7e805a954 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0039-fcntl-fix-the-time-def-to-use-time_t.patch @@ -0,0 +1,28 @@ +From 9590d073d3abe02fe0783ef8c530aef2e873ba9b Mon Sep 17 00:00:00 2001 +From: Christopher Larson +Date: Tue, 13 Dec 2016 12:48:29 -0700 +Subject: [PATCH] fcntl: fix the time() def to use time_t + +This fixes the build on X32, where long is 32-bit rather than 64-bit. + +Signed-off-by: Christopher Larson +--- + testcases/kernel/syscalls/fcntl/fcntl14.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/testcases/kernel/syscalls/fcntl/fcntl14.c b/testcases/kernel/syscalls/fcntl/fcntl14.c +index 3b36572..65ac8fa 100644 +--- a/testcases/kernel/syscalls/fcntl/fcntl14.c ++++ b/testcases/kernel/syscalls/fcntl/fcntl14.c +@@ -789,7 +789,7 @@ void dochild(void) + + void run_test(int file_flag, int file_mode, int seek, int start, int end) + { +- extern long time(); ++ extern time_t time(); + + /* reset fail to 0 for each run_test call */ + fail = 0; +-- +2.8.0 + diff --git a/meta/recipes-extended/ltp/ltp/0040-containers-userns05-use-unsigned-int-for-ns-id.patch b/meta/recipes-extended/ltp/ltp/0040-containers-userns05-use-unsigned-int-for-ns-id.patch new file mode 100644 index 0000000000..4dee1f5a9b --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0040-containers-userns05-use-unsigned-int-for-ns-id.patch @@ -0,0 +1,60 @@ +From 3b63d350e9fe9e4271916cc0abfac65a5d6419ff Mon Sep 17 00:00:00 2001 +From: Jiri Jaburek +Date: Tue, 7 Feb 2017 07:58:16 +0000 +Subject: [PATCH] containers/userns05: use unsigned int for ns id + +The kernel defines it as 'unsigned int' in 'struct ns_common' +and formats it as + + snprintf(buf, size, "%s:[%u]", ns_ops->name, ns->inum); + +This change makes the test work on 32bit systems where LONG_MAX +is smaller than UINT_MAX. + +Signed-off-by: Jiri Jaburek + +Upstream-Status: Backport + +Signed-off-by: He Zhe +--- + testcases/kernel/containers/userns/userns05.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/testcases/kernel/containers/userns/userns05.c b/testcases/kernel/containers/userns/userns05.c +index 8d8c40a..8eac729 100644 +--- a/testcases/kernel/containers/userns/userns05.c ++++ b/testcases/kernel/containers/userns/userns05.c +@@ -49,18 +49,18 @@ static int child_fn1(void) + return 0; + } + +-static long getusernsidbypid(int pid) ++static unsigned int getusernsidbypid(int pid) + { + char path[BUFSIZ]; + char userid[BUFSIZ]; +- long id = 0; ++ unsigned int id = 0; + + sprintf(path, "/proc/%d/ns/user", pid); + + if (readlink(path, userid, BUFSIZ) == -1) + tst_resm(TFAIL | TERRNO, "readlink failure."); + +- if (sscanf(userid, "user:[%ld]", &id) != 1) ++ if (sscanf(userid, "user:[%u]", &id) != 1) + tst_resm(TFAIL, "sscanf failure."); + return id; + } +@@ -68,7 +68,7 @@ static long getusernsidbypid(int pid) + static void test_userns_id(void) + { + int cpid1, cpid2, cpid3; +- long parentuserns, cpid1userns, cpid2userns, newparentuserns; ++ unsigned int parentuserns, cpid1userns, cpid2userns, newparentuserns; + + parentuserns = getusernsidbypid(getpid()); + cpid1 = ltp_clone_quick(SIGCHLD, (void *)child_fn1, +-- +2.9.3 + diff --git a/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch b/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch deleted file mode 100644 index f7e805a954..0000000000 --- a/meta/recipes-extended/ltp/ltp/fcntl-fix-the-time-def-to-use-time_t.patch +++ /dev/null @@ -1,28 +0,0 @@ -From 9590d073d3abe02fe0783ef8c530aef2e873ba9b Mon Sep 17 00:00:00 2001 -From: Christopher Larson -Date: Tue, 13 Dec 2016 12:48:29 -0700 -Subject: [PATCH] fcntl: fix the time() def to use time_t - -This fixes the build on X32, where long is 32-bit rather than 64-bit. - -Signed-off-by: Christopher Larson ---- - testcases/kernel/syscalls/fcntl/fcntl14.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/testcases/kernel/syscalls/fcntl/fcntl14.c b/testcases/kernel/syscalls/fcntl/fcntl14.c -index 3b36572..65ac8fa 100644 ---- a/testcases/kernel/syscalls/fcntl/fcntl14.c -+++ b/testcases/kernel/syscalls/fcntl/fcntl14.c -@@ -789,7 +789,7 @@ void dochild(void) - - void run_test(int file_flag, int file_mode, int seek, int start, int end) - { -- extern long time(); -+ extern time_t time(); - - /* reset fail to 0 for each run_test call */ - fail = 0; --- -2.8.0 - diff --git a/meta/recipes-extended/ltp/ltp_20160126.bb b/meta/recipes-extended/ltp/ltp_20160126.bb index 72d465bed3..aaa63c268c 100644 --- a/meta/recipes-extended/ltp/ltp_20160126.bb +++ b/meta/recipes-extended/ltp/ltp_20160126.bb @@ -65,7 +65,8 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0036-testcases-network-nfsv4-acl-acl1.c-Security-fix-on-s.patch \ file://0037-containers-netns_netlink-Avoid-segmentation-fault.patch \ file://0038-run-posix-option-group-test-replace-CWD-qith-PWD.patch \ - file://fcntl-fix-the-time-def-to-use-time_t.patch \ + file://0039-fcntl-fix-the-time-def-to-use-time_t.patch \ + file://0040-containers-userns05-use-unsigned-int-for-ns-id.patch \ " S = "${WORKDIR}/git" -- cgit v1.2.3-54-g00ecf