From ac09753064da6b96199af5d1feedd371b24f1a3a Mon Sep 17 00:00:00 2001 From: Tom Hochstein Date: Thu, 25 Jul 2024 06:59:32 -0500 Subject: time64.inc: Simplify GLIBC_64BIT_TIME_FLAGS usage The implementation uses the append operator to include GLIBC_64BIT_TIME_FLAGS in TARGET_CC_ARCH, but it places the space in the GLIBC_64BIT_TIME_FLAGS assignment in order to avoid a 'spurious space' when the value is empty. 68b50d3 time64: Remove leading whitespace from GLIBC_64BIT_TIME_FLAGS The problem with this is it requires anyone wishing to assign a value to GLIBC_64BIT_TIME_FLAGS to add the leading space, otherwise this is the error: cc1: error: '-Werror=format-security-D_TIME_BITS=64': no option '-Wformat-security-D_TIME_BITS=64' Add a new constant variable to capture the value needed for the 32-bit special case, including the space. (From OE-Core rev: e8177827f92e71c80c5b63453d8bbd1defbe1fbc) Signed-off-by: Tom Hochstein Signed-off-by: Richard Purdie --- meta/conf/distro/include/time64.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'meta/conf') diff --git a/meta/conf/distro/include/time64.inc b/meta/conf/distro/include/time64.inc index 510da11039..9d556bac16 100644 --- a/meta/conf/distro/include/time64.inc +++ b/meta/conf/distro/include/time64.inc @@ -8,10 +8,11 @@ # # Working to address those (before Y2038 rolls in) will be appreciated. -GLIBC_64BIT_TIME_FLAGS = " -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" +GLIBC_64BIT_TIME_FLAGS = "${GLIBC_64BIT_TIME_FLAGS_WHEN_NEEDED}" # Only needed for some 32-bit architectures, some relatively newer # architectures do not need it ( e.g. riscv32 ) +GLIBC_64BIT_TIME_FLAGS_WHEN_NEEDED = " -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" TARGET_CC_ARCH:append:arm = "${GLIBC_64BIT_TIME_FLAGS}" TARGET_CC_ARCH:append:armeb = "${GLIBC_64BIT_TIME_FLAGS}" TARGET_CC_ARCH:append:mipsarcho32 = "${GLIBC_64BIT_TIME_FLAGS}" -- cgit v1.2.3-54-g00ecf