From d03e29fec2c596894d01114d913e03fb9b6af482 Mon Sep 17 00:00:00 2001 From: Mark Hatle Date: Wed, 23 May 2012 15:24:37 -0500 Subject: package.bbclass: Add additional debugging for dependencies When trying to understand why a QA wanring such as: ERROR: QA Issue: foo rdepends on bar-dev it is very difficult to figure out where the bar-dev dependency comes from, since many of them are added dynamically. This adds a debug statement that says which dependency adds an rdepends to the system. Also, while doing this work, it was noted that the same dependencies were being scanned for over and over. Instead we shorten the list by only added to the dep list if the dependency was not already there. (From OE-Core rev: 257b9e371143421b78a6991ef5401e564918c164) Signed-off-by: Mark Hatle Signed-off-by: Richard Purdie --- meta/classes/package.bbclass | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'meta/classes') diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 6fba5b6907..8b0ac55b76 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1266,7 +1266,8 @@ python package_do_shlibs() { for l in lines: m = re.match("\s+NEEDED\s+([^\s]*)", l) if m: - needed[pkg].append(m.group(1)) + if m.group(1) not in needed[pkg]: + needed[pkg].append(m.group(1)) m = re.match("\s+SONAME\s+([^\s]*)", l) if m: this_soname = m.group(1) @@ -1338,7 +1339,7 @@ python package_do_shlibs() { name = dep.replace("-l", "lib") if pkg not in needed: needed[pkg] = [] - if name: + if name and name not in needed[pkg]: needed[pkg].append(name) #bb.note("Adding %s for %s" % (name, pkg)) @@ -1443,6 +1444,8 @@ python package_do_shlibs() { if n in shlib_provider.keys(): (dep_pkg, ver_needed) = shlib_provider[n] + bb.debug(2, '%s: Dependency %s requires package %s' % (pkg, n, dep_pkg)) + if dep_pkg == pkg: continue -- cgit v1.2.3-54-g00ecf