From 89a27680008dbe7a02016afc94fd62a05b0c9ff6 Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Thu, 1 Aug 2019 16:09:44 +0100 Subject: insane: check if the recipe incorrectly uses DEPENDS_${PN} Some people mistakenly use DEPENDS_${PN} and wonder why the dependencies don't work. Check for this and tell the user to use DEPENDS. (From OE-Core rev: cfaa104955c4ad0aafbe5d59ef85e4a8e3526c69) Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- meta/classes/insane.bbclass | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'meta/classes') diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 891d3a8421..35c4fdb491 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -1237,6 +1237,11 @@ python () { if prog.search(pn): package_qa_handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d) + # Some people mistakenly use DEPENDS_${PN} instead of DEPENDS and wonder + # why it doesn't work. + if (d.getVar(d.expand('DEPENDS_${PN}'))): + package_qa_handle_error("pkgvarcheck", "recipe uses DEPENDS_${PN}, should use DEPENDS", d) + issues = [] if (d.getVar('PACKAGES') or "").split(): for dep in (d.getVar('QADEPENDS') or "").split(): -- cgit v1.2.3-54-g00ecf