From 5e6e95d71be1486c58d979ace744656a182feba2 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Fri, 23 Jan 2015 06:48:17 -0800 Subject: binconfig-disabled: try harder to prevent usage of config scripts Returning a non-zero exit code is not enough to cause errors when configure scripts call the patched config scripts: for example, swig's configure script uses PCRE_LIBS=`$PCRE_CONFIG --libs` and does not abort on errors. Using empty output may then succeed, for example when the required library is available indirectly. Returning some nonsense command line arguments covers such cases, because using them will definitely lead to errors during compilation. The faked arguments were chosen such that these errors can be linked back to the root cause. (From OE-Core rev: d1ff61a16a3fcfdd7cf882bc89fb1d164cb1603a) Signed-off-by: Patrick Ohly Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- meta/classes/binconfig-disabled.bbclass | 3 +++ 1 file changed, 3 insertions(+) (limited to 'meta/classes/binconfig-disabled.bbclass') diff --git a/meta/classes/binconfig-disabled.bbclass b/meta/classes/binconfig-disabled.bbclass index 27f904eb42..4c42ae22e4 100644 --- a/meta/classes/binconfig-disabled.bbclass +++ b/meta/classes/binconfig-disabled.bbclass @@ -10,6 +10,9 @@ FILES_${PN}-dev += "${bindir}/*-config" do_install_append () { for x in ${BINCONFIG}; do echo "#!/bin/sh" > ${D}$x + # Make the disabled script emit invalid parameters for those configure + # scripts which call it without checking the return code. + echo "echo '--should-not-have-used-$x'" > ${D}$x echo "exit 1" >> ${D}$x done } -- cgit v1.2.3-54-g00ecf