From 014558f14c275237e3b64d24f117cd05b1236b5a Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Sun, 15 Dec 2019 17:46:01 +0000 Subject: bitbake: runqueue: Optimise out pointless loop iteration (Bitbake rev: 14babbf0a32637db640e0494b0331397dcb0f715) Signed-off-by: Richard Purdie (cherry picked from commit 105d1f0748edde7753a4063e6fdc758ffc8a8a9e) Signed-off-by: Richard Purdie --- bitbake/lib/bb/runqueue.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'bitbake') diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py index 6da612b719..73775d9761 100644 --- a/bitbake/lib/bb/runqueue.py +++ b/bitbake/lib/bb/runqueue.py @@ -1182,11 +1182,8 @@ class RunQueueData: return len(self.runtaskentries) def prepare_task_hash(self, tid): - procdep = [] - for dep in self.runtaskentries[tid].depends: - procdep.append(dep) - bb.parse.siggen.prep_taskhash(tid, procdep, self.dataCaches[mc_from_tid(tid)]) - self.runtaskentries[tid].hash = bb.parse.siggen.get_taskhash(tid, procdep, self.dataCaches[mc_from_tid(tid)]) + bb.parse.siggen.prep_taskhash(tid, self.runtaskentries[tid].depends, self.dataCaches[mc_from_tid(tid)]) + self.runtaskentries[tid].hash = bb.parse.siggen.get_taskhash(tid, self.runtaskentries[tid].depends, self.dataCaches[mc_from_tid(tid)]) self.runtaskentries[tid].unihash = bb.parse.siggen.get_unihash(tid) def dump_data(self): @@ -2294,11 +2291,8 @@ class RunQueueExecute: for tid in current: if len(self.rqdata.runtaskentries[p].depends) and not self.rqdata.runtaskentries[tid].depends.isdisjoint(total): continue - procdep = [] - for dep in self.rqdata.runtaskentries[tid].depends: - procdep.append(dep) orighash = self.rqdata.runtaskentries[tid].hash - newhash = bb.parse.siggen.get_taskhash(tid, procdep, self.rqdata.dataCaches[mc_from_tid(tid)]) + newhash = bb.parse.siggen.get_taskhash(tid, self.rqdata.runtaskentries[tid].depends, self.rqdata.dataCaches[mc_from_tid(tid)]) origuni = self.rqdata.runtaskentries[tid].unihash newuni = bb.parse.siggen.get_unihash(tid) # FIXME, need to check it can come from sstate at all for determinism? -- cgit v1.2.3-54-g00ecf