From c82dc42d4dca89121de6e781b6cb48d5d952df55 Mon Sep 17 00:00:00 2001 From: Joshua Lock Date: Fri, 12 Aug 2011 15:06:06 -0700 Subject: bb/ui/crumbs/tasklistmodel: optimise find_path_for_item If the item_name contains virtual/, -native or -cross it won't be present in the model. Return None early in this circumstance rather than iterating the entire model and still returning None. (Bitbake rev: aeef5a4b3999bd924e89e7738efe24f80ae94fd0) Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie --- bitbake/lib/bb/ui/crumbs/tasklistmodel.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'bitbake/lib') diff --git a/bitbake/lib/bb/ui/crumbs/tasklistmodel.py b/bitbake/lib/bb/ui/crumbs/tasklistmodel.py index 1f00f6cfb2..baf4ede4af 100644 --- a/bitbake/lib/bb/ui/crumbs/tasklistmodel.py +++ b/bitbake/lib/bb/ui/crumbs/tasklistmodel.py @@ -472,6 +472,11 @@ class TaskListModel(gtk.ListStore): Returns the path in the model or None """ def find_path_for_item(self, item_name): + # We don't include virtual/* or *-native items in the model so save a + # heavy iteration loop by exiting early for these items + if item_name.startswith("virtual/") or item_name.count('-native') or item_name.count('-cross'): + return None + it = self.get_iter_first() path = None while it: -- cgit v1.2.3-54-g00ecf