From a16e0b4014173af46ef80d643bb71055219b0dab Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Mon, 10 Aug 2015 18:27:18 +0100 Subject: bitbake: toaster: reduced amount of instance attributes Used local variables instead of instance attributes in ViewTests.setUp Fixed pylint warning: Too many instance attributes (9/7) (too-many-instance-attributes) (Bitbake rev: 0c419902e5f58dcee9b7fbe9af1928da37e18399) Signed-off-by: Ed Bartosh Signed-off-by: Michael Wood Signed-off-by: Richard Purdie --- bitbake/lib/toaster/toastergui/tests.py | 55 ++++++++++++++------------------- 1 file changed, 24 insertions(+), 31 deletions(-) (limited to 'bitbake/lib') diff --git a/bitbake/lib/toaster/toastergui/tests.py b/bitbake/lib/toaster/toastergui/tests.py index bc108010bf..93a85ac7a9 100644 --- a/bitbake/lib/toaster/toastergui/tests.py +++ b/bitbake/lib/toaster/toastergui/tests.py @@ -34,38 +34,31 @@ class ViewTests(TestCase): """Tests to verify view APIs.""" def setUp(self): - self.bbv = BitbakeVersion.objects.create(\ - name="test bbv", giturl="/tmp/", - branch="master", dirpath="") - self.release = Release.objects.create(\ - name="test release", bitbake_version=self.bbv) + bbv = BitbakeVersion.objects.create(name="test bbv", giturl="/tmp/", + branch="master", dirpath="") + release = Release.objects.create(name="test release", + bitbake_version=bbv) self.project = Project.objects.create_project(name=PROJECT_NAME, - release=self.release) - self.layersrc = LayerSource.objects.create(\ - sourcetype=LayerSource.TYPE_IMPORTED) - self.priority = ReleaseLayerSourcePriority.objects.create(\ - release=self.release, - layer_source=self.layersrc) - self.layer = Layer.objects.create(\ - name="base-layer", - layer_source=self.layersrc, vcs_url="/tmp/") - self.lver = Layer_Version.objects.create(\ - layer=self.layer, project=self.project, - layer_source=self.layersrc, commit="master") - - self.recipe = Recipe.objects.create(\ - layer_source=self.layersrc, name="base-recipe", - version="1.2", summary="one recipe", - description="recipe", layer_version=self.lver) - - self.machine = Machine.objects.create(\ - layer_version=self.lver, name="wisk", - description="wisking machine") - - ProjectLayer.objects.create(project=self.project, - layercommit=self.lver) - - self.assertTrue(self.lver in self.project.compatible_layerversions()) + release=release) + layersrc = LayerSource.objects.create(sourcetype=LayerSource.TYPE_IMPORTED) + self.priority = ReleaseLayerSourcePriority.objects.create(release=release, + layer_source=layersrc) + layer = Layer.objects.create(name="base-layer", layer_source=layersrc, + vcs_url="/tmp/") + + lver = Layer_Version.objects.create(layer=layer, project=self.project, + layer_source=layersrc, commit="master") + + Recipe.objects.create(layer_source=layersrc, name="base-recipe", + version="1.2", summary="one recipe", + description="recipe", layer_version=lver) + + Machine.objects.create(layer_version=lver, name="wisk", + description="wisking machine") + + ProjectLayer.objects.create(project=self.project, layercommit=lver) + + self.assertTrue(lver in self.project.compatible_layerversions()) def test_get_base_call_returns_html(self): """Basic test for all-projects view""" -- cgit v1.2.3-54-g00ecf