From 9475a684c4baa45ba7bdc6ac7a122c122ed17ed9 Mon Sep 17 00:00:00 2001 From: Elliot Smith Date: Tue, 12 Jul 2016 15:54:55 -0700 Subject: bitbake: toaster: the customise image button shouldn't rely on targets The build dashboard customise image button (for creating a new custom image based on an image recipe used by a build) shouldn't rely on targets: whether a new custom image can be created or not depends on whether any of the recipes used by the build are image recipes. Modify the method used to determine whether a build has customisable images to look at the image recipes used during the build, rather than whether the targets run by the build refer to image recipes. (Bitbake rev: 6648876c91134bda8498b4f8d7ace9147ec0d985) Signed-off-by: Elliot Smith Signed-off-by: bavery Signed-off-by: Richard Purdie --- bitbake/lib/toaster/orm/models.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'bitbake/lib/toaster/orm/models.py') diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py index 8e40f0aca2..048399f34d 100644 --- a/bitbake/lib/toaster/orm/models.py +++ b/bitbake/lib/toaster/orm/models.py @@ -449,18 +449,13 @@ class Build(models.Model): break return has_images - def has_image_targets(self): + def has_image_recipes(self): """ Returns True if a build has any targets which were built from image recipes. """ - targets = Target.objects.filter(build_id=self.id) - has_image_targets = False - for target in targets: - if target.is_image: - has_image_targets = True - break - return has_image_targets + image_recipes = self.get_image_recipes() + return len(image_recipes) > 0 def get_image_file_extensions(self): """ -- cgit v1.2.3-54-g00ecf