From 9889a0ff1af115e37ea1268f0580ef8b344c32e9 Mon Sep 17 00:00:00 2001 From: Michael Opdenacker Date: Fri, 12 Apr 2024 11:02:32 +0200 Subject: bitbake: prserv: remove unnecessary code In db.py, the ifnull() statement guarantees that the SQL request will return a value. It's therefore unnecessary to test the case when no value is found. (Bitbake rev: e4ae5177861c9a27e93e5a2d3a6c393baecd6416) Signed-off-by: Michael Opdenacker Cc: Joshua Watt Cc: Tim Orling Cc: Thomas Petazzoni Signed-off-by: Richard Purdie --- bitbake/lib/prserv/db.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'bitbake/lib/prserv') diff --git a/bitbake/lib/prserv/db.py b/bitbake/lib/prserv/db.py index 7c200602ed..eb41508198 100644 --- a/bitbake/lib/prserv/db.py +++ b/bitbake/lib/prserv/db.py @@ -172,11 +172,7 @@ class PRTable(object): if self.read_only: data = self._execute("SELECT ifnull(max(value)+1, 0) FROM %s where version=? AND pkgarch=?;" % (self.table), (version, pkgarch)) - row = data.fetchone() - if row is not None: - return row[0] - else: - return 0 + return data.fetchone()[0] try: self._execute("INSERT OR REPLACE INTO %s VALUES (?, ?, ?, (select ifnull(max(value)+1, 0) from %s where version=? AND pkgarch=?));" -- cgit v1.2.3-54-g00ecf