From 7f6165735767fbe2e0017b2c7619746b14a78a65 Mon Sep 17 00:00:00 2001 From: Shane Wang Date: Wed, 29 Feb 2012 22:15:01 +0800 Subject: Hob: fixed the issue in the brought-in-by dialog. When typing any thing in the search entry, the brough-in-by dialog will be shown. That is because we call back "selection-changed" signal to pop up the dialog, which is not correct. This patch is to fix the problem by using "row-activated" signal. (Bitbake rev: ea56ae787153460166697bbcae92f51a77ca1571) Signed-off-by: Liming An Signed-off-by: Shane Wang Signed-off-by: Richard Purdie --- bitbake/lib/bb/ui/crumbs/recipeselectionpage.py | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) (limited to 'bitbake/lib/bb/ui/crumbs/recipeselectionpage.py') diff --git a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py index 93540b2a95..8a356935ac 100755 --- a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py +++ b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py @@ -140,8 +140,7 @@ class RecipeSelectionPage (HobPage): tab.set_model(self.recipe_model.tree_model(filter)) tab.connect("toggled", self.table_toggled_cb) if self.pages[i]['name'] == "Included": - tab.connect("changed", self.tree_selection_cb) - + tab.connect("row-activated", self.tree_row_activated_cb) reset_button = gtk.Button("Reset") reset_button.connect("clicked", self.reset_clicked_cb) hbox = gtk.HBox(False, 5) @@ -185,14 +184,8 @@ class RecipeSelectionPage (HobPage): self.back_button.connect("clicked", self.back_button_clicked_cb) button_box.pack_start(self.back_button, expand=False, fill=False) - def tree_selection_cb(self, table, tree_selection, tree_view): - tree_model = tree_view.get_model() - path, column = tree_view.get_cursor() - if not path or column == tree_view.get_column(2): - return - - it = tree_model.get_iter(path) - binb = tree_model.get_value(it, RecipeListModel.COL_BINB) + def tree_row_activated_cb(self, table, tree_model, path): + binb = tree_model.get_value(tree_model.get_iter(path), RecipeListModel.COL_BINB) if binb: self.builder.show_binb_dialog(binb) -- cgit v1.2.3-54-g00ecf