From 991557216e4d7bf6d47e5f8054c0c3b0879a8bf5 Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Fri, 21 Sep 2012 15:47:23 +0100 Subject: bitbake: hob: don't show error dialog for errors during building During building we already report errors in a special tab and indicate when the build has failed; bringing up a dialog was a regression introduced in bitbake revision 5bab81b124087d63d6eb62a861e1241714fcd483. Fixes [YOCTO #3151]. (Bitbake rev: cf0a67d62f631aa48d1afc3fbdd0f73995b1c401) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- bitbake/lib/bb/ui/crumbs/hobeventhandler.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'bitbake/lib/bb/ui/crumbs/hobeventhandler.py') diff --git a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py index 8fc1732a8e..49db2deb27 100644 --- a/bitbake/lib/bb/ui/crumbs/hobeventhandler.py +++ b/bitbake/lib/bb/ui/crumbs/hobeventhandler.py @@ -183,10 +183,11 @@ class HobHandler(gobject.GObject): self.emit("sanity-failed", event._msg) elif isinstance(event, logging.LogRecord): - if event.levelno >= logging.ERROR: - formatter = bb.msg.BBLogFormatter() - msg = formatter.format(event) - self.error_msg += msg + '\n' + if not self.building: + if event.levelno >= logging.ERROR: + formatter = bb.msg.BBLogFormatter() + msg = formatter.format(event) + self.error_msg += msg + '\n' elif isinstance(event, bb.event.TargetsTreeGenerated): self.current_phase = "data generation" -- cgit v1.2.3-54-g00ecf