From 560fa9ad8dd46f23cff7a2e88a3492c363314b29 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Tue, 10 Sep 2013 12:33:27 -0400 Subject: bitbake: methodpool: Retire it, remove global method scope Having a global method scope confuses users and with the introduction of parallel parsing, its not even possible to correctly detect conflicting functions. Rather than try and fix that, its simpler to retire the global method scope and restrict functions to those locations they're defined within. This is more what users actually expect too. If we remove the global function scope, the need for methodpool is reduced to the point we may as well retire it. There is some small loss of caching of parsed functions but timing measurements so the impact to be neglibile in the overall parsing time. (Bitbake rev: bbb4fa427739912ff3b87379bf629066f6662458) Signed-off-by: Richard Purdie Tested-by: Denys Dmytriyenko --- bitbake/lib/bb/parse/parse_py/BBHandler.py | 4 ---- 1 file changed, 4 deletions(-) (limited to 'bitbake/lib/bb/parse/parse_py/BBHandler.py') diff --git a/bitbake/lib/bb/parse/parse_py/BBHandler.py b/bitbake/lib/bb/parse/parse_py/BBHandler.py index 81fb8d3adf..2aba9a09f3 100644 --- a/bitbake/lib/bb/parse/parse_py/BBHandler.py +++ b/bitbake/lib/bb/parse/parse_py/BBHandler.py @@ -166,10 +166,6 @@ def handle(fn, d, include): if oldfile: d.setVar("FILE", oldfile) - # we have parsed the bb class now - if ext == ".bbclass" or ext == ".inc": - bb.methodpool.set_parsed_module(base_name) - return d def feeder(lineno, s, fn, root, statements): -- cgit v1.2.3-54-g00ecf