From 1110dde73aa04772090ca7b2b21a953d49734fb0 Mon Sep 17 00:00:00 2001 From: Joshua Lock Date: Tue, 4 Oct 2016 11:03:55 +0100 Subject: bitbake: event: prevent unclosed file warning in print_ui_queue Use logger.addHandler(), rather than assigning an array of Handlers to the loggers handlers property directly, to avoid a warning from Python 3 about unclosed files: $ bitbake Nothing to do. Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information. WARNING: /home/joshuagl/Projects/poky/bitbake/lib/bb/event.py:143: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/joshuagl/Projects/poky/build/tmp/log/cooker/qemux86/20161004094928.log' mode='a' encoding='UTF-8'> logger.handlers = [stdout] (Bitbake rev: 1e23b1f1a80066223b98e18b163840051ac74944) Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie --- bitbake/lib/bb/event.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'bitbake/lib/bb/event.py') diff --git a/bitbake/lib/bb/event.py b/bitbake/lib/bb/event.py index 65b7ebb43b..c5a5f94dee 100644 --- a/bitbake/lib/bb/event.py +++ b/bitbake/lib/bb/event.py @@ -143,16 +143,16 @@ def print_ui_queue(): if isinstance(event, logging.LogRecord): if event.levelno > logging.DEBUG: if event.levelno >= logging.WARNING: - logger.handlers = [stderr] + logger.addHandler(stderr) else: - logger.handlers = [stdout] + logger.addHandler(stdout) logger.handle(event) msgprint = True if msgprint: return # Nope, so just print all of the messages we have (including debug messages) - logger.handlers = [stdout] + logger.addHandler(stdout) for event in ui_queue: if isinstance(event, logging.LogRecord): logger.handle(event) -- cgit v1.2.3-54-g00ecf