From 2639c37b25d5c19b92e8a4ce65075a6d807ff16e Mon Sep 17 00:00:00 2001 From: Robert Yang Date: Wed, 30 Nov 2011 17:23:51 +0800 Subject: Remove the async_cmds and sync_cmds from command.py In bitbake/lib/bb/command.py::Command::__init__, we have the following lines: for attr in CommandsSync.__dict__: command = attr[:].lower() method = getattr(CommandsSync, attr) sync_cmds[command] = (method) for attr in CommandsAsync.__dict__: command = attr[:].lower() method = getattr(CommandsAsync, attr) async_cmds[command] = (method) The sync_cmds and async_cmds are defined as global dictionaries, but it seems that we've never used them (I did a "grep -r async_cmds bitbake/", , there is no result except the ones that I have removed), and I can't find the history of it from "git log -p", I guess that they have been replaced by the self.cmds_sync and self.cmds_async. [YOCTO #1791] (Bitbake rev: 24e99460800856035bb54a84c7aa33b3517436e9) Signed-off-by: Robert Yang Signed-off-by: Richard Purdie --- bitbake/lib/bb/command.py | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'bitbake/lib/bb/command.py') diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py index 1808f0c7e5..83907f6cc3 100644 --- a/bitbake/lib/bb/command.py +++ b/bitbake/lib/bb/command.py @@ -31,10 +31,6 @@ Commands are queued in a CommandQueue import bb.event import bb.cooker -async_cmds = {} -sync_cmds = {} - - class CommandCompleted(bb.event.Event): pass @@ -60,16 +56,6 @@ class Command: # FIXME Add lock for this self.currentAsyncCommand = None - for attr in CommandsSync.__dict__: - command = attr[:].lower() - method = getattr(CommandsSync, attr) - sync_cmds[command] = (method) - - for attr in CommandsAsync.__dict__: - command = attr[:].lower() - method = getattr(CommandsAsync, attr) - async_cmds[command] = (method) - def runCommand(self, commandline): try: command = commandline.pop(0) -- cgit v1.2.3-54-g00ecf