From f82b7bf988d912c7c413790c28e03b2b9f7a51cc Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Sat, 9 Apr 2022 12:27:17 -0700 Subject: python3: Do not detect multiarch when cross compiling This was a long standing problem seen on aarch64 build hosts when compiling python3 with clang cross compiler. The issue is not seen with gcc because native glibc headers are still compatible with gcc cross compiler (From OE-Core rev: 407744b00d702e3133304e1b43064a5634ca02cf) Signed-off-by: Khem Raj Cc: Ross Burton Cc: Jon Mason Signed-off-by: Richard Purdie --- ...-not-detect-multiarch-paths-when-cross-co.patch | 42 ++++++++++++++++++++++ meta/recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 43 insertions(+) create mode 100644 meta/recipes-devtools/python/python3/0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch diff --git a/meta/recipes-devtools/python/python3/0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch b/meta/recipes-devtools/python/python3/0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch new file mode 100644 index 0000000000..1844e0efa3 --- /dev/null +++ b/meta/recipes-devtools/python/python3/0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch @@ -0,0 +1,42 @@ +From dc966f1278c1077938626d682666767d2c8d0c72 Mon Sep 17 00:00:00 2001 +From: Khem Raj +Date: Sat, 9 Apr 2022 18:29:47 +0000 +Subject: [PATCH] setup.py: Do not detect multiarch paths when cross-compiling + +add_multiarch_paths() function relies on host tools like dpkg-configure +to operate, which is not good when cross compiling, since it ends up +adding native paths in includes in certain cases, e.g. when building +for aarch64 targets using aarch64 build hosts running debian-like +distributions e.g. ubuntu, it ends up adding native multiarch paths +-I/usr/include/aarch64-linux-gnu during cross compile and since arches +are so similar, cross compiler (epecially clang) is inhererently configured +with multiarch ends up adding these paths to compiler cmdline which +works ok with gcc since headers are similar but clang barfs on some gcc +extentions and build fails due to missing gnu extentions but it silently +compiles when using cross gcc. + +Fixes python3 cross build by not running this funciton when cross compiling + +Upstream-Status: Inappropriate [OE-Specific] +Signed-off-by: Khem Raj +--- + setup.py | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/setup.py b/setup.py +index 2e7f263..f7a3d39 100644 +--- a/setup.py ++++ b/setup.py +@@ -840,7 +840,8 @@ class PyBuildExt(build_ext): + # only change this for cross builds for 3.3, issues on Mageia + if CROSS_COMPILING: + self.add_cross_compiling_paths() +- self.add_multiarch_paths() ++ if not CROSS_COMPILING: ++ self.add_multiarch_paths() + self.add_ldflags_cppflags() + + def init_inc_lib_dirs(self): +-- +2.25.1 + diff --git a/meta/recipes-devtools/python/python3_3.10.4.bb b/meta/recipes-devtools/python/python3_3.10.4.bb index 522f0d71ee..7eaafe34ad 100644 --- a/meta/recipes-devtools/python/python3_3.10.4.bb +++ b/meta/recipes-devtools/python/python3_3.10.4.bb @@ -32,6 +32,7 @@ SRC_URI = "http://www.python.org/ftp/python/${PV}/Python-${PV}.tar.xz \ file://makerace.patch \ file://0001-sysconfig.py-use-platlibdir-also-for-purelib.patch \ file://0001-Lib-pty.py-handle-stdin-I-O-errors-same-way-as-maste.patch \ + file://0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch \ " SRC_URI:append:class-native = " \ -- cgit v1.2.3-54-g00ecf