From dccb9b9fe826948e2d90a97b31998c31b114bed2 Mon Sep 17 00:00:00 2001 From: Robert Yang Date: Wed, 30 Nov 2011 17:23:50 +0800 Subject: Remove the duplicated assignments of self.configuration.cmd The assignments of self.configuration.cmd in BBCooker seems duplicated, have the followings in both BBCooker::__init__ and BBCooker::loadConfigurationData: if not self.configuration.cmd: self.configuration.cmd = self.configuration.data.getVar("BB_DEFAULT_TASK", True) or "build" The __init__ invokes the loadConfigurationData, and it would make sure that self.configuration.cmd has been assigned a proper value, so we can remove the one in __init__. [YOCTO #1791] Signed-off-by: Robert Yang Signed-off-by: Richard Purdie --- bitbake/lib/bb/cooker.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index d1198d4496..15243f2194 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -135,9 +135,6 @@ class BBCooker: self.configuration.data = None self.loadConfigurationData() - if not self.configuration.cmd: - self.configuration.cmd = self.configuration.data.getVar("BB_DEFAULT_TASK", True) or "build" - # Take a lock so only one copy of bitbake can run against a given build # directory at a time lockfile = self.configuration.data.expand("${TOPDIR}/bitbake.lock") -- cgit v1.2.3-54-g00ecf