From dcb85d7dd59b3c24e05e8ba50c0f3093e815d305 Mon Sep 17 00:00:00 2001 From: Stefan Wiehler Date: Thu, 2 Jun 2022 11:45:14 +0200 Subject: kernel-yocto.bbclass: Reset to exiting on non-zero return code at end of task Several tasks deactivate exiting on non-zero return codes via set +e because they run subcommands that have legitimate non-zero return codes. However when appending to those tasks, this behavior is not expected and can lead to builds silently proceeding in case of an error. Therefore reset the default behavior at the end of the respective tasks via set -e. (From OE-Core rev: 83a6f28d2e464f00202090e998a63045adba9e4e) Signed-off-by: Stefan Wiehler Signed-off-by: Richard Purdie --- meta/classes/kernel-yocto.bbclass | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index b276ded775..ce1446f7aa 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass @@ -310,6 +310,8 @@ do_kernel_metadata() { bbnote "KERNEL_FEATURES: $KERNEL_FEATURES_FINAL" bbnote "Final scc/cfg list: $sccs_defconfig $bsp_definition $sccs $KERNEL_FEATURES_FINAL" fi + + set -e } do_patch() { @@ -343,6 +345,8 @@ do_patch() { fi done fi + + set -e } do_kernel_checkout() { @@ -401,6 +405,8 @@ do_kernel_checkout() { git commit -q -m "baseline commit: creating repo for ${PN}-${PV}" git clean -d -f fi + + set -e } do_kernel_checkout[dirs] = "${S} ${WORKDIR}" @@ -695,6 +701,8 @@ do_validate_branches() { kgit-s2q --clean fi fi + + set -e } OE_TERMINAL_EXPORTS += "KBUILD_OUTPUT" -- cgit v1.2.3-54-g00ecf