From bae35b3e5f3f388027cee30dbfc2df8f5a707aba Mon Sep 17 00:00:00 2001 From: Joshua Lock Date: Tue, 4 Oct 2016 11:03:55 +0100 Subject: bitbake: event: prevent unclosed file warning in print_ui_queue Use logger.addHandler(), rather than assigning an array of Handlers to the loggers handlers property directly, to avoid a warning from Python 3 about unclosed files: $ bitbake Nothing to do. Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information. WARNING: /home/joshuagl/Projects/poky/bitbake/lib/bb/event.py:143: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/joshuagl/Projects/poky/build/tmp/log/cooker/qemux86/20161004094928.log' mode='a' encoding='UTF-8'> logger.handlers = [stdout] (Bitbake rev: 775888307dc2917ef4b52799cc1600a6b3a01abe) Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie --- bitbake/lib/bb/event.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bitbake/lib/bb/event.py b/bitbake/lib/bb/event.py index 2cac074a05..4b133a7c12 100644 --- a/bitbake/lib/bb/event.py +++ b/bitbake/lib/bb/event.py @@ -129,16 +129,16 @@ def print_ui_queue(): if isinstance(event, logging.LogRecord): if event.levelno > logging.DEBUG: if event.levelno >= logging.WARNING: - logger.handlers = [stderr] + logger.addHandler(stderr) else: - logger.handlers = [stdout] + logger.addHandler(stdout) logger.handle(event) msgprint = True if msgprint: return # Nope, so just print all of the messages we have (including debug messages) - logger.handlers = [stdout] + logger.addHandler(stdout) for event in ui_queue: if isinstance(event, logging.LogRecord): logger.handle(event) -- cgit v1.2.3-54-g00ecf