From 9daf6ef908eb7907f30c18a34dded1929ef66671 Mon Sep 17 00:00:00 2001 From: Belen Barros Pena Date: Tue, 6 Oct 2015 14:20:44 +0100 Subject: bitbake: toaster: Comment out broken sorting and filters YOCTO #8131 records that the sorting by 'errors', 'warnings' and 'time', and the filtering by 'errors' and 'warnings', are broken in the 'all builds' and 'project builds' pages. To avoid exposing broken functionality to users, comment out the sorting and filtering in those columns until we we have a fix for YOCTO #8131. (Bitbake rev: 1f15557efc922bf460640eeaf1622453419bc9a6) Signed-off-by: Belen Barros Pena Signed-off-by: Elliot Smith Signed-off-by: Richard Purdie --- bitbake/lib/toaster/toastergui/views.py | 49 +++++++++++++++++---------------- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py index 9f16e8f76f..db791cfd80 100755 --- a/bitbake/lib/toaster/toastergui/views.py +++ b/bitbake/lib/toaster/toastergui/views.py @@ -2103,35 +2103,38 @@ if True: }, {'name': 'Errors', 'clclass': 'errors_no', 'qhelp': "How many errors were encountered during the build (if any)", - 'orderfield': _get_toggle_order(request, "errors_no", True), - 'ordericon':_get_toggle_order_icon(request, "errors_no"), - 'orderkey' : 'errors_no', - 'filter' : {'class' : 'errors_no', - 'label': 'Show:', - 'options' : [ - ('Builds with errors', 'errors_no__gte:1', queryset_with_search.filter(errors_no__gte=1).count()), - ('Builds without errors', 'errors_no:0', queryset_with_search.filter(errors_no=0).count()), - ] - } + # Comment out sorting and filter until YOCTO #8131 is fixed + #'orderfield': _get_toggle_order(request, "errors_no", True), + #'ordericon':_get_toggle_order_icon(request, "errors_no"), + #'orderkey' : 'errors_no', + #'filter' : {'class' : 'errors_no', + # 'label': 'Show:', + # 'options' : [ + # ('Builds with errors', 'errors_no__gte:1', queryset_with_search.filter(errors_no__gte=1).count()), + # ('Builds without errors', 'errors_no:0', queryset_with_search.filter(errors_no=0).count()), + # ] + # } }, {'name': 'Warnings', 'clclass': 'warnings_no', 'qhelp': "How many warnings were encountered during the build (if any)", - 'orderfield': _get_toggle_order(request, "warnings_no", True), - 'ordericon':_get_toggle_order_icon(request, "warnings_no"), - 'orderkey' : 'warnings_no', - 'filter' : {'class' : 'warnings_no', - 'label': 'Show:', - 'options' : [ - ('Builds with warnings','warnings_no__gte:1', queryset_with_search.filter(warnings_no__gte=1).count()), - ('Builds without warnings','warnings_no:0', queryset_with_search.filter(warnings_no=0).count()), - ] - } + # Comment out sorting and filter until YOCTO #8131 is fixed + #'orderfield': _get_toggle_order(request, "warnings_no", True), + #'ordericon':_get_toggle_order_icon(request, "warnings_no"), + #'orderkey' : 'warnings_no', + #'filter' : {'class' : 'warnings_no', + # 'label': 'Show:', + # 'options' : [ + # ('Builds with warnings','warnings_no__gte:1', queryset_with_search.filter(warnings_no__gte=1).count()), + # ('Builds without warnings','warnings_no:0', queryset_with_search.filter(warnings_no=0).count()), + # ] + # } }, {'name': 'Time', 'clclass': 'time', 'hidden' : 1, 'qhelp': "How long it took the build to finish", - 'orderfield': _get_toggle_order(request, "timespent", True), - 'ordericon':_get_toggle_order_icon(request, "timespent"), - 'orderkey' : 'timespent', + # Comment out sorting until YOCTO #8131 is fixed + #'orderfield': _get_toggle_order(request, "timespent", True), + #'ordericon':_get_toggle_order_icon(request, "timespent"), + #'orderkey' : 'timespent', }, {'name': 'Image files', 'clclass': 'output', 'qhelp': "The root file system types produced by the build. You can find them in your /build/tmp/deploy/images/ directory", -- cgit v1.2.3-54-g00ecf