From 51c8ac2d6ae20ce605d863244739c87ef60110ec Mon Sep 17 00:00:00 2001 From: Alexander Kanavin Date: Fri, 21 Apr 2017 10:57:01 +0300 Subject: oe-selftest: add a test for upstream version check regressions The test runs an upstream version check, and then compares the list of recipes that failed the check (i.e. those where latest upstream version could not be established) against the list of known-broken upstreams. Mismatches either way (upstream check failed, recipe not in the exception list, or upstream check worked, recipe in exception list) fail the test. [YOCTO #11031] (From OE-Core rev: 544e04a11ab6c26a367ac0b67774bf7ffdf43c88) Signed-off-by: Alexander Kanavin Signed-off-by: Richard Purdie --- meta-selftest/files/distrodata/checkpkg_exceptions | 26 +++++++++++++ meta/lib/oeqa/selftest/cases/distrodata.py | 43 ++++++++++++++++++++++ 2 files changed, 69 insertions(+) create mode 100644 meta-selftest/files/distrodata/checkpkg_exceptions create mode 100644 meta/lib/oeqa/selftest/cases/distrodata.py diff --git a/meta-selftest/files/distrodata/checkpkg_exceptions b/meta-selftest/files/distrodata/checkpkg_exceptions new file mode 100644 index 0000000000..f0d1f67487 --- /dev/null +++ b/meta-selftest/files/distrodata/checkpkg_exceptions @@ -0,0 +1,26 @@ +build-compare +calibrateproto +dbus-wait +distcc +fstests +gnu-config +gst-player +kmscube +libxcalibrate +linux-firmware +lsb +mmc-utils +ovmf +piglit +psplash +puzzles +rpm +squashfs-tools +tcf-agent +unzip +update-rc.d +x264 +xcursor-transparent-theme +xinetd +xvideo-tests +zip diff --git a/meta/lib/oeqa/selftest/cases/distrodata.py b/meta/lib/oeqa/selftest/cases/distrodata.py new file mode 100644 index 0000000000..d5d286d5cc --- /dev/null +++ b/meta/lib/oeqa/selftest/cases/distrodata.py @@ -0,0 +1,43 @@ +from oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_bb_vars +from oeqa.utils.decorators import testcase +from oeqa.utils.ftools import write_file + +class Distrodata(OESelftestTestCase): + + @classmethod + def setUpClass(cls): + super(Distrodata, cls).setUpClass() + cls.exceptions_path = os.path.join(cls.testlayer_path, 'files', 'distrodata', "checkpkg_exceptions") + + def test_checkpkg(self): + """ + Summary: Test that upstream version checks do not regress + Expected: Upstream version checks should succeed except for the recipes listed in the exception list. + Product: oe-core + Author: Alexander Kanavin + """ + feature = 'INHERIT += "distrodata"\n' + feature += 'LICENSE_FLAGS_WHITELIST += " commercial"\n' + + self.write_config(feature) + bitbake('-c checkpkg world') + checkpkg_result = open(os.path.join(get_bb_var("LOG_DIR"), "checkpkg.csv")).readlines()[1:] + exceptions = [exc.strip() for exc in open(self.exceptions_path).readlines()] + failed_upstream_checks = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] if pkg_data[11] == ''] + regressed_failures = set(failed_upstream_checks) - set(exceptions) + regressed_successes = set(exceptions) - set(failed_upstream_checks) + msg = "" + if len(regressed_failures) > 0: + msg = msg + """ +The following packages failed upstream version checks. Please fix them using UPSTREAM_CHECK_URI/UPSTREAM_CHECK_REGEX +(when using tarballs) or UPSTREAM_CHECK_GITTAGREGEX (when using git). If an upstream version check cannot be performed +(for example, if upstream does not use git tags), you can add the package to list of exceptions in +meta-selftest/files/distrodata/checkpkg_exceptions. +""" + "\n".join(regressed_failures) + if len(regressed_successes) > 0: + msg = msg + """ +The following packages have been checked successfully for upstream versions (or they no longer exist in oe-core), +but are in the exceptions list in meta-selftest/files/distrodata/checkpkg_exceptions. Please remove them from that list. +""" + "\n".join(regressed_successes) + self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg) -- cgit v1.2.3-54-g00ecf