From 4fe9a766d6357e88a024e14c732db33c9747cad5 Mon Sep 17 00:00:00 2001 From: Vasyl Vavrychuk Date: Mon, 17 Aug 2020 16:57:28 +0300 Subject: runqemu: Check gtk or sdl option is passed together with gl or gl-es options. runqemu help reports that gtk or sdl option is needed with gl or gl-es option. But if user forgot to add gtk or sdl option, then gl or gl-es options were silently skipped. (From OE-Core rev: bec0a45393d968251059f5075add2cf633aecd1a) Signed-off-by: Vasyl Vavrychuk Signed-off-by: Richard Purdie (cherry picked from commit 4d1e93d4bf013bb0c48032bfda43f77c5aba9ecf) Signed-off-by: Steve Sakoman Signed-off-by: Richard Purdie --- scripts/runqemu | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/runqemu b/scripts/runqemu index 310d79fdc5..398f0a0910 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -454,7 +454,8 @@ class BaseConfig(object): self.qemu_opt_script += ' -display gtk' elif arg == 'gl' or arg == 'gl-es': # These args are handled inside sdl or gtk blocks above - pass + if ('gtk' not in sys.argv) and ('sdl' not in sys.argv): + raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg)) elif arg == 'egl-headless': self.qemu_opt_script += ' -vga virtio -display egl-headless' # As runqemu can be run within bitbake (when using testimage, for example), -- cgit v1.2.3-54-g00ecf