From 4d3a53ff36526669fcde7b64dc947e8d76aba56b Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 17 May 2013 11:40:01 +0300 Subject: bitbake: fetch2/utils: Clean up imports Move various random imports to the start of the modules as cleanup and avoid an import issue with bb.process on python 2.6. (Bitbake rev: aed4adfbe3a591ca4f8e41fb763c9f961bf2e6d5) Signed-off-by: Richard Purdie --- bitbake/lib/bb/fetch2/__init__.py | 11 ++++------- bitbake/lib/bb/utils.py | 7 ++++--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py index dd1cc932d4..9029a5a83c 100644 --- a/bitbake/lib/bb/fetch2/__init__.py +++ b/bitbake/lib/bb/fetch2/__init__.py @@ -28,6 +28,8 @@ BitBake build tools. from __future__ import absolute_import from __future__ import print_function import os, re +import signal +import glob import logging import urllib import urlparse @@ -38,6 +40,8 @@ import operator import bb.persist_data, bb.utils import bb.checksum from bb import data +import bb.process +import subprocess __version__ = "2" _checksum_cache = bb.checksum.FileChecksumCache() @@ -584,7 +588,6 @@ def update_stamp(u, ud, d): open(ud.donestamp, 'w').close() def subprocess_setup(): - import signal # Python installs a SIGPIPE handler by default. This is usually not what # non-Python subprocesses expect. # SIGPIPE errors are known issues with gzip/bash @@ -653,9 +656,6 @@ def runfetchcmd(cmd, d, quiet = False, cleanup = []): Optionally remove the files/directories listed in cleanup upon failure """ - import bb.process - import subprocess - # Need to export PATH as binary could be in metadata paths # rather than host provided # Also include some other variables. @@ -913,7 +913,6 @@ def get_file_checksums(filelist, pn): try: checksum = _checksum_cache.get_checksum(f) except OSError as e: - import traceback bb.warn("Unable to get checksum for %s SRC_URI entry %s: %s" % (pn, os.path.basename(f), e)) return None return checksum @@ -923,7 +922,6 @@ def get_file_checksums(filelist, pn): checksum = None if '*' in pth: # Handle globs - import glob for f in glob.glob(pth): checksum = checksum_file(f) if checksum: @@ -1133,7 +1131,6 @@ class FetchMethod(object): raise NoMethodError(url) def unpack(self, urldata, rootdir, data): - import subprocess iterate = False file = urldata.localpath diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py index 2e10fc24dd..1ecc44a01a 100644 --- a/bitbake/lib/bb/utils.py +++ b/bitbake/lib/bb/utils.py @@ -27,6 +27,10 @@ import bb import bb.msg import multiprocessing import fcntl +import subprocess +import glob +import traceback +import errno from commands import getstatusoutput from contextlib import contextmanager @@ -276,7 +280,6 @@ def better_compile(text, file, realfile, mode = "exec"): def _print_exception(t, value, tb, realfile, text, context): error = [] try: - import traceback exception = traceback.format_exception_only(t, value) error.append('Error executing a python function in %s:\n' % realfile) @@ -565,11 +568,9 @@ def remove(path, recurse=False): if not path: return if recurse: - import subprocess, glob # shutil.rmtree(name) would be ideal but its too slow subprocess.call(['rm', '-rf'] + glob.glob(path)) return - import os, errno, glob for name in glob.glob(path): try: os.unlink(name) -- cgit v1.2.3-54-g00ecf