From 149f42b59ea18f2d04d8173642580dddadf3fdd0 Mon Sep 17 00:00:00 2001 From: Alexis Lothoré Date: Mon, 5 Feb 2024 16:57:30 +0100 Subject: patchtest-send-results: properly parse test status MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit patchtest-send-results currently search the word "FAIL" in the whole testresults file to decide whether it should send a report to patch submitter or not. This global search can lead to false positives, for example if the commit subject contains the word "FAIL" (as observed in [1]) Prevent those false positives by explicitely parsing the test status from each line. Each test result line, generated by the patchtest script, is expected to have the following format: : [1] https://lore.kernel.org/openembedded-core/0101018d79bfe020-06f2ce89-ea19-456b-92e7-66ee1c710fd1-000000@us-west-2.amazonses.com/ (From OE-Core rev: 3567c21af8ed65448f9325ee3fe85b8be839e1b5) Signed-off-by: Alexis Lothoré Signed-off-by: Richard Purdie --- scripts/patchtest-send-results | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/patchtest-send-results b/scripts/patchtest-send-results index 024be003ce..075b60d8f7 100755 --- a/scripts/patchtest-send-results +++ b/scripts/patchtest-send-results @@ -33,6 +33,9 @@ under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!""" +def has_a_failed_test(raw_results): + return any(raw_result.split(':')[0] == "FAIL" for raw_result in raw_results.splitlines()) + parser = argparse.ArgumentParser(description="Send patchtest results to a submitter for a given patch") parser.add_argument("-p", "--patch", dest="patch", required=True, help="The patch file to summarize") args = parser.parse_args() @@ -69,7 +72,7 @@ from_address = "patchtest@automation.yoctoproject.org" # mailing list to CC cc_address = "openembedded-core@lists.openembedded.org" -if "FAIL" in testresult: +if has_a_failed_test(testresult): reply_contents = None if len(max(open(result_file, 'r'), key=len)) > 220: warning = "Tests failed for the patch, but the results log could not be processed due to excessive result line length." -- cgit v1.2.3-54-g00ecf